)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"b82f9aef5efd249cb7499fb4620657be6ddbc615","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alex Rudenko \u003calexei.rudenko@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-08-31 16:35:22 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Additional parameter to localrc APACHE_SERVER_NAME. Specifies the server name for apache\u0027s virtual host. Helpful if you use apache for other applications too"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ia8969b0a291a6f10db1508087723d92fd08b84ce"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAASn%2F%2Fpic%3D","line":7,"updated":"2013-09-01 15:26:10.000000000","message":"it is not normal commit message style, especially for openstack recommendation, at least the commit message is too long for a single line, most time you need to format message to ensure line length less than 80(72 is better)\n\ni think this style is good: https://wiki.openstack.org/wiki/Gerrit_Workflow#Committing_Changes","commit_id":"0d03c6dcbb047728d298305b01480f1ae8783e6b"},{"author":{"_account_id":2667,"name":"Alex Glikson","email":"glikson@il.ibm.com","username":"glikson"},"change_message_id":"89be3e2989485f02bc882317bb73568e26450d6f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alex Rudenko \u003calexei.rudenko@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-09-01 17:46:48 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added additional variable  APACHE_SERVER_NAME."},{"line_number":8,"context_line":"It specifies the server name for apache\u0027s virtual host."},{"line_number":9,"context_line":"Helpful if you use apache for other applications too"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAASn%2F%2Fpeo%3D","line":7,"updated":"2013-09-01 15:57:36.000000000","message":"First line should not end with a period and must be followed by a single blank line. See https://github.com/openstack-dev/hacking/blob/master/HACKING.rst","commit_id":"2d03995282832d5eec520366570939643db66a32"},{"author":{"_account_id":2667,"name":"Alex Glikson","email":"glikson@il.ibm.com","username":"glikson"},"change_message_id":"89be3e2989485f02bc882317bb73568e26450d6f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Added additional variable  APACHE_SERVER_NAME."},{"line_number":8,"context_line":"It specifies the server name for apache\u0027s virtual host."},{"line_number":9,"context_line":"Helpful if you use apache for other applications too"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ia8969b0a291a6f10db1508087723d92fd08b84ce"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAASn%2F%2Fpeg%3D","line":10,"updated":"2013-09-01 15:57:36.000000000","message":"Does it implement a blueprint or fix a bug?","commit_id":"2d03995282832d5eec520366570939643db66a32"}],"lib/horizon":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"b82f9aef5efd249cb7499fb4620657be6ddbc615","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        s,%GROUP%,$APACHE_GROUP,g;"},{"line_number":140,"context_line":"        s,%HORIZON_DIR%,$HORIZON_DIR,g;"},{"line_number":141,"context_line":"        s,%APACHE_NAME%,$APACHE_NAME,g;"},{"line_number":142,"context_line":"\t\ts,%APACHE_SERVER_NAME%,$APACHE_SERVER_NAME,g;"},{"line_number":143,"context_line":"        s,%DEST%,$DEST,g;"},{"line_number":144,"context_line":"        s,%HORIZON_REQUIRE%,$HORIZON_REQUIRE,g;"},{"line_number":145,"context_line":"    \\\" $FILES/apache-horizon.template \u003e$horizon_conf\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAASn%2F%2Fph8%3D","line":142,"updated":"2013-09-01 15:26:10.000000000","message":"tab-\u003espance","commit_id":"0d03c6dcbb047728d298305b01480f1ae8783e6b"}],"stack.sh":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"b82f9aef5efd249cb7499fb4620657be6ddbc615","unresolved":false,"context_lines":[{"line_number":752,"context_line":""},{"line_number":753,"context_line":"if is_service_enabled horizon; then"},{"line_number":754,"context_line":"    # dashboard"},{"line_number":755,"context_line":"\tif [ ! $APACHE_SERVER_NAME ]; then"},{"line_number":756,"context_line":"\t\teval \"APACHE_SERVER_NAME\u003dopenstack.loc\""},{"line_number":757,"context_line":"\t\techo \"APACHE_SERVER_NAME\u003dopenstack.loc\" \u003e\u003e $localrc"},{"line_number":758,"context_line":"\tfi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAASn%2F%2FpiA%3D","line":755,"updated":"2013-09-01 15:26:10.000000000","message":"you are using an editor with tabstop\u003d8, while most of source code with 4, please use space to indent instead of tab","commit_id":"0d03c6dcbb047728d298305b01480f1ae8783e6b"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"d256bf2ca58024a1e99ef3db4e8c6a5c9c18629a","unresolved":false,"context_lines":[{"line_number":752,"context_line":""},{"line_number":753,"context_line":"if is_service_enabled horizon; then"},{"line_number":754,"context_line":"    # dashboard"},{"line_number":755,"context_line":"    if [ ! $APACHE_SERVER_NAME ]; then"},{"line_number":756,"context_line":"        eval \"APACHE_SERVER_NAME\u003dopenstack.loc\""},{"line_number":757,"context_line":"        echo \"APACHE_SERVER_NAME\u003dopenstack.loc\" \u003e\u003e $localrc"},{"line_number":758,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAASn%2F%2Fdao%3D","line":755,"updated":"2013-09-04 14:53:01.000000000","message":"This entire addition needs to be in configure_horizon().  Also, other things need to move from init_horizon() to configure_horizon() but that\u0027s another issue.\n\nAlso, it can be handled in one line:\n\n  APACHE_SERVER_NAME\u003d${APACHE_SERVER_NAME:-openstack-horizon}","commit_id":"296da7e6e3dfa540251b6f7a205c6e3ac7c6b89f"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"a5c99e41f0cfdef50698d75b76b9bdc754ce616e","unresolved":false,"context_lines":[{"line_number":753,"context_line":"if is_service_enabled horizon; then"},{"line_number":754,"context_line":"    # dashboard"},{"line_number":755,"context_line":"    if [ ! $APACHE_SERVER_NAME ]; then"},{"line_number":756,"context_line":"        eval \"APACHE_SERVER_NAME\u003dopenstack.loc\""},{"line_number":757,"context_line":"        echo \"APACHE_SERVER_NAME\u003dopenstack.loc\" \u003e\u003e $localrc"},{"line_number":758,"context_line":"    fi"},{"line_number":759,"context_line":"    echo \"Setting APACHE_SERVER_NAME\u003d$APACHE_SERVER_NAME\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAASn%2F%2Feew%3D","line":756,"updated":"2013-09-04 11:20:52.000000000","message":"why the eval? why not just do defaulting like is done everywhere else?","commit_id":"296da7e6e3dfa540251b6f7a205c6e3ac7c6b89f"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"d256bf2ca58024a1e99ef3db4e8c6a5c9c18629a","unresolved":false,"context_lines":[{"line_number":754,"context_line":"    # dashboard"},{"line_number":755,"context_line":"    if [ ! $APACHE_SERVER_NAME ]; then"},{"line_number":756,"context_line":"        eval \"APACHE_SERVER_NAME\u003dopenstack.loc\""},{"line_number":757,"context_line":"        echo \"APACHE_SERVER_NAME\u003dopenstack.loc\" \u003e\u003e $localrc"},{"line_number":758,"context_line":"    fi"},{"line_number":759,"context_line":"    echo \"Setting APACHE_SERVER_NAME\u003d$APACHE_SERVER_NAME\""},{"line_number":760,"context_line":"    install_horizon"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAASn%2F%2Fhes%3D","line":757,"updated":"2013-09-04 14:53:01.000000000","message":"stack.sh only modifies localrc to save passwords entered interactively.  Otherwise we should never touch it.","commit_id":"296da7e6e3dfa540251b6f7a205c6e3ac7c6b89f"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"a5c99e41f0cfdef50698d75b76b9bdc754ce616e","unresolved":false,"context_lines":[{"line_number":756,"context_line":"        eval \"APACHE_SERVER_NAME\u003dopenstack.loc\""},{"line_number":757,"context_line":"        echo \"APACHE_SERVER_NAME\u003dopenstack.loc\" \u003e\u003e $localrc"},{"line_number":758,"context_line":"    fi"},{"line_number":759,"context_line":"    echo \"Setting APACHE_SERVER_NAME\u003d$APACHE_SERVER_NAME\""},{"line_number":760,"context_line":"    install_horizon"},{"line_number":761,"context_line":"    configure_horizon"},{"line_number":762,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAASn%2F%2Fees%3D","line":759,"updated":"2013-09-04 11:20:52.000000000","message":"is there a reason this variable is so special that you always need to tell the user about it in stdout?","commit_id":"296da7e6e3dfa540251b6f7a205c6e3ac7c6b89f"}]}