)]}'
{"SYSTEMD.rst":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"e75c772cac619afff2ba872059a6ef5b1fa503e9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"DevStack can be run with all the services as systemd unit"},{"line_number":6,"context_line":"files. Systemd is now the default init system for nearly every Llinux"},{"line_number":7,"context_line":"distro, and systemd encodes and solves many of the problems related to"},{"line_number":8,"context_line":"poorly running processes."},{"line_number":9,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_f39bf363","line":6,"range":{"start_line":6,"start_character":63,"end_line":6,"end_character":69},"updated":"2017-03-22 16:07:27.000000000","message":"s/Llinux/Linux/","commit_id":"097f723704fe21b672bb65a9b8c9a31875693311"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"42ad39ef304ae091136e56bc5648ef1877ae018f","unresolved":false,"context_lines":[{"line_number":8,"context_line":"   with DevStack and systemd."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"DevStack can be run with all the services as systemd unit"},{"line_number":11,"context_line":"files. Systemd is now the default init system for nearly every Llinux"},{"line_number":12,"context_line":"distro, and systemd encodes and solves many of the problems related to"},{"line_number":13,"context_line":"poorly running processes."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"ffe62b97_b56de899","line":11,"range":{"start_line":11,"start_character":63,"end_line":11,"end_character":69},"updated":"2017-03-24 19:25:00.000000000","message":"probably just Linux, but maybe this is Stallman\u0027s new thing","commit_id":"aab1aae669347b91c812aa7f73379fecba74f007"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"d8a888bfc1ca5a30cd1f5a27e79e0d52b12d0da6","unresolved":false,"context_lines":[{"line_number":8,"context_line":"   with DevStack and systemd."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"DevStack can be run with all the services as systemd unit"},{"line_number":11,"context_line":"files. Systemd is now the default init system for nearly every Llinux"},{"line_number":12,"context_line":"distro, and systemd encodes and solves many of the problems related to"},{"line_number":13,"context_line":"poorly running processes."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"ffe62b97_06a46856","line":11,"range":{"start_line":11,"start_character":63,"end_line":11,"end_character":69},"in_reply_to":"ffe62b97_b56de899","updated":"2017-03-24 20:53:17.000000000","message":"ACK, I\u0027ll fix that on the next go or after.","commit_id":"aab1aae669347b91c812aa7f73379fecba74f007"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"42ad39ef304ae091136e56bc5648ef1877ae018f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"The screen model for DevStack was invented when the number of services"},{"line_number":19,"context_line":"that a devstack user was going to run was typically \u003c 10. This made"},{"line_number":20,"context_line":"screen hot keys to jump around very easy. However, the landscape has"},{"line_number":21,"context_line":"changed (not all services are stoppable in screen as some are under"},{"line_number":22,"context_line":"apache, there are typically at least 20 items)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"There is also a common developer workflow of changing code in more"},{"line_number":25,"context_line":"than one service, and needing to restart a bunch of services for that"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ffe62b97_d5f50ccd","line":22,"range":{"start_line":21,"start_character":8,"end_line":22,"end_character":46},"updated":"2017-03-24 19:25:00.000000000","message":"probably doesn\u0027t need to be in parenthesis","commit_id":"aab1aae669347b91c812aa7f73379fecba74f007"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"1a227917d595d156c2a6022935a2041e0e23cdc4","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"   The ``systemd`` python package appears to only be python3 in recent"},{"line_number":132,"context_line":"   releases, so there is going to need to be some conditional nature"},{"line_number":133,"context_line":"   of using this."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"sub targets/slices"},{"line_number":136,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ffe62b97_b2a250fb","line":133,"updated":"2017-03-27 19:56:10.000000000","message":"I smell some py3 migration bait...","commit_id":"aab1aae669347b91c812aa7f73379fecba74f007"}],"functions":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"e75c772cac619afff2ba872059a6ef5b1fa503e9","unresolved":false,"context_lines":[{"line_number":607,"context_line":"    local conf_file\u003d$1"},{"line_number":608,"context_line":"    local conf_section\u003d\"DEFAULT\""},{"line_number":609,"context_line":"    local project_var\u003d\"project_name\""},{"line_number":610,"context_line":"    local user_var\u003d\"user_name\""},{"line_number":611,"context_line":"    iniset $conf_file $conf_section logging_context_format_string \"%(levelname)s %(name)s [%(request_id)s %(\"$project_var\")s %(\"$user_var\")s] %(instance)s%(message)s\""},{"line_number":612,"context_line":"    iniset $conf_file $conf_section logging_default_format_string \"%(levelname)s %(name)s [-] %(instance)s%(color)s%(message)s\""},{"line_number":613,"context_line":"    iniset $conf_file $conf_section logging_debug_format_suffix \"from (pid\u003d%(process)d) %(funcName)s %(pathname)s:%(lineno)d\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1a1ced50_f3b213e4","line":610,"updated":"2017-03-22 16:07:27.000000000","message":"I know its done this way in the function above, but if project_var is hardcoded to project_name and user_var to user_name why don\u0027t we just encode it into the logging strings below and remove the vars? I must be missing some utility here.","commit_id":"097f723704fe21b672bb65a9b8c9a31875693311"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"d43116fe22a8f74633e35135c27788882f3001e2","unresolved":false,"context_lines":[{"line_number":607,"context_line":"    local conf_file\u003d$1"},{"line_number":608,"context_line":"    local conf_section\u003d\"DEFAULT\""},{"line_number":609,"context_line":"    local project_var\u003d\"project_name\""},{"line_number":610,"context_line":"    local user_var\u003d\"user_name\""},{"line_number":611,"context_line":"    iniset $conf_file $conf_section logging_context_format_string \"%(levelname)s %(name)s [%(request_id)s %(\"$project_var\")s %(\"$user_var\")s] %(instance)s%(message)s\""},{"line_number":612,"context_line":"    iniset $conf_file $conf_section logging_default_format_string \"%(levelname)s %(name)s [-] %(instance)s%(color)s%(message)s\""},{"line_number":613,"context_line":"    iniset $conf_file $conf_section logging_debug_format_suffix \"from (pid\u003d%(process)d) %(funcName)s %(pathname)s:%(lineno)d\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1a1ced50_b39976c6","line":610,"in_reply_to":"1a1ced50_f3b213e4","updated":"2017-03-22 17:33:18.000000000","message":"honestly, it\u0027s vestigial.","commit_id":"097f723704fe21b672bb65a9b8c9a31875693311"}],"functions-common":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"e75c772cac619afff2ba872059a6ef5b1fa503e9","unresolved":false,"context_lines":[{"line_number":1472,"context_line":"    local systemd_service\u003d\"devstack@$service.service\""},{"line_number":1473,"context_line":"    local group\u003d$3"},{"line_number":1474,"context_line":"    if [[ -n \"$group\" ]]; then"},{"line_number":1475,"context_line":"        cmd\u003d\"/usr/bin/sg $group $command\""},{"line_number":1476,"context_line":"    fi"},{"line_number":1477,"context_line":"    write_user_unit_file $systemd_service \"$cmd\" \"$group\""},{"line_number":1478,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1a1ced50_73ec63f3","line":1475,"updated":"2017-03-22 16:07:27.000000000","message":"I would put the info about Group\u003dfoo not working in user units here. Just so its close to the code too for when someone decides to \"fix\" it.","commit_id":"097f723704fe21b672bb65a9b8c9a31875693311"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"e75c772cac619afff2ba872059a6ef5b1fa503e9","unresolved":false,"context_lines":[{"line_number":1656,"context_line":"    SERVICE_DIR\u003d${SERVICE_DIR:-${DEST}/status}"},{"line_number":1657,"context_line":""},{"line_number":1658,"context_line":"    if is_service_enabled $service; then"},{"line_number":1659,"context_line":"        # Kill via pid if we have one available"},{"line_number":1660,"context_line":"        if [[ \"$USE_SYSTEMD\" \u003d\u003d \"True\" ]]; then"},{"line_number":1661,"context_line":"            systemctl --user stop devstack@$service.service"},{"line_number":1662,"context_line":"            systemctl --user disable devstack@$service.service"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1a1ced50_739aa36f","line":1659,"updated":"2017-03-22 16:07:27.000000000","message":"This comment belongs to the old block below.","commit_id":"097f723704fe21b672bb65a9b8c9a31875693311"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"e75c772cac619afff2ba872059a6ef5b1fa503e9","unresolved":false,"context_lines":[{"line_number":1662,"context_line":"            systemctl --user disable devstack@$service.service"},{"line_number":1663,"context_line":"        fi"},{"line_number":1664,"context_line":""},{"line_number":1665,"context_line":"        if [[ -r $SERVICE_DIR/$SCREEN_NAME/$service.pid ]]; then"},{"line_number":1666,"context_line":"            pkill -g $(cat $SERVICE_DIR/$SCREEN_NAME/$service.pid)"},{"line_number":1667,"context_line":"            # oslo.service tends to stop actually shutting down"},{"line_number":1668,"context_line":"            # reliably in between releases because someone believes it"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1a1ced50_b3a7bbbb","line":1665,"updated":"2017-03-22 16:07:27.000000000","message":"This can be an elif block, though functionally is fine since systemd won\u0027t write a pid file here.","commit_id":"097f723704fe21b672bb65a9b8c9a31875693311"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"42ad39ef304ae091136e56bc5648ef1877ae018f","unresolved":false,"context_lines":[{"line_number":1455,"context_line":"    local unitfile\u003d\"$SYSTEMD_DIR/$service\""},{"line_number":1456,"context_line":"    mkdir -p $SYSTEMD_DIR"},{"line_number":1457,"context_line":"    # kind of a hack, but writing things as root sucks"},{"line_number":1458,"context_line":"    sudo chown -R $STACK_USER $SYSTEMD_DIR"},{"line_number":1459,"context_line":"    cat - \u003c\u003cEOF \u003e $unitfile"},{"line_number":1460,"context_line":"[Unit]"},{"line_number":1461,"context_line":"Description\u003dDevstack $service"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"ffe62b97_15b7f4d7","line":1458,"updated":"2017-03-24 19:25:00.000000000","message":"Is this something we really want to do? In the system unit case won\u0027t this change the permissions of all the unit files, not just the devstack ones?\n\nI\u0027m not sure it matters but I feel like changing the permissions on not devstack created files for this is a bit weird.","commit_id":"aab1aae669347b91c812aa7f73379fecba74f007"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"d8a888bfc1ca5a30cd1f5a27e79e0d52b12d0da6","unresolved":false,"context_lines":[{"line_number":1455,"context_line":"    local unitfile\u003d\"$SYSTEMD_DIR/$service\""},{"line_number":1456,"context_line":"    mkdir -p $SYSTEMD_DIR"},{"line_number":1457,"context_line":"    # kind of a hack, but writing things as root sucks"},{"line_number":1458,"context_line":"    sudo chown -R $STACK_USER $SYSTEMD_DIR"},{"line_number":1459,"context_line":"    cat - \u003c\u003cEOF \u003e $unitfile"},{"line_number":1460,"context_line":"[Unit]"},{"line_number":1461,"context_line":"Description\u003dDevstack $service"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"ffe62b97_669574e4","line":1458,"in_reply_to":"ffe62b97_15b7f4d7","updated":"2017-03-24 20:53:17.000000000","message":"it will, part of the concern is being able to write these files as normal user. I could probably just change the top level dir.","commit_id":"aab1aae669347b91c812aa7f73379fecba74f007"}]}