)]}'
{"lib/nova_plugins/functions-libvirt":[{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"17aed7fac92d2eb037b3f05c3324b34be7ee6d11","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            if [ -f $f ]; then"},{"line_number":50,"context_line":"                # set the ulimit in libvirt service file and reload"},{"line_number":51,"context_line":"                # config"},{"line_number":52,"context_line":"                sudo sed -i \u0027s/\\[Service\\]/\u0026\\nLimitCORE\u003dinfinity/\u0027 $f"},{"line_number":53,"context_line":"                sudo systemctl daemon-reload"},{"line_number":54,"context_line":"                # make sure it\u0027s widely writable"},{"line_number":55,"context_line":"                sudo mkdir /var/core"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"ffe62b97_96d93123","line":52,"updated":"2017-03-29 10:03:21.000000000","message":"You can do this without awk by adding a config dir. Pretty sure it would look like this (untested):\n\nmkdir -p /etc/systemd/system/libvirt-bin.service.d\ncat \u003e /etc/systemd/system/libvirt-bin.service.d/core-dump.conf \u003c\u003cEOF\n[Service]\nLimitCORE\u003dinfinity\nEOF\n\nThis gets layered over the default config by systemd, and is the recommended way to do this.","commit_id":"ea160bc9b18def4e9342eebbb73a0b5046e48428"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"cd3ca740e23ab8499841a4f715b91b52c30377d4","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            if [ -f $f ]; then"},{"line_number":50,"context_line":"                # set the ulimit in libvirt service file and reload"},{"line_number":51,"context_line":"                # config"},{"line_number":52,"context_line":"                sudo sed -i \u0027s/\\[Service\\]/\u0026\\nLimitCORE\u003dinfinity/\u0027 $f"},{"line_number":53,"context_line":"                sudo systemctl daemon-reload"},{"line_number":54,"context_line":"                # make sure it\u0027s widely writable"},{"line_number":55,"context_line":"                sudo mkdir /var/core"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"ffe62b97_1b454c70","line":52,"updated":"2017-03-29 09:35:24.000000000","message":"we can use iniset here, right?","commit_id":"ea160bc9b18def4e9342eebbb73a0b5046e48428"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"cb63831d815864692bbbbf65c5a2df1d12be714d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            if [ -f $f ]; then"},{"line_number":50,"context_line":"                # set the ulimit in libvirt service file and reload"},{"line_number":51,"context_line":"                # config"},{"line_number":52,"context_line":"                sudo sed -i \u0027s/\\[Service\\]/\u0026\\nLimitCORE\u003dinfinity/\u0027 $f"},{"line_number":53,"context_line":"                sudo systemctl daemon-reload"},{"line_number":54,"context_line":"                # make sure it\u0027s widely writable"},{"line_number":55,"context_line":"                sudo mkdir /var/core"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"ffe62b97_7efb23c0","line":52,"in_reply_to":"ffe62b97_96d93123","updated":"2017-03-29 10:38:41.000000000","message":"@Matthew sounds like a good idea.  Do you want to propose a follow-on, or even modify this, after a test to confirm it\u0027s picked up?","commit_id":"ea160bc9b18def4e9342eebbb73a0b5046e48428"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"17aed7fac92d2eb037b3f05c3324b34be7ee6d11","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                echo \u0027/var/core/core.%e.%p.%h.%t\u0027 | \\"},{"line_number":59,"context_line":"                    sudo tee /proc/sys/kernel/core_pattern"},{"line_number":60,"context_line":"                # restart for good measure"},{"line_number":61,"context_line":"                sudo /etc/init.d/libvirt-bin restart"},{"line_number":62,"context_line":"            else"},{"line_number":63,"context_line":"                # not systemd??"},{"line_number":64,"context_line":"                echo \"*** WARNING: libvirt coredumps not configured\""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"ffe62b97_963491df","line":61,"updated":"2017-03-29 10:03:21.000000000","message":"nit:\n\nsudo systemctl restart libvirt-bin.service?\n\nSeems weird to explicitly update the systemd unit, then explicitly call a SysV init script. I\u0027m assuming, btw, that the SysV script just calls systemd on Ubuntu so this is fine even though it looks wrong?","commit_id":"ea160bc9b18def4e9342eebbb73a0b5046e48428"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"a126e112453b78ca700244d6c7793a57c4be8a35","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                iniset -sudo $f \"Service\" \"LimitCORE\" \"infinity\""},{"line_number":53,"context_line":"                sudo systemctl daemon-reload"},{"line_number":54,"context_line":"                # make sure it\u0027s widely writable"},{"line_number":55,"context_line":"                sudo mkdir /var/core"},{"line_number":56,"context_line":"                sudo chmod a+wrx /var/core"},{"line_number":57,"context_line":"                # instruct the kernel to save to here"},{"line_number":58,"context_line":"                echo \u0027/var/core/core.%e.%p.%h.%t\u0027 | \\"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"ffe62b97_73259108","line":55,"updated":"2017-03-29 14:00:01.000000000","message":"This fails if /var/core already exists.","commit_id":"3f46eab1c600ccd06ba75a42715adaa5959d3826"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"577a15083dc236a8f161643c173ea3bec7adacb6","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    # Drop a config file to up the core ulimit"},{"line_number":48,"context_line":"    sudo mkdir -p ${confdir}"},{"line_number":49,"context_line":"    sudo tee ${conffile} \u003c\u003cEOF"},{"line_number":50,"context_line":"[Service]"},{"line_number":51,"context_line":"LimitCORE\u003dinfinity"},{"line_number":52,"context_line":"EOF"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"ffe62b97_bc1621f1","line":49,"updated":"2017-03-30 10:56:06.000000000","message":"In case it comes up, there were 2 reasons I didn\u0027t use inifile here:\n\n1. It\u0027s unnecessary complexity when we\u0027re creating a new file\n2. When I added efence I noticed that inifile doesn\u0027t support setting the same value (Environment) multiple times\n\nWe could use it, but if we end up poking environment variables in here later we\u0027d have to take it out again. I think this is clear.","commit_id":"bfcc760b9650b09af073e1c6beb489069e5eec0d"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"451389287c97284c58700ae4ac0ad6251c71d2c1","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    # Drop a config file to up the core ulimit"},{"line_number":48,"context_line":"    sudo mkdir -p ${confdir}"},{"line_number":49,"context_line":"    sudo tee ${conffile} \u003c\u003cEOF"},{"line_number":50,"context_line":"[Service]"},{"line_number":51,"context_line":"LimitCORE\u003dinfinity"},{"line_number":52,"context_line":"EOF"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"dfeb2761_788777d9","line":49,"in_reply_to":"ffe62b97_bc1621f1","updated":"2017-03-31 05:44:23.000000000","message":"i think this is quite clear anyway","commit_id":"bfcc760b9650b09af073e1c6beb489069e5eec0d"}]}