)]}'
{"stack.sh":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ccc3d6938fc85bc489bf165406bdef8e95fe6dc3","unresolved":false,"context_lines":[{"line_number":55,"context_line":"# Configuration"},{"line_number":56,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"if [[ -d /etc/apt/sources.list.d ]] ; then"},{"line_number":59,"context_line":"    source /etc/nodepool/provider"},{"line_number":60,"context_line":"    NODEPOOL_MIRROR_HOST\u003d${NODEPOOL_MIRROR_HOST:-mirror.$NODEPOOL_REGION.$NODEPOOL_CLOUD.openstack.org}"},{"line_number":61,"context_line":"    NODEPOOL_MIRROR_HOST\u003d$(echo $NODEPOOL_MIRROR_HOST|tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ffe62b97_546ee2c8","line":58,"updated":"2017-03-29 21:11:05.000000000","message":"Is this Debian safe?","commit_id":"cefc4814fd9f7d012bea8c44526a757689ae7936"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"455d4d1e5ad446f9753d157223e51405aed033d0","unresolved":false,"context_lines":[{"line_number":212,"context_line":"# Local Settings"},{"line_number":213,"context_line":"# --------------"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"if is_ubuntu \u0026\u0026 [[ -d /etc/apt/sources.list.d ]] ; then"},{"line_number":216,"context_line":"    # Use UCA for newer libvirt. Should give us libvirt 2.5.0."},{"line_number":217,"context_line":"    if [[ -f /etc/nodepool/provider ]] ; then"},{"line_number":218,"context_line":"        # If we are on a nodepool provided host and apt is configured to use"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ffe62b97_fa0f1f2b","line":215,"updated":"2017-03-29 22:03:24.000000000","message":"we probably want a specific ${DISTRO} gate on this","commit_id":"4ab0243a9b9d220cdba7ccf41ac02003577dd1cd"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"c45f286bbb9a65f546987f3468517794b7c25e29","unresolved":false,"context_lines":[{"line_number":212,"context_line":"# Local Settings"},{"line_number":213,"context_line":"# --------------"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"if [[ $os_VENDOR \u003d~ (Ubuntu) ]] \u0026\u0026 [[ -d /etc/apt/sources.list.d ]] ; then"},{"line_number":216,"context_line":"    # Use UCA for newer libvirt. Should give us libvirt 2.5.0."},{"line_number":217,"context_line":"    if [[ -f /etc/nodepool/provider ]] ; then"},{"line_number":218,"context_line":"        # If we are on a nodepool provided host and apt is configured to use"}],"source_content_type":"text/x-sh","patch_set":8,"id":"dfeb2761_b51d18bf","line":215,"updated":"2017-03-30 19:07:42.000000000","message":"I think this logic should be moved in tools/fixup.sh. At least somewhere else than stack.sh\n\nAlso, that would be great if that was controlled by a config flag (USE_UCA_FOR_LIBVIRT).\n\nFinally this PPA makes use get more than libvirt from UCA. Maybe it\u0027s worth considering http://askubuntu.com/a/170265 but that may be overkill and actually this may no be an issue.","commit_id":"cf07dcf0c15368f1646ef9cfcf7376530ec1a249"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d3680109d553d8a45f1b97e85600a9975e5f7b6e","unresolved":false,"context_lines":[{"line_number":212,"context_line":"# Local Settings"},{"line_number":213,"context_line":"# --------------"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"if [[ $os_VENDOR \u003d~ (Ubuntu) ]] \u0026\u0026 [[ -d /etc/apt/sources.list.d ]] ; then"},{"line_number":216,"context_line":"    # Use UCA for newer libvirt. Should give us libvirt 2.5.0."},{"line_number":217,"context_line":"    if [[ -f /etc/nodepool/provider ]] ; then"},{"line_number":218,"context_line":"        # If we are on a nodepool provided host and apt is configured to use"}],"source_content_type":"text/x-sh","patch_set":8,"id":"dfeb2761_7b889f70","line":215,"in_reply_to":"dfeb2761_b51d18bf","updated":"2017-03-30 20:06:05.000000000","message":"Ya we can clean up the helper stuff (the use mirror check below is a good candidate too).\n\nAs for making UCA configurable my current thought on that is it shouldn\u0027t be. It just adds too much variance to the builds which affects wheel mirrors among other things. We have in the past stuck to not using UCA and I think we can potentially decide to use the UCA but shouldn\u0027t make it configurable.","commit_id":"cf07dcf0c15368f1646ef9cfcf7376530ec1a249"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"05ad28d9c12db012c2396be6b6d67783df06566f","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        NODEPOOL_UCA_MIRROR\u003d${NODEPOOL_UCA_MIRROR:-http://$NODEPOOL_MIRROR_HOST/ubuntu-cloud-archive}"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        if grep \"$NODEPOOL_MIRROR_HOST\" /etc/apt/sources.list ; then"},{"line_number":226,"context_line":"            echo \"deb $NODEPOOL_UCA_MIRROR xenial-updates/ocata main\" \u003e /tmp/use-ocata-uca.list"},{"line_number":227,"context_line":"            sudo mv /tmp/use-ocata-uca.list /etc/apt/sources.list.d/use-ocata-uca.list"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"            # Disable use of libvirt wheel here as presence of mirror implies"}],"source_content_type":"text/x-sh","patch_set":8,"id":"dfeb2761_967063de","line":226,"updated":"2017-04-04 11:13:43.000000000","message":"You can use apt-add-repository here as well \n\n  apt-add-repository \"deb $NODEPOOL_UCA_MIRROR xenial-updates/ocata main\"\n\nIt would also be nice for nodepool to actually set NODEPOOL_UCA_MIRROR itself instead of us constructing it.","commit_id":"cf07dcf0c15368f1646ef9cfcf7376530ec1a249"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"dcdeda4927d9a204d30ea085739ae92782d66591","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        # we can find local mirrors then use that mirror."},{"line_number":220,"context_line":"        source /etc/ci/mirror_info.sh"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        sudo apt-add-repository \"deb $NODEPOOL_UCA_MIRROR xenial-updates/ocata main\""},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        # Disable use of libvirt wheel here as presence of mirror implies"},{"line_number":225,"context_line":"        # presence of cached wheel build against older libvirt binary."}],"source_content_type":"text/x-sh","patch_set":9,"id":"bff0334d_329bbc66","line":222,"range":{"start_line":222,"start_character":58,"end_line":222,"end_character":64},"updated":"2017-04-10 17:24:48.000000000","message":"is this going to be an issue (hard coding xenial transition?) also what happens when we roll over to another LTS?","commit_id":"840cd7eafbb7cfb941e0ba3f21504bb0fd1e2c38"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"e01eb552637d040f9f987cf947bd5ef3aaf029d9","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        # we can find local mirrors then use that mirror."},{"line_number":220,"context_line":"        source /etc/ci/mirror_info.sh"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        sudo apt-add-repository \"deb $NODEPOOL_UCA_MIRROR xenial-updates/ocata main\""},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        # Disable use of libvirt wheel here as presence of mirror implies"},{"line_number":225,"context_line":"        # presence of cached wheel build against older libvirt binary."}],"source_content_type":"text/x-sh","patch_set":9,"id":"bff0334d_7505ae10","line":222,"range":{"start_line":222,"start_character":58,"end_line":222,"end_character":64},"in_reply_to":"bff0334d_329bbc66","updated":"2017-04-10 17:39:14.000000000","message":"I should further restrict this to is really ubuntu and is xenial I think. That way newer distro releases can use their default packages and then new LTS can opt into UCA itself when ready.","commit_id":"840cd7eafbb7cfb941e0ba3f21504bb0fd1e2c38"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"f1d7f52657366275880eb6cca79501bdda3f46d2","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    fi"},{"line_number":233,"context_line":"    # This means the next package installl will trigger the right updating"},{"line_number":234,"context_line":"    unset REPOS_UPDATED"},{"line_number":235,"context_line":"fi"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"# Make sure the proxy config is visible to sub-processes"},{"line_number":238,"context_line":"export_proxy_variables"}],"source_content_type":"text/x-sh","patch_set":11,"id":"bff0334d_d3536f6a","line":235,"updated":"2017-04-10 20:27:44.000000000","message":"I think the only questions I\u0027ve got is whether this remains in the main flow or in fixups.sh (which is where we do lots of other package tweaks). I don\u0027t think there is anything quite as critical about this as the epel setup, so pushing it to fixup.sh seems a little cleaner.","commit_id":"bbab945028b310ec4d1b4923cce947f4772c4bdc"}],"stackrc":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a9f74a0656b94f9a7ee257f81e8bbd64695e5a4b","unresolved":false,"context_lines":[{"line_number":602,"context_line":"        if [[ \"$os_VENDOR\" \u003d~ (Debian|Ubuntu) ]]; then"},{"line_number":603,"context_line":"            # The groups change with newer libvirt. Do a quick check if a"},{"line_number":604,"context_line":"            # group already exists to handle grenade\u0027s case."},{"line_number":605,"context_line":"            LIBVIRT_GROUP\u003d$(cut -d \u0027:\u0027 -f 1 /etc/group | grep libvirt || true)"},{"line_number":606,"context_line":"            LIBVIRT_GROUP\u003d${LIBVIRT_GROUP:-libvirt}"},{"line_number":607,"context_line":"        else"},{"line_number":608,"context_line":"            LIBVIRT_GROUP\u003dlibvirtd"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"bff0334d_8e3927d8","line":605,"updated":"2017-04-11 13:20:52.000000000","message":"The pkg libvirt-daemon-system also install a group \"libvirt-qemu\", resulting in setting LIBVIRT_GROUP\u003d\"libvirt libvirt-qemu\" which looks broken to me.","commit_id":"3cc8e1d24ba11459b94f9054b2f166ffc5d26730"}],"tools/fixup_stuff.sh":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a8d84bdbaab0aee4fe19495520719403b50d1122","unresolved":false,"context_lines":[{"line_number":72,"context_line":"# We\u0027ve found that Libvirt on Xenial is flaky and crashes enough to be"},{"line_number":73,"context_line":"# a regular top e-r bug. Opt into Ubuntu Cloud Archive if on Xenial to"},{"line_number":74,"context_line":"# get newer Libvirt."},{"line_number":75,"context_line":"if is_really_ubuntu \u0026\u0026 [[ \"$os_CODENAME\" \u003d \"xenial\" ]]; then"},{"line_number":76,"context_line":"    # This pulls in apt-add-repository"},{"line_number":77,"context_line":"    install_package \"software-properties-common\""},{"line_number":78,"context_line":"    # Use UCA for newer libvirt. Should give us libvirt 2.5.0."}],"source_content_type":"text/x-sh","patch_set":14,"id":"bff0334d_bd441175","line":75,"updated":"2017-04-11 21:28:49.000000000","message":"$DISTRO is the one to check ... os_CODENAME does work i guess but DISTRO is the one we\u0027re exposing\n\ndo we really need \"is_really_ubuntu\" when checking the distro?  it\u0027s implied?","commit_id":"6c45cd6213c8d02924cea1c67e87884c84a58b6a"}]}