)]}'
{"functions-common":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fcc43ecb2b3430c7c6c7f3f58f5780ab18a70668","unresolved":false,"context_lines":[{"line_number":1506,"context_line":"    local user\u003d${4:-$STACK_USER}"},{"line_number":1507,"context_line":"    local uwsgi\u003d$(trueorfalse False $5)"},{"line_number":1508,"context_line":"    if [[ \"$uwsgi\" \u003d\u003d \"True\" ]] ; then"},{"line_number":1509,"context_line":"        write_uwsgi_unit_file $systemd_service \"$cmd\" \"$group\" \"$user\""},{"line_number":1510,"context_line":"    else"},{"line_number":1511,"context_line":"        write_user_unit_file $systemd_service \"$cmd\" \"$group\" \"$user\""},{"line_number":1512,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ffe62b97_111061ff","line":1509,"updated":"2017-03-30 04:54:20.000000000","message":"write_uwsgi_user_unit_file","commit_id":"cecfab8184e5d4367efb44b4d63f941461708a64"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a495d975a94c26bb094274e3f34f15c2d5320c52","unresolved":false,"context_lines":[{"line_number":1474,"context_line":"    local user\u003d$4"},{"line_number":1475,"context_line":"    local extra\u003d\"\""},{"line_number":1476,"context_line":"    if [[ -n \"$group\" ]]; then"},{"line_number":1477,"context_line":"        extra\u003d\"Group\u003d$group\""},{"line_number":1478,"context_line":"    fi"},{"line_number":1479,"context_line":"    local unitfile\u003d\"$SYSTEMD_DIR/$service\""},{"line_number":1480,"context_line":"    mkdir -p $SYSTEMD_DIR"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"dfeb2761_9b355e49","line":1477,"updated":"2017-04-03 06:20:13.000000000","message":"This is still not being used anywhere, so pls drop it.","commit_id":"07b6162f84afdf7986b2a0830aa907c46ccfb8b9"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"20bf951b25f66d217e3102b651f734327e5b66ce","unresolved":false,"context_lines":[{"line_number":1474,"context_line":"    local user\u003d$4"},{"line_number":1475,"context_line":"    local extra\u003d\"\""},{"line_number":1476,"context_line":"    if [[ -n \"$group\" ]]; then"},{"line_number":1477,"context_line":"        extra\u003d\"Group\u003d$group\""},{"line_number":1478,"context_line":"    fi"},{"line_number":1479,"context_line":"    local unitfile\u003d\"$SYSTEMD_DIR/$service\""},{"line_number":1480,"context_line":"    mkdir -p $SYSTEMD_DIR"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"dfeb2761_c4df75d4","line":1477,"in_reply_to":"dfeb2761_9b355e49","updated":"2017-04-03 14:32:17.000000000","message":"agree","commit_id":"07b6162f84afdf7986b2a0830aa907c46ccfb8b9"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"73c109e735e8b550821a24ad39d71b3fabbe68d4","unresolved":false,"context_lines":[{"line_number":1474,"context_line":"    local user\u003d$4"},{"line_number":1475,"context_line":"    local extra\u003d\"\""},{"line_number":1476,"context_line":"    if [[ -n \"$group\" ]]; then"},{"line_number":1477,"context_line":"        extra\u003d\"Group\u003d$group\""},{"line_number":1478,"context_line":"    fi"},{"line_number":1479,"context_line":"    local unitfile\u003d\"$SYSTEMD_DIR/$service\""},{"line_number":1480,"context_line":"    mkdir -p $SYSTEMD_DIR"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"dfeb2761_9b3667e6","line":1477,"in_reply_to":"dfeb2761_c4df75d4","updated":"2017-04-03 16:49:07.000000000","message":"Done","commit_id":"07b6162f84afdf7986b2a0830aa907c46ccfb8b9"},{"author":{"_account_id":17716,"name":"Luz Cazares","email":"luz.cazares@intel.com","username":"luzcazares"},"change_message_id":"2d8d275a85bf5b285832ab10055514cb45479e70","unresolved":false,"context_lines":[{"line_number":1500,"context_line":"    local systemd_service\u003d\"devstack@$service.service\""},{"line_number":1501,"context_line":"    local group\u003d$3"},{"line_number":1502,"context_line":"    local user\u003d${4:-$STACK_USER}"},{"line_number":1503,"context_line":"    if [[ \"$command\" \u003d~ \"uwsgi\" ]] ; then"},{"line_number":1504,"context_line":"        write_uwsgi_user_unit_file $systemd_service \"$cmd\" \"$group\" \"$user\""},{"line_number":1505,"context_line":"    else"},{"line_number":1506,"context_line":"        write_user_unit_file $systemd_service \"$cmd\" \"$group\" \"$user\""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"dfeb2761_ce487988","line":1503,"range":{"start_line":1503,"start_character":4,"end_line":1503,"end_character":41},"updated":"2017-04-04 21:21:02.000000000","message":"why not modifying \"write_user_unit_file\" method to handle uwsgi case - for reusability purposes?","commit_id":"9c5ffd8d132866bd6120696e138e5b7b42dc3f23"}],"lib/keystone":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fcc43ecb2b3430c7c6c7f3f58f5780ab18a70668","unresolved":false,"context_lines":[{"line_number":604,"context_line":"        # TODO(sdague): we should really get down to a single keystone here"},{"line_number":605,"context_line":"        enable_service key-p"},{"line_number":606,"context_line":"        enable_service key-a"},{"line_number":607,"context_line":"        run_process key-p \"$KEYSTONE_BIN_DIR/uwsgi --ini $KEYSTONE_PUBLIC_UWSGI_FILE\" \"\" \"True\""},{"line_number":608,"context_line":"        run_process key-a \"$KEYSTONE_BIN_DIR/uwsgi --ini $KEYSTONE_ADMIN_UWSGI_FILE\" \"\" \"True\""},{"line_number":609,"context_line":"    fi"},{"line_number":610,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ffe62b97_31a9258f","line":607,"updated":"2017-03-30 04:54:20.000000000","message":"if I\u0027m not miscounting arguments, this sets the user to True, need to insert another \"\" to set uwsgi.","commit_id":"cecfab8184e5d4367efb44b4d63f941461708a64"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"3c10899c809173e2f02148253b19345b47c12855","unresolved":false,"context_lines":[{"line_number":605,"context_line":"        enable_service key-p"},{"line_number":606,"context_line":"        enable_service key-a"},{"line_number":607,"context_line":"        run_process key-p \"$KEYSTONE_BIN_DIR/uwsgi --ini $KEYSTONE_PUBLIC_UWSGI_FILE\" \"\" \"\" \"True\""},{"line_number":608,"context_line":"        run_process key-a \"$KEYSTONE_BIN_DIR/uwsgi --ini $KEYSTONE_ADMIN_UWSGI_FILE\" \"\" \"\" \"True\""},{"line_number":609,"context_line":"    fi"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"    echo \"Waiting for keystone to start...\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"dfeb2761_5ff5a2ca","line":608,"updated":"2017-03-31 17:46:29.000000000","message":"the extra parameters are no longer needed","commit_id":"1b36f1b233ae8507c6f9d36fde7c65897cff5dea"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"00693eba73c136a8d130db4795042903fcce57c7","unresolved":false,"context_lines":[{"line_number":605,"context_line":"        enable_service key-p"},{"line_number":606,"context_line":"        enable_service key-a"},{"line_number":607,"context_line":"        run_process key-p \"$KEYSTONE_BIN_DIR/uwsgi --ini $KEYSTONE_PUBLIC_UWSGI_FILE\" \"\" \"\" \"True\""},{"line_number":608,"context_line":"        run_process key-a \"$KEYSTONE_BIN_DIR/uwsgi --ini $KEYSTONE_ADMIN_UWSGI_FILE\" \"\" \"\" \"True\""},{"line_number":609,"context_line":"    fi"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"    echo \"Waiting for keystone to start...\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"dfeb2761_0b2b58eb","line":608,"in_reply_to":"dfeb2761_5ff5a2ca","updated":"2017-03-31 20:15:37.000000000","message":"Done","commit_id":"1b36f1b233ae8507c6f9d36fde7c65897cff5dea"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"3c10899c809173e2f02148253b19345b47c12855","unresolved":false,"context_lines":[{"line_number":640,"context_line":"        restart_apache_server"},{"line_number":641,"context_line":"    fi"},{"line_number":642,"context_line":"    # Kill the Keystone screen window"},{"line_number":643,"context_line":"    stop_process key"},{"line_number":644,"context_line":"}"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"# bootstrap_keystone() - Initialize user, role and project"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"dfeb2761_7f21864d","line":643,"updated":"2017-03-31 17:46:29.000000000","message":"this is going to need to be stop_process key-a, key-p as well","commit_id":"1b36f1b233ae8507c6f9d36fde7c65897cff5dea"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"00693eba73c136a8d130db4795042903fcce57c7","unresolved":false,"context_lines":[{"line_number":640,"context_line":"        restart_apache_server"},{"line_number":641,"context_line":"    fi"},{"line_number":642,"context_line":"    # Kill the Keystone screen window"},{"line_number":643,"context_line":"    stop_process key"},{"line_number":644,"context_line":"}"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"# bootstrap_keystone() - Initialize user, role and project"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"dfeb2761_2bf05c90","line":643,"in_reply_to":"dfeb2761_7f21864d","updated":"2017-03-31 20:15:37.000000000","message":"Done","commit_id":"1b36f1b233ae8507c6f9d36fde7c65897cff5dea"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a495d975a94c26bb094274e3f34f15c2d5320c52","unresolved":false,"context_lines":[{"line_number":604,"context_line":"        # TODO(sdague): we should really get down to a single keystone here"},{"line_number":605,"context_line":"        enable_service key-p"},{"line_number":606,"context_line":"        enable_service key-a"},{"line_number":607,"context_line":"        run_process key-p \"$KEYSTONE_BIN_DIR/uwsgi --ini $KEYSTONE_PUBLIC_UWSGI_FILE\" \"\" \"True\""},{"line_number":608,"context_line":"        run_process key-a \"$KEYSTONE_BIN_DIR/uwsgi --ini $KEYSTONE_ADMIN_UWSGI_FILE\" \"\" \"True\""},{"line_number":609,"context_line":"    fi"},{"line_number":610,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"dfeb2761_9b0e7e8b","line":607,"updated":"2017-04-03 06:20:13.000000000","message":"That \"True\" parameter at the end will try to set the user the process is being run as, you should drop it.\n\nAlso, can you explain why the \"--ini\" is being needed? Seemed to work find without it before.","commit_id":"07b6162f84afdf7986b2a0830aa907c46ccfb8b9"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"73c109e735e8b550821a24ad39d71b3fabbe68d4","unresolved":false,"context_lines":[{"line_number":604,"context_line":"        # TODO(sdague): we should really get down to a single keystone here"},{"line_number":605,"context_line":"        enable_service key-p"},{"line_number":606,"context_line":"        enable_service key-a"},{"line_number":607,"context_line":"        run_process key-p \"$KEYSTONE_BIN_DIR/uwsgi --ini $KEYSTONE_PUBLIC_UWSGI_FILE\" \"\" \"True\""},{"line_number":608,"context_line":"        run_process key-a \"$KEYSTONE_BIN_DIR/uwsgi --ini $KEYSTONE_ADMIN_UWSGI_FILE\" \"\" \"True\""},{"line_number":609,"context_line":"    fi"},{"line_number":610,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"dfeb2761_5b9c5fbf","line":607,"in_reply_to":"dfeb2761_24dbc1ed","updated":"2017-04-03 16:49:07.000000000","message":"Done.\n\nAs for --ini it was in the uwsgi docs so I figured it was better to add it. Looking at the uwsgi docs it will automatically assume --ini if the config file passed in ends with \u0027.ini\u0027. But, only xml and ini are detected based on the file extension. But, I can drop it if you don\u0027t think we want to be opinionated about the config file format (uwsgi also supports xml, yaml, json, ldap, and in the near future sqlite for configuration) Personally, I think it\u0027s fine to say we only want ini files for the keystone uwsgi config though.","commit_id":"07b6162f84afdf7986b2a0830aa907c46ccfb8b9"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"20bf951b25f66d217e3102b651f734327e5b66ce","unresolved":false,"context_lines":[{"line_number":604,"context_line":"        # TODO(sdague): we should really get down to a single keystone here"},{"line_number":605,"context_line":"        enable_service key-p"},{"line_number":606,"context_line":"        enable_service key-a"},{"line_number":607,"context_line":"        run_process key-p \"$KEYSTONE_BIN_DIR/uwsgi --ini $KEYSTONE_PUBLIC_UWSGI_FILE\" \"\" \"True\""},{"line_number":608,"context_line":"        run_process key-a \"$KEYSTONE_BIN_DIR/uwsgi --ini $KEYSTONE_ADMIN_UWSGI_FILE\" \"\" \"True\""},{"line_number":609,"context_line":"    fi"},{"line_number":610,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"dfeb2761_24dbc1ed","line":607,"in_reply_to":"dfeb2761_9b0e7e8b","updated":"2017-04-03 14:32:17.000000000","message":"agree","commit_id":"07b6162f84afdf7986b2a0830aa907c46ccfb8b9"}]}