)]}'
{"lib/docker":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"74725ee1199c79d20c15b2dc3a550d4fcb3eba5e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    # things. It\u0027s a bug in install_docker.sh that it relies on those and"},{"line_number":49,"context_line":"    # uses a shebang of /bin/sh, but that doesn\u0027t help us if we want to run"},{"line_number":50,"context_line":"    # docker and specifically Kuryr. So, this works around that."},{"line_number":51,"context_line":"    sudo update-alternatives --install /bin/sh sh /bin/bash 100"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    # Install docker only if it\u0027s not already installed. The following checks"},{"line_number":54,"context_line":"    # whether the docker-engine package is already installed, as this is the"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dfeb2761_5f5c507d","line":51,"updated":"2017-04-03 15:07:07.000000000","message":"I suggest, although I totally understand the googlie eyes, just changing the invocations of install_docker.sh to be \"bash install_docker.sh\" - god only knows what else will break by changing system /bin/sh back to bash (it\u0027s been dash since at least maverick)","commit_id":"76d40fc7a0e9fea4abbe88ab70bc587f271c6915"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"7ddb8ffac078505a75ae3ab22533244eb75308e5","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    # things. It\u0027s a bug in install_docker.sh that it relies on those and"},{"line_number":49,"context_line":"    # uses a shebang of /bin/sh, but that doesn\u0027t help us if we want to run"},{"line_number":50,"context_line":"    # docker and specifically Kuryr. So, this works around that."},{"line_number":51,"context_line":"    sudo update-alternatives --install /bin/sh sh /bin/bash 100"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    # Install docker only if it\u0027s not already installed. The following checks"},{"line_number":54,"context_line":"    # whether the docker-engine package is already installed, as this is the"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dfeb2761_7a9e02b9","line":51,"in_reply_to":"dfeb2761_5f5c507d","updated":"2017-04-03 15:08:14.000000000","message":"Agreed, it would also mean that projects could accidentally ship /bin/sh scripts that aren\u0027t using sh","commit_id":"76d40fc7a0e9fea4abbe88ab70bc587f271c6915"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"225c769e7a1d13bd9e72dee0dc3dcf65844ea917","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    # manually installed, the install_docker.sh script will prompt a warning"},{"line_number":57,"context_line":"    # if another docker executable is found"},{"line_number":58,"context_line":"    check_docker || {"},{"line_number":59,"context_line":"        wget http://get.docker.com -O install_docker.sh"},{"line_number":60,"context_line":"        sudo chmod 777 install_docker.sh"},{"line_number":61,"context_line":"        sudo sh install_docker.sh"},{"line_number":62,"context_line":"        sudo rm install_docker.sh"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dfeb2761_737e356c","line":59,"updated":"2017-04-03 13:18:35.000000000","message":"at a minimum this *must* be an HTTPS address. This is also going to not really work well in the gate.\n\nHonestly, why are we unrolling the repository additions in the install_docker.sh script and doing them here? That would also allow them to be mirrored to infra, and not rely in network during gate jobs.","commit_id":"76d40fc7a0e9fea4abbe88ab70bc587f271c6915"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"227872aa758271084fc727a1ee9e6c52fb9d9e2d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    # manually installed, the install_docker.sh script will prompt a warning"},{"line_number":57,"context_line":"    # if another docker executable is found"},{"line_number":58,"context_line":"    check_docker || {"},{"line_number":59,"context_line":"        wget http://get.docker.com -O install_docker.sh"},{"line_number":60,"context_line":"        sudo chmod 777 install_docker.sh"},{"line_number":61,"context_line":"        sudo sh install_docker.sh"},{"line_number":62,"context_line":"        sudo rm install_docker.sh"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7ffa3b31_d643ccae","line":59,"in_reply_to":"dfeb2761_1f2808e0","updated":"2017-04-17 20:20:27.000000000","message":"Done","commit_id":"76d40fc7a0e9fea4abbe88ab70bc587f271c6915"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"73ba960145f3b46b8c695033eabfb1cae59b51d2","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    # manually installed, the install_docker.sh script will prompt a warning"},{"line_number":57,"context_line":"    # if another docker executable is found"},{"line_number":58,"context_line":"    check_docker || {"},{"line_number":59,"context_line":"        wget http://get.docker.com -O install_docker.sh"},{"line_number":60,"context_line":"        sudo chmod 777 install_docker.sh"},{"line_number":61,"context_line":"        sudo sh install_docker.sh"},{"line_number":62,"context_line":"        sudo rm install_docker.sh"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dfeb2761_7f34b4fb","line":59,"in_reply_to":"dfeb2761_1f2808e0","updated":"2017-04-03 15:06:38.000000000","message":"Sure. Will look into how to do that.","commit_id":"76d40fc7a0e9fea4abbe88ab70bc587f271c6915"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"cb07b35de3f26504682be1afabc12cdfb16fd2ca","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    # manually installed, the install_docker.sh script will prompt a warning"},{"line_number":57,"context_line":"    # if another docker executable is found"},{"line_number":58,"context_line":"    check_docker || {"},{"line_number":59,"context_line":"        wget http://get.docker.com -O install_docker.sh"},{"line_number":60,"context_line":"        sudo chmod 777 install_docker.sh"},{"line_number":61,"context_line":"        sudo sh install_docker.sh"},{"line_number":62,"context_line":"        sudo rm install_docker.sh"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dfeb2761_459d6cba","line":59,"in_reply_to":"dfeb2761_1f2808e0","updated":"2017-04-04 19:04:54.000000000","message":"yes that install script is just setting up a repository and adding a key. can easily be done in line.","commit_id":"76d40fc7a0e9fea4abbe88ab70bc587f271c6915"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"63d99fcc66747d1e2caa9fd1f7a3f32fce5e8c80","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    # manually installed, the install_docker.sh script will prompt a warning"},{"line_number":57,"context_line":"    # if another docker executable is found"},{"line_number":58,"context_line":"    check_docker || {"},{"line_number":59,"context_line":"        wget http://get.docker.com -O install_docker.sh"},{"line_number":60,"context_line":"        sudo chmod 777 install_docker.sh"},{"line_number":61,"context_line":"        sudo sh install_docker.sh"},{"line_number":62,"context_line":"        sudo rm install_docker.sh"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dfeb2761_1f2808e0","line":59,"in_reply_to":"dfeb2761_737e356c","updated":"2017-04-03 14:57:47.000000000","message":"That should be \"why aren\u0027t we\". When I read the install_docker.sh it\u0027s mostly about setting up some repositories and doing package installs, we should really just do that inline in devstack.","commit_id":"76d40fc7a0e9fea4abbe88ab70bc587f271c6915"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"225c769e7a1d13bd9e72dee0dc3dcf65844ea917","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        run_process docker-engine \"sudo /usr/bin/docker daemon -H unix://$DOCKER_ENGINE_SOCKET_FILE -H tcp://0.0.0.0:$DOCKER_ENGINE_PORT --cluster-store etcd://localhost:$ETCD_PORT\""},{"line_number":72,"context_line":"    else"},{"line_number":73,"context_line":"        run_process docker-engine \"sudo /usr/bin/docker daemon -H unix://$DOCKER_ENGINE_SOCKET_FILE -H tcp://0.0.0.0:$DOCKER_ENGINE_PORT\""},{"line_number":74,"context_line":"    fi"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    # We put the stack user as owner of the socket so we do not need to"},{"line_number":77,"context_line":"    # run the Docker commands with sudo when developing."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dfeb2761_b3371db1","line":74,"updated":"2017-04-03 13:18:35.000000000","message":"this is going to put docker in screen by default? Why can\u0027t we use the existing .service files coming off the repository to restart in a normal way?","commit_id":"76d40fc7a0e9fea4abbe88ab70bc587f271c6915"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"227872aa758271084fc727a1ee9e6c52fb9d9e2d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        run_process docker-engine \"sudo /usr/bin/docker daemon -H unix://$DOCKER_ENGINE_SOCKET_FILE -H tcp://0.0.0.0:$DOCKER_ENGINE_PORT --cluster-store etcd://localhost:$ETCD_PORT\""},{"line_number":72,"context_line":"    else"},{"line_number":73,"context_line":"        run_process docker-engine \"sudo /usr/bin/docker daemon -H unix://$DOCKER_ENGINE_SOCKET_FILE -H tcp://0.0.0.0:$DOCKER_ENGINE_PORT\""},{"line_number":74,"context_line":"    fi"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    # We put the stack user as owner of the socket so we do not need to"},{"line_number":77,"context_line":"    # run the Docker commands with sudo when developing."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7ffa3b31_b67960fd","line":74,"in_reply_to":"bff0334d_3e2529c3","updated":"2017-04-17 20:20:27.000000000","message":"Move it to docker configuration file /etc/docker/daemon.json . Done.","commit_id":"76d40fc7a0e9fea4abbe88ab70bc587f271c6915"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"02e65f1848da2e46b6f580d60cdb248b556d7b28","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        run_process docker-engine \"sudo /usr/bin/docker daemon -H unix://$DOCKER_ENGINE_SOCKET_FILE -H tcp://0.0.0.0:$DOCKER_ENGINE_PORT --cluster-store etcd://localhost:$ETCD_PORT\""},{"line_number":72,"context_line":"    else"},{"line_number":73,"context_line":"        run_process docker-engine \"sudo /usr/bin/docker daemon -H unix://$DOCKER_ENGINE_SOCKET_FILE -H tcp://0.0.0.0:$DOCKER_ENGINE_PORT\""},{"line_number":74,"context_line":"    fi"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    # We put the stack user as owner of the socket so we do not need to"},{"line_number":77,"context_line":"    # run the Docker commands with sudo when developing."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dfeb2761_fad7b24e","line":74,"in_reply_to":"dfeb2761_7a50420b","updated":"2017-04-03 15:10:23.000000000","message":"Well, I\u0027m working towards getting rid of screen, and using systemd for everything in devstack, so I think we should consider if we really want to maintain a dedicated .service that\u0027s not the installed one.","commit_id":"76d40fc7a0e9fea4abbe88ab70bc587f271c6915"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"227872aa758271084fc727a1ee9e6c52fb9d9e2d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        run_process docker-engine \"sudo /usr/bin/docker daemon -H unix://$DOCKER_ENGINE_SOCKET_FILE -H tcp://0.0.0.0:$DOCKER_ENGINE_PORT --cluster-store etcd://localhost:$ETCD_PORT\""},{"line_number":72,"context_line":"    else"},{"line_number":73,"context_line":"        run_process docker-engine \"sudo /usr/bin/docker daemon -H unix://$DOCKER_ENGINE_SOCKET_FILE -H tcp://0.0.0.0:$DOCKER_ENGINE_PORT\""},{"line_number":74,"context_line":"    fi"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    # We put the stack user as owner of the socket so we do not need to"},{"line_number":77,"context_line":"    # run the Docker commands with sudo when developing."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7ffa3b31_b614c0a1","line":74,"in_reply_to":"dfeb2761_b3371db1","updated":"2017-04-17 20:20:27.000000000","message":"Done","commit_id":"76d40fc7a0e9fea4abbe88ab70bc587f271c6915"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"73ba960145f3b46b8c695033eabfb1cae59b51d2","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        run_process docker-engine \"sudo /usr/bin/docker daemon -H unix://$DOCKER_ENGINE_SOCKET_FILE -H tcp://0.0.0.0:$DOCKER_ENGINE_PORT --cluster-store etcd://localhost:$ETCD_PORT\""},{"line_number":72,"context_line":"    else"},{"line_number":73,"context_line":"        run_process docker-engine \"sudo /usr/bin/docker daemon -H unix://$DOCKER_ENGINE_SOCKET_FILE -H tcp://0.0.0.0:$DOCKER_ENGINE_PORT\""},{"line_number":74,"context_line":"    fi"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    # We put the stack user as owner of the socket so we do not need to"},{"line_number":77,"context_line":"    # run the Docker commands with sudo when developing."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dfeb2761_7a50420b","line":74,"in_reply_to":"dfeb2761_b3371db1","updated":"2017-04-03 15:06:38.000000000","message":"Kuryr put docker in screen, but perhaps others won\u0027t. So agree with you, there should be an option to decide whether to put docker in screen and the default could be using existing .service files.","commit_id":"76d40fc7a0e9fea4abbe88ab70bc587f271c6915"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"e0d4ac0ef8a663c5da8b52bb666072aff9cd2501","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        run_process docker-engine \"sudo /usr/bin/docker daemon -H unix://$DOCKER_ENGINE_SOCKET_FILE -H tcp://0.0.0.0:$DOCKER_ENGINE_PORT --cluster-store etcd://localhost:$ETCD_PORT\""},{"line_number":72,"context_line":"    else"},{"line_number":73,"context_line":"        run_process docker-engine \"sudo /usr/bin/docker daemon -H unix://$DOCKER_ENGINE_SOCKET_FILE -H tcp://0.0.0.0:$DOCKER_ENGINE_PORT\""},{"line_number":74,"context_line":"    fi"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    # We put the stack user as owner of the socket so we do not need to"},{"line_number":77,"context_line":"    # run the Docker commands with sudo when developing."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bff0334d_3e2529c3","line":74,"in_reply_to":"dfeb2761_fad7b24e","updated":"2017-04-06 19:23:05.000000000","message":"We should be using the /etc/default/docker file for this. It supports DOCKER_OPTS for configuring specific things. Then, like Sean says, it already have a systemd file we can leverage.","commit_id":"76d40fc7a0e9fea4abbe88ab70bc587f271c6915"}]}