)]}'
{"lib/cinder":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"c135f3b80acc675713b3c0d5b21cc56e785a0b4b","unresolved":false,"context_lines":[{"line_number":542,"context_line":"# create_volume_types() - Create Cinder\u0027s configured volume types"},{"line_number":543,"context_line":"function create_volume_types {"},{"line_number":544,"context_line":"    # Create volume types"},{"line_number":545,"context_line":"    if is_service_enabled keystone \u0026\u0026 is_service_enabled c-api \u0026\u0026 [[ -n \"$CINDER_ENABLED_BACKENDS\" ]]; then"},{"line_number":546,"context_line":"        local be be_name"},{"line_number":547,"context_line":"        for be in ${CINDER_ENABLED_BACKENDS//,/ }; do"},{"line_number":548,"context_line":"            be_name\u003d${be##*:}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3f1d235d_38240cc6","line":545,"updated":"2017-07-11 13:02:17.000000000","message":"why is this guarded by keystone now? Will this not work in a noauth env?","commit_id":"8559df7997a72779cb7446fe1b9100a2b63f33a5"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"f15215d4ac70742843333c310830df1ca1d2bed9","unresolved":false,"context_lines":[{"line_number":542,"context_line":"# create_volume_types() - Create Cinder\u0027s configured volume types"},{"line_number":543,"context_line":"function create_volume_types {"},{"line_number":544,"context_line":"    # Create volume types"},{"line_number":545,"context_line":"    if is_service_enabled keystone \u0026\u0026 is_service_enabled c-api \u0026\u0026 [[ -n \"$CINDER_ENABLED_BACKENDS\" ]]; then"},{"line_number":546,"context_line":"        local be be_name"},{"line_number":547,"context_line":"        for be in ${CINDER_ENABLED_BACKENDS//,/ }; do"},{"line_number":548,"context_line":"            be_name\u003d${be##*:}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9f436f4f_e02310a6","line":545,"in_reply_to":"3f1d235d_38240cc6","updated":"2017-08-15 12:54:45.000000000","message":"It will work with noauth too. We need this check to have cinder working without Keystone","commit_id":"8559df7997a72779cb7446fe1b9100a2b63f33a5"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"1361fc24bd66cba6dbce24f434374a0edbb43620","unresolved":false,"context_lines":[{"line_number":543,"context_line":"function create_volume_types {"},{"line_number":544,"context_line":"    # Create volume types"},{"line_number":545,"context_line":"    # NOTE (e0ne): We don\u0027t need to create volume type if keystone is not"},{"line_number":546,"context_line":"    # enabled because openstack client doesn\u0027t support noauth"},{"line_number":547,"context_line":"    if is_service_enabled keystone \u0026\u0026 is_service_enabled c-api \u0026\u0026 [[ -n \"$CINDER_ENABLED_BACKENDS\" ]]; then"},{"line_number":548,"context_line":"        local be be_name"},{"line_number":549,"context_line":"        for be in ${CINDER_ENABLED_BACKENDS//,/ }; do"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7f287b81_87e1232d","line":546,"range":{"start_line":546,"start_character":22,"end_line":546,"end_character":54},"updated":"2017-08-28 13:58:46.000000000","message":"it does already - use \u0027none\u0027 auth type (auth plugin) and \u0027endpoint_override\u0027 option to point to cinder API URL (requires ksa ~3.1 AFAIR which is already in g-r and u-c)\n\nor the \u0027noauth\u0027 auth type bundled with cinderclient...\n\ndo volume types somehow require keystone?","commit_id":"2746f912118e8b635a17956cad85cb2e3b24216e"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"c86d581eaecac44fdab93b66c5b85d637bb10775","unresolved":false,"context_lines":[{"line_number":543,"context_line":"function create_volume_types {"},{"line_number":544,"context_line":"    # Create volume types"},{"line_number":545,"context_line":"    # NOTE (e0ne): We don\u0027t need to create volume type if keystone is not"},{"line_number":546,"context_line":"    # enabled because openstack client doesn\u0027t support noauth"},{"line_number":547,"context_line":"    if is_service_enabled keystone \u0026\u0026 is_service_enabled c-api \u0026\u0026 [[ -n \"$CINDER_ENABLED_BACKENDS\" ]]; then"},{"line_number":548,"context_line":"        local be be_name"},{"line_number":549,"context_line":"        for be in ${CINDER_ENABLED_BACKENDS//,/ }; do"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7f287b81_aed27e26","line":546,"range":{"start_line":546,"start_character":22,"end_line":546,"end_character":54},"in_reply_to":"7f287b81_87e1232d","updated":"2017-08-30 12:10:53.000000000","message":"Pavlo, thanks for the review. Unfortunately, cinderclient doesn\u0027t work with nouath mode + openstackclient [1]. I\u0027m going to fix it in a next release of cinderclient\n\n[1] http://paste.openstack.org/show/619882/","commit_id":"2746f912118e8b635a17956cad85cb2e3b24216e"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"0f8e65bc96ec7c95f43cc3588b8b95308e7c1c2d","unresolved":false,"context_lines":[{"line_number":544,"context_line":"    # Create volume types"},{"line_number":545,"context_line":"    # NOTE (e0ne): We don\u0027t need to create volume type if keystone is not"},{"line_number":546,"context_line":"    # enabled because openstack client doesn\u0027t support noauth"},{"line_number":547,"context_line":"    if is_service_enabled keystone \u0026\u0026 is_service_enabled c-api \u0026\u0026 [[ -n \"$CINDER_ENABLED_BACKENDS\" ]]; then"},{"line_number":548,"context_line":"        local be be_name"},{"line_number":549,"context_line":"        for be in ${CINDER_ENABLED_BACKENDS//,/ }; do"},{"line_number":550,"context_line":"            be_name\u003d${be##*:}"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"1f2f7f8d_cb235505","line":547,"updated":"2017-09-19 00:28:20.000000000","message":"I still don\u0027t understand why this has been gated by keystone?  don\u0027t you need to set the volume type always?","commit_id":"2746f912118e8b635a17956cad85cb2e3b24216e"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"33d16f177ea06ce6401013fb98a516167d9e0950","unresolved":false,"context_lines":[{"line_number":536,"context_line":"                # TODO (e0ne): use openstack client once it will support cinder in noauth mode"},{"line_number":537,"context_line":"                local cinder_url"},{"line_number":538,"context_line":"                cinder_url\u003d$CINDER_SERVICE_PROTOCOL://$SERVICE_HOST:$CINDER_SERVICE_PORT/v3"},{"line_number":539,"context_line":"                OS_USER_ID\u003d$OS_USERNAME OS_PROJECT_ID\u003d$OS_PROJECT_NAME cinder --os-auth-type noauth --os-endpoint\u003d$cinder_url type-create ${be_name}"},{"line_number":540,"context_line":"                OS_USER_ID\u003d$OS_USERNAME OS_PROJECT_ID\u003d$OS_PROJECT_NAME cinder --os-auth-type noauth --os-endpoint\u003d$cinder_url type-key ${be_name} set volume_backend_name\u003d${be_name}"},{"line_number":541,"context_line":"           fi"},{"line_number":542,"context_line":"        done"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3f4b6375_ae6ba6b4","line":539,"range":{"start_line":539,"start_character":93,"end_line":539,"end_character":99},"updated":"2017-11-06 17:39:21.000000000","message":"AFAIU the \u0027noauth\u0027 auth plugin provided by cinderclient is mostly suitable for cinder \u003c v3, as that requires a (fake) project_id..\n\nas you are using cinder v3, can you use a \u0027none\u0027 auth plugin from keystoneauth here?","commit_id":"08fe376ba804b8f97c77c71051adf188d5c7aed2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a9df69e1469ff9d37cee2115d7cee400a718c377","unresolved":false,"context_lines":[{"line_number":524,"context_line":"# create_volume_types() - Create Cinder\u0027s configured volume types"},{"line_number":525,"context_line":"function create_volume_types {"},{"line_number":526,"context_line":"    # Create volume types"},{"line_number":527,"context_line":"    if  is_service_enabled c-api \u0026\u0026 [[ -n \"$CINDER_ENABLED_BACKENDS\" ]]; then"},{"line_number":528,"context_line":"        local be be_name"},{"line_number":529,"context_line":"        for be in ${CINDER_ENABLED_BACKENDS//,/ }; do"},{"line_number":530,"context_line":"            be_name\u003d${be##*:}"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"df7087c5_70009668","line":527,"updated":"2018-03-09 11:40:27.000000000","message":"Nit: The added \" \" looks unrelated/unnecessary.","commit_id":"b3445fe1d04484a5ec63a725ff2786fa15e035f3"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"49cff951c608988f4090f042649a1676274f3fad","unresolved":false,"context_lines":[{"line_number":524,"context_line":"# create_volume_types() - Create Cinder\u0027s configured volume types"},{"line_number":525,"context_line":"function create_volume_types {"},{"line_number":526,"context_line":"    # Create volume types"},{"line_number":527,"context_line":"    if  is_service_enabled c-api \u0026\u0026 [[ -n \"$CINDER_ENABLED_BACKENDS\" ]]; then"},{"line_number":528,"context_line":"        local be be_name"},{"line_number":529,"context_line":"        for be in ${CINDER_ENABLED_BACKENDS//,/ }; do"},{"line_number":530,"context_line":"            be_name\u003d${be##*:}"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"df7087c5_0dcb0a1e","line":527,"in_reply_to":"df7087c5_70009668","updated":"2018-03-12 20:26:12.000000000","message":"Done","commit_id":"b3445fe1d04484a5ec63a725ff2786fa15e035f3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a9df69e1469ff9d37cee2115d7cee400a718c377","unresolved":false,"context_lines":[{"line_number":532,"context_line":"            if is_service_enabled keystone; then"},{"line_number":533,"context_line":"                openstack --os-region-name\u003d\"$REGION_NAME\" volume type create --property volume_backend_name\u003d\"${be_name}\" ${be_name}"},{"line_number":534,"context_line":"            else"},{"line_number":535,"context_line":"                # TODO (e0ne): use openstack client once it will support cinder in noauth mode"},{"line_number":536,"context_line":"                local cinder_url"},{"line_number":537,"context_line":"                cinder_url\u003d$CINDER_SERVICE_PROTOCOL://$SERVICE_HOST:$CINDER_SERVICE_PORT/v3"},{"line_number":538,"context_line":"                OS_USER_ID\u003d$OS_USERNAME OS_PROJECT_ID\u003d$OS_PROJECT_NAME cinder --os-auth-type noauth --os-endpoint\u003d$cinder_url type-create ${be_name}"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"df7087c5_30d1befc","line":535,"updated":"2018-03-09 11:40:27.000000000","message":"Is there a bug report for that? Would be nice to have some reference to track.","commit_id":"b3445fe1d04484a5ec63a725ff2786fa15e035f3"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"49cff951c608988f4090f042649a1676274f3fad","unresolved":false,"context_lines":[{"line_number":532,"context_line":"            if is_service_enabled keystone; then"},{"line_number":533,"context_line":"                openstack --os-region-name\u003d\"$REGION_NAME\" volume type create --property volume_backend_name\u003d\"${be_name}\" ${be_name}"},{"line_number":534,"context_line":"            else"},{"line_number":535,"context_line":"                # TODO (e0ne): use openstack client once it will support cinder in noauth mode"},{"line_number":536,"context_line":"                local cinder_url"},{"line_number":537,"context_line":"                cinder_url\u003d$CINDER_SERVICE_PROTOCOL://$SERVICE_HOST:$CINDER_SERVICE_PORT/v3"},{"line_number":538,"context_line":"                OS_USER_ID\u003d$OS_USERNAME OS_PROJECT_ID\u003d$OS_PROJECT_NAME cinder --os-auth-type noauth --os-endpoint\u003d$cinder_url type-create ${be_name}"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"df7087c5_6ddba6ec","line":535,"in_reply_to":"df7087c5_30d1befc","updated":"2018-03-12 20:26:12.000000000","message":"Done","commit_id":"b3445fe1d04484a5ec63a725ff2786fa15e035f3"}]}