)]}'
{"id":"openstack%2Fdevstack~462727","triplet_id":"openstack%2Fdevstack~master~I204e94cd86b8c67012aabfca74796e593151c3a4","project":"openstack/devstack","branch":"master","topic":"mrclean","hashtags":[],"change_id":"I204e94cd86b8c67012aabfca74796e593151c3a4","subject":"Always have ./clean.sh run ./unstack.sh","status":"MERGED","created":"2017-05-04 20:06:06.000000000","updated":"2017-05-05 05:25:43.000000000","submitted":"2017-05-05 05:25:43.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3dbed49637d87680e68694443e1c241fd16b311a","_number":462727,"virtual_id_number":462727,"owner":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-05-05 05:25:43.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-05-04 20:57:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":2,"date":"2017-05-04 20:16:40.000000000","_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":2,"date":"2017-05-05 00:21:12.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":1,"date":"2017-05-05 00:21:12.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-05-04 20:16:40.000000000","updated_by":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"reviewer":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"state":"REVIEWER"},{"updated":"2017-05-04 20:57:09.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2017-05-05 05:25:43.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"f273e24e34acc47cb2e3fd3823ac66326b75bbc7","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2017-05-04 20:06:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"54a679abdaaf8a574af8c5a13376f9580e014f14","author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"date":"2017-05-04 20:16:40.000000000","message":"Patch Set 1: Code-Review+2\n\nHeh, I like that old todo in the original comment. How old is that?","accounts_in_message":[],"_revision_number":1},{"id":"258b2ea21bbe0c93bf401b6ba9417a7b3d2a5ff5","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2017-05-04 20:57:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/devstack/27/462727/1/check/tempest-dsvm-full-xenial/acee233/ : SUCCESS in 50m 45s","accounts_in_message":[],"_revision_number":1},{"id":"0b5d153a4f254f47b0f0f99c6610efa910fdf2a1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-04 21:31:03.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial http://logs.openstack.org/27/462727/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/644aca6/ : SUCCESS in 1h 07m 21s\n- gate-grenade-dsvm-neutron-ubuntu-xenial http://logs.openstack.org/27/462727/1/check/gate-grenade-dsvm-neutron-ubuntu-xenial/910258d/ : SUCCESS in 43m 05s\n- gate-tempest-dsvm-py35-ubuntu-xenial http://logs.openstack.org/27/462727/1/check/gate-tempest-dsvm-py35-ubuntu-xenial/934ad98/ : SUCCESS in 1h 13m 11s\n- gate-devstack-docs-ubuntu-xenial http://docs-draft.openstack.org/27/462727/1/check/gate-devstack-docs-ubuntu-xenial/418c56f//doc/build/html/ : SUCCESS in 2m 13s\n- gate-devstack-bashate http://logs.openstack.org/27/462727/1/check/gate-devstack-bashate/825ebef/ : SUCCESS in 2m 40s\n- gate-devstack-unit-tests http://logs.openstack.org/27/462727/1/check/gate-devstack-unit-tests/29a9006/ : SUCCESS in 2m 38s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv http://logs.openstack.org/27/462727/1/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv/f1467f1/ : SUCCESS in 37m 17s (non-voting)\n- gate-devstack-dsvm-updown-ubuntu-xenial http://logs.openstack.org/27/462727/1/check/gate-devstack-dsvm-updown-ubuntu-xenial/0cbe132/ : SUCCESS in 16m 36s\n- gate-devstack-dsvm-py35-updown-ubuntu-xenial-nv http://logs.openstack.org/27/462727/1/check/gate-devstack-dsvm-py35-updown-ubuntu-xenial-nv/d850dfe/ : SUCCESS in 22m 35s (non-voting)\n- gate-tempest-dsvm-neutron-identity-v3-only-full-ubuntu-xenial-nv http://logs.openstack.org/27/462727/1/check/gate-tempest-dsvm-neutron-identity-v3-only-full-ubuntu-xenial-nv/52dfcc8/ : SUCCESS in 1h 19m 19s (non-voting)\n- gate-swift-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/27/462727/1/check/gate-swift-dsvm-functional-ubuntu-xenial-nv/6dfa6a2/ : SUCCESS in 20m 53s (non-voting)\n- gate-grenade-dsvm-neutron-multinode-ubuntu-xenial http://logs.openstack.org/27/462727/1/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/eb91724/ : SUCCESS in 40m 10s\n- gate-tempest-dsvm-neutron-full-centos-7-nv http://logs.openstack.org/27/462727/1/check/gate-tempest-dsvm-neutron-full-centos-7-nv/15ada56/ : SUCCESS in 1h 18m 32s (non-voting)\n- gate-tempest-dsvm-neutron-linuxbridge-ubuntu-xenial http://logs.openstack.org/27/462727/1/check/gate-tempest-dsvm-neutron-linuxbridge-ubuntu-xenial/db9d0d3/ : SUCCESS in 1h 14m 36s","accounts_in_message":[],"_revision_number":1},{"id":"e2f305a6b402010660d948452ed24856a0dea830","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2017-05-04 21:45:42.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- dsvm-tempest-neutron-network http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/27/462727/1/check/dsvm-tempest-neutron-network/ba0c8a2 : SUCCESS in 1h 36m 13s","accounts_in_message":[],"_revision_number":1},{"id":"85b662cf5acf0875a8f4b769b36678331650d64e","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2017-05-04 23:20:22.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-full-nfv-xenial http://intel-openstack-ci-logs.ovh/portland/2017-05-04/462727/1/check/tempest-dsvm-full-nfv-xenial/8cf28b5 : SUCCESS in 2h 01m 40s\n- tempest-dsvm-ovsdpdk-nfv-networking-centos http://intel-openstack-ci-logs.ovh/portland/2017-05-04/462727/1/check/tempest-dsvm-ovsdpdk-nfv-networking-centos/af00255 : SUCCESS in 1h 31m 00s (non-voting)\n- tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial http://intel-openstack-ci-logs.ovh/portland/2017-05-04/462727/1/check/tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial/8956292 : SUCCESS in 1h 38m 11s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"36dc42cf9e48acfe1dbd69afce34f6598de53da3","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2017-05-05 00:21:12.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"a5f663d5d1f7ec07c2843eeb06ef8d6c87c30fea","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-05 00:21:22.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"b2ec78941f1b6b39bb9e5f3175b76a56e7e20d3d","date":"2017-05-05 05:25:43.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"af630bab2d6fc24c36f2ceccf4496f156b4dcf1e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-05 05:25:43.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial http://logs.openstack.org/27/462727/1/gate/gate-tempest-dsvm-neutron-full-ubuntu-xenial/47b2076/ : SUCCESS in 1h 17m 37s\n- gate-grenade-dsvm-neutron-ubuntu-xenial http://logs.openstack.org/27/462727/1/gate/gate-grenade-dsvm-neutron-ubuntu-xenial/5bb1a53/ : SUCCESS in 34m 12s\n- gate-tempest-dsvm-py35-ubuntu-xenial http://logs.openstack.org/27/462727/1/gate/gate-tempest-dsvm-py35-ubuntu-xenial/f1b6922/ : SUCCESS in 1h 10m 34s\n- gate-devstack-docs-ubuntu-xenial http://docs-draft.openstack.org/27/462727/1/gate/gate-devstack-docs-ubuntu-xenial/fdbc0ac//doc/build/html/ : SUCCESS in 2m 17s\n- gate-devstack-bashate http://logs.openstack.org/27/462727/1/gate/gate-devstack-bashate/1d2cd96/ : SUCCESS in 2m 04s\n- gate-grenade-dsvm-neutron-multinode-ubuntu-xenial http://logs.openstack.org/27/462727/1/gate/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/36a3bfc/ : SUCCESS in 59m 25s\n- gate-tempest-dsvm-neutron-linuxbridge-ubuntu-xenial http://logs.openstack.org/27/462727/1/gate/gate-tempest-dsvm-neutron-linuxbridge-ubuntu-xenial/ca036d1/ : SUCCESS in 1h 16m 36s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"eaadffe07b0516f103321c84013b755061ba7fb5","revisions":{"eaadffe07b0516f103321c84013b755061ba7fb5":{"kind":"REWORK","_number":1,"created":"2017-05-04 20:06:06.000000000","uploader":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"ref":"refs/changes/27/462727/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/27/462727/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/27/462727/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/27/462727/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/27/462727/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/27/462727/1"}}},"commit":{"parents":[{"commit":"b2bfe5617ac43a678a9113d5c955f5456c151319","subject":"Turn off use_journal because of eventlet concerns","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/b2bfe5617ac43a678a9113d5c955f5456c151319"}]}],"author":{"name":"Sean Dague","email":"sean@dague.net","date":"2017-05-04 20:05:19.000000000","tz":-240},"committer":{"name":"Sean Dague","email":"sean@dague.net","date":"2017-05-04 20:05:19.000000000","tz":-240},"subject":"Always have ./clean.sh run ./unstack.sh","message":"Always have ./clean.sh run ./unstack.sh\n\nThere was detection code in clean.sh to only run it if a screen\nsession was found, but in systemd world, that\u0027s obviously not\ntrue. This was causing me (and others) substantial confusion.\n\nChange-Id: I204e94cd86b8c67012aabfca74796e593151c3a4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/eaadffe07b0516f103321c84013b755061ba7fb5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/eaadffe07b0516f103321c84013b755061ba7fb5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}