)]}'
{"stackrc":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"2e7e855f18c087095eeec810ffb3ff6074b485cc","unresolved":false,"context_lines":[{"line_number":667,"context_line":""},{"line_number":668,"context_line":"# By default, devstack will use Ubuntu Cloud Archive. This can be"},{"line_number":669,"context_line":"# disabled by enabling the setting below."},{"line_number":670,"context_line":"# export DISABLE_UBUNTU_CLOUD_ARCHIVE\u003dTrue"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"# Images"},{"line_number":673,"context_line":"# ------"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff0f0b1f_46d9ac1f","line":670,"range":{"start_line":670,"start_character":0,"end_line":670,"end_character":42},"updated":"2017-05-24 11:31:53.000000000","message":"I would prefer something like:\n\nDISABLE_UBUNTU_CLOUD_ARCHIVE\u003d$(trueorfalse True DISABLE_UBUNTU_CLOUD_ARCHIVE)\n\nWith the proposed implementation setting DISABLE_UBUNTU_CLOUD_ARCHIVE\u003dFalse disables UCA which I find confusing.","commit_id":"46b24b1ddd8faadd0bce261e21e498cbe32b4a7c"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b33c93eb1045f6f4aafe0a75158bf731e83f3d4c","unresolved":false,"context_lines":[{"line_number":667,"context_line":""},{"line_number":668,"context_line":"# By default, devstack will use Ubuntu Cloud Archive. This can be"},{"line_number":669,"context_line":"# disabled by enabling the setting below."},{"line_number":670,"context_line":"# export DISABLE_UBUNTU_CLOUD_ARCHIVE\u003dTrue"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"# Images"},{"line_number":673,"context_line":"# ------"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff0f0b1f_00236ac0","line":670,"range":{"start_line":670,"start_character":0,"end_line":670,"end_character":42},"in_reply_to":"ff0f0b1f_46d9ac1f","updated":"2017-05-25 16:24:07.000000000","message":"agreed, having the variable with the negative sense is also confusing. I\u0027ve changed it to be ENABLE_CLOUD_ARCHIVE which will default to True.\n\nTesting now.","commit_id":"46b24b1ddd8faadd0bce261e21e498cbe32b4a7c"}],"tools/fixup_stuff.sh":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c3ca637ae7e0e84f54d3e5885609aa944c962304","unresolved":false,"context_lines":[{"line_number":75,"context_line":"# Make it possible to switch this based on an environment variable as"},{"line_number":76,"context_line":"# libvirt 2.5.0 doesn\u0027t handle nested virtualization quite well and this"},{"line_number":77,"context_line":"# is required for the trove development environment."},{"line_number":78,"context_line":"if [[ -z \"${DISABLE_UBUNTU_CLOUD_ARCHIVE}\" ]]; then"},{"line_number":79,"context_line":"    if [[ \"$DISTRO\" \u003d \"xenial\" ]]; then"},{"line_number":80,"context_line":"        # This pulls in apt-add-repository"},{"line_number":81,"context_line":"        install_package \"software-properties-common\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"1f013ff3_c091ce54","line":78,"updated":"2017-05-16 05:43:46.000000000","message":"can we make this a bit more devstacky and put the value \u0026 comment in stackrc and check it here","commit_id":"1b7bcfdef041d8ce35eb8aaee21a27eb042140d7"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"65d4729188a64cd9382fea8fce0d4b02342fef53","unresolved":false,"context_lines":[{"line_number":75,"context_line":"# Make it possible to switch this based on an environment variable as"},{"line_number":76,"context_line":"# libvirt 2.5.0 doesn\u0027t handle nested virtualization quite well and this"},{"line_number":77,"context_line":"# is required for the trove development environment."},{"line_number":78,"context_line":"if [[ -z \"${DISABLE_UBUNTU_CLOUD_ARCHIVE}\" ]]; then"},{"line_number":79,"context_line":"    if [[ \"$DISTRO\" \u003d \"xenial\" ]]; then"},{"line_number":80,"context_line":"        # This pulls in apt-add-repository"},{"line_number":81,"context_line":"        install_package \"software-properties-common\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"ff0f0b1f_54596f32","line":78,"in_reply_to":"1f013ff3_c091ce54","updated":"2017-05-23 19:17:41.000000000","message":"Done","commit_id":"1b7bcfdef041d8ce35eb8aaee21a27eb042140d7"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e9fe467b0be4561df9b447df44994af8bf32be9b","unresolved":false,"context_lines":[{"line_number":75,"context_line":"# Make it possible to switch this based on an environment variable as"},{"line_number":76,"context_line":"# libvirt 2.5.0 doesn\u0027t handle nested virtualization quite well and this"},{"line_number":77,"context_line":"# is required for the trove development environment."},{"line_number":78,"context_line":"if [[ -z \"${DISABLE_UBUNTU_CLOUD_ARCHIVE}\" ]]; then"},{"line_number":79,"context_line":"    if [[ \"$DISTRO\" \u003d \"xenial\" ]]; then"},{"line_number":80,"context_line":"        # This pulls in apt-add-repository"},{"line_number":81,"context_line":"        install_package \"software-properties-common\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"ff0f0b1f_3bdcaee2","line":78,"in_reply_to":"1f013ff3_c091ce54","updated":"2017-05-23 18:12:50.000000000","message":"ok","commit_id":"1b7bcfdef041d8ce35eb8aaee21a27eb042140d7"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c3ca637ae7e0e84f54d3e5885609aa944c962304","unresolved":false,"context_lines":[{"line_number":76,"context_line":"# libvirt 2.5.0 doesn\u0027t handle nested virtualization quite well and this"},{"line_number":77,"context_line":"# is required for the trove development environment."},{"line_number":78,"context_line":"if [[ -z \"${DISABLE_UBUNTU_CLOUD_ARCHIVE}\" ]]; then"},{"line_number":79,"context_line":"    if [[ \"$DISTRO\" \u003d \"xenial\" ]]; then"},{"line_number":80,"context_line":"        # This pulls in apt-add-repository"},{"line_number":81,"context_line":"        install_package \"software-properties-common\""},{"line_number":82,"context_line":"        # Use UCA for newer libvirt. Should give us libvirt 2.5.0."}],"source_content_type":"text/x-sh","patch_set":1,"id":"1f013ff3_00b0d6f3","line":79,"updated":"2017-05-16 05:43:46.000000000","message":"can we just do an || to remove a level of indent?","commit_id":"1b7bcfdef041d8ce35eb8aaee21a27eb042140d7"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"65d4729188a64cd9382fea8fce0d4b02342fef53","unresolved":false,"context_lines":[{"line_number":76,"context_line":"# libvirt 2.5.0 doesn\u0027t handle nested virtualization quite well and this"},{"line_number":77,"context_line":"# is required for the trove development environment."},{"line_number":78,"context_line":"if [[ -z \"${DISABLE_UBUNTU_CLOUD_ARCHIVE}\" ]]; then"},{"line_number":79,"context_line":"    if [[ \"$DISTRO\" \u003d \"xenial\" ]]; then"},{"line_number":80,"context_line":"        # This pulls in apt-add-repository"},{"line_number":81,"context_line":"        install_package \"software-properties-common\""},{"line_number":82,"context_line":"        # Use UCA for newer libvirt. Should give us libvirt 2.5.0."}],"source_content_type":"text/x-sh","patch_set":1,"id":"ff0f0b1f_143f77b4","line":79,"in_reply_to":"1f013ff3_00b0d6f3","updated":"2017-05-23 19:17:41.000000000","message":"Done","commit_id":"1b7bcfdef041d8ce35eb8aaee21a27eb042140d7"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e9fe467b0be4561df9b447df44994af8bf32be9b","unresolved":false,"context_lines":[{"line_number":76,"context_line":"# libvirt 2.5.0 doesn\u0027t handle nested virtualization quite well and this"},{"line_number":77,"context_line":"# is required for the trove development environment."},{"line_number":78,"context_line":"if [[ -z \"${DISABLE_UBUNTU_CLOUD_ARCHIVE}\" ]]; then"},{"line_number":79,"context_line":"    if [[ \"$DISTRO\" \u003d \"xenial\" ]]; then"},{"line_number":80,"context_line":"        # This pulls in apt-add-repository"},{"line_number":81,"context_line":"        install_package \"software-properties-common\""},{"line_number":82,"context_line":"        # Use UCA for newer libvirt. Should give us libvirt 2.5.0."}],"source_content_type":"text/x-sh","patch_set":1,"id":"ff0f0b1f_dbded2d8","line":79,"in_reply_to":"1f013ff3_00b0d6f3","updated":"2017-05-23 18:12:50.000000000","message":"sure","commit_id":"1b7bcfdef041d8ce35eb8aaee21a27eb042140d7"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"2e7e855f18c087095eeec810ffb3ff6074b485cc","unresolved":false,"context_lines":[{"line_number":75,"context_line":"# Make it possible to switch this based on an environment variable as"},{"line_number":76,"context_line":"# libvirt 2.5.0 doesn\u0027t handle nested virtualization quite well and this"},{"line_number":77,"context_line":"# is required for the trove development environment."},{"line_number":78,"context_line":"if [[ -z \"${DISABLE_UBUNTU_CLOUD_ARCHIVE}\" \u0026\u0026 \"$DISTRO\" \u003d \"xenial\" ]]; then"},{"line_number":79,"context_line":"    # This pulls in apt-add-repository"},{"line_number":80,"context_line":"    install_package \"software-properties-common\""},{"line_number":81,"context_line":"    # Use UCA for newer libvirt. Should give us libvirt 2.5.0."}],"source_content_type":"text/x-sh","patch_set":2,"id":"ff0f0b1f_06097494","line":78,"range":{"start_line":78,"start_character":5,"end_line":78,"end_character":9},"updated":"2017-05-24 11:31:53.000000000","message":"We should check for \u003d\u003d \"True\" instead.","commit_id":"46b24b1ddd8faadd0bce261e21e498cbe32b4a7c"}]}