)]}'
{"id":"openstack%2Fdevstack~468172","triplet_id":"openstack%2Fdevstack~master~I0e9eeed20e1d4da14c88d9f13b5dc9986f660007","project":"openstack/devstack","branch":"master","hashtags":[],"change_id":"I0e9eeed20e1d4da14c88d9f13b5dc9986f660007","subject":"Make ETCD_DATA_DIR configurable and default it to be in DATA_DIR","status":"ABANDONED","created":"2017-05-25 21:34:56.000000000","updated":"2017-08-29 05:27:35.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"92c25451781af0e8dc9f75d91f3c2e9b2921e9dd","_number":468172,"virtual_id_number":468172,"owner":{"_account_id":24147,"name":"Mark Giles","email":"mark.giles@oracle.com","username":"mark-giles"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2017-05-26 01:38:16.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"date":"2017-05-26 17:49:27.000000000","_account_id":24147,"name":"Mark Giles","email":"mark.giles@oracle.com","username":"mark-giles"},{"value":1,"date":"2017-05-25 23:11:40.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-05-25 22:20:44.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"date":"2017-05-26 11:59:18.000000000","_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"date":"2017-05-26 08:25:00.000000000","_account_id":21784,"name":"Radek Zetik","email":"radekx.zetik@intel.com","username":"rzetikx"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":24147,"name":"Mark Giles","email":"mark.giles@oracle.com","username":"mark-giles"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":21784,"name":"Radek Zetik","email":"radekx.zetik@intel.com","username":"rzetikx"},{"value":-1,"date":"2017-05-26 17:23:55.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":24147,"name":"Mark Giles","email":"mark.giles@oracle.com","username":"mark-giles"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"_account_id":21784,"name":"Radek Zetik","email":"radekx.zetik@intel.com","username":"rzetikx"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":24147,"name":"Mark Giles","email":"mark.giles@oracle.com","username":"mark-giles"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":21784,"name":"Radek Zetik","email":"radekx.zetik@intel.com","username":"rzetikx"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"_account_id":21784,"name":"Radek Zetik","email":"radekx.zetik@intel.com","username":"rzetikx"},{"_account_id":24147,"name":"Mark Giles","email":"mark.giles@oracle.com","username":"mark-giles"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-05-25 22:20:44.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2017-05-25 23:11:40.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-05-26 01:38:16.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2017-05-26 08:25:00.000000000","updated_by":{"_account_id":21784,"name":"Radek Zetik","email":"radekx.zetik@intel.com","username":"rzetikx"},"reviewer":{"_account_id":21784,"name":"Radek Zetik","email":"radekx.zetik@intel.com","username":"rzetikx"},"state":"REVIEWER"},{"updated":"2017-05-26 11:59:18.000000000","updated_by":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2017-05-26 17:23:55.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"}],"messages":[{"id":"7e8952dcbfc8d805f81d3d8c029ff72538f275df","author":{"_account_id":24147,"name":"Mark Giles","email":"mark.giles@oracle.com","username":"mark-giles"},"date":"2017-05-25 21:34:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b76a7430bb9243d2b7ea1a9ab68ab3bd35218321","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2017-05-25 22:20:44.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/devstack/72/468172/1/check/tempest-dsvm-full-xenial/81cad3f/ : SUCCESS in 45m 32s","accounts_in_message":[],"_revision_number":1},{"id":"3be1834673188ccf8f733cdd6b4cc9bd38ca808e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-25 23:11:40.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial http://logs.openstack.org/72/468172/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/d8882d7/ : SUCCESS in 1h 32m 11s\n- gate-grenade-dsvm-neutron-ubuntu-xenial http://logs.openstack.org/72/468172/1/check/gate-grenade-dsvm-neutron-ubuntu-xenial/b8410f9/ : SUCCESS in 52m 40s\n- gate-tempest-dsvm-py35-ubuntu-xenial http://logs.openstack.org/72/468172/1/check/gate-tempest-dsvm-py35-ubuntu-xenial/1793ce9/ : SUCCESS in 1h 12m 45s\n- gate-devstack-docs-ubuntu-xenial http://docs-draft.openstack.org/72/468172/1/check/gate-devstack-docs-ubuntu-xenial/17552ec//doc/build/html/ : SUCCESS in 2m 16s\n- gate-devstack-bashate http://logs.openstack.org/72/468172/1/check/gate-devstack-bashate/8db5d88/ : SUCCESS in 2m 33s\n- gate-devstack-unit-tests http://logs.openstack.org/72/468172/1/check/gate-devstack-unit-tests/5839b36/ : SUCCESS in 2m 54s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv http://logs.openstack.org/72/468172/1/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv/ae8cb80/ : SUCCESS in 38m 16s (non-voting)\n- gate-devstack-dsvm-updown-ubuntu-xenial http://logs.openstack.org/72/468172/1/check/gate-devstack-dsvm-updown-ubuntu-xenial/3e2cca6/ : SUCCESS in 17m 53s\n- gate-devstack-dsvm-py35-updown-ubuntu-xenial-nv http://logs.openstack.org/72/468172/1/check/gate-devstack-dsvm-py35-updown-ubuntu-xenial-nv/09dbd00/ : SUCCESS in 16m 13s (non-voting)\n- gate-tempest-dsvm-neutron-identity-v3-only-full-ubuntu-xenial-nv http://logs.openstack.org/72/468172/1/check/gate-tempest-dsvm-neutron-identity-v3-only-full-ubuntu-xenial-nv/106f7f2/ : SUCCESS in 1h 12m 33s (non-voting)\n- gate-swift-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/72/468172/1/check/gate-swift-dsvm-functional-ubuntu-xenial-nv/30db63e/ : SUCCESS in 22m 50s (non-voting)\n- gate-grenade-dsvm-neutron-multinode-ubuntu-xenial http://logs.openstack.org/72/468172/1/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/7fe1618/ : SUCCESS in 55m 01s\n- gate-tempest-dsvm-neutron-full-centos-7-nv http://logs.openstack.org/72/468172/1/check/gate-tempest-dsvm-neutron-full-centos-7-nv/d94b893/ : SUCCESS in 1h 28m 24s (non-voting)\n- gate-tempest-dsvm-neutron-linuxbridge-ubuntu-xenial http://logs.openstack.org/72/468172/1/check/gate-tempest-dsvm-neutron-linuxbridge-ubuntu-xenial/291a87b/ : SUCCESS in 1h 34m 38s","accounts_in_message":[],"_revision_number":1},{"id":"7cfa0dd264de9ea8d90f50aa551af5993a2c32cd","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2017-05-25 23:44:38.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline). To recheck leave a comment with \u0027intel-nfv-ci recheck\u0027. For more info go to https://wiki.openstack.org/wiki/ThirdPartySystems/Intel_NFV_CI.\n\n- tempest-dsvm-full-nfv-xenial http://intel-openstack-ci-logs.ovh/portland/2017-05-25/468172/1/check/tempest-dsvm-full-nfv-xenial/7c9a8a6 : FAILURE in 2h 09m 25s\n- tempest-dsvm-ovsdpdk-nfv-networking-centos http://intel-openstack-ci-logs.ovh/portland/2017-05-25/468172/1/check/tempest-dsvm-ovsdpdk-nfv-networking-centos/418630a : SUCCESS in 1h 28m 41s (non-voting)\n- tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial http://intel-openstack-ci-logs.ovh/portland/2017-05-25/468172/1/check/tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial/1fc7c4d : SUCCESS in 1h 38m 17s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e71b413aff1dd03e279ab6ea13b4c7fc201472de","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2017-05-26 01:38:16.000000000","message":"Patch Set 1:\n\nBuild failed.  To recheck use \u0027xenserver: recheck\u0027.  For 3rd party ci contact info: https://wiki.openstack.org/wiki/ThirdPartySystems\n\n- dsvm-tempest-neutron-network http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/72/468172/1/check/dsvm-tempest-neutron-network/18da0c2 : FAILURE in 4h 02m 57s","accounts_in_message":[],"_revision_number":1},{"id":"b927ba12ad27dec27b11c0c2e364dded0dea5804","author":{"_account_id":21784,"name":"Radek Zetik","email":"radekx.zetik@intel.com","username":"rzetikx"},"date":"2017-05-26 08:25:00.000000000","message":"Patch Set 1:\n\nintel-nfv-ci recheck","accounts_in_message":[],"_revision_number":1},{"id":"d7c0ca26592aa1222156984a1500bab5d9175cd5","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2017-05-26 11:59:18.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-full-nfv-xenial http://intel-openstack-ci-logs.ovh/portland/2017-05-26/468172/1/check/tempest-dsvm-full-nfv-xenial/a19c78e : SUCCESS in 2h 18m 57s\n- tempest-dsvm-ovsdpdk-nfv-networking-centos http://intel-openstack-ci-logs.ovh/portland/2017-05-26/468172/1/check/tempest-dsvm-ovsdpdk-nfv-networking-centos/9f467dc : FAILURE in 19m 06s (non-voting)\n- tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial http://intel-openstack-ci-logs.ovh/portland/2017-05-26/468172/1/check/tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial/ae81228 : FAILURE in 3h 00m 08s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"214b312881a5233b59de9bc1ebd9c89c8da22ecd","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2017-05-26 17:23:55.000000000","message":"Patch Set 1: Code-Review-1\n\nI\u0027m not actually sure why this needs to be configurable. This is for a devstack environment where we are managing the install.","accounts_in_message":[],"_revision_number":1},{"id":"6d468a197115f03b71c36dc8facdbd7ba7a81662","author":{"_account_id":24147,"name":"Mark Giles","email":"mark.giles@oracle.com","username":"mark-giles"},"date":"2017-05-26 17:49:27.000000000","message":"Patch Set 1:\n\nI actually care more that it\u0027s relative to DATA_DIR than that it be configurable.  All other data is stored under DATA_DIR and I believe this should also be for consistency.  I have a DATA_DIR that is in a separate directory (not under DEST), and when I re-initialize my devstack environment I always clean out my DATA_DIR.  With this hardcoded, when I re-initialized my devstack this was left over and caused failures. I can manually clean this out as well, but it feels like it should fit into the same pattern as other data.  With the default definition of DATA_DIR, this ps doesn\u0027t actually change the ETCD_DATA_DIR location - just the way it\u0027s specified.\n\nMaking it configurable is secondary, IMO.  In the devstack architecture, it appears that almost all variables are defined with the FOO\u003d${FOO:-defaultvalue} syntax which allows them to be configured by the user.  Therefore, having this be configurable just seems more consistent with the rest of the devstack design.\n\nI\u0027m certainly willing to back out making it customizable and just specify it as ${DATA_DIR}/etcd, if that is the preference.  This would meet my needs and would at least put it in the same location as other devstack data.","accounts_in_message":[],"_revision_number":1},{"id":"92c25451781af0e8dc9f75d91f3c2e9b2921e9dd","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2017-08-29 05:27:35.000000000","message":"Abandoned\n\nThe same thing has come up in Icdc65f52a9d75981b63789036248e00d8ab72f11.  Let\u0027s discuss it there","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c0609fcb2df01f7f1981e6342b50848fc507e02c","revisions":{"c0609fcb2df01f7f1981e6342b50848fc507e02c":{"kind":"REWORK","_number":1,"created":"2017-05-25 21:34:56.000000000","uploader":{"_account_id":24147,"name":"Mark Giles","email":"mark.giles@oracle.com","username":"mark-giles"},"ref":"refs/changes/72/468172/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/72/468172/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/72/468172/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/72/468172/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/72/468172/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/72/468172/1"}}},"commit":{"parents":[{"commit":"9b2a2fa55dbba724a781d2720546611a8add8936","subject":"Merge \"Fix typo\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/9b2a2fa55dbba724a781d2720546611a8add8936"}]}],"author":{"name":"Mark Giles","email":"mark.giles@oracle.com","date":"2017-05-25 21:29:59.000000000","tz":-240},"committer":{"name":"Mark Giles","email":"mark.giles@oracle.com","date":"2017-05-25 21:29:59.000000000","tz":-240},"subject":"Make ETCD_DATA_DIR configurable and default it to be in DATA_DIR","message":"Make ETCD_DATA_DIR configurable and default it to be in DATA_DIR\n\nRespect users\u0027 settings for the ETCD_DATA_DIR if they exist. Also\nchange the default value to use the global DATA_DIR as the base\ndirectory for this value.\n\nChange-Id: I0e9eeed20e1d4da14c88d9f13b5dc9986f660007\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c0609fcb2df01f7f1981e6342b50848fc507e02c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c0609fcb2df01f7f1981e6342b50848fc507e02c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}