)]}'
{"lib/cinder":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"ba5646be0dcc82ea1f1d588be782878215ba5663","unresolved":false,"context_lines":[{"line_number":143,"context_line":"# Test if any Cinder services are enabled"},{"line_number":144,"context_line":"# is_cinder_enabled"},{"line_number":145,"context_line":"function is_cinder_enabled {"},{"line_number":146,"context_line":"    # If cinder is explicitly disabled return false"},{"line_number":147,"context_line":"    [[ ,${DISABLED_SERVICES} \u003d~ ,\"cinder\" ]] \u0026\u0026 return 1"},{"line_number":148,"context_line":"    # Otherwise if any cinder services are enabled return true."},{"line_number":149,"context_line":"    [[ ,${ENABLED_SERVICES} \u003d~ ,\"c-\" ]] \u0026\u0026 return 0"},{"line_number":150,"context_line":"    return 1"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ff0f0b1f_cbce8082","line":147,"range":{"start_line":146,"start_character":0,"end_line":147,"end_character":56},"updated":"2017-05-27 10:22:08.000000000","message":"if we are going to do this, we really should do it for everything, not just cinder. Otherwise that gets pretty confusing.","commit_id":"78877900fdae5964d7cb09e36ad7af1ea4ac39f0"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"7739637929a8eb65fe890933d1f2e6e387d91f71","unresolved":false,"context_lines":[{"line_number":143,"context_line":"# Test if any Cinder services are enabled"},{"line_number":144,"context_line":"# is_cinder_enabled"},{"line_number":145,"context_line":"function is_cinder_enabled {"},{"line_number":146,"context_line":"    # If cinder is explicitly disabled return false"},{"line_number":147,"context_line":"    [[ ,${DISABLED_SERVICES} \u003d~ ,\"cinder\" ]] \u0026\u0026 return 1"},{"line_number":148,"context_line":"    # Otherwise if any cinder services are enabled return true."},{"line_number":149,"context_line":"    [[ ,${ENABLED_SERVICES} \u003d~ ,\"c-\" ]] \u0026\u0026 return 0"},{"line_number":150,"context_line":"    return 1"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"df140735_5619f376","line":147,"range":{"start_line":146,"start_character":0,"end_line":147,"end_character":56},"in_reply_to":"ff0f0b1f_cbce8082","updated":"2017-05-30 21:14:45.000000000","message":"I have pushed https://review.openstack.org/469253 to do that and updated this change to only handle the changed block below.","commit_id":"78877900fdae5964d7cb09e36ad7af1ea4ac39f0"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"ba5646be0dcc82ea1f1d588be782878215ba5663","unresolved":false,"context_lines":[{"line_number":532,"context_line":"        # Start proxies if enabled"},{"line_number":533,"context_line":"        if is_service_enabled tls-proxy; then"},{"line_number":534,"context_line":"            start_tls_proxy cinder \u0027*\u0027 $CINDER_SERVICE_PORT $CINDER_SERVICE_HOST $CINDER_SERVICE_PORT_INT"},{"line_number":535,"context_line":"        fi"},{"line_number":536,"context_line":"    fi"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"    run_process c-sch \"$CINDER_BIN_DIR/cinder-scheduler --config-file $CINDER_CONF\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ff0f0b1f_8bc88874","line":535,"updated":"2017-05-27 10:22:08.000000000","message":"+1 to all of this","commit_id":"78877900fdae5964d7cb09e36ad7af1ea4ac39f0"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"3e0354bc6081a205715bc4d1e0bf89ce9a03cefb","unresolved":false,"context_lines":[{"line_number":528,"context_line":""},{"line_number":529,"context_line":"        # Start proxies if enabled"},{"line_number":530,"context_line":"        if is_service_enabled tls-proxy; then"},{"line_number":531,"context_line":"            start_tls_proxy cinder \u0027*\u0027 $CINDER_SERVICE_PORT $CINDER_SERVICE_HOST $CINDER_SERVICE_PORT_INT"},{"line_number":532,"context_line":"        fi"},{"line_number":533,"context_line":"    fi"},{"line_number":534,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"df140735_d5e9741a","line":531,"updated":"2017-05-31 03:17:32.000000000","message":"fwiw, we probably don\u0027t need this if $CINDER_USE_MOD_WSGI is true because should be handling the ssl there already.","commit_id":"2dfca047d97d4867048dbc9eec34b6f7ff54655e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"3e0354bc6081a205715bc4d1e0bf89ce9a03cefb","unresolved":false,"context_lines":[{"line_number":536,"context_line":"    run_process c-bak \"$CINDER_BIN_DIR/cinder-backup --config-file $CINDER_CONF\""},{"line_number":537,"context_line":"    run_process c-vol \"$CINDER_BIN_DIR/cinder-volume --config-file $CINDER_CONF\""},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    # NOTE(jdg): For cinder, startup order matters.  To ensure that repor_capabilities is received"},{"line_number":540,"context_line":"    # by the scheduler start the cinder-volume service last (or restart it) after the scheduler"},{"line_number":541,"context_line":"    # has started.  This is a quick fix for lp bug/1189595"},{"line_number":542,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"df140735_7581884a","line":539,"updated":"2017-05-31 03:17:32.000000000","message":"This comment is kind of on nothing now, we probably should move it before we call run_process c-vol.","commit_id":"2dfca047d97d4867048dbc9eec34b6f7ff54655e"}]}