)]}'
{"stack.sh":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c3f76b5118366d50ab53cf2a0a66be598ff748e9","unresolved":false,"context_lines":[{"line_number":1302,"context_line":""},{"line_number":1303,"context_line":"# Start placement before any of the service that are likely to want"},{"line_number":1304,"context_line":"# to use it to manage resource providers."},{"line_number":1305,"context_line":"# NOTE(cdent): We configure placement after nova, because it is part"},{"line_number":1306,"context_line":"# of nova for the time being, but we need it to start before nova."},{"line_number":1307,"context_line":"if is_service_enabled placement; then"},{"line_number":1308,"context_line":"    echo_summary \"Starting Placement\""},{"line_number":1309,"context_line":"    start_placement"}],"source_content_type":"text/x-sh","patch_set":1,"id":"df140735_f433c812","line":1306,"range":{"start_line":1305,"start_character":15,"end_line":1306,"end_character":66},"updated":"2017-06-05 16:10:32.000000000","message":"I\u0027m confused, don\u0027t we need/want the config to happen before it\u0027s started? Or are we just OK with default config right now? Looks like the only places we might use config in placement-api right now are logging and possibly policy, although by default all policy is admin-only.","commit_id":"507c1cad764ce8dddee2a9d9f348c0c7001eb0d5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b1bacc5e56a1158c31c9737b6417ec14541adcc1","unresolved":false,"context_lines":[{"line_number":1303,"context_line":"# Start placement before any of the service that are likely to want"},{"line_number":1304,"context_line":"# to use it to manage resource providers."},{"line_number":1305,"context_line":"# NOTE(cdent): We configure placement after nova, because it is part"},{"line_number":1306,"context_line":"# of nova for the time being, but we need it to start before nova."},{"line_number":1307,"context_line":"if is_service_enabled placement; then"},{"line_number":1308,"context_line":"    echo_summary \"Starting Placement\""},{"line_number":1309,"context_line":"    start_placement"}],"source_content_type":"text/x-sh","patch_set":1,"id":"df140735_686238da","line":1306,"in_reply_to":"df140735_f41ce878","updated":"2017-06-05 16:18:13.000000000","message":"OK I\u0027d probably just remove the note as it\u0027s confusing and mixing two different things I think:\n\n1. configuring nova.conf for placement the service to use before it\u0027s started\n\n2. configure nova.conf for nova-* services to use placement before they are started, just like we would for other things nova depends on like glance, neutron and cinder.\n\nI\u0027d just remove the comment.","commit_id":"507c1cad764ce8dddee2a9d9f348c0c7001eb0d5"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"9b31dfbe3dfc39173520201de93be39b982deab1","unresolved":false,"context_lines":[{"line_number":1303,"context_line":"# Start placement before any of the service that are likely to want"},{"line_number":1304,"context_line":"# to use it to manage resource providers."},{"line_number":1305,"context_line":"# NOTE(cdent): We configure placement after nova, because it is part"},{"line_number":1306,"context_line":"# of nova for the time being, but we need it to start before nova."},{"line_number":1307,"context_line":"if is_service_enabled placement; then"},{"line_number":1308,"context_line":"    echo_summary \"Starting Placement\""},{"line_number":1309,"context_line":"    start_placement"}],"source_content_type":"text/x-sh","patch_set":1,"id":"df140735_f41ce878","line":1306,"in_reply_to":"df140735_f433c812","updated":"2017-06-05 16:12:52.000000000","message":"The config has already happened at this point, up around line 875, this note is trying say \"although we config placement after nova, we want to start it before nove\"\n\nnova config was about line 865","commit_id":"507c1cad764ce8dddee2a9d9f348c0c7001eb0d5"}]}