)]}'
{"files/ldap/user.ldif.in":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"2252070faf89bbc1ae9a4d2fe6adcaab8c5c07e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3f1d235d_c50ba127","updated":"2017-07-05 14:01:22.000000000","message":"this file needs a license header","commit_id":"abf4d79d3e3ed6fa712b3b1b7334a186288044cb"}],"lib/horizon":[{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"f0a231f5587423196a9358ddb629ee0775c0cfde","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    _horizon_config_set $local_settings \"\" OPENSTACK_HOST \\\"${KEYSTONE_SERVICE_HOST}\\\""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    _horizon_config_set $local_settings \"\" OPENSTACK_API_VERSIONS {\\\"identity\\\":3}"},{"line_number":98,"context_line":"    _horizon_config_set $local_settings \"\" OPENSTACK_KEYSTONE_MULTIDOMAIN_SUPPORT \"True\""},{"line_number":99,"context_line":"    _horizon_config_set $local_settings \"\" OPENSTACK_KEYSTONE_URL \"\\\"${KEYSTONE_SERVICE_URI}/v3\\\"\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    # note(trebskit): if HOST_IP points at non-localhost ip address, horizon cannot be accessed"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5f201791_7c023a0d","line":98,"updated":"2017-06-26 11:46:12.000000000","message":"So, the default value for this operation should stay as `False`, so we should use some if-case here, to verified if we had enabled it in Keystone previously.","commit_id":"cba9627a1b5328b51a51268c6d16f96b5a9d0e73"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"2252070faf89bbc1ae9a4d2fe6adcaab8c5c07e6","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    _horizon_config_set $local_settings \"\" COMPRESS_OFFLINE True"},{"line_number":93,"context_line":"    _horizon_config_set $local_settings \"\" OPENSTACK_KEYSTONE_DEFAULT_ROLE \\\"Member\\\""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    _horizon_config_set $local_settings \"\" OPENSTACK_HOST \\\"${KEYSTONE_SERVICE_HOST}\\\""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    _horizon_config_set $local_settings \"\" OPENSTACK_API_VERSIONS {\\\"identity\\\":3}"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"3f1d235d_85f7e959","side":"PARENT","line":94,"updated":"2017-07-05 14:01:22.000000000","message":"this is a not related change, you should undo this.","commit_id":"87362e572204ed7a8d66b7d4c518735bd311f256"}],"lib/keystone":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"313982654dedb374125e926c25852235af8d3c65","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        iniset $KEYSTONE_CONF ldap user $LDAP_MANAGER_DN"},{"line_number":221,"context_line":"        iniset $KEYSTONE_CONF ldap suffix $LDAP_BASE_DN"},{"line_number":222,"context_line":"        iniset $KEYSTONE_CONF ldap user_tree_dn \"ou\u003dUsers,$LDAP_BASE_DN\""},{"line_number":223,"context_line":"        iniset $KEYSTONE_CONF DEFAULT member_role_id \"9fe2ff9ee4384b1894a90878d3e92bab\""},{"line_number":224,"context_line":"        iniset $KEYSTONE_CONF DEFAULT member_role_name \"_member_\""},{"line_number":225,"context_line":"    fi"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    iniset $KEYSTONE_CONF identity driver \"$KEYSTONE_IDENTITY_BACKEND\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5f201791_114ead6e","side":"PARENT","line":224,"range":{"start_line":223,"start_character":0,"end_line":224,"end_character":65},"updated":"2017-06-23 21:00:33.000000000","message":"I guess we are not going to set this anymore since the LDAP will be only the Identity backend?","commit_id":"1ca22d50b0847f9af0c569ed32f358711952b17a"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"2252070faf89bbc1ae9a4d2fe6adcaab8c5c07e6","unresolved":false,"context_lines":[{"line_number":329,"context_line":""},{"line_number":330,"context_line":"# Migrated from keystone_data.sh"},{"line_number":331,"context_line":"function create_keystone_accounts {"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    # The keystone bootstrapping process (performed via keystone-manage bootstrap)"},{"line_number":334,"context_line":"    # creates an admin user, admin role and admin project. As a sanity check"},{"line_number":335,"context_line":"    # we exercise the CLI to retrieve the IDs for these values."}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"3f1d235d_858c89d7","side":"PARENT","line":332,"updated":"2017-07-05 14:01:22.000000000","message":"another unrelated change, undo this","commit_id":"87362e572204ed7a8d66b7d4c518735bd311f256"}],"lib/ldap":[{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"f0a231f5587423196a9358ddb629ee0775c0cfde","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    if is_ubuntu; then"},{"line_number":141,"context_line":"        start_ldap"},{"line_number":142,"context_line":"    elif is_fedora; then"},{"line_number":143,"context_line":"        restart_ldap"},{"line_number":144,"context_line":"    elif is_suse; then"},{"line_number":145,"context_line":"        _ldap_varsubst $FILES/ldap/suse-base-config.ldif.in \u003e$tmp_ldap_dir/suse-base-config.ldif"},{"line_number":146,"context_line":"        sudo slapadd -F /etc/openldap/slapd.d/ -bcn\u003dconfig -l $tmp_ldap_dir/suse-base-config.ldif"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5f201791_bf3a04c9","line":143,"updated":"2017-06-26 11:46:12.000000000","message":"I\u0027m not a big fan on change previous script names. What about we keep this as start_ldap and choose a new name for your script? maybe configure_ldap, ldap_setup or something like that.","commit_id":"cba9627a1b5328b51a51268c6d16f96b5a9d0e73"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"ecb3512b48c86a72f3a05d1b2ee21fdc3e103904","unresolved":false,"context_lines":[{"line_number":229,"context_line":"    ldap_user\u003d$(openstack user show --domain\u003dUsers demo -f value -c id)"},{"line_number":230,"context_line":"    local admin_role\u003d\"admin\""},{"line_number":231,"context_line":"    get_or_create_role $admin_role"},{"line_number":232,"context_line":"    "},{"line_number":233,"context_line":"    get_or_add_user_project_role $admin_role $ldap_user $admin_project"},{"line_number":234,"context_line":"}"},{"line_number":235,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3f1d235d_9693ba5b","line":232,"updated":"2017-07-04 19:44:19.000000000","message":"nit: trailing spaces","commit_id":"01028c3acd214871c11fc22c959b216570f1ee60"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"2252070faf89bbc1ae9a4d2fe6adcaab8c5c07e6","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    ldapdelete -x -w $LDAP_PASSWORD -D \"$LDAP_MANAGER_DN\" -H $LDAP_URL -r \"$LDAP_BASE_DN\" || :"},{"line_number":184,"context_line":"}"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"function create_ldap_domain {"},{"line_number":187,"context_line":"    openstack --os-identity-api-version\u003d3 domain create --description \"LDAP domain\" Users"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    KEYSTONE_LDAP_DOMAIN_FILE\u003d$KEYSTONE_CONF_DIR/domains/keystone.Users.conf"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"3f1d235d_e560dd03","line":186,"range":{"start_line":186,"start_character":9,"end_line":186,"end_character":27},"updated":"2017-07-05 14:01:22.000000000","message":"is there a reason to place this function in this file? Seems like it is only being used in the keystone specific script.","commit_id":"abf4d79d3e3ed6fa712b3b1b7334a186288044cb"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"2252070faf89bbc1ae9a4d2fe6adcaab8c5c07e6","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    sudo service apache2 reload"},{"line_number":217,"context_line":"    sudo systemctl restart devstack@keystone"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    local tmp_ldap_dir"},{"line_number":220,"context_line":"    tmp_ldap_dir\u003d$(mktemp -d -t ldap.$$.XXXXXXXXXX)"},{"line_number":221,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"3f1d235d_651bad80","line":218,"updated":"2017-07-05 14:01:22.000000000","message":"add comments to explain the steps here, this seems a bit confusing","commit_id":"abf4d79d3e3ed6fa712b3b1b7334a186288044cb"}],"stack.sh":[{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"f0a231f5587423196a9358ddb629ee0775c0cfde","unresolved":false,"context_lines":[{"line_number":684,"context_line":""},{"line_number":685,"context_line":"    # Only request LDAP password if the service is enabled"},{"line_number":686,"context_line":"    if is_service_enabled ldap; then"},{"line_number":687,"context_line":"        echo \"ENTER LDAP DOMAIN NAME\""},{"line_number":688,"context_line":"        read LDAP_DOMAIN_NAME"},{"line_number":689,"context_line":"        read_password LDAP_PASSWORD \"ENTER A PASSWORD TO USE FOR LDAP\""},{"line_number":690,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"5f201791_9fb6283e","line":687,"updated":"2017-06-26 11:46:12.000000000","message":"\"ENTER A LDAP DOMAIN NAME\" would be better :)","commit_id":"cba9627a1b5328b51a51268c6d16f96b5a9d0e73"}]}