)]}'
{"lib/keystone":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"9774b6d1e9dad02e2f1ac71c17a5af765d5fd781","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    fi"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    iniset $KEYSTONE_CONF identity driver \"$KEYSTONE_IDENTITY_BACKEND\""},{"line_number":228,"context_line":"    iniset $KEYSTONE_CONF identity password_hash_rounds 4"},{"line_number":229,"context_line":"    iniset $KEYSTONE_CONF assignment driver \"$KEYSTONE_ASSIGNMENT_BACKEND\""},{"line_number":230,"context_line":"    iniset $KEYSTONE_CONF role driver \"$KEYSTONE_ROLE_BACKEND\""},{"line_number":231,"context_line":"    iniset $KEYSTONE_CONF resource driver \"$KEYSTONE_RESOURCE_BACKEND\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7f231b9d_e443a6ae","line":228,"range":{"start_line":228,"start_character":4,"end_line":228,"end_character":57},"updated":"2017-06-12 23:14:40.000000000","message":"This is fine. This however, should be handled as a $KEYSTONE_PASSWORD_HASH_ROUNDS variable which is set as a default of 4 if not set (see above at the top of the file for the correct manner to do this/location):\n\n  KEYSTONE_PASSWORD_HASH_ROUNDS\u003d${KEYSTONE_PASSWORD_HASH_ROUNDS:-4}","commit_id":"970c43a9de518976e9b02ee5b36d34ef0fb68ada"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"e8d178b177c6540c78f12773ad97fe747fca132f","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    fi"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    iniset $KEYSTONE_CONF identity driver \"$KEYSTONE_IDENTITY_BACKEND\""},{"line_number":228,"context_line":"    iniset $KEYSTONE_CONF identity password_hash_rounds 4"},{"line_number":229,"context_line":"    iniset $KEYSTONE_CONF assignment driver \"$KEYSTONE_ASSIGNMENT_BACKEND\""},{"line_number":230,"context_line":"    iniset $KEYSTONE_CONF role driver \"$KEYSTONE_ROLE_BACKEND\""},{"line_number":231,"context_line":"    iniset $KEYSTONE_CONF resource driver \"$KEYSTONE_RESOURCE_BACKEND\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7f231b9d_6711d8ac","line":228,"range":{"start_line":228,"start_character":4,"end_line":228,"end_character":57},"in_reply_to":"7f231b9d_44b25a96","updated":"2017-06-12 23:56:23.000000000","message":"Okay fixed both comments","commit_id":"970c43a9de518976e9b02ee5b36d34ef0fb68ada"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3b39b4dbd12de8e9e30dc12c903a758eafcdcb7a","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    fi"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    iniset $KEYSTONE_CONF identity driver \"$KEYSTONE_IDENTITY_BACKEND\""},{"line_number":228,"context_line":"    iniset $KEYSTONE_CONF identity password_hash_rounds 4"},{"line_number":229,"context_line":"    iniset $KEYSTONE_CONF assignment driver \"$KEYSTONE_ASSIGNMENT_BACKEND\""},{"line_number":230,"context_line":"    iniset $KEYSTONE_CONF role driver \"$KEYSTONE_ROLE_BACKEND\""},{"line_number":231,"context_line":"    iniset $KEYSTONE_CONF resource driver \"$KEYSTONE_RESOURCE_BACKEND\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7f231b9d_44b25a96","line":228,"range":{"start_line":228,"start_character":4,"end_line":228,"end_character":57},"in_reply_to":"7f231b9d_e443a6ae","updated":"2017-06-12 23:29:47.000000000","message":"this should also be commented as to what\u0027s going on ... because people copy this stuff without examination and next thing you know everywhere has it","commit_id":"970c43a9de518976e9b02ee5b36d34ef0fb68ada"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b1b54849774d465ea697f2b339abf055ccf04d39","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"# Number of bcrypt hashing rounds, increasing number exponentially increases required"},{"line_number":131,"context_line":"# resources to generate password hash. This is very effective way to protect from"},{"line_number":132,"context_line":"# brutforce attacks. 4 is minimal value that can be specified for bcrypt and"},{"line_number":133,"context_line":"# it works way faster than default 12. Minimal value is great for CI and development"},{"line_number":134,"context_line":"# however may not be suitable for real production."},{"line_number":135,"context_line":"KEYSTONE_PASSWORD_HASH_ROUNDS\u003d${KEYSTONE_PASSWORD_HASH_ROUNDS:-4}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7f231b9d_489388a4","line":132,"updated":"2017-06-13 05:09:57.000000000","message":"\"brute\" if we have another change","commit_id":"ccc4bc84c6224f3560234d57d992f56ef6db75fa"}]}