)]}'
{"lib/tls":[{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"8971868b674b6fac251312c9736678cfe77a0dcd","unresolved":false,"context_lines":[{"line_number":348,"context_line":"    local key\u003d${!key_var}"},{"line_number":349,"context_line":"    local ca\u003d${!ca_var}"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    if [[ $cert \u0026\u0026 $key \u0026\u0026 $ca ]]; then"},{"line_number":352,"context_line":"        cat $ca \u003e\u003e $SSL_BUNDLE_FILE"},{"line_number":353,"context_line":"    else"},{"line_number":354,"context_line":"        if [[ ! $CERT_GEN_INITIALIZED ]]; then"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAATH%2F%2FQTE%3D","line":351,"updated":"2013-10-19 02:09:20.000000000","message":"Please you certmonger  instead.  We don\u0027t want any more custom openssl code","commit_id":"97ca1f6ef040c4ca42f5acd450beb5d3c9c1f3e2"},{"author":{"_account_id":8116,"name":"John Dennis","email":"jdennis@redhat.com","username":"jdennis"},"change_message_id":"97ef495a59c0c106bf96482ef7f2b75a3cf5766e","unresolved":false,"context_lines":[{"line_number":348,"context_line":"    local key\u003d${!key_var}"},{"line_number":349,"context_line":"    local ca\u003d${!ca_var}"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    if [[ $cert \u0026\u0026 $key \u0026\u0026 $ca ]]; then"},{"line_number":352,"context_line":"        cat $ca \u003e\u003e $SSL_BUNDLE_FILE"},{"line_number":353,"context_line":"    else"},{"line_number":354,"context_line":"        if [[ ! $CERT_GEN_INITIALIZED ]]; then"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAATn%2F%2F9Qw%3D","line":351,"in_reply_to":"AAAATH%2F%2FQTE%3D","updated":"2013-10-25 16:28:19.000000000","message":"lib/tls has used OpenSSL for a while now AFAIK, this patch isn\u0027t adding any OpenSSL\u0027isms that aren\u0027t already present, it\u0027s just calling into existing functions. I too would like to see OpenSSL get factored out but that seems to me to be the work of another blueprint and patch set. I don\u0027t see any reason to hold this patch up simply because it\u0027s utilizing the existing functions.","commit_id":"97ca1f6ef040c4ca42f5acd450beb5d3c9c1f3e2"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"78b4eeb003c66b2b1ce0331a397d15afd4fa4d1f","unresolved":false,"context_lines":[{"line_number":351,"context_line":"    if [[ $cert \u0026\u0026 $key \u0026\u0026 $ca ]]; then"},{"line_number":352,"context_line":"        cat $ca \u003e\u003e $SSL_BUNDLE_FILE"},{"line_number":353,"context_line":"    else"},{"line_number":354,"context_line":"        if [[ ! $CERT_GEN_INITIALIZED ]]; then"},{"line_number":355,"context_line":"            rm -rf $INT_CA_DIR"},{"line_number":356,"context_line":"            rm -rf $ROOT_CA_DIR"},{"line_number":357,"context_line":"            init_CA"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAVX%2F%2F%2FMY%3D","line":354,"updated":"2014-02-27 00:31:12.000000000","message":"Is there a specific sequence you are protecting against here?  I don\u0027t think configure_keystone() (and hence ensure_certificates() ) gets called more than once per stack.sh run.  Do you want the certs to persist across runs?\n\nI don\u0027t think this would be an issue in Grenade ad configure_keystone() is not used during the upgrade and the certs should persist there.","commit_id":"bd9e610d1eaea40de8622be9379edccfc5fd42c2"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"c1574df824e031a3c63cad28fc0b6b30ce35d5b4","unresolved":false,"context_lines":[{"line_number":351,"context_line":"    if [[ $cert \u0026\u0026 $key \u0026\u0026 $ca ]]; then"},{"line_number":352,"context_line":"        cat $ca \u003e\u003e $SSL_BUNDLE_FILE"},{"line_number":353,"context_line":"    else"},{"line_number":354,"context_line":"        if [[ ! $CERT_GEN_INITIALIZED ]]; then"},{"line_number":355,"context_line":"            rm -rf $INT_CA_DIR"},{"line_number":356,"context_line":"            rm -rf $ROOT_CA_DIR"},{"line_number":357,"context_line":"            init_CA"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAVX%2F%2F%2BYE%3D","line":354,"in_reply_to":"AAAAVX%2F%2F%2FMY%3D","updated":"2014-02-27 02:47:16.000000000","message":"No i\u0027m looking to have a CA that is capable of being shared across services. so configure_keystone only gets run once but if we do a configure_nova or configure_glance with an SSL cert i would like the certificates that are generated to all come from the same CA.","commit_id":"bd9e610d1eaea40de8622be9379edccfc5fd42c2"}]}