)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ad0b34cef46b01b6bd71a3ed4f29cbd41598b9a6","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Note that this also sets the notification transport_url to the top-level mq"},{"line_number":12,"context_line":"so that we continue to get a unified stream of notifications."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I08d7da843d18b426dda8a8a231039d950a4c0ce5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f201791_81a92725","line":13,"updated":"2017-06-26 14:38:19.000000000","message":"Would be good to relate this to bug 1700496 for tracking.","commit_id":"352f34fb64f9f18488fea67718a7a9b410a152cb"}],"lib/nova":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"eb5554356c8f48d9a9a5c5b36f103c9d32281c59","unresolved":false,"context_lines":[{"line_number":692,"context_line":"        $NOVA_BIN_DIR/nova-manage --config-file $NOVA_CONF db online_data_migrations"},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"        # FIXME(danms): Should this be configurable?"},{"line_number":695,"context_line":"        iniset $NOVA_CONF workarounds disable_group_policy_check_upcall True"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        # create the cell1 cell for the main nova db where the hosts live"},{"line_number":698,"context_line":"        for i in $(seq 1 $NOVA_NUM_CELLS); do"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3f1d235d_d1b6633f","line":695,"range":{"start_line":695,"start_character":8,"end_line":695,"end_character":76},"updated":"2017-07-07 17:10:21.000000000","message":"This is not getting set in nova-cpu.conf in the subnode so instances that go there and do a server group affinity check blow up.","commit_id":"32c00b4e1524b195efa5ce534f44924bc2fee823"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4ec8988c5a1da10fc71d12cc0e7bfaab50b6740e","unresolved":false,"context_lines":[{"line_number":692,"context_line":"        $NOVA_BIN_DIR/nova-manage --config-file $NOVA_CONF db online_data_migrations"},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"        # FIXME(danms): Should this be configurable?"},{"line_number":695,"context_line":"        iniset $NOVA_CONF workarounds disable_group_policy_check_upcall True"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        # create the cell1 cell for the main nova db where the hosts live"},{"line_number":698,"context_line":"        for i in $(seq 1 $NOVA_NUM_CELLS); do"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3f1d235d_9188eb22","line":695,"range":{"start_line":695,"start_character":8,"end_line":695,"end_character":76},"in_reply_to":"3f1d235d_d1b6633f","updated":"2017-07-07 17:19:09.000000000","message":"So this either needs to also be in an else block after the L434 condition, or we should just do this in start_nova_compute. I\u0027d vote for the latter.","commit_id":"32c00b4e1524b195efa5ce534f44924bc2fee823"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"62b8c14af1f4827e5a70a410cdb54c6545bc3452","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# The total number of cells we expect. Must be greater than one and doesn\u0027t"},{"line_number":64,"context_line":"# count cell0."},{"line_number":65,"context_line":"NOVA_NUM_CELLS\u003d${NOVA_NUM_CELLS:-1}"},{"line_number":66,"context_line":"# Our cell index, so we know what rabbit vhost to connect to."},{"line_number":67,"context_line":"# This should be in the range of 1-$NOVA_NUM_CELLS"},{"line_number":68,"context_line":"NOVA_CPU_CELL\u003d${NOVA_CPU_CELL:-1}"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"1f1a1f67_390b7ad6","line":65,"updated":"2017-07-19 18:39:07.000000000","message":"The comment says NOVA_NUM_CELLS must be greater than one. Isn\u0027t it 1 here?","commit_id":"f3d533157267a1568eeb36a349aee637195e9c8a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"494523d94e68717c8fae0996cecb5902c98efe4a","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# The total number of cells we expect. Must be greater than one and doesn\u0027t"},{"line_number":64,"context_line":"# count cell0."},{"line_number":65,"context_line":"NOVA_NUM_CELLS\u003d${NOVA_NUM_CELLS:-1}"},{"line_number":66,"context_line":"# Our cell index, so we know what rabbit vhost to connect to."},{"line_number":67,"context_line":"# This should be in the range of 1-$NOVA_NUM_CELLS"},{"line_number":68,"context_line":"NOVA_CPU_CELL\u003d${NOVA_CPU_CELL:-1}"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"ff346bd7_a7ab4a1b","line":65,"in_reply_to":"1f1a1f67_390b7ad6","updated":"2017-07-25 13:23:24.000000000","message":"Yeah, should be \"at least one\".","commit_id":"f3d533157267a1568eeb36a349aee637195e9c8a"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"62b8c14af1f4827e5a70a410cdb54c6545bc3452","unresolved":false,"context_lines":[{"line_number":944,"context_line":"}"},{"line_number":945,"context_line":""},{"line_number":946,"context_line":"function stop_nova_conductor {"},{"line_number":947,"context_line":"    enable_nova_fleet"},{"line_number":948,"context_line":"    for srv in n-super-cond $(seq -f n-cond-cell%0.f 1 $NOVA_NUM_CELLS); do"},{"line_number":949,"context_line":"        if is_service_enabled $srv; then"},{"line_number":950,"context_line":"            stop_process $srv"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"1f1a1f67_95910e4a","line":947,"range":{"start_line":947,"start_character":4,"end_line":947,"end_character":21},"updated":"2017-07-19 18:39:07.000000000","message":"Why do you need to enable_nova_fleet during the stop function? I thought it was enabled during start_nova_conductor.","commit_id":"f3d533157267a1568eeb36a349aee637195e9c8a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"494523d94e68717c8fae0996cecb5902c98efe4a","unresolved":false,"context_lines":[{"line_number":944,"context_line":"}"},{"line_number":945,"context_line":""},{"line_number":946,"context_line":"function stop_nova_conductor {"},{"line_number":947,"context_line":"    enable_nova_fleet"},{"line_number":948,"context_line":"    for srv in n-super-cond $(seq -f n-cond-cell%0.f 1 $NOVA_NUM_CELLS); do"},{"line_number":949,"context_line":"        if is_service_enabled $srv; then"},{"line_number":950,"context_line":"            stop_process $srv"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"ff346bd7_c771aee0","line":947,"range":{"start_line":947,"start_character":4,"end_line":947,"end_character":21},"in_reply_to":"1f1a1f67_95910e4a","updated":"2017-07-25 13:23:24.000000000","message":"Check out the comments on the original patch for the discussion.","commit_id":"f3d533157267a1568eeb36a349aee637195e9c8a"}]}