)]}'
{"id":"openstack%2Fdevstack~4825","triplet_id":"openstack%2Fdevstack~master~I55e2962c5fec9aad237b674732b1e922ad37a62e","project":"openstack/devstack","branch":"master","topic":"bug/944593","hashtags":[],"change_id":"I55e2962c5fec9aad237b674732b1e922ad37a62e","subject":"Improve exercise robustness","status":"MERGED","created":"2012-03-02 19:15:46.000000000","updated":"2012-03-03 02:41:18.000000000","submitted":"2012-03-03 02:41:18.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c9652f5495c4fbb0cd09197f1948d934ea5f8789","_number":4825,"virtual_id_number":4825,"owner":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":1,"date":"2012-03-03 02:41:18.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"all":[{"value":2,"date":"2012-03-03 01:56:53.000000000","_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":2,"date":"2012-03-03 02:22:00.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"date":"2012-03-03 02:25:26.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"all":[{"value":1,"date":"2012-03-03 02:35:59.000000000","_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":1,"date":"2012-03-03 02:22:00.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-03-02 23:11:52.000000000","updated_by":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"reviewer":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"state":"REVIEWER"},{"updated":"2012-03-03 02:22:00.000000000","updated_by":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"reviewer":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"state":"REVIEWER"},{"updated":"2012-03-03 02:35:59.000000000","updated_by":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"reviewer":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"state":"REVIEWER"},{"updated":"2012-03-03 02:41:18.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"426cc1c6e690f6f258ab6b1687d33572b57bf9f3","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2012-03-02 19:16:52.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t submit this\n\nI can\u0027t test all of the exercises on my little VM, please try them out and report.","accounts_in_message":[],"_revision_number":1},{"id":"2b61bc82f1dbe6287993bbeed83f615ad91a2e73","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2012-03-02 23:00:02.000000000","message":"Patch Set 1: No score\n\nI\u0027ve managed to run all of the exercises now","accounts_in_message":[],"_revision_number":1},{"id":"484758f36387b08757c246fa98dc4eb2fa2fa1b0","author":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"date":"2012-03-02 23:03:52.000000000","message":"Patch Set 1:\n\nI really like where this is going!\n\nwhat about naming die_if_not_zero - die_if_not_success (or something more english-y?)","accounts_in_message":[],"_revision_number":1},{"id":"7ed94de559543c751f9ab8e15de2873f16f71e1f","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2012-03-02 23:11:52.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nVery nice!","accounts_in_message":[],"_revision_number":1},{"id":"d0468445ae187f693ec1ea255d20fa10ca5b18f5","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2012-03-02 23:20:01.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"1b29b62c75885f17ec3b9a8330a583f9aff86461","author":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"date":"2012-03-02 23:21:59.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nnice","accounts_in_message":[],"_revision_number":2},{"id":"e9a3af1975ac1a8b49e58a86a2d7733cb36b5dc4","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-03-03 00:16:35.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t submit this\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"1b48a365203e70f20ae30e89b65174649a1e21bc","author":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"date":"2012-03-03 01:55:39.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"d3edef03f8a3b3234e9c2f0c9ccb97b60b275880","author":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"date":"2012-03-03 01:56:53.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\nfixed the issue vishy found","accounts_in_message":[],"_revision_number":3},{"id":"67d5cb9536a4ff0083d83d747be5084f6a068c13","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-03-03 02:22:00.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"0933483d8fb33a7611e839b6a21bf7487fcc4d2b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-03-03 02:25:26.000000000","message":"Patch Set 3: Fails\n\nBuild Failed \n \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/2066/ : FAILURE \nhttps://jenkins.openstack.org/job/gate-devstack-merge/194/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"e5dbba80bed7b91475a5ed3ef4962f48a31c7c15","author":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"date":"2012-03-03 02:35:59.000000000","message":"Patch Set 3: Approved\n\ntry to send through again ...","accounts_in_message":[],"_revision_number":3},{"id":"e00c73092821a9491569264a23330b29114a919f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-03-03 02:41:18.000000000","message":"Patch Set 3: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/2067/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-devstack-merge/195/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"b5d6d9e33b88b3ff1ee4d8f636a9e6af243d80be","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-03-03 02:41:18.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"489bd2a62b5949665bc7c4a05a52d27a987e0489","revisions":{"f605452adedb4997b837cc21d703fcce19cc4ccb":{"kind":"REWORK","_number":1,"created":"2012-03-02 19:15:46.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/25/4825/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/25/4825/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/25/4825/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/25/4825/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/25/4825/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/25/4825/1"}}},"commit":{"parents":[{"commit":"3993816fe6fb92c609043b765fd07d08d469a2bf","subject":"Remove hardcoding of flat network bridge","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/3993816fe6fb92c609043b765fd07d08d469a2bf"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2012-03-02 16:44:29.000000000","tz":-360},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2012-03-02 19:10:30.000000000","tz":-360},"subject":"Exercise robustness","message":"Exercise robustness\n\n* Test returns and exit codes on most command invocations\n* Add start and end banners to make output easier to find in\n  long log files\n* Add some function tests\n\nFixes bug 944593\n\nChange-Id: I55e2962c5fec9aad237b674732b1e922ad37a62e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/f605452adedb4997b837cc21d703fcce19cc4ccb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/f605452adedb4997b837cc21d703fcce19cc4ccb"}]},"branch":"refs/heads/master"},"6e99bf01a9b0a83347605a146db74f769f51541d":{"kind":"REWORK","_number":2,"created":"2012-03-02 23:20:01.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/25/4825/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/25/4825/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/25/4825/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/25/4825/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/25/4825/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/25/4825/2"}}},"commit":{"parents":[{"commit":"3993816fe6fb92c609043b765fd07d08d469a2bf","subject":"Remove hardcoding of flat network bridge","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/3993816fe6fb92c609043b765fd07d08d469a2bf"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2012-03-02 16:44:29.000000000","tz":-360},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2012-03-02 23:16:26.000000000","tz":-360},"subject":"Improve exercise robustness","message":"Improve exercise robustness\n\n* Test returns and exit codes on most command invocations\n* Add start and end banners to make output easier to find in\n  long log files\n* Adds die_if_error(), die_if_not_set() and is_set() to functions\n* Add some function tests\n\nFixes bug 944593\n\nChange-Id: I55e2962c5fec9aad237b674732b1e922ad37a62e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/6e99bf01a9b0a83347605a146db74f769f51541d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/6e99bf01a9b0a83347605a146db74f769f51541d"}]},"branch":"refs/heads/master"},"489bd2a62b5949665bc7c4a05a52d27a987e0489":{"kind":"REWORK","_number":3,"created":"2012-03-03 01:55:39.000000000","uploader":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"ref":"refs/changes/25/4825/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/25/4825/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/25/4825/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/25/4825/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/25/4825/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/25/4825/3"}}},"commit":{"parents":[{"commit":"4807df8e5bc0e5e78536ecea37a0ca7621720524","subject":"Update openrc to focus on current OS_* environment variables","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/4807df8e5bc0e5e78536ecea37a0ca7621720524"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2012-03-02 16:44:29.000000000","tz":-360},"committer":{"name":"Jesse Andrews","email":"anotherjesse@gmail.com","date":"2012-03-03 01:55:37.000000000","tz":-480},"subject":"Improve exercise robustness","message":"Improve exercise robustness\n\n* Test returns and exit codes on most command invocations\n* Add start and end banners to make output easier to find in\n  long log files\n* Adds die_if_error(), die_if_not_set() and is_set() to functions\n* Add some function tests\n\nFixes bug 944593\n\nChange-Id: I55e2962c5fec9aad237b674732b1e922ad37a62e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/489bd2a62b5949665bc7c4a05a52d27a987e0489"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/489bd2a62b5949665bc7c4a05a52d27a987e0489"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}