)]}'
{"id":"openstack%2Fdevstack~48384","triplet_id":"openstack%2Fdevstack~master~I6f06899133ffe377b948a9a491b29c2a13bbd01a","project":"openstack/devstack","branch":"master","topic":"rhel6-git-log","hashtags":[],"change_id":"I6f06899133ffe377b948a9a491b29c2a13bbd01a","subject":"Fake true return value for git show --quiet","status":"ABANDONED","created":"2013-09-26 04:40:51.000000000","updated":"2013-09-27 05:16:07.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7d4f8225150b433eb3e9681b0a8f3a2516757d9d","_number":48384,"virtual_id_number":48384,"owner":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2013-09-26 05:08:46.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-09-27 05:11:13.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},{"value":0,"date":"2013-09-26 14:33:58.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2013-09-26 04:45:49.000000000","_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},{"date":"2013-09-26 04:45:44.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"date":"2013-09-26 04:45:37.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-09-26 04:45:37.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-09-26 04:45:44.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2013-09-26 04:45:49.000000000","updated_by":{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},"reviewer":{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},"state":"REVIEWER"},{"updated":"2013-09-26 05:08:46.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"b84df64bd13daf8f248b454a1559d6c517c824ae","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-09-26 05:08:46.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-tempest-devstack-vm-full http://logs.openstack.org/84/48384/1/check/gate-tempest-devstack-vm-full/6697ea1 : SUCCESS in 25m 50s\n- gate-tempest-devstack-vm-postgres-full http://logs.openstack.org/84/48384/1/check/gate-tempest-devstack-vm-postgres-full/99d3d3d : SUCCESS in 27m 49s\n- gate-tempest-devstack-vm-neutron http://logs.openstack.org/84/48384/1/check/gate-tempest-devstack-vm-neutron/fa8ab75 : SUCCESS in 16m 23s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/84/48384/1/check/gate-tempest-devstack-vm-large-ops/b1a2999 : SUCCESS in 10m 27s (non-voting)\n- gate-grenade-devstack-vm http://logs.openstack.org/84/48384/1/check/gate-grenade-devstack-vm/654239f : SUCCESS in 27m 06s\n- gate-swift-devstack-vm-functional http://logs.openstack.org/84/48384/1/check/gate-swift-devstack-vm-functional/0b61954 : SUCCESS in 9m 58s\n","accounts_in_message":[],"_revision_number":1},{"id":"9a16364e314ca1d9c897a2dc5e46e92b22dfc2c3","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-09-26 14:33:58.000000000","message":"Patch Set 1:\n\nIan, it looks like https://review.openstack.org/48265 merged while you were submitting this, does it address the problem?","accounts_in_message":[],"_revision_number":1},{"id":"9afe809ec6e27ccde1c5d064a8709ce91da71871","author":{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},"date":"2013-09-27 05:11:13.000000000","message":"Patch Set 1:\n\nIMHO this solution is a bit more elegant, because\n- \u003ccmd\u003e || true is known idiom to ignore failures when set -e is enabled. It explicitly says, we don\u0027t care about the exit value\n\n- doesn\u0027t invoke and external command - head -1 \n- doesn\u0027t git show --oneline --quiet already show only oneline, so isn\u0027t head -1 superfluous?","accounts_in_message":[],"_revision_number":1},{"id":"48b71fa745283f58fd630945d9624383d53aea0b","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2013-09-27 05:16:07.000000000","message":"Patch Set 1: Abandoned\n\nIn my (rather extensive :) bisecting of git changes I found that --oneline was broken for quite a while during git\u0027s 1.7 days anyway and showed the whole change.  so the prior change probably works around that too.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"83eb0699c31b348abe51770dc2563ffb60f155bb","revisions":{"83eb0699c31b348abe51770dc2563ffb60f155bb":{"kind":"REWORK","_number":1,"created":"2013-09-26 04:40:51.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/84/48384/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/84/48384/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/84/48384/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/84/48384/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/84/48384/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/84/48384/1"}}},"commit":{"parents":[{"commit":"6c92b2adfb7c671953cc01c60784d26c4c289920","subject":"Merge \"fake hypervisor plugin\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/6c92b2adfb7c671953cc01c60784d26c4c289920"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2013-09-26 04:23:09.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2013-09-26 04:23:09.000000000","tz":600},"subject":"Fake true return value for git show --quiet","message":"Fake true return value for git show --quiet\n\nUpstream change [1] introduced --quiet to the git show command.\nUnfortunately on older git\u0027s before [2], to quote the git change-log:\n\n    ...allows us to catch the \"--quiet\" option which causes some of the\n    log-related commands to misbehave as it would otherwise get passed on\n    to the diff.\n\nMisbehaviour includes returning 1 instead of 0, which breaks the\nstack.sh run.  Thus we fake a return value to be maximally compatible\n\n[1] https://review.openstack.org/#/c/48011/\n[2] https://github.com/git/git/commit/1c40c36b9acbb55726ea0fcf98714a85e159e45f\n\nChange-Id: I6f06899133ffe377b948a9a491b29c2a13bbd01a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/83eb0699c31b348abe51770dc2563ffb60f155bb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/83eb0699c31b348abe51770dc2563ffb60f155bb"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
