)]}'
{"functions":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"64da16ca8d81a9c2b4f997bc84934d9281f4bb8f","unresolved":false,"context_lines":[{"line_number":1221,"context_line":"# Uses globals ``STACK_USER``, ``TRACK_DEPENDS``, ``REQUIREMENTS_DIR``"},{"line_number":1222,"context_line":"# setup_develop directory"},{"line_number":1223,"context_line":"function setup_develop() {"},{"line_number":1224,"context_line":"    local project_dir\u003d$1 update_requirements"},{"line_number":1225,"context_line":""},{"line_number":1226,"context_line":"    echo \"cd $REQUIREMENTS_DIR; $SUDO_CMD python update.py $project_dir\""},{"line_number":1227,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAS3%2F%2FdKA%3D","line":1224,"updated":"2013-09-26 12:53:55.000000000","message":"Since update_requirements is declared local where it is initialized! is this necessary?","commit_id":"159b67b7d2b3f264726218b8112ccf8cdee98b1b"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"6ac76ac58c58d925f3ff187f81c7d2cb7c5113cf","unresolved":false,"context_lines":[{"line_number":1221,"context_line":"# Uses globals ``STACK_USER``, ``TRACK_DEPENDS``, ``REQUIREMENTS_DIR``"},{"line_number":1222,"context_line":"# setup_develop directory"},{"line_number":1223,"context_line":"function setup_develop() {"},{"line_number":1224,"context_line":"    local project_dir\u003d$1 update_requirements"},{"line_number":1225,"context_line":""},{"line_number":1226,"context_line":"    echo \"cd $REQUIREMENTS_DIR; $SUDO_CMD python update.py $project_dir\""},{"line_number":1227,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAS3%2F%2FdBY%3D","line":1224,"in_reply_to":"AAAAS3%2F%2FdKA%3D","updated":"2013-09-26 13:50:06.000000000","message":"oh yeah right missed that.","commit_id":"159b67b7d2b3f264726218b8112ccf8cdee98b1b"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"64da16ca8d81a9c2b4f997bc84934d9281f4bb8f","unresolved":false,"context_lines":[{"line_number":1229,"context_line":"    (cd $project_dir \u0026\u0026 git diff --quiet)"},{"line_number":1230,"context_line":"    local update_requirements\u003d$?"},{"line_number":1231,"context_line":""},{"line_number":1232,"context_line":"    if [[ ! -e $project_dir/requirements.txt \u0026\u0026 ! -e $project_dir/test-requirements.txt ]];then"},{"line_number":1233,"context_line":"        update_requirements\u003d1"},{"line_number":1234,"context_line":"    fi"},{"line_number":1235,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAS3%2F%2FdJs%3D","line":1232,"updated":"2013-09-26 12:53:55.000000000","message":"The update program may also change setup.py, and we would want those changes reverted, too. Maybe it would be better to go back to doing git reset?","commit_id":"159b67b7d2b3f264726218b8112ccf8cdee98b1b"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"3636cdd3bd6b10e9b98d1bf35d8f3d2b9a24f72a","unresolved":false,"context_lines":[{"line_number":1229,"context_line":"    (cd $project_dir \u0026\u0026 git diff --quiet)"},{"line_number":1230,"context_line":"    local update_requirements\u003d$?"},{"line_number":1231,"context_line":""},{"line_number":1232,"context_line":"    if [[ ! -e $project_dir/requirements.txt \u0026\u0026 ! -e $project_dir/test-requirements.txt ]];then"},{"line_number":1233,"context_line":"        update_requirements\u003d1"},{"line_number":1234,"context_line":"    fi"},{"line_number":1235,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAS3%2F%2FZl8%3D","line":1232,"in_reply_to":"AAAAS3%2F%2Fc7c%3D","updated":"2013-09-27 14:11:54.000000000","message":"Remove this if block entirely.","commit_id":"159b67b7d2b3f264726218b8112ccf8cdee98b1b"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"9667b511d9b0a57a984f079aed86d4912c069d0a","unresolved":false,"context_lines":[{"line_number":1229,"context_line":"    (cd $project_dir \u0026\u0026 git diff --quiet)"},{"line_number":1230,"context_line":"    local update_requirements\u003d$?"},{"line_number":1231,"context_line":""},{"line_number":1232,"context_line":"    if [[ ! -e $project_dir/requirements.txt \u0026\u0026 ! -e $project_dir/test-requirements.txt ]];then"},{"line_number":1233,"context_line":"        update_requirements\u003d1"},{"line_number":1234,"context_line":"    fi"},{"line_number":1235,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAS3%2F%2Fc7c%3D","line":1232,"in_reply_to":"AAAAS3%2F%2Fc94%3D","updated":"2013-09-26 13:58:33.000000000","message":"Yeah, I\u0027m trying to future-proof this, though, so it doesn\u0027t break if the requirements updater adds a doc-requirements.txt or some other file.","commit_id":"159b67b7d2b3f264726218b8112ccf8cdee98b1b"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"6ac76ac58c58d925f3ff187f81c7d2cb7c5113cf","unresolved":false,"context_lines":[{"line_number":1229,"context_line":"    (cd $project_dir \u0026\u0026 git diff --quiet)"},{"line_number":1230,"context_line":"    local update_requirements\u003d$?"},{"line_number":1231,"context_line":""},{"line_number":1232,"context_line":"    if [[ ! -e $project_dir/requirements.txt \u0026\u0026 ! -e $project_dir/test-requirements.txt ]];then"},{"line_number":1233,"context_line":"        update_requirements\u003d1"},{"line_number":1234,"context_line":"    fi"},{"line_number":1235,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAS3%2F%2Fc94%3D","line":1232,"in_reply_to":"AAAAS3%2F%2FdJs%3D","updated":"2013-09-26 13:50:06.000000000","message":"I think it would  update it only if it has pbr keywork in there :\n\nhttps://github.com/openstack/requirements/blob/master/update.py#L153\n\nand if it has pbr it would have {test-,}requirements.txt, right?","commit_id":"159b67b7d2b3f264726218b8112ccf8cdee98b1b"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"a49833b2e1fcfe7ede6c7fd4d7bdc3c7e999f6d7","unresolved":false,"context_lines":[{"line_number":1232,"context_line":"    if [[ ! -e $project_dir/requirements.txt \u0026\u0026 ! -e $project_dir/test-requirements.txt ]];then"},{"line_number":1233,"context_line":"        update_requirements\u003d1"},{"line_number":1234,"context_line":"    fi"},{"line_number":1235,"context_line":""},{"line_number":1236,"context_line":"    if [ $update_requirements -eq 0 ]; then"},{"line_number":1237,"context_line":"        (cd $REQUIREMENTS_DIR; \\"},{"line_number":1238,"context_line":"            $SUDO_CMD python update.py $project_dir)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAS3%2F%2FdRU%3D","line":1235,"updated":"2013-09-26 12:16:01.000000000","message":"update_requirements is no longer being initialized. Is an empty local equal to 0?","commit_id":"159b67b7d2b3f264726218b8112ccf8cdee98b1b"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"64da16ca8d81a9c2b4f997bc84934d9281f4bb8f","unresolved":false,"context_lines":[{"line_number":1232,"context_line":"    if [[ ! -e $project_dir/requirements.txt \u0026\u0026 ! -e $project_dir/test-requirements.txt ]];then"},{"line_number":1233,"context_line":"        update_requirements\u003d1"},{"line_number":1234,"context_line":"    fi"},{"line_number":1235,"context_line":""},{"line_number":1236,"context_line":"    if [ $update_requirements -eq 0 ]; then"},{"line_number":1237,"context_line":"        (cd $REQUIREMENTS_DIR; \\"},{"line_number":1238,"context_line":"            $SUDO_CMD python update.py $project_dir)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAS3%2F%2FdKQ%3D","line":1235,"in_reply_to":"AAAAS3%2F%2FdNs%3D","updated":"2013-09-26 12:53:55.000000000","message":"Sorry, I missed that. I was just looking at the new override logic. :/","commit_id":"159b67b7d2b3f264726218b8112ccf8cdee98b1b"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"bbf0b87a01f195ac8eb08cb05fe60fad49e32034","unresolved":false,"context_lines":[{"line_number":1232,"context_line":"    if [[ ! -e $project_dir/requirements.txt \u0026\u0026 ! -e $project_dir/test-requirements.txt ]];then"},{"line_number":1233,"context_line":"        update_requirements\u003d1"},{"line_number":1234,"context_line":"    fi"},{"line_number":1235,"context_line":""},{"line_number":1236,"context_line":"    if [ $update_requirements -eq 0 ]; then"},{"line_number":1237,"context_line":"        (cd $REQUIREMENTS_DIR; \\"},{"line_number":1238,"context_line":"            $SUDO_CMD python update.py $project_dir)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAS3%2F%2FdNs%3D","line":1235,"in_reply_to":"AAAAS3%2F%2FdRU%3D","updated":"2013-09-26 12:32:48.000000000","message":"It will be initialized at line 1230 ($? which would always come back with an integer after a command)","commit_id":"159b67b7d2b3f264726218b8112ccf8cdee98b1b"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"3636cdd3bd6b10e9b98d1bf35d8f3d2b9a24f72a","unresolved":false,"context_lines":[{"line_number":1243,"context_line":"    safe_chown -R $STACK_USER $1/*.egg-info"},{"line_number":1244,"context_line":""},{"line_number":1245,"context_line":"    # Undo requirements changes, if we made them"},{"line_number":1246,"context_line":"    if [ $update_requirements -eq 0 ]; then"},{"line_number":1247,"context_line":"        (cd $project_dir \u0026\u0026 git checkout -- requirements.txt test-requirements.txt setup.py)"},{"line_number":1248,"context_line":"    fi"},{"line_number":1249,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAS3%2F%2FZls%3D","line":1246,"updated":"2013-09-27 14:11:54.000000000","message":"Change this line to\n\n  (cd $project_dir \u0026\u0026 git reset --hard)","commit_id":"159b67b7d2b3f264726218b8112ccf8cdee98b1b"}]}