)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"40ac71b43c488ac414a52281fa12dbbc07c4d2ce","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Along with converting to the database backend for console token auth,"},{"line_number":10,"context_line":"the console proxies need to run per cell instead of globally. This way,"},{"line_number":11,"context_line":"the instance UUID isn\u0027t needed in the access url as users will be"},{"line_number":12,"context_line":"handed an access url local to the cell their instances is in. With"},{"line_number":13,"context_line":"console proxies sharded across cells, a large cloud will no longer have"},{"line_number":14,"context_line":"a bottleneck of one console proxy for the entire deployment."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9f6a8fd7_2ea2bf9b","line":12,"range":{"start_line":12,"start_character":45,"end_line":12,"end_character":54},"updated":"2018-04-30 19:56:04.000000000","message":"instance","commit_id":"e951ad14d56a4b01e16b2d81b1d00746de5fcb3c"}],"lib/nova":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"40ac71b43c488ac414a52281fa12dbbc07c4d2ce","unresolved":false,"context_lines":[{"line_number":945,"context_line":""},{"line_number":946,"context_line":"    local api_cell_conf\u003d$NOVA_CONF"},{"line_number":947,"context_line":"    # console proxies run globally for cells v1, else they run per cell"},{"line_number":948,"context_line":"    if is_service_enabled n-cell; then"},{"line_number":949,"context_line":"        if is_service_enabled n-novnc; then"},{"line_number":950,"context_line":"            run_process n-novnc \"$NOVA_BIN_DIR/nova-novncproxy --config-file $api_cell_conf --web $NOVNC_WEB_DIR\""},{"line_number":951,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"9f6a8fd7_aec6cf15","line":948,"range":{"start_line":948,"start_character":7,"end_line":948,"end_character":32},"updated":"2018-04-30 19:56:04.000000000","message":"Is this condition also true if we\u0027re running in \"singleconductor\" mode? Note that if we\u0027re running nova-cells, we\u0027re automatically in singleconductor mode, see _set_singleconductor.\n\nIn other words, I\u0027m wondering if this condition should just be checking if we\u0027re in singleconductor mode.","commit_id":"e951ad14d56a4b01e16b2d81b1d00746de5fcb3c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9926082b48b794f2c5821548ad1f3344865df46d","unresolved":false,"context_lines":[{"line_number":945,"context_line":""},{"line_number":946,"context_line":"    local api_cell_conf\u003d$NOVA_CONF"},{"line_number":947,"context_line":"    # console proxies run globally for cells v1, else they run per cell"},{"line_number":948,"context_line":"    if is_service_enabled n-cell; then"},{"line_number":949,"context_line":"        if is_service_enabled n-novnc; then"},{"line_number":950,"context_line":"            run_process n-novnc \"$NOVA_BIN_DIR/nova-novncproxy --config-file $api_cell_conf --web $NOVNC_WEB_DIR\""},{"line_number":951,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"9f6a8fd7_d4a392b0","line":948,"range":{"start_line":948,"start_character":7,"end_line":948,"end_character":32},"in_reply_to":"9f6a8fd7_aec6cf15","updated":"2018-04-30 21:20:35.000000000","message":"Okay, yeah, in that case I think we could just check if we\u0027re in singleconductor mode. The requirement is just that console proxies must be local to a cell database, so their untargeted database accesses will be able to find instance\u0027s token auths.","commit_id":"e951ad14d56a4b01e16b2d81b1d00746de5fcb3c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"40ac71b43c488ac414a52281fa12dbbc07c4d2ce","unresolved":false,"context_lines":[{"line_number":946,"context_line":"    local api_cell_conf\u003d$NOVA_CONF"},{"line_number":947,"context_line":"    # console proxies run globally for cells v1, else they run per cell"},{"line_number":948,"context_line":"    if is_service_enabled n-cell; then"},{"line_number":949,"context_line":"        if is_service_enabled n-novnc; then"},{"line_number":950,"context_line":"            run_process n-novnc \"$NOVA_BIN_DIR/nova-novncproxy --config-file $api_cell_conf --web $NOVNC_WEB_DIR\""},{"line_number":951,"context_line":"        fi"},{"line_number":952,"context_line":"        if is_service_enabled n-xvnc; then"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"9f6a8fd7_2ef95f7f","line":949,"range":{"start_line":949,"start_character":8,"end_line":949,"end_character":43},"updated":"2018-04-30 19:56:04.000000000","message":"You don\u0027t need the \u0027is_service_enabled\u0027 checks since the run_process function already does that check, which is why it wasn\u0027t needed before.","commit_id":"e951ad14d56a4b01e16b2d81b1d00746de5fcb3c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9926082b48b794f2c5821548ad1f3344865df46d","unresolved":false,"context_lines":[{"line_number":946,"context_line":"    local api_cell_conf\u003d$NOVA_CONF"},{"line_number":947,"context_line":"    # console proxies run globally for cells v1, else they run per cell"},{"line_number":948,"context_line":"    if is_service_enabled n-cell; then"},{"line_number":949,"context_line":"        if is_service_enabled n-novnc; then"},{"line_number":950,"context_line":"            run_process n-novnc \"$NOVA_BIN_DIR/nova-novncproxy --config-file $api_cell_conf --web $NOVNC_WEB_DIR\""},{"line_number":951,"context_line":"        fi"},{"line_number":952,"context_line":"        if is_service_enabled n-xvnc; then"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"9f6a8fd7_f947afbb","line":949,"range":{"start_line":949,"start_character":8,"end_line":949,"end_character":43},"in_reply_to":"9f6a8fd7_2ef95f7f","updated":"2018-04-30 21:20:35.000000000","message":"Oh, I see. I wondered about that before.","commit_id":"e951ad14d56a4b01e16b2d81b1d00746de5fcb3c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"40ac71b43c488ac414a52281fa12dbbc07c4d2ce","unresolved":false,"context_lines":[{"line_number":963,"context_line":"        for i in $(seq 1 $NOVA_NUM_CELLS); do"},{"line_number":964,"context_line":"            local conf"},{"line_number":965,"context_line":"            conf\u003d$(conductor_conf $i)"},{"line_number":966,"context_line":"            if is_service_enabled n-novnc; then"},{"line_number":967,"context_line":"                run_process n-novnc-cell${i} \"$NOVA_BIN_DIR/nova-novncproxy --config-file $conf --web $NOVNC_WEB_DIR\""},{"line_number":968,"context_line":"            fi"},{"line_number":969,"context_line":"            if is_service_enabled n-xvnc; then"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"9f6a8fd7_4ef4d387","line":966,"range":{"start_line":966,"start_character":12,"end_line":966,"end_character":47},"updated":"2018-04-30 19:56:04.000000000","message":"same","commit_id":"e951ad14d56a4b01e16b2d81b1d00746de5fcb3c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"40ac71b43c488ac414a52281fa12dbbc07c4d2ce","unresolved":false,"context_lines":[{"line_number":1068,"context_line":"}"},{"line_number":1069,"context_line":""},{"line_number":1070,"context_line":"function stop_nova_console_proxies {"},{"line_number":1071,"context_line":"    if is_service_enabled n-cell; then"},{"line_number":1072,"context_line":"        for srv in n-novnc n-xvnc n-spice n-sproxy; do"},{"line_number":1073,"context_line":"            if service_enabled $srv; then"},{"line_number":1074,"context_line":"                stop_process $srv"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"9f6a8fd7_cec9c325","line":1071,"updated":"2018-04-30 19:56:04.000000000","message":"same question about singleconductor mode","commit_id":"e951ad14d56a4b01e16b2d81b1d00746de5fcb3c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"40ac71b43c488ac414a52281fa12dbbc07c4d2ce","unresolved":false,"context_lines":[{"line_number":1070,"context_line":"function stop_nova_console_proxies {"},{"line_number":1071,"context_line":"    if is_service_enabled n-cell; then"},{"line_number":1072,"context_line":"        for srv in n-novnc n-xvnc n-spice n-sproxy; do"},{"line_number":1073,"context_line":"            if service_enabled $srv; then"},{"line_number":1074,"context_line":"                stop_process $srv"},{"line_number":1075,"context_line":"            fi"},{"line_number":1076,"context_line":"        done"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"9f6a8fd7_2e271f15","line":1073,"range":{"start_line":1073,"start_character":12,"end_line":1073,"end_character":41},"updated":"2018-04-30 19:56:04.000000000","message":"You don\u0027t need this, stop_process already checks it.","commit_id":"e951ad14d56a4b01e16b2d81b1d00746de5fcb3c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"40ac71b43c488ac414a52281fa12dbbc07c4d2ce","unresolved":false,"context_lines":[{"line_number":1075,"context_line":"            fi"},{"line_number":1076,"context_line":"        done"},{"line_number":1077,"context_line":"    else"},{"line_number":1078,"context_line":"        enable_nova_console_proxies"},{"line_number":1079,"context_line":"        for i in $(seq 1 $NOVA_NUM_CELLS); do"},{"line_number":1080,"context_line":"            for srv in n-novnc n-xvnc n-spice n-sproxy; do"},{"line_number":1081,"context_line":"                if service_enabled $srv; then"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"9f6a8fd7_ce16a3a8","line":1078,"updated":"2018-04-30 19:56:04.000000000","message":"Why is this needed here when start_nova_console_proxies already calls it?","commit_id":"e951ad14d56a4b01e16b2d81b1d00746de5fcb3c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"edf4d3bd0d1ae0c61fb63552343fc7170175f4e7","unresolved":false,"context_lines":[{"line_number":1075,"context_line":"            fi"},{"line_number":1076,"context_line":"        done"},{"line_number":1077,"context_line":"    else"},{"line_number":1078,"context_line":"        enable_nova_console_proxies"},{"line_number":1079,"context_line":"        for i in $(seq 1 $NOVA_NUM_CELLS); do"},{"line_number":1080,"context_line":"            for srv in n-novnc n-xvnc n-spice n-sproxy; do"},{"line_number":1081,"context_line":"                if service_enabled $srv; then"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"9f6a8fd7_cb2a10e6","line":1078,"in_reply_to":"9f6a8fd7_ce16a3a8","updated":"2018-05-01 00:02:18.000000000","message":"There\u0027s a reason for this but I\u0027ve forgotten why -- see L1095 for another example. Need to ask Dan.","commit_id":"e951ad14d56a4b01e16b2d81b1d00746de5fcb3c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"40ac71b43c488ac414a52281fa12dbbc07c4d2ce","unresolved":false,"context_lines":[{"line_number":1078,"context_line":"        enable_nova_console_proxies"},{"line_number":1079,"context_line":"        for i in $(seq 1 $NOVA_NUM_CELLS); do"},{"line_number":1080,"context_line":"            for srv in n-novnc n-xvnc n-spice n-sproxy; do"},{"line_number":1081,"context_line":"                if service_enabled $srv; then"},{"line_number":1082,"context_line":"                    stop_process ${srv}-cell${i}"},{"line_number":1083,"context_line":"                fi"},{"line_number":1084,"context_line":"            done"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"9f6a8fd7_4e229303","line":1081,"range":{"start_line":1081,"start_character":16,"end_line":1081,"end_character":45},"updated":"2018-04-30 19:56:04.000000000","message":"same","commit_id":"e951ad14d56a4b01e16b2d81b1d00746de5fcb3c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"edf4d3bd0d1ae0c61fb63552343fc7170175f4e7","unresolved":false,"context_lines":[{"line_number":1092,"context_line":"        return"},{"line_number":1093,"context_line":"    fi"},{"line_number":1094,"context_line":""},{"line_number":1095,"context_line":"    enable_nova_fleet"},{"line_number":1096,"context_line":"    for srv in n-super-cond $(seq -f n-cond-cell%0.f 1 $NOVA_NUM_CELLS); do"},{"line_number":1097,"context_line":"        if is_service_enabled $srv; then"},{"line_number":1098,"context_line":"            stop_process $srv"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"9f6a8fd7_8b34184c","line":1095,"updated":"2018-05-01 00:02:18.000000000","message":"Same deal here, enable before stopping.","commit_id":"e951ad14d56a4b01e16b2d81b1d00746de5fcb3c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"c1a1ff9ee43ce8d1f348c5fbead211c9b551b3cb","unresolved":false,"context_lines":[{"line_number":1057,"context_line":"            stop_process $srv"},{"line_number":1058,"context_line":"        done"},{"line_number":1059,"context_line":"    else"},{"line_number":1060,"context_line":"        enable_nova_console_proxies"},{"line_number":1061,"context_line":"        for i in $(seq 1 $NOVA_NUM_CELLS); do"},{"line_number":1062,"context_line":"            for srv in n-novnc n-xvnc n-spice n-sproxy; do"},{"line_number":1063,"context_line":"                stop_process ${srv}-cell${i}"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"9f6a8fd7_d30155b1","line":1060,"range":{"start_line":1060,"start_character":8,"end_line":1060,"end_character":35},"updated":"2018-05-01 19:13:35.000000000","message":"From the chat on IRC, I *think* the reason we need this \"enable before stop\" is because the per cell services enabled by start_nova_console_proxies aren\u0027t going to be persisted anywhere after a stack.sh run. So if we\u0027re doing a unstack.sh, we won\u0027t have the information anymore that the per cell services were enabled during stack.sh. So we have to enable them first before we can stop the processes (since stop_process checks \"if enabled\" first before it will do the stop).","commit_id":"ed2d491960138f92e819b6f6ed9dd5eb99d4a54f"}]}