)]}'
{"id":"openstack%2Fdevstack~490904","triplet_id":"openstack%2Fdevstack~master~I2896dc9c2e516167a2ef9b84f5b0aee78788357c","project":"openstack/devstack","branch":"master","topic":"fix-graceful-shutdown","hashtags":[],"change_id":"I2896dc9c2e516167a2ef9b84f5b0aee78788357c","subject":"Enable reloadable config in uwsgi","status":"ABANDONED","created":"2017-08-04 15:18:57.000000000","updated":"2017-10-12 17:24:25.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"49bbaef4cca77cad1694f46139e0b162ab42eb29","_number":490904,"virtual_id_number":490904,"owner":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":-1,"date":"2017-09-06 01:56:55.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-08-04 16:34:55.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"date":"2017-08-04 17:45:19.000000000","_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"date":"2017-08-24 07:10:33.000000000","_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":2,"date":"2017-08-08 08:26:39.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":2,"date":"2017-08-04 18:43:56.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":1,"date":"2017-08-08 08:26:39.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-08-04 16:34:55.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2017-08-04 17:45:19.000000000","updated_by":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2017-08-04 18:43:56.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2017-08-08 08:26:39.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2017-08-24 07:10:33.000000000","updated_by":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"reviewer":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"state":"REVIEWER"},{"updated":"2017-09-06 01:56:55.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"ffd6a8e1d407e71dea4330afbd9c693c72efe55b","author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"date":"2017-08-04 15:18:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"75ae2c489591df8d0d711891b77b2db196e9fcde","author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"date":"2017-08-04 15:25:50.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"372e18835340d0b6ced2361750528401df1cacba","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2017-08-04 16:34:55.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/devstack/04/490904/2/check/tempest-dsvm-full-xenial/068010b/ : SUCCESS in 1h 08m 37s","accounts_in_message":[],"_revision_number":2},{"id":"be59423dc4e25cb3196e3083e9f17ac559a90fa6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-04 16:58:19.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial http://logs.openstack.org/04/490904/2/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/9f7ec69/ : SUCCESS in 1h 21m 09s\n- gate-grenade-dsvm-neutron-ubuntu-xenial http://logs.openstack.org/04/490904/2/check/gate-grenade-dsvm-neutron-ubuntu-xenial/02de8b2/ : SUCCESS in 41m 16s\n- gate-tempest-dsvm-py35-ubuntu-xenial http://logs.openstack.org/04/490904/2/check/gate-tempest-dsvm-py35-ubuntu-xenial/d11d621/ : SUCCESS in 1h 15m 29s\n- gate-devstack-docs-ubuntu-xenial http://docs-draft.openstack.org/04/490904/2/check/gate-devstack-docs-ubuntu-xenial/c9a132d//doc/build/html/ : SUCCESS in 2m 31s\n- gate-devstack-bashate http://logs.openstack.org/04/490904/2/check/gate-devstack-bashate/e623685/ : SUCCESS in 4m 40s\n- gate-devstack-unit-tests http://logs.openstack.org/04/490904/2/check/gate-devstack-unit-tests/8183065/ : SUCCESS in 2m 09s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv http://logs.openstack.org/04/490904/2/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv/a9be73c/ : SUCCESS in 29m 14s (non-voting)\n- gate-devstack-dsvm-updown-ubuntu-xenial http://logs.openstack.org/04/490904/2/check/gate-devstack-dsvm-updown-ubuntu-xenial/e105a38/ : SUCCESS in 31m 42s\n- gate-devstack-dsvm-py35-updown-ubuntu-xenial-nv http://logs.openstack.org/04/490904/2/check/gate-devstack-dsvm-py35-updown-ubuntu-xenial-nv/ac09e49/ : SUCCESS in 28m 01s (non-voting)\n- gate-swift-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/04/490904/2/check/gate-swift-dsvm-functional-ubuntu-xenial-nv/b02ec1f/ : SUCCESS in 23m 51s (non-voting)\n- gate-grenade-dsvm-neutron-multinode-ubuntu-xenial http://logs.openstack.org/04/490904/2/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/b780ed4/ : SUCCESS in 47m 29s\n- gate-tempest-dsvm-neutron-full-centos-7-nv http://logs.openstack.org/04/490904/2/check/gate-tempest-dsvm-neutron-full-centos-7-nv/3d033ab/ : SUCCESS in 1h 23m 53s (non-voting)\n- gate-tempest-dsvm-neutron-linuxbridge-ubuntu-xenial http://logs.openstack.org/04/490904/2/check/gate-tempest-dsvm-neutron-linuxbridge-ubuntu-xenial/e87d0d3/ : SUCCESS in 1h 28m 43s\n- gate-tempest-dsvm-neutron-full-opensuse-422-nv http://logs.openstack.org/04/490904/2/check/gate-tempest-dsvm-neutron-full-opensuse-422-nv/c7756e9/ : SUCCESS in 1h 18m 44s (non-voting)\n- gate-tempest-dsvm-neutron-full-opensuse-423-nv http://logs.openstack.org/04/490904/2/check/gate-tempest-dsvm-neutron-full-opensuse-423-nv/613e3e3/ : SUCCESS in 1h 31m 54s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv http://logs.openstack.org/04/490904/2/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/d28a5d1/ : SUCCESS in 1h 21m 31s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"57cd80f6cda93966f6f9ebf605dcf991c188c53c","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2017-08-04 17:45:19.000000000","message":"Patch Set 2:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-full-nfv-xenial http://intel-openstack-ci-logs.ovh/portland/2017-08-04/490904/2/check/tempest-dsvm-full-nfv-xenial/b1a54f5 : SUCCESS in 2h 19m 05s\n- tempest-dsvm-ovsdpdk-nfv-networking-centos http://intel-openstack-ci-logs.ovh/portland/2017-08-04/490904/2/check/tempest-dsvm-ovsdpdk-nfv-networking-centos/fa0ab2f : SUCCESS in 1h 27m 48s (non-voting)\n- tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial http://intel-openstack-ci-logs.ovh/portland/2017-08-04/490904/2/check/tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial/b8f67fa : SUCCESS in 1h 37m 52s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"15d6bff69edc61f4919a2719055d4430d001c353","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2017-08-04 18:43:56.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"47052871e45bc723613f08697ab2030fbeb99361","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2017-08-08 08:26:39.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nseems reasonable","accounts_in_message":[],"_revision_number":2},{"id":"962b040641fb127b8330a3d64f88da8cd8117e9d","author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"date":"2017-08-24 07:10:33.000000000","message":"Patch Set 2:\n\n(2 comments)\n\nHi all, \n\nThis patch is dependent on patch: https://review.openstack.org/#/c/490903/ which needs review comments given to be fixed.\n\nWe can also add \"systemctl reload\" command support to services in this patch itself by adding below parameter to [service] section of service unit file:\n\n\tExecReload\u003d/bin/kill -HUP $MAINPID\n\nWith this user/developer don\u0027t need to explicitly send SIGHUP(1) signal to parent service he/she can just hit:\n\n\tsudo systemctl reload devstack@n-api.service\n\n@Matthew Treinish- I have both the patches ready locally. As this patch is approved already with your permission I can update both of them.","accounts_in_message":[],"_revision_number":2},{"id":"cff12de046ff961ef280c86133b5f7b6cf845c47","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-06 01:56:55.000000000","message":"Patch Set 2: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"1dad6487fabb6322b9c2aba663a7830f65c6e987","author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"date":"2017-10-12 17:24:25.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d995a8ccfda9d06b3052a25cc5ab734f08e9df52","revisions":{"a5fe22eb92724f349a10d2ac4d6b8981b14e11da":{"kind":"REWORK","_number":1,"created":"2017-08-04 15:18:57.000000000","uploader":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"ref":"refs/changes/04/490904/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/04/490904/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/04/490904/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/04/490904/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/04/490904/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/04/490904/1"}}},"commit":{"parents":[{"commit":"521436eb5c6a62c49372a94c7eb98a9d6150602d","subject":"Enable graceful shutdown for uwsgi","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/521436eb5c6a62c49372a94c7eb98a9d6150602d"}]}],"author":{"name":"Matthew Treinish","email":"mtreinish@kortar.org","date":"2017-08-04 15:15:55.000000000","tz":-240},"committer":{"name":"Matthew Treinish","email":"mtreinish@kortar.org","date":"2017-08-04 15:15:55.000000000","tz":-240},"subject":"Enable reloadable config in uwsgi","message":"Enable reloadable config in uwsgi\n\nBy default uwsgi is set to exit on reload this breaks config reloading\nof the service. [1][2]\n\n[1] https://etherpad.openstack.org/p/uwsgi-issues\n[2] http://uwsgi-docs.readthedocs.io/en/latest/Options.html#exit-on-reload\n\nChange-Id: I2896dc9c2e516167a2ef9b84f5b0aee78788357c\nCo-Authored-By: Abhishek Kekane \u003cAbhishek.Kekane@nttdata.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/a5fe22eb92724f349a10d2ac4d6b8981b14e11da"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/a5fe22eb92724f349a10d2ac4d6b8981b14e11da"}]},"branch":"refs/heads/master"},"d995a8ccfda9d06b3052a25cc5ab734f08e9df52":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2017-08-04 15:25:50.000000000","uploader":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"ref":"refs/changes/04/490904/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/04/490904/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/04/490904/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/04/490904/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/04/490904/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/04/490904/2"}}},"commit":{"parents":[{"commit":"a681aa1e955178ded2d4b7e352c9e68281e3a261","subject":"Enable graceful shutdown for uwsgi","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/a681aa1e955178ded2d4b7e352c9e68281e3a261"}]}],"author":{"name":"Matthew Treinish","email":"mtreinish@kortar.org","date":"2017-08-04 15:15:55.000000000","tz":-240},"committer":{"name":"Matthew Treinish","email":"mtreinish@kortar.org","date":"2017-08-04 15:25:23.000000000","tz":-240},"subject":"Enable reloadable config in uwsgi","message":"Enable reloadable config in uwsgi\n\nBy default uwsgi is set to exit on reload this breaks config reloading\nof the service. [1][2]\n\n[1] https://etherpad.openstack.org/p/uwsgi-issues\n[2] http://uwsgi-docs.readthedocs.io/en/latest/Options.html#exit-on-reload\n\nChange-Id: I2896dc9c2e516167a2ef9b84f5b0aee78788357c\nCo-Authored-By: Dinesh Bhor \u003cdinesh.bhor@nttdata.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d995a8ccfda9d06b3052a25cc5ab734f08e9df52"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d995a8ccfda9d06b3052a25cc5ab734f08e9df52"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}