)]}'
{"id":"openstack%2Fdevstack~49214","triplet_id":"openstack%2Fdevstack~master~I54018fc478728b6246921746ef82d893bbcd0dab","project":"openstack/devstack","branch":"master","topic":"sudo-force","hashtags":[],"change_id":"I54018fc478728b6246921746ef82d893bbcd0dab","subject":"Pass FORCE through to sudo invocation","status":"ABANDONED","created":"2013-10-01 16:54:08.000000000","updated":"2013-10-04 20:09:40.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"52503b3750bb9c23e9f85ca8c05455073bc9cd45","_number":49214,"virtual_id_number":49214,"owner":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":1,"date":"2013-10-04 10:32:52.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"disliked":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":1,"date":"2013-10-01 16:57:12.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-10-04 16:10:12.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2013-10-01 18:38:31.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},{"value":-1,"date":"2013-10-04 11:57:35.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2013-10-04 16:10:12.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},{"date":"2013-10-04 11:57:35.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-10-01 16:57:12.000000000","updated_by":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"reviewer":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"state":"REVIEWER"},{"updated":"2013-10-04 10:32:52.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2013-10-04 11:57:35.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-10-04 16:10:12.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"}],"messages":[{"id":"007b54901ea454a6523ff72a1b8d7b1cd6babf09","author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"date":"2013-10-01 16:57:12.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"078aca74ca2a0509866fc90016d6488888bfb4be","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-01 17:45:34.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- check-tempest-devstack-vm-full http://logs.openstack.org/14/49214/1/check/check-tempest-devstack-vm-full/666ffb7 : FAILURE in 45m 15s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/14/49214/1/check/check-tempest-devstack-vm-postgres-full/b3ec933 : SUCCESS in 36m 00s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/14/49214/1/check/check-tempest-devstack-vm-neutron/869bbf8 : SUCCESS in 29m 54s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/14/49214/1/check/gate-tempest-devstack-vm-large-ops/7631ce7 : SUCCESS in 27m 57s\n- check-grenade-devstack-vm http://logs.openstack.org/14/49214/1/check/check-grenade-devstack-vm/c1e9917 : SUCCESS in 41m 04s\n- check-swift-devstack-vm-functional http://logs.openstack.org/14/49214/1/check/check-swift-devstack-vm-functional/4ea7e9f : SUCCESS in 21m 17s\n","accounts_in_message":[],"_revision_number":1},{"id":"155d6d979acc3560b5ed1a8269db281905efff2b","author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"date":"2013-10-01 18:38:31.000000000","message":"Patch Set 1:\n\nrecheck bug 1233743","accounts_in_message":[],"_revision_number":1},{"id":"eec3333b39086448ef8ba3013d8d4f837788e2a2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-01 19:23:25.000000000","message":"Patch Set 1:\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- check-tempest-devstack-vm-full http://logs.openstack.org/14/49214/1/check/check-tempest-devstack-vm-full/59a2230 : SUCCESS in 30m 58s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/14/49214/1/check/check-tempest-devstack-vm-postgres-full/e19fa3d : FAILURE in 44m 41s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/14/49214/1/check/check-tempest-devstack-vm-neutron/1cc4b7a : SUCCESS in 17m 38s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/14/49214/1/check/gate-tempest-devstack-vm-large-ops/1f36a39 : SUCCESS in 21m 47s\n- check-grenade-devstack-vm http://logs.openstack.org/14/49214/1/check/check-grenade-devstack-vm/1d8d8e2 : SUCCESS in 25m 35s\n- check-swift-devstack-vm-functional http://logs.openstack.org/14/49214/1/check/check-swift-devstack-vm-functional/6224346 : SUCCESS in 14m 28s\n","accounts_in_message":[],"_revision_number":1},{"id":"92fdb5b445c5d3198d2a4843717b040acfa33133","author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"date":"2013-10-03 16:37:38.000000000","message":"Patch Set 1:\n\nrecheck bug 1205344 since #49181 reintroduced skipping of failing test.","accounts_in_message":[],"_revision_number":1},{"id":"131388b0bff5e86b6f6bf998b443205eb7a74e48","author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"date":"2013-10-04 09:14:00.000000000","message":"Patch Set 1:\n\nrecheck bug 1205344","accounts_in_message":[],"_revision_number":1},{"id":"c8a9223810fbe6929de2f69710257e8f8f11948c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-04 09:44:09.000000000","message":"Patch Set 1:\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- check-tempest-devstack-vm-full http://logs.openstack.org/14/49214/1/check/check-tempest-devstack-vm-full/58798ea : SUCCESS in 29m 14s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/14/49214/1/check/check-tempest-devstack-vm-postgres-full/ec68a4f : SUCCESS in 29m 56s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/14/49214/1/check/check-tempest-devstack-vm-neutron/5c1973a : SUCCESS in 22m 05s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/14/49214/1/check/gate-tempest-devstack-vm-large-ops/9fe8e19 : SUCCESS in 11m 49s\n- check-grenade-devstack-vm http://logs.openstack.org/14/49214/1/check/check-grenade-devstack-vm/ca0ba39 : SUCCESS in 26m 54s\n- check-swift-devstack-vm-functional http://logs.openstack.org/14/49214/1/check/check-swift-devstack-vm-functional/7509def : FAILURE in 7m 02s\n","accounts_in_message":[],"_revision_number":1},{"id":"eb1ceb07a3278d7b4dd81038e26fc7ca3dd8b5a6","author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"date":"2013-10-04 09:56:51.000000000","message":"Patch Set 1:\n\nrecheck bug 1221247","accounts_in_message":[],"_revision_number":1},{"id":"e47b87644b74323e4c5361c2a432988164ca9fed","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-04 10:32:52.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- check-tempest-devstack-vm-full http://logs.openstack.org/14/49214/1/check/check-tempest-devstack-vm-full/0346a77 : SUCCESS in 28m 31s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/14/49214/1/check/check-tempest-devstack-vm-postgres-full/dc35da8 : SUCCESS in 29m 01s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/14/49214/1/check/check-tempest-devstack-vm-neutron/6408577 : SUCCESS in 17m 35s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/14/49214/1/check/gate-tempest-devstack-vm-large-ops/fed73f1 : SUCCESS in 11m 03s\n- check-grenade-devstack-vm http://logs.openstack.org/14/49214/1/check/check-grenade-devstack-vm/5451efe : SUCCESS in 35m 41s\n- check-swift-devstack-vm-functional http://logs.openstack.org/14/49214/1/check/check-swift-devstack-vm-functional/1e57243 : SUCCESS in 14m 23s\n","accounts_in_message":[],"_revision_number":1},{"id":"6ad413411344ed991d2d7587923c153966460337","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-10-04 11:57:35.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nI don\u0027t think we really want to be supporting running stack.sh as root","accounts_in_message":[],"_revision_number":1},{"id":"c5e252101d43f48f31aa03051d9e90a6bdf0c8dd","author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"date":"2013-10-04 13:18:12.000000000","message":"Patch Set 1:\n\nWe are *already* supporting running stack.sh as root.  This merely fixes it.","accounts_in_message":[],"_revision_number":1},{"id":"9ac314d9a61d04eeae539fa9e9eb53f7c48c71f1","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-10-04 16:10:12.000000000","message":"Patch Set 1:\n\nI\u0027d argue that we _don\u0027t_ support running as root but we have an ugly hack to let people start stack.sh as root.  This has actually caused more problems than I think is worth.  If FORCE needs to be passed, what about HTTP_PROXY?  Or any of the other things that probably needs to be in localrc anyway?\n\nI\u0027d like to dump the whole root hack thing...","accounts_in_message":[],"_revision_number":1},{"id":"bcbddfc1958aa8024b9ca7c9d06783b54e34d823","author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"date":"2013-10-04 17:04:54.000000000","message":"Patch Set 1:\n\nThere\u0027s nothing on the website or in the README.md which says stack.sh should or shouldn\u0027t be run as root.  stack.sh\u0027s current behaviour is to fairly gracefully handle running as root, so it seems entirely reasonable for newcomers to assume it should work.  If it really is officially unsupported, then it\u0027s a very misleading state of affairs for newcomers :-/  In that case it should at very least barf with a \"please don\u0027t run me as root\" error message.\n\nI totally share your concerns about HTTP_PROXY etc. so I\u0027m not going to argue against the idea of removing root support in either the short or long term.  However I think we need to clarify the status quo and set users\u0027 expectations correctly ASAP.\n\nSo IMHO there are only three reasonable ways forward:\n\n1. *immediately* remove support for running as root, and update the website to explain how to correctly set up sudoers, or\n\n2. accept short-term fixes for current breakage when running as root, but maintain a medium or long term target of removing support for running as root, or\n\n3. decide to maintain support for running as root indefinitely.\n\nWhat I\u0027d hate to see happen is:\n\n4. my fixes for the breakage get rejected, but partially broken root support is left in for any significant period of time.\n\nOn a similar topic, it\u0027s not very clear from the website (to me at least) which distro platforms are supported or where support can be found, but that\u0027s another can of worms which I\u0027ll open elsewhere ...","accounts_in_message":[],"_revision_number":1},{"id":"f13b24bce51f84e21801a339d4667bcf1c79cf03","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-10-04 18:06:05.000000000","message":"Patch Set 1:\n\nYou are correct about the perils of leaving partially broken code in place, and since I\u0027ve considered this bit broken since it was added here is my proposal: https://review.openstack.org/#/c/49798/","accounts_in_message":[],"_revision_number":1},{"id":"906d484f7ec8ad080dc0e4c9b49ca8d740bcc8a4","author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"date":"2013-10-04 20:09:40.000000000","message":"Patch Set 1: Abandoned\n\nSuperceded by 49798.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c7c82cc6679c3b74cfccfbce7e81710291435367","revisions":{"c7c82cc6679c3b74cfccfbce7e81710291435367":{"kind":"REWORK","_number":1,"created":"2013-10-01 16:54:08.000000000","uploader":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"ref":"refs/changes/14/49214/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/14/49214/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/14/49214/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/14/49214/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/14/49214/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/14/49214/1"}}},"commit":{"parents":[{"commit":"1c1aef0eb7796f0fe8b2502eb4aaa62369b7842a","subject":"Revert \"Enable tenant isolation to tempest for neutron\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/1c1aef0eb7796f0fe8b2502eb4aaa62369b7842a"}]}],"author":{"name":"Adam Spiers","email":"aspiers@suse.com","date":"2013-09-30 23:03:05.000000000","tz":60},"committer":{"name":"Adam Spiers","email":"aspiers@suse.com","date":"2013-10-01 16:53:52.000000000","tz":60},"subject":"Pass FORCE through to sudo invocation","message":"Pass FORCE through to sudo invocation\n\nIf we ran stack.sh as root, pass through the value of the FORCE variable\nthrough to the child stack.sh running as the \u0027stack\u0027 user via sudo,\notherwise the child process will not have FORCE set and will abort\nprematurely.\n\nChange-Id: I54018fc478728b6246921746ef82d893bbcd0dab\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c7c82cc6679c3b74cfccfbce7e81710291435367"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c7c82cc6679c3b74cfccfbce7e81710291435367"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}