)]}'
{"id":"openstack%2Fdevstack~49215","triplet_id":"openstack%2Fdevstack~master~I7a55784c31e5395e29ab9bbe2bb112b83b9be693","project":"openstack/devstack","branch":"master","topic":"helpers-abort-on-error","hashtags":[],"change_id":"I7a55784c31e5395e29ab9bbe2bb112b83b9be693","subject":"set errexit and xtrace in helper scripts","status":"MERGED","created":"2013-10-01 16:56:38.000000000","updated":"2013-10-04 19:17:08.000000000","submitted":"2013-10-04 19:17:07.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3fb39d1d55922218b384952443bb191748dbf290","_number":49215,"virtual_id_number":49215,"owner":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-10-04 19:17:07.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-10-01 18:40:30.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},{"value":2,"date":"2013-10-04 18:37:48.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":2,"date":"2013-10-04 12:51:07.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},{"value":1,"date":"2013-10-04 18:37:48.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2013-10-04 12:51:07.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-10-04 12:51:07.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-10-04 18:37:48.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2013-10-04 19:17:07.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"79a2e73c565c5d8e80cedaa73dea0cea11d932de","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-01 17:53:30.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- check-tempest-devstack-vm-full http://logs.openstack.org/15/49215/1/check/check-tempest-devstack-vm-full/056f7ec : SUCCESS in 50m 31s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/15/49215/1/check/check-tempest-devstack-vm-postgres-full/4850d56 : FAILURE in 47m 32s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/15/49215/1/check/check-tempest-devstack-vm-neutron/2f150f9 : SUCCESS in 31m 30s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/15/49215/1/check/gate-tempest-devstack-vm-large-ops/f009f17 : SUCCESS in 28m 20s\n- check-grenade-devstack-vm http://logs.openstack.org/15/49215/1/check/check-grenade-devstack-vm/0820e5d : SUCCESS in 33m 55s\n- check-swift-devstack-vm-functional http://logs.openstack.org/15/49215/1/check/check-swift-devstack-vm-functional/bb6af09 : SUCCESS in 13m 31s\n","accounts_in_message":[],"_revision_number":1},{"id":"c138aabbc3548956063098d339d670e7ec744446","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2013-10-01 17:53:52.000000000","message":"Patch Set 1:\n\nI noticed tempest failed, I think you hit bug https://bugs.launchpad.net/bugs/1226337","accounts_in_message":[],"_revision_number":1},{"id":"e5637143a5de8d7afe3aab26cd8c66e722ee75b3","author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"date":"2013-10-01 18:40:30.000000000","message":"Patch Set 1:\n\nrecheck bug 1233743","accounts_in_message":[],"_revision_number":1},{"id":"c17c9ad0db8b16715ea57d60e20be46132b8f0ca","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-01 19:25:57.000000000","message":"Patch Set 1:\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- check-tempest-devstack-vm-full http://logs.openstack.org/15/49215/1/check/check-tempest-devstack-vm-full/3908b91 : SUCCESS in 45m 05s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/15/49215/1/check/check-tempest-devstack-vm-postgres-full/5620b38 : FAILURE in 45m 12s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/15/49215/1/check/check-tempest-devstack-vm-neutron/4b1efc4 : FAILURE in 30m 59s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/15/49215/1/check/gate-tempest-devstack-vm-large-ops/11184fd : SUCCESS in 10m 23s\n- check-grenade-devstack-vm http://logs.openstack.org/15/49215/1/check/check-grenade-devstack-vm/3193da5 : SUCCESS in 33m 17s\n- check-swift-devstack-vm-functional http://logs.openstack.org/15/49215/1/check/check-swift-devstack-vm-functional/f502542 : SUCCESS in 11m 52s\n","accounts_in_message":[],"_revision_number":1},{"id":"c88e136bb744edcbcc7b0de4922949ba826b29f8","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2013-10-01 19:26:19.000000000","message":"Patch Set 1:\n\nI noticed tempest failed, I think you hit bug https://bugs.launchpad.net/bugs/1230407","accounts_in_message":[],"_revision_number":1},{"id":"ffec960333a5cc36b98d6d6f538e43d4166b4ac7","author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"date":"2013-10-03 16:40:07.000000000","message":"Patch Set 1:\n\nrecheck bug 1205344 since #49181 reintroduced skipping of failing test.","accounts_in_message":[],"_revision_number":1},{"id":"6e8104059c5f4199b811b6d2423a12b4ecfcd85e","author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"date":"2013-10-03 17:04:59.000000000","message":"Patch Set 1:\n\nHmm, maybe the recheck bot requires an unpolluted line.  I\u0027ll try again without the extra comment.","accounts_in_message":[],"_revision_number":1},{"id":"800c4a690267d4b627e979eefcd9da090bc131bc","author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"date":"2013-10-03 17:05:09.000000000","message":"Patch Set 1:\n\nrecheck bug 1205344","accounts_in_message":[],"_revision_number":1},{"id":"1e8ededb220e41c14954f937204039252ae5de30","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-03 17:37:43.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- check-tempest-devstack-vm-full http://logs.openstack.org/15/49215/1/check/check-tempest-devstack-vm-full/4581cde : SUCCESS in 28m 52s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/15/49215/1/check/check-tempest-devstack-vm-postgres-full/3f50954 : SUCCESS in 28m 21s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/15/49215/1/check/check-tempest-devstack-vm-neutron/5d4f0bf : SUCCESS in 24m 01s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/15/49215/1/check/gate-tempest-devstack-vm-large-ops/82ad7b1 : SUCCESS in 11m 58s\n- check-grenade-devstack-vm http://logs.openstack.org/15/49215/1/check/check-grenade-devstack-vm/2f356c5 : SUCCESS in 32m 21s\n- check-swift-devstack-vm-functional http://logs.openstack.org/15/49215/1/check/check-swift-devstack-vm-functional/01da62d : SUCCESS in 12m 24s\n","accounts_in_message":[],"_revision_number":1},{"id":"93912d9359bcb03c411149e0cbab877d9e14c3fc","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-10-04 12:51:07.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nseems fine to me","accounts_in_message":[],"_revision_number":1},{"id":"3f490525a637db0e83a07ddbf8dc4f8a62bc2efc","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-10-04 18:37:48.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"30ad9b65ec2971d5f98316f599cfea569d39483b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-04 18:37:49.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"0721886f443649db68096f4ad9ae24280eb33225","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-04 19:17:07.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- gate-tempest-devstack-vm-full http://logs.openstack.org/15/49215/1/gate/gate-tempest-devstack-vm-full/3cf7c0d : SUCCESS in 31m 41s\n- gate-tempest-devstack-vm-postgres-full http://logs.openstack.org/15/49215/1/gate/gate-tempest-devstack-vm-postgres-full/c601186 : SUCCESS in 33m 34s\n- gate-tempest-devstack-vm-neutron http://logs.openstack.org/15/49215/1/gate/gate-tempest-devstack-vm-neutron/f9ba632 : SUCCESS in 17m 29s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/15/49215/1/gate/gate-tempest-devstack-vm-large-ops/eaf5904 : SUCCESS in 12m 09s\n- gate-grenade-devstack-vm http://logs.openstack.org/15/49215/1/gate/gate-grenade-devstack-vm/2810523 : SUCCESS in 26m 12s\n- gate-swift-devstack-vm-functional http://logs.openstack.org/15/49215/1/gate/gate-swift-devstack-vm-functional/996aaf4 : SUCCESS in 11m 50s\n","accounts_in_message":[],"_revision_number":1},{"id":"24e71b81faa07ebc6880d0573af8237d45f975ff","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-04 19:17:08.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c85ade77204af724ee04f7b7d6d406e50f25ead6","revisions":{"c85ade77204af724ee04f7b7d6d406e50f25ead6":{"kind":"REWORK","_number":1,"created":"2013-10-01 16:56:38.000000000","uploader":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"ref":"refs/changes/15/49215/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/15/49215/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/15/49215/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/15/49215/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/15/49215/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/15/49215/1"}}},"commit":{"parents":[{"commit":"1c1aef0eb7796f0fe8b2502eb4aaa62369b7842a","subject":"Revert \"Enable tenant isolation to tempest for neutron\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/1c1aef0eb7796f0fe8b2502eb4aaa62369b7842a"}]}],"author":{"name":"Adam Spiers","email":"aspiers@suse.com","date":"2013-09-30 23:35:16.000000000","tz":60},"committer":{"name":"Adam Spiers","email":"aspiers@suse.com","date":"2013-10-01 16:54:40.000000000","tz":60},"subject":"set errexit and xtrace in helper scripts","message":"set errexit and xtrace in helper scripts\n\nstack.sh invokes some helper scripts as separate processes, rather than\nby source\u0027ing them.  As with stack.sh itself, abort immediately on the\nfirst error, so that errors don\u0027t compound and result in confusing error\nmessages.  If one of these helper scripts aborts, stack.sh itself will\nalso abort in the usual manner.\n\nDue to the change in behaviour, tweak some mv invocations to ensure that\nthey don\u0027t trigger false failures.\n\nAs with stack.sh itself, also enable xtrace so we can see exactly what\u0027s\nhappening.  In particular this allows us to see the cause of any\npremature termination due to a command failing whilst errexit is\nenabled.\n\nChange-Id: I7a55784c31e5395e29ab9bbe2bb112b83b9be693\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c85ade77204af724ee04f7b7d6d406e50f25ead6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c85ade77204af724ee04f7b7d6d406e50f25ead6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
