)]}'
{"id":"openstack%2Fdevstack~49216","triplet_id":"openstack%2Fdevstack~master~If42ad6270d60f4b01b1587032448654699d4c812","project":"openstack/devstack","branch":"master","topic":"sudo-unstack","hashtags":[],"change_id":"If42ad6270d60f4b01b1587032448654699d4c812","subject":"Make unstack.sh work when run as root","status":"ABANDONED","created":"2013-10-01 16:57:34.000000000","updated":"2013-10-04 20:12:02.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"cb295ccf9d516094537e2ec1f6122b91cc1c6ff6","_number":49216,"virtual_id_number":49216,"owner":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2013-10-03 16:16:01.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-10-01 18:42:40.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},{"value":-2,"date":"2013-10-04 12:03:18.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},{"date":"2013-10-04 12:03:18.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-10-03 16:16:01.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2013-10-04 12:03:18.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"}],"messages":[{"id":"e92a325ccd81b87f46c0312f53d5a8634e83360c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-01 17:55:25.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- check-tempest-devstack-vm-full http://logs.openstack.org/16/49216/1/check/check-tempest-devstack-vm-full/43b685d : SUCCESS in 48m 40s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/16/49216/1/check/check-tempest-devstack-vm-postgres-full/53c1692 : FAILURE in 50m 39s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/16/49216/1/check/check-tempest-devstack-vm-neutron/fbbaff8 : FAILURE in 31m 47s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/16/49216/1/check/gate-tempest-devstack-vm-large-ops/f76a425 : SUCCESS in 11m 44s\n- check-grenade-devstack-vm http://logs.openstack.org/16/49216/1/check/check-grenade-devstack-vm/632416f : SUCCESS in 34m 09s\n- check-swift-devstack-vm-functional http://logs.openstack.org/16/49216/1/check/check-swift-devstack-vm-functional/3542343 : SUCCESS in 26m 04s\n","accounts_in_message":[],"_revision_number":1},{"id":"c466400dab3ec258d0157352e364094a373d31b0","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2013-10-01 17:57:41.000000000","message":"Patch Set 1:\n\nI noticed tempest failed, I think you hit bug https://bugs.launchpad.net/bugs/1229475","accounts_in_message":[],"_revision_number":1},{"id":"defed62a79d7d1ab770248031720d0da3bba2312","author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"date":"2013-10-01 18:42:40.000000000","message":"Patch Set 1:\n\nrecheck bug 1233743","accounts_in_message":[],"_revision_number":1},{"id":"47575fdf6c6fd8ee19e707a0e177c78a588a74f9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-01 19:36:13.000000000","message":"Patch Set 1:\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- check-tempest-devstack-vm-full http://logs.openstack.org/16/49216/1/check/check-tempest-devstack-vm-full/f295ef5 : FAILURE in 44m 12s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/16/49216/1/check/check-tempest-devstack-vm-postgres-full/e0f925a : SUCCESS in 42m 32s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/16/49216/1/check/check-tempest-devstack-vm-neutron/e6f1cd4 : SUCCESS in 27m 02s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/16/49216/1/check/gate-tempest-devstack-vm-large-ops/4f39322 : SUCCESS in 14m 09s\n- check-grenade-devstack-vm http://logs.openstack.org/16/49216/1/check/check-grenade-devstack-vm/f0d837e : SUCCESS in 36m 08s\n- check-swift-devstack-vm-functional http://logs.openstack.org/16/49216/1/check/check-swift-devstack-vm-functional/58c0112 : SUCCESS in 12m 14s\n","accounts_in_message":[],"_revision_number":1},{"id":"e24ea159c7c9cb3fb5be52a5d6de87bc52ebe200","author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"date":"2013-10-03 15:36:31.000000000","message":"Patch Set 1:\n\nrecheck bug 1205344","accounts_in_message":[],"_revision_number":1},{"id":"cbe0f4470fcc09b79e629ff88b7567146d700cce","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-03 16:16:01.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- check-tempest-devstack-vm-full http://logs.openstack.org/16/49216/1/check/check-tempest-devstack-vm-full/b8e1984 : SUCCESS in 30m 44s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/16/49216/1/check/check-tempest-devstack-vm-postgres-full/8382688 : SUCCESS in 39m 21s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/16/49216/1/check/check-tempest-devstack-vm-neutron/84ffe2d : SUCCESS in 35m 33s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/16/49216/1/check/gate-tempest-devstack-vm-large-ops/d9a03fd : SUCCESS in 10m 43s\n- check-grenade-devstack-vm http://logs.openstack.org/16/49216/1/check/check-grenade-devstack-vm/6bf431a : SUCCESS in 27m 31s\n- check-swift-devstack-vm-functional http://logs.openstack.org/16/49216/1/check/check-swift-devstack-vm-functional/06cfd39 : SUCCESS in 10m 46s\n","accounts_in_message":[],"_revision_number":1},{"id":"fd29707503aa5c871015dc0f7083095af116f827","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-10-04 12:03:18.000000000","message":"Patch Set 1: Do not merge\n\nhonestly, I don\u0027t want to have the effort to make this stuff run as root. Doing development as root is a terrible idea.","accounts_in_message":[],"_revision_number":1},{"id":"e0d8448ad72a21c86109fcc5eb6989c77b56dc6b","author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"date":"2013-10-04 13:17:26.000000000","message":"Patch Set 1:\n\nSorry Sean, I\u0027m not sure I follow your logic exactly.  I won\u0027t disagree that developing as root is a stupid idea, but that\u0027s precisely why ./stack.sh will already automatically create a dedicated user for devstack, configure sudo, and then switch to that user.\n\nSince we already support people invoking ./stack.sh as root, isn\u0027t it reasonable to also support invoking ./unstack.sh as root?  But currently that\u0027s just plain broken, which is what this patch fixes.","accounts_in_message":[],"_revision_number":1},{"id":"0822ac801cbcebd73c8a9f503a3e48a828243a49","author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"date":"2013-10-04 20:12:02.000000000","message":"Patch Set 1: Abandoned\n\nSuperceded by https://review.openstack.org/#/c/49798/","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"009385a903d09f2f658dcf9791ab1da6a8599158","revisions":{"009385a903d09f2f658dcf9791ab1da6a8599158":{"kind":"REWORK","_number":1,"created":"2013-10-01 16:57:34.000000000","uploader":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"ref":"refs/changes/16/49216/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/16/49216/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/16/49216/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/16/49216/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/16/49216/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/16/49216/1"}}},"commit":{"parents":[{"commit":"1c1aef0eb7796f0fe8b2502eb4aaa62369b7842a","subject":"Revert \"Enable tenant isolation to tempest for neutron\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/1c1aef0eb7796f0fe8b2502eb4aaa62369b7842a"}]}],"author":{"name":"Adam Spiers","email":"aspiers@suse.com","date":"2013-10-01 15:27:41.000000000","tz":60},"committer":{"name":"Adam Spiers","email":"aspiers@suse.com","date":"2013-10-01 16:57:18.000000000","tz":60},"subject":"Make unstack.sh work when run as root","message":"Make unstack.sh work when run as root\n\nMake unstack.sh check whether it\u0027s running as root, and if so, use the\nsame approach as stack.sh in order to switch to the $STACK_USER account,\nand re-exec itself.  In contrast to stack.sh, we can skip the sudo and\n$STACK_USER account setup code, because this should have already been\ntaken care of via a stack.sh run (and if it hasn\u0027t, presumably there is\nnothing worth \"unstacking\").\n\nChange-Id: If42ad6270d60f4b01b1587032448654699d4c812\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/009385a903d09f2f658dcf9791ab1da6a8599158"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/009385a903d09f2f658dcf9791ab1da6a8599158"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}