)]}'
{"lib/apache":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"7717a751aa7e02c63063163fd92d283a9a4cf31a","unresolved":false,"context_lines":[{"line_number":334,"context_line":"    local apache_conf\u003d\"\""},{"line_number":335,"context_line":"    apache_conf\u003d$(apache_site_config_for $name)"},{"line_number":336,"context_line":"    echo \"KeepAlive Off\" | sudo tee $apache_conf"},{"line_number":337,"context_line":"    echo \"SetEnv proxy-sendchunked 1\" | sudo tee -a $apache_conf"},{"line_number":338,"context_line":"    echo \"ProxyPass \\\"${url}\\\" \\\"http://127.0.0.1:$port\\\" retry\u003d0 \" | sudo tee -a $apache_conf"},{"line_number":339,"context_line":"    enable_apache_site $name"},{"line_number":340,"context_line":"    restart_apache_server"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9f436f4f_b8c4d860","line":337,"updated":"2017-08-17 17:28:49.000000000","message":"The docs are a bit ambiguous here: \" It allows request bodies to be sent to the backend using chunked transfer encoding.\"\n\n\"allows\". I guess that means if it comes that way, send it on, otherwise, don\u0027t.\n\nThat\u0027s what we want, so good.\n\nMy worry was that this could have the global consequences, in the other direction, as sendcl.","commit_id":"a3488d5f0067b570974c14572c58bbf8cedf7ed2"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"10024f9ca8fb2380c55554ef09860fddb974888f","unresolved":false,"context_lines":[{"line_number":334,"context_line":"    local apache_conf\u003d\"\""},{"line_number":335,"context_line":"    apache_conf\u003d$(apache_site_config_for $name)"},{"line_number":336,"context_line":"    echo \"KeepAlive Off\" | sudo tee $apache_conf"},{"line_number":337,"context_line":"    echo \"SetEnv proxy-sendchunked 1\" | sudo tee -a $apache_conf"},{"line_number":338,"context_line":"    echo \"ProxyPass \\\"${url}\\\" \\\"http://127.0.0.1:$port\\\" retry\u003d0 \" | sudo tee -a $apache_conf"},{"line_number":339,"context_line":"    enable_apache_site $name"},{"line_number":340,"context_line":"    restart_apache_server"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9f436f4f_186be41f","line":337,"in_reply_to":"9f436f4f_b8c4d860","updated":"2017-08-17 17:41:50.000000000","message":"Right, I read it as just making sure the proxy properly forwards chunked bodies, instead of doing something else with it I guess.\n\nYeah, I thought about that potential issue before pushing this up. This reverse problem is why I set sendcl in the other uwsgi path, just to make sure we didn\u0027t fail if nova or cinder got a chunked request by chance. But, to get apache configured where this is just for the services using write_local_uwsgi_http_config would be a much bigger change. I\u0027d need to rework how we create the different proxy config files in apache to make sure they\u0027re all separated into different virtualhosts to isolate them. (or something similar) Which is why I opted for the easy fix here.\n\nI think the chances we get a random chunked encoding on a body for the other services is probably pretty low. But even if we did it would fail with a known error, a 411 for the missing content length.","commit_id":"a3488d5f0067b570974c14572c58bbf8cedf7ed2"}]}