)]}'
{"id":"openstack%2Fdevstack~49394","triplet_id":"openstack%2Fdevstack~master~I965506d9105608c936bcbcb5913d1e154bedaad3","project":"openstack/devstack","branch":"master","topic":"bug/1234254","hashtags":[],"change_id":"I965506d9105608c936bcbcb5913d1e154bedaad3","subject":"force run_process to really spawn a bash process","status":"ABANDONED","created":"2013-10-02 16:07:01.000000000","updated":"2013-10-18 15:05:02.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"71399cdbad2212c5f5c3e41f2029c3073e659c1f","_number":49394,"virtual_id_number":49394,"owner":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2013-10-14 10:16:13.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-10-11 13:41:12.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"value":-2,"date":"2013-10-11 07:17:45.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2013-10-14 14:34:21.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-10-02 16:38:05.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2013-10-03 08:04:03.000000000","updated_by":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"reviewer":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"state":"REVIEWER"},{"updated":"2013-10-04 10:03:39.000000000","updated_by":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"reviewer":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"state":"REVIEWER"},{"updated":"2013-10-04 11:19:21.000000000","updated_by":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"reviewer":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"state":"REVIEWER"},{"updated":"2013-10-04 11:33:32.000000000","updated_by":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"reviewer":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"state":"REVIEWER"},{"updated":"2013-10-08 13:09:17.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-10-11 13:41:12.000000000","updated_by":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"reviewer":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"state":"REVIEWER"},{"updated":"2013-10-14 10:16:13.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"2efb5594121fa564215be84ce65443b8408b7491","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2013-10-02 16:09:05.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"07758f61a04de464ac5de33245a386f347632419","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2013-10-02 16:14:01.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"b72ca49f1e50775351995e8ef5234359b434bbae","author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"date":"2013-10-02 16:36:35.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c81d9963ac405a4fdfbf47ee0fc838c7f2483bc2","author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"date":"2013-10-02 16:37:09.000000000","message":"Patch Set 1: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"1bd9b85bfabd39f02b6f72d1349d91f2343589b8","author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"date":"2013-10-02 16:37:50.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"2af02cf0e19fcbb9954f56da92754b0e5092fe54","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-10-02 16:37:58.000000000","message":"Patch Set 3:\n\nNew patchset patch-id matches previous patchset, but whitespace content has changed.","accounts_in_message":[],"_revision_number":3},{"id":"1348f65ae079f19b61c8e2f482ddbfefd4dcc486","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-10-02 16:38:05.000000000","message":"Patch Set 3: Do not merge\n\nrun_process() is working exactly as desired.  Ceilometer behaves differently here because it does not do \"cd $CEILOMETER_DIR; ...\" in the screen_it command like all of the other services.  That has the same effect without affecting run_process().","accounts_in_message":[],"_revision_number":3},{"id":"3a425cdd66f3947f2168b71249017e38003ec2d0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-02 17:18:29.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- check-tempest-devstack-vm-full http://logs.openstack.org/94/49394/3/check/check-tempest-devstack-vm-full/2c8a6d3 : SUCCESS in 40m 25s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/94/49394/3/check/check-tempest-devstack-vm-postgres-full/2d04791 : SUCCESS in 40m 22s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/94/49394/3/check/check-tempest-devstack-vm-neutron/82da2d0 : SUCCESS in 28m 32s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/94/49394/3/check/gate-tempest-devstack-vm-large-ops/9917a68 : SUCCESS in 11m 39s\n- check-grenade-devstack-vm http://logs.openstack.org/94/49394/3/check/check-grenade-devstack-vm/78d12c7 : SUCCESS in 35m 39s\n- check-swift-devstack-vm-functional http://logs.openstack.org/94/49394/3/check/check-swift-devstack-vm-functional/4197be7 : SUCCESS in 18m 37s\n","accounts_in_message":[],"_revision_number":3},{"id":"4d498c2a4dab11eddb93d4a094a0eec0d4797482","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2013-10-02 18:31:34.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\nI think Medhi\u0027s fix is the way to go. It took us days to find the original issue in Ceilometer, as we don\u0027t need to do any sort of \"cd /foobar \u0026\u0026\" to run it. Any service that will have the same non-requirement will encounter this problem.\n\nThis run_process function has a bug, we just encountered it. It is better to fix it than to have each of the service papering over it.","accounts_in_message":[],"_revision_number":3},{"id":"6bc610e8a1f71db28c5492cf2c5273accd6c7198","author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"date":"2013-10-02 21:36:29.000000000","message":"Patch Set 3:\n\nWhy do we need to workaround the bug of run_process in each screen_it call ? the role of run_process is clear, create a simulation of double fork to detach a process.\n\nIf this is the \"true;$command\" that is not sexy, we can write \u0027{ $command ; }\u0027, it works too and it look less hackish.","accounts_in_message":[],"_revision_number":3},{"id":"9aaf159c1738e34152e9c4e34615c242c193ac4f","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2013-10-03 08:55:44.000000000","message":"Patch Set 3:\n\nyeah { } looks better","accounts_in_message":[],"_revision_number":3},{"id":"9c5be0341444cff544a458649ae45f0e442e2ab9","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2013-10-03 12:22:04.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"af51cda53be218181d3c960322f768ccad178cbe","author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"date":"2013-10-03 12:34:39.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"ec3ad0c4cee4bd34c45c0b1c973981de1ff8a354","author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"date":"2013-10-04 08:25:41.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"0d15867f9dba3255ada530d477422d86ef9036eb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-04 09:08:55.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- check-tempest-devstack-vm-full http://logs.openstack.org/94/49394/4/check/check-tempest-devstack-vm-full/db14691 : SUCCESS in 29m 05s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/94/49394/4/check/check-tempest-devstack-vm-postgres-full/91ba544 : SUCCESS in 43m 04s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/94/49394/4/check/check-tempest-devstack-vm-neutron/a1c2434 : SUCCESS in 17m 34s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/94/49394/4/check/gate-tempest-devstack-vm-large-ops/f546e03 : SUCCESS in 10m 38s\n- check-grenade-devstack-vm http://logs.openstack.org/94/49394/4/check/check-grenade-devstack-vm/2c6b92b : SUCCESS in 32m 14s\n- check-swift-devstack-vm-functional http://logs.openstack.org/94/49394/4/check/check-swift-devstack-vm-functional/b3c6fe6 : SUCCESS in 10m 23s\n","accounts_in_message":[],"_revision_number":4},{"id":"4fe64639b9bca25f8cc0fedc2dcafb6c3917511a","author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"date":"2013-10-04 10:03:39.000000000","message":"Patch Set 4: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":4},{"id":"ba4abd12c5b06caa1f2b45661be4d2e1c561240c","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2013-10-04 10:27:03.000000000","message":"Patch Set 4: Looks good to me, but someone else must approve\n\nDean: this is blocking QA work that\u0027s being done on Ceilometer , so it would *really* help if you could answer and/or lift your -2.","accounts_in_message":[],"_revision_number":4},{"id":"874bc13a549a2640014b9a6bff95e11112cd1cf8","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2013-10-04 11:19:21.000000000","message":"Patch Set 4: Looks good to me, but someone else must approve\n\nThis seems less magical than the previous patch.","accounts_in_message":[],"_revision_number":4},{"id":"373314e65d5772486b52eff4ba65e63864b03cb2","author":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"date":"2013-10-04 11:33:32.000000000","message":"Patch Set 4: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":4},{"id":"65b4a2608d35b99aed98927a33a5567a885ba230","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-10-08 13:09:17.000000000","message":"Patch Set 4: Do not merge\n\nI do not understand why ceilometer is different here than the other processes, and this commit message or the bug are not helping with that. Why isn\u0027t this an issue for other services?","accounts_in_message":[],"_revision_number":4},{"id":"8d234690460bd69aa19b89ead7c695c6e4329847","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2013-10-08 13:19:49.000000000","message":"Patch Set 4:\n\nSean, with all my due respect, the fact that you do not understand unfortunately don\u0027t imply that you are right. You are basically adding -2 without even arguing, which is not a good thing to do.\n\nTherefore, I\u0027ll try to explain.\n\nThere\u0027s two cases when using \"bash -c\":\n#1 When using \"bash -c \u0027command\u0027\", the bash process belongs to the same process group that the process that called \"bash -c\".\n\n#2 When using \"bash -c \u0027command1; command2\u0027\", the bash process starts a new process group to run these commands. This also happens when using \"bash -c \u0027{ command; }\u0027\" as this starts a new process group.\n\n\nIn devstack, there\u0027s a clean up procedure that kills all jobs started by the script using \"jobs -p\". The -p option lists all the processes that are part of the same group process of the shell running \"jobs -p\", in this case the script.\n\n\nSome projects in devstack runs the commands \"cd foobar \u0026\u0026 foobar\", which is translated into case #2. In such case, \"jobs -p\" does not return the PID of these, and they are not cleaned out by the killing spree.\n\nHowever, Ceilometer has no need to change the directory before running, so we simple asked \"ceilometer-api\" to be ran. However, this translates to case #1. And in the end, that makes Ceilometer part of the same process group as the script, therefore listed in the \"jobs -p\" output and it is killed as the environment is cleaned. Rendering Ceilometer non functionnal.\n\nNothing in the prototype or documentation of this function indicates that the command should be composed of at least two components, that\u0027s why Mehdi\u0027s proposing to fix this function to work in _every_ cases and to to make all its call fall into the case #2. Fixing our the Ceilometer problem in a clean way, and avoiding this pitfalls for future users.","accounts_in_message":[],"_revision_number":4},{"id":"e60f294553904bbda7863b68d876b84e31e4929f","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-10-08 14:52:01.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t merge this\n\nso I -2ed to get an explanation, which I don\u0027t think is out of line. The point of a core reviewer is to ensure they are comfortable with what\u0027s going into the tree. What it looks like the issue is that ceilometer isn\u0027t calling out of the git tree but out of /usr/local instead (unlike other services).\n\nSo how does this impact the ability to C-c the process, change code in the git tree, and start it again with a command and taking the updates in the code? If this is a new model for processes we should probably apply it across the board instead of piece meal on a single project.","accounts_in_message":[],"_revision_number":4},{"id":"4ba9f486a48b6bbc4622ce0c10884031afd67b08","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-10-08 19:28:59.000000000","message":"Patch Set 4:\n\n@Sean, this is only an issue when USE_SCREEN\u003dFalse so all of the screen-related development workflow is unchanged.\n\nI\u0027ll state one more time, run_process() and _run_process() are operating exactly as designed.  You can get the behaviour that you want by changing the screen_it calls in lib/ceilometer.  After applying this patch you can not get the existing behaviour (direct exec without a subshell) if desired.","accounts_in_message":[],"_revision_number":4},{"id":"ce3edad5396b9780a69bb66801d2872c7230a878","author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"date":"2013-10-09 07:33:02.000000000","message":"Patch Set 4:\n\nSorry, but I don\u0027t see in devstack a call of run_process with \u0027direct exec without a subshell\u0027\n\nAnd _run_process comment say \"is designed to be backgrounded by run_process() to simulate a fork. \", and I when I read this I understand that _run_process must have this subshell to  work and \u0027simulate a fork\u0027.\n\nI have found two other issues about this when USE_SCREEN\u003dFalse :\n\n- nova-baremetal-deploy-helper is killed by devstack (like ceilometer processes) too.\n- and more important: do you have already remarks that the sysstat log and dat are incomplete ? because is killed at the end of devstack.sh run too.\n\n(for example http://logs.openstack.org/56/49456/6/check/check-tempest-devstack-vm-full/9a4e4f3/logs/screen-sysstat.txt.gz run during 2 minutes or this gate job take 20 minutes)","accounts_in_message":[],"_revision_number":4},{"id":"a9f1f2ea243ff479b10cee422626f201515e3ff3","author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"date":"2013-10-11 07:17:45.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"583bc4792987b13726d040d9f2748107c71c6e56","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-10-11 07:17:56.000000000","message":"Patch Set 5:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":5},{"id":"affccec7be890f10ef1408b7e395e72c9603c81a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-11 07:54:27.000000000","message":"Patch Set 5: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- check-tempest-devstack-vm-full http://logs.openstack.org/94/49394/5/check/check-tempest-devstack-vm-full/a78f7f9 : SUCCESS in 31m 18s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/94/49394/5/check/check-tempest-devstack-vm-postgres-full/10c7e7a : FAILURE in 36m 34s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/94/49394/5/check/check-tempest-devstack-vm-neutron/803c193 : SUCCESS in 19m 26s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/94/49394/5/check/gate-tempest-devstack-vm-large-ops/e588e2e : SUCCESS in 14m 39s\n- check-grenade-devstack-vm http://logs.openstack.org/94/49394/5/check/check-grenade-devstack-vm/8b57e2e : SUCCESS in 27m 04s\n- check-swift-devstack-vm-functional http://logs.openstack.org/94/49394/5/check/check-swift-devstack-vm-functional/50dcbe7 : SUCCESS in 12m 07s\n","accounts_in_message":[],"_revision_number":5},{"id":"e3e0f97fb70233253316faf778d78b6cc684251a","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2013-10-11 07:55:49.000000000","message":"Patch Set 5:\n\nI noticed tempest failed, I think you hit bugs: https://bugs.launchpad.net/bugs/1235437","accounts_in_message":[],"_revision_number":5},{"id":"21f09d6e898ee634110fe47588dcaa7a458fe55a","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2013-10-11 13:41:12.000000000","message":"Patch Set 5:\n\nrecheck bug /1235437","accounts_in_message":[],"_revision_number":5},{"id":"896f798d65017f6c1bb67c97ef8170729f86182d","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2013-10-14 09:44:26.000000000","message":"Patch Set 5:\n\nrecheck bug 1235437","accounts_in_message":[],"_revision_number":5},{"id":"0247e55d5abe9709e55199381789c11b40d708e2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-14 10:16:13.000000000","message":"Patch Set 5: Works for me\n\nBuild succeeded.\n\n- check-tempest-devstack-vm-full http://logs.openstack.org/94/49394/5/check/check-tempest-devstack-vm-full/ab50ca6 : SUCCESS in 31m 06s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/94/49394/5/check/check-tempest-devstack-vm-postgres-full/9d3f313 : SUCCESS in 30m 36s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/94/49394/5/check/check-tempest-devstack-vm-neutron/05a1e8f : SUCCESS in 19m 11s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/94/49394/5/check/gate-tempest-devstack-vm-large-ops/cc5696c : SUCCESS in 13m 28s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/94/49394/5/check/gate-tempest-devstack-vm-neutron-large-ops/0209be6 : SUCCESS in 16m 32s (non-voting)\n- check-grenade-devstack-vm http://logs.openstack.org/94/49394/5/check/check-grenade-devstack-vm/bba78d5 : SUCCESS in 31m 38s\n- check-swift-devstack-vm-functional http://logs.openstack.org/94/49394/5/check/check-swift-devstack-vm-functional/b385ad2 : SUCCESS in 12m 46s\n","accounts_in_message":[],"_revision_number":5},{"id":"47ad58728fca58855395a44848a420f38f26c272","author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"date":"2013-10-14 14:34:21.000000000","message":"Patch Set 5:\n\nThe other way to solve the ceilometer QA issue:\n\nhttps://review.openstack.org/#/q/status:open+project:openstack-dev/devstack+branch:master+topic:bug/1234254-otherways,n,z","accounts_in_message":[],"_revision_number":5},{"id":"b962f1126fcd2122d19a3255c30ecd4f9fb99d05","author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"date":"2013-10-18 15:05:02.000000000","message":"Patch Set 5: Abandoned","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"40be78dd2f51ee469d4e5724efc9ea8fc4821606","revisions":{"487c34b13d9a1f1342af60e49404860e9e5de904":{"kind":"REWORK","_number":1,"created":"2013-10-02 16:07:01.000000000","uploader":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"ref":"refs/changes/94/49394/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/94/49394/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/94/49394/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/94/49394/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/94/49394/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/94/49394/1"}}},"commit":{"parents":[{"commit":"1c1aef0eb7796f0fe8b2502eb4aaa62369b7842a","subject":"Revert \"Enable tenant isolation to tempest for neutron\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/1c1aef0eb7796f0fe8b2502eb4aaa62369b7842a"}]}],"author":{"name":"Mehdi Abaakouk","email":"mehdi.abaakouk@enovance.com","date":"2013-10-02 15:43:43.000000000","tz":0},"committer":{"name":"Mehdi Abaakouk","email":"mehdi.abaakouk@enovance.com","date":"2013-10-02 16:04:54.000000000","tz":0},"subject":"force run_process to really spawn a bash process","message":"force run_process to really spawn a bash process\n\nBefore this change ceilometer process are killed by stack.sh in gate\n\ngate use \u0027USE_SCREEN\u003dFalse\u0027 for devstack, this run service process in\nsome bash subshell instead of a screen.\n\nThe ceilometer service process are started directly without embeded shell\ncommand: \u0027screen_it ceilometer-api \"ceilometer-api -d -v ...\"\u0027,\nand this have as effect to not add a additionnal bash (subshell) process between\nthe stack.sh process and the ceilometer process.\n\nAnd when stack.sh kill all directly attached process (clean function),\nit kill the with ceilometer one too.\n\nThis is because the \u0027bash -c \"only_one_command\"\u0027 use exec to start the command\nand does not execute the command as a bash script.\n\nThis patch add \u0027true;\u0027 to the service command to be sure that bash don\u0027t exec the\ncommand passed to \u0027-c\u0027 but execute it as a shell script.\n\nFixes bug #1234254\n\nChange-Id: I965506d9105608c936bcbcb5913d1e154bedaad3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/487c34b13d9a1f1342af60e49404860e9e5de904"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/487c34b13d9a1f1342af60e49404860e9e5de904"}]},"branch":"refs/heads/master"},"27e30a698d06966850228137a6b5ebc14e47a6fe":{"kind":"REWORK","_number":2,"created":"2013-10-02 16:36:35.000000000","uploader":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"ref":"refs/changes/94/49394/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/94/49394/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/94/49394/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/94/49394/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/94/49394/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/94/49394/2"}}},"commit":{"parents":[{"commit":"1c1aef0eb7796f0fe8b2502eb4aaa62369b7842a","subject":"Revert \"Enable tenant isolation to tempest for neutron\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/1c1aef0eb7796f0fe8b2502eb4aaa62369b7842a"}]}],"author":{"name":"Mehdi Abaakouk","email":"mehdi.abaakouk@enovance.com","date":"2013-10-02 15:43:43.000000000","tz":0},"committer":{"name":"Mehdi Abaakouk","email":"mehdi.abaakouk@enovance.com","date":"2013-10-02 16:36:24.000000000","tz":120},"subject":"force run_process to really spawn a bash process","message":"force run_process to really spawn a bash process\n\nBefore this change ceilometer process are killed by stack.sh in gate\n\ngate use \u0027USE_SCREEN\u003dFalse\u0027 for devstack, this run service process in\nsome bash subshell instead of a screen.\n\nThe ceilometer service process are started directly without embeded shell\ncommand: \u0027screen_it ceilometer-api \"ceilometer-api -d -v ...\"\u0027,\nand this have as effect to not add a additionnal bash (subshell) process between\nthe stack.sh process and the ceilometer process.\n\nAnd when stack.sh kill all directly attached process (clean function),\nit kill the with ceilometer one too.\n\nThis is because the \u0027bash -c \"only_one_command\"\u0027 use exec to start the command\nand does not execute the command as a bash script.\n\nThis patch add \u0027true;\u0027 to the service command to be sure that bash don\u0027t exec the\ncommand passed to \u0027-c\u0027 but execute it as a shell script.\n\nFixes bug #1234254\n\nChange-Id: I965506d9105608c936bcbcb5913d1e154bedaad3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/27e30a698d06966850228137a6b5ebc14e47a6fe"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/27e30a698d06966850228137a6b5ebc14e47a6fe"}]},"branch":"refs/heads/master"},"c631fe2dce3d594db97ed6e95106ac0196eb55ba":{"kind":"REWORK","_number":3,"created":"2013-10-02 16:37:50.000000000","uploader":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"ref":"refs/changes/94/49394/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/94/49394/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/94/49394/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/94/49394/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/94/49394/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/94/49394/3"}}},"commit":{"parents":[{"commit":"1c1aef0eb7796f0fe8b2502eb4aaa62369b7842a","subject":"Revert \"Enable tenant isolation to tempest for neutron\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/1c1aef0eb7796f0fe8b2502eb4aaa62369b7842a"}]}],"author":{"name":"Mehdi Abaakouk","email":"mehdi.abaakouk@enovance.com","date":"2013-10-02 15:43:43.000000000","tz":0},"committer":{"name":"Mehdi Abaakouk","email":"mehdi.abaakouk@enovance.com","date":"2013-10-02 16:37:37.000000000","tz":120},"subject":"force run_process to really spawn a bash process","message":"force run_process to really spawn a bash process\n\nBefore this change ceilometer process are killed by stack.sh in gate\n\ngate use \u0027USE_SCREEN\u003dFalse\u0027 for devstack, this run service process in\nsome bash subshell instead of a screen.\n\nThe ceilometer service process are started directly without embeded shell\ncommand: \u0027screen_it ceilometer-api \"ceilometer-api -d -v ...\"\u0027,\nand this have as effect to not add a additionnal bash (subshell) process between\nthe stack.sh process and the ceilometer process.\n\nAnd when stack.sh kill all directly attached process (clean function),\nit kill the with ceilometer one too.\n\nThis is because the \u0027bash -c \"only_one_command\"\u0027 use exec to start the command\nand does not execute the command as a bash script.\n\nThis patch add \u0027true;\u0027 to the service command to be sure that bash don\u0027t exec the\ncommand passed to \u0027-c\u0027 but execute it as a shell script.\n\nFixes bug #1234254\n\nChange-Id: I965506d9105608c936bcbcb5913d1e154bedaad3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c631fe2dce3d594db97ed6e95106ac0196eb55ba"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c631fe2dce3d594db97ed6e95106ac0196eb55ba"}]},"branch":"refs/heads/master"},"609631baa02c541a8270f79bd62cc37744797584":{"kind":"REWORK","_number":4,"created":"2013-10-04 08:25:41.000000000","uploader":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"ref":"refs/changes/94/49394/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/94/49394/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/94/49394/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/94/49394/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/94/49394/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/94/49394/4"}}},"commit":{"parents":[{"commit":"c5affb48d6f0eab5d517bc8dc5ddbaeaa09a98c6","subject":"Merge \"Ensure SSL CA certificates are installed for curl\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c5affb48d6f0eab5d517bc8dc5ddbaeaa09a98c6"}]}],"author":{"name":"Mehdi Abaakouk","email":"mehdi.abaakouk@enovance.com","date":"2013-10-02 15:43:43.000000000","tz":0},"committer":{"name":"Mehdi Abaakouk","email":"mehdi.abaakouk@enovance.com","date":"2013-10-04 08:25:34.000000000","tz":120},"subject":"force run_process to really spawn a bash process","message":"force run_process to really spawn a bash process\n\nBefore this change ceilometer process are killed by stack.sh in gate\n\ngate use \u0027USE_SCREEN\u003dFalse\u0027 for devstack, this run service process in\nsome bash subshell instead of a screen.\n\nThe ceilometer service process are started directly without embeded shell\ncommand: \u0027screen_it ceilometer-api \"ceilometer-api -d -v ...\"\u0027,\nand this have as effect to not add a additionnal bash (subshell) process between\nthe stack.sh process and the ceilometer process.\n\nAnd when stack.sh kill all directly attached process (clean function),\nit kill the with ceilometer one too.\n\nThis is because the \u0027bash -c \"only_one_command\"\u0027 use exec to start the command\nand does not execute the command as a bash script.\n\nThis patch use \"{ $command ; }\" to be sure that bash don\u0027t exec the command\npassed to \u0027-c\u0027 but execute it as a shell script.\n\nFixes bug #1234254\n\nChange-Id: I965506d9105608c936bcbcb5913d1e154bedaad3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/609631baa02c541a8270f79bd62cc37744797584"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/609631baa02c541a8270f79bd62cc37744797584"}]},"branch":"refs/heads/master"},"40be78dd2f51ee469d4e5724efc9ea8fc4821606":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":5,"created":"2013-10-11 07:17:45.000000000","uploader":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"ref":"refs/changes/94/49394/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/94/49394/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/94/49394/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/94/49394/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/94/49394/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/94/49394/5"}}},"commit":{"parents":[{"commit":"67f7da2de299f4f9ab58718aafce336012035cd8","subject":"Merge \"Use the rdo havana repo with the RHEL family\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/67f7da2de299f4f9ab58718aafce336012035cd8"}]}],"author":{"name":"Mehdi Abaakouk","email":"mehdi.abaakouk@enovance.com","date":"2013-10-02 15:43:43.000000000","tz":0},"committer":{"name":"Mehdi Abaakouk","email":"mehdi.abaakouk@enovance.com","date":"2013-10-11 07:14:47.000000000","tz":120},"subject":"force run_process to really spawn a bash process","message":"force run_process to really spawn a bash process\n\nBefore this change ceilometer/sar process are killed by stack.sh in gate\n\ngate use \u0027USE_SCREEN\u003dFalse\u0027 for devstack, this run service process in\nsome bash subshell instead of a screen.\n\nThe ceilometer service or the sar command are started directly without embeded shell\ncommand: \u0027screen_it ceilometer-api \"ceilometer-api -d -v ...\"\u0027,\nand this have as effect to not add a additionnal bash (subshell) process between\nthe stack.sh process and the ceilometer/sar process.\n\nAnd when stack.sh kill all directly attached process (clean function),\nit kill the with ceilometer and sar too.\n\nThis is because the \u0027bash -c \"only_one_command\"\u0027 use exec to start the command\nand does not execute the command as a bash script.\n\nThis patch use \"{ $command ; }\" to be sure that bash don\u0027t exec the command\npassed to \u0027-c\u0027 but execute it as a shell script.\n\nFixes bug #1234254\nFixes bug #1238482\n\nChange-Id: I965506d9105608c936bcbcb5913d1e154bedaad3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/40be78dd2f51ee469d4e5724efc9ea8fc4821606"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/40be78dd2f51ee469d4e5724efc9ea8fc4821606"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}