)]}'
{"README.md":[{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"95ce4aca7a7ad234d1ece0bd7b4699f6d634b673","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# Start A Dev Cloud"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Installing in a dedicated disposable vm is safer than installing on your dev machine!  To start a dev cloud:"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    ./stack.sh"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"When the script finishes executing, you should be able to access OpenStack endpoints, like so:"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"AAAAS3%2F%2FE5Q%3D","side":"PARENT","line":38,"updated":"2013-10-04 19:38:18.000000000","message":"It would be better to tell what to do, not what shouldn\u0027t be done. So please add a reference to the new tools command to be run as root and then the other stuff as the newly created user.","commit_id":"af2b982842c79e8d7f320893d4d2552b3adeb114"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"5038fc50eec08de1e114a3e1afe77f872a76b9d7","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# Start A Dev Cloud"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Installing in a dedicated disposable vm is safer than installing on your dev machine!  To start a dev cloud:"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    ./stack.sh"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"When the script finishes executing, you should be able to access OpenStack endpoints, like so:"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"AAAAS3%2F%2FEmw%3D","side":"PARENT","line":38,"in_reply_to":"AAAAS3%2F%2FE5Q%3D","updated":"2013-10-04 21:20:33.000000000","message":"Yeah, this could be handled better, but I want the initial walk-through to be simple for the suggested default case.  I\u0027ll work it over a bit more","commit_id":"af2b982842c79e8d7f320893d4d2552b3adeb114"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"c704debc497db9574e6567acd943fc7c073128e1","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"DevStack runs rampant over the system it runs on, installing things and uninstalling other things.  Running this on a system you care about is a recipe for disappointment, or worse.  Alas, we\u0027re all in the virtualization business here, so run it in a VM.  And take advantage of the snapshot capabilities of your hypervisor of choice to reduce testing cycle times.  You might even save enough time to write one more feature before the next feature freeze..."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"``stack.sh`` needs to have root access for a lot of tasks, but it also needs to have not-root permissions for most of its work and for all of the OpenStack services.  So ``stack.sh`` specifically does not run if you are root. This is a recent change (Oct 2013) from the previous behaviour of automatically creating a ``stack`` user.  Automatically creating a user account is not always the right response to running as root, so that bit is now an explicit step using ``tools/create-stack-user.sh``.  Run that (as root!) if you do not want to just use your normal login here, which works perfectly fine."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Customizing"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":2,"id":"AAAAS3%2F%2FEYg%3D","line":64,"updated":"2013-10-04 22:44:34.000000000","message":"The text looks good.  Being really pedantic, only single backticks are needed here, not double ... I\u0027d also prefer lines wrapped at 72 columns, but I notice that this file is already a mix of cleanly line-wrapped paragraphs and extremely long lines, so it\u0027s no biggie.","commit_id":"23f69d83e5564ece0308535117cc6d224fcc3557"}],"stack.sh":[{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"91d657928c1e646c7253ce7526d51b13dac37f26","unresolved":false,"context_lines":[{"line_number":200,"context_line":"echo \"Defaults:$STACK_USER secure_path\u003d/sbin:/usr/sbin:/usr/bin:/bin:/usr/local/sbin:/usr/local/bin\" \u003e\u003e $TEMPFILE"},{"line_number":201,"context_line":"chmod 0440 $TEMPFILE"},{"line_number":202,"context_line":"sudo chown root:root $TEMPFILE"},{"line_number":203,"context_line":"sudo mv $TEMPFILE /etc/sudoers.d/50_stack_sh"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"# Create the destination directory and ensure it is writable by the user"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAAS3%2F%2FE0Y%3D","line":203,"updated":"2013-10-04 20:08:48.000000000","message":"This section all seems a bit chicken-and-egg (if we can already chown/mv via sudo, are we likely to need to add 50_stack_sh?), but this is a pre-existing condition which the proposed patch certainly doesn\u0027t make any worse, so I\u0027m not against it.","commit_id":"60f10ea7b2ed9b7a87ecde2e1168e45700d10aa1"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"5038fc50eec08de1e114a3e1afe77f872a76b9d7","unresolved":false,"context_lines":[{"line_number":200,"context_line":"echo \"Defaults:$STACK_USER secure_path\u003d/sbin:/usr/sbin:/usr/bin:/bin:/usr/local/sbin:/usr/local/bin\" \u003e\u003e $TEMPFILE"},{"line_number":201,"context_line":"chmod 0440 $TEMPFILE"},{"line_number":202,"context_line":"sudo chown root:root $TEMPFILE"},{"line_number":203,"context_line":"sudo mv $TEMPFILE /etc/sudoers.d/50_stack_sh"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"# Create the destination directory and ensure it is writable by the user"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAAS3%2F%2FEnM%3D","line":203,"in_reply_to":"AAAAS3%2F%2FE0Y%3D","updated":"2013-10-04 21:20:33.000000000","message":"For people who never need to create $STACK_USER (I run as my own login in the VMs) this is still necessary. In my case it is useful to change $STACK_USER to not need a password.  Also the PATH bit is helpful.","commit_id":"60f10ea7b2ed9b7a87ecde2e1168e45700d10aa1"}],"tools/create-stack-user.sh":[{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"95ce4aca7a7ad234d1ece0bd7b4699f6d634b673","unresolved":false,"context_lines":[{"line_number":26,"context_line":"GetDistro"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Needed to get ``ENABLED_SERVICES``"},{"line_number":29,"context_line":"source $TOP_DIR/stackrc"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# Give the non-root user the ability to run as **root** via ``sudo``"},{"line_number":32,"context_line":"is_package_installed sudo || install_package sudo"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAAS3%2F%2FE70%3D","line":29,"updated":"2013-10-04 19:38:18.000000000","message":"Enabled services isn\u0027t used here, is it? I guess this is needed for Stack_User?","commit_id":"60f10ea7b2ed9b7a87ecde2e1168e45700d10aa1"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"5038fc50eec08de1e114a3e1afe77f872a76b9d7","unresolved":false,"context_lines":[{"line_number":26,"context_line":"GetDistro"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Needed to get ``ENABLED_SERVICES``"},{"line_number":29,"context_line":"source $TOP_DIR/stackrc"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# Give the non-root user the ability to run as **root** via ``sudo``"},{"line_number":32,"context_line":"is_package_installed sudo || install_package sudo"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAAS3%2F%2FEnA%3D","line":29,"in_reply_to":"AAAAS3%2F%2FE70%3D","updated":"2013-10-04 21:20:33.000000000","message":"Yup","commit_id":"60f10ea7b2ed9b7a87ecde2e1168e45700d10aa1"}]}