)]}'
{"id":"openstack%2Fdevstack~49798","triplet_id":"openstack%2Fdevstack~master~I5d967c00c89f32e861449234ea8fe19261cd9ae3","project":"openstack/devstack","branch":"master","topic":"no-root","hashtags":[],"change_id":"I5d967c00c89f32e861449234ea8fe19261cd9ae3","subject":"Split the creation of $STACK_USER account out of stack.sh","status":"MERGED","created":"2013-10-04 18:04:18.000000000","updated":"2013-10-05 14:02:50.000000000","submitted":"2013-10-05 14:02:49.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"88d81c8db59479ee586f841b7ac8b6a11dac4787","_number":49798,"virtual_id_number":49798,"owner":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":2,"date":"2013-10-05 14:02:49.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"recommended":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"all":[{"value":0,"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-10-04 22:44:34.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":2,"date":"2013-10-05 13:34:30.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":1,"date":"2013-10-05 13:34:30.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-10-04 19:38:18.000000000","updated_by":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"reviewer":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"state":"REVIEWER"},{"updated":"2013-10-04 22:44:34.000000000","updated_by":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"reviewer":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"state":"REVIEWER"},{"updated":"2013-10-05 13:34:30.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-10-05 14:02:49.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"8c598e7e905737152dcecc6d3c2c632f0d802439","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-04 18:44:15.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- check-tempest-devstack-vm-full http://logs.openstack.org/98/49798/1/check/check-tempest-devstack-vm-full/05bda7e : SUCCESS in 39m 03s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/98/49798/1/check/check-tempest-devstack-vm-postgres-full/8ff0fc9 : SUCCESS in 39m 47s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/98/49798/1/check/check-tempest-devstack-vm-neutron/909cf19 : SUCCESS in 22m 07s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/98/49798/1/check/gate-tempest-devstack-vm-large-ops/2efd8b6 : SUCCESS in 10m 05s\n- check-grenade-devstack-vm http://logs.openstack.org/98/49798/1/check/check-grenade-devstack-vm/b1384fc : SUCCESS in 31m 26s\n- check-swift-devstack-vm-functional http://logs.openstack.org/98/49798/1/check/check-swift-devstack-vm-functional/0421bb9 : SUCCESS in 12m 27s\n","accounts_in_message":[],"_revision_number":1},{"id":"95ce4aca7a7ad234d1ece0bd7b4699f6d634b673","author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"date":"2013-10-04 19:38:18.000000000","message":"Patch Set 1: (2 inline comments)\n\nLooks good to me, a few comments inline.","accounts_in_message":[],"_revision_number":1},{"id":"91d657928c1e646c7253ce7526d51b13dac37f26","author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"date":"2013-10-04 20:08:48.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"bc48d87eb234d9be31cbefb2cd806b7d028c2516","author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"date":"2013-10-04 20:11:30.000000000","message":"Patch Set 1: No score\n\nOn second thoughts, please can you add a non-root check for unstack.sh into this patch?","accounts_in_message":[],"_revision_number":1},{"id":"5038fc50eec08de1e114a3e1afe77f872a76b9d7","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-10-04 21:20:33.000000000","message":"Patch Set 1: (3 inline comments)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"8f956edfe3bcf3ff89995db3fecf63ff5f994ca0","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-10-04 21:37:11.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4be97e84d487eb8db8ce126da0c29da006d2d7a0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-04 22:18:10.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- check-tempest-devstack-vm-full http://logs.openstack.org/98/49798/2/check/check-tempest-devstack-vm-full/e259af2 : SUCCESS in 38m 53s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/98/49798/2/check/check-tempest-devstack-vm-postgres-full/97137fc : SUCCESS in 40m 47s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/98/49798/2/check/check-tempest-devstack-vm-neutron/cecec44 : SUCCESS in 22m 44s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/98/49798/2/check/gate-tempest-devstack-vm-large-ops/051281b : SUCCESS in 12m 09s\n- check-grenade-devstack-vm http://logs.openstack.org/98/49798/2/check/check-grenade-devstack-vm/a99ef4d : SUCCESS in 31m 55s\n- check-swift-devstack-vm-functional http://logs.openstack.org/98/49798/2/check/check-swift-devstack-vm-functional/a935df7 : SUCCESS in 10m 57s\n","accounts_in_message":[],"_revision_number":2},{"id":"c704debc497db9574e6567acd943fc7c073128e1","author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"date":"2013-10-04 22:44:34.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"d3b4b0e584448663d9ad56af27b9758ec5302c41","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-10-05 13:34:30.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"581f20e05b511ae12ce6f226305d95ef5f7a6932","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-05 13:34:31.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"4ebe75ab8194093bbca1186b039d8749e3714482","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-05 14:02:49.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- gate-tempest-devstack-vm-full http://logs.openstack.org/98/49798/2/gate/gate-tempest-devstack-vm-full/15987f5 : SUCCESS in 27m 11s\n- gate-tempest-devstack-vm-postgres-full http://logs.openstack.org/98/49798/2/gate/gate-tempest-devstack-vm-postgres-full/ac56da0 : SUCCESS in 28m 09s\n- gate-tempest-devstack-vm-neutron http://logs.openstack.org/98/49798/2/gate/gate-tempest-devstack-vm-neutron/2702f81 : SUCCESS in 17m 15s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/98/49798/2/gate/gate-tempest-devstack-vm-large-ops/836d18c : SUCCESS in 10m 23s\n- gate-grenade-devstack-vm http://logs.openstack.org/98/49798/2/gate/gate-grenade-devstack-vm/f4fe11f : SUCCESS in 21m 06s\n- gate-swift-devstack-vm-functional http://logs.openstack.org/98/49798/2/gate/gate-swift-devstack-vm-functional/bea743b : SUCCESS in 12m 24s\n","accounts_in_message":[],"_revision_number":2},{"id":"025810b3ac6876a9e79579ecbc225ba54e8f6342","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-05 14:02:50.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"23f69d83e5564ece0308535117cc6d224fcc3557","revisions":{"60f10ea7b2ed9b7a87ecde2e1168e45700d10aa1":{"kind":"REWORK","_number":1,"created":"2013-10-04 18:04:18.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/98/49798/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/98/49798/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/98/49798/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/98/49798/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/98/49798/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/98/49798/1"}}},"commit":{"parents":[{"commit":"af2b982842c79e8d7f320893d4d2552b3adeb114","subject":"Merge \"Add back rpc_notifier when ceilometer is enabled\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/af2b982842c79e8d7f320893d4d2552b3adeb114"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2013-10-04 17:35:24.000000000","tz":-300},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2013-10-04 17:42:03.000000000","tz":-300},"subject":"Split the creation of $STACK_USER account out of stack.sh","message":"Split the creation of $STACK_USER account out of stack.sh\n\nAutomatically creating a new user account is not always the right course\nof action when stack.sh is running as root.  Plus, the re-exec did not\nwork correctly in some cases.\n\n* Create tools/create-stack-user.sh to set up a suitable user\n  for running DevStack\n* Abort stack.sh if running as root and suggest creating a suitable user\n\nChange-Id: I5d967c00c89f32e861449234ea8fe19261cd9ae3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/60f10ea7b2ed9b7a87ecde2e1168e45700d10aa1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/60f10ea7b2ed9b7a87ecde2e1168e45700d10aa1"}]},"branch":"refs/heads/master"},"23f69d83e5564ece0308535117cc6d224fcc3557":{"kind":"REWORK","_number":2,"created":"2013-10-04 21:37:11.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/98/49798/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/98/49798/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/98/49798/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/98/49798/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/98/49798/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/98/49798/2"}}},"commit":{"parents":[{"commit":"af2b982842c79e8d7f320893d4d2552b3adeb114","subject":"Merge \"Add back rpc_notifier when ceilometer is enabled\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/af2b982842c79e8d7f320893d4d2552b3adeb114"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2013-10-04 17:35:24.000000000","tz":-300},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2013-10-04 21:36:00.000000000","tz":-300},"subject":"Split the creation of $STACK_USER account out of stack.sh","message":"Split the creation of $STACK_USER account out of stack.sh\n\nAutomatically creating a new user account is not always the right course\nof action when stack.sh is running as root.  Plus, the re-exec did not\nwork correctly in some cases.\n\n* Create tools/create-stack-user.sh to set up a suitable user\n  for running DevStack\n* Abort stack.sh and unstack.sh if running as root and suggest creating a\n  suitable user account.\n\nChange-Id: I5d967c00c89f32e861449234ea8fe19261cd9ae3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/23f69d83e5564ece0308535117cc6d224fcc3557"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/23f69d83e5564ece0308535117cc6d224fcc3557"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}