)]}'
{"lib/cinder":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"13972655d6d99894996be0ecf6d1274b61980304","unresolved":false,"context_lines":[{"line_number":506,"context_line":"        if [ \"$CINDER_USE_MOD_WSGI\" \u003d\u003d \"False\" ]; then"},{"line_number":507,"context_line":"            run_process c-api \"$CINDER_BIN_DIR/cinder-api --config-file $CINDER_CONF\""},{"line_number":508,"context_line":"            cinder_url\u003d$service_protocol://$SERVICE_HOST:$service_port"},{"line_number":509,"context_line":"            # Start proxy if tsl enabled"},{"line_number":510,"context_line":"            if is_service_enabled tls_proxy; then"},{"line_number":511,"context_line":"                start_tls_proxy cinder \u0027*\u0027 $CINDER_SERVICE_PORT $CINDER_SERVICE_HOST $CINDER_SERVICE_PORT_INT"},{"line_number":512,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7f287b81_2eba386d","line":509,"updated":"2017-08-29 05:11:19.000000000","message":"s/tsl/tls/ while we\u0027re here","commit_id":"0cf63077d26e18ffe8ede5fe160ec9ea799433b7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0797cbe32fdb187c773dce45e3182bab584cd02b","unresolved":false,"context_lines":[{"line_number":506,"context_line":"        if [ \"$CINDER_USE_MOD_WSGI\" \u003d\u003d \"False\" ]; then"},{"line_number":507,"context_line":"            run_process c-api \"$CINDER_BIN_DIR/cinder-api --config-file $CINDER_CONF\""},{"line_number":508,"context_line":"            cinder_url\u003d$service_protocol://$SERVICE_HOST:$service_port"},{"line_number":509,"context_line":"            # Start proxy if tsl enabled"},{"line_number":510,"context_line":"            if is_service_enabled tls_proxy; then"},{"line_number":511,"context_line":"                start_tls_proxy cinder \u0027*\u0027 $CINDER_SERVICE_PORT $CINDER_SERVICE_HOST $CINDER_SERVICE_PORT_INT"},{"line_number":512,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7f287b81_f061aeaa","line":509,"in_reply_to":"7f287b81_2eba386d","updated":"2017-08-29 05:37:46.000000000","message":"Done","commit_id":"0cf63077d26e18ffe8ede5fe160ec9ea799433b7"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"13972655d6d99894996be0ecf6d1274b61980304","unresolved":false,"context_lines":[{"line_number":507,"context_line":"            run_process c-api \"$CINDER_BIN_DIR/cinder-api --config-file $CINDER_CONF\""},{"line_number":508,"context_line":"            cinder_url\u003d$service_protocol://$SERVICE_HOST:$service_port"},{"line_number":509,"context_line":"            # Start proxy if tsl enabled"},{"line_number":510,"context_line":"            if is_service_enabled tls_proxy; then"},{"line_number":511,"context_line":"                start_tls_proxy cinder \u0027*\u0027 $CINDER_SERVICE_PORT $CINDER_SERVICE_HOST $CINDER_SERVICE_PORT_INT"},{"line_number":512,"context_line":"            fi"},{"line_number":513,"context_line":"        else"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7f287b81_4eb5847d","line":510,"updated":"2017-08-29 05:11:19.000000000","message":"Didn\u0027t you wonder why this never worked? ;)\n\nI believe this should be \"tls-proxy\" (not underscore).  Hence why this path wasn\u0027t taken.","commit_id":"0cf63077d26e18ffe8ede5fe160ec9ea799433b7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0797cbe32fdb187c773dce45e3182bab584cd02b","unresolved":false,"context_lines":[{"line_number":507,"context_line":"            run_process c-api \"$CINDER_BIN_DIR/cinder-api --config-file $CINDER_CONF\""},{"line_number":508,"context_line":"            cinder_url\u003d$service_protocol://$SERVICE_HOST:$service_port"},{"line_number":509,"context_line":"            # Start proxy if tsl enabled"},{"line_number":510,"context_line":"            if is_service_enabled tls_proxy; then"},{"line_number":511,"context_line":"                start_tls_proxy cinder \u0027*\u0027 $CINDER_SERVICE_PORT $CINDER_SERVICE_HOST $CINDER_SERVICE_PORT_INT"},{"line_number":512,"context_line":"            fi"},{"line_number":513,"context_line":"        else"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7f287b81_b00c46ec","line":510,"in_reply_to":"7f287b81_4eb5847d","updated":"2017-08-29 05:37:46.000000000","message":"You are right, done, thx.\n\nI was indeed wondering, but assumed that it wasn\u0027t noticed because by default CINDER_USE_MOD_WSGI is true and thus the \"else\" branch is taken.","commit_id":"0cf63077d26e18ffe8ede5fe160ec9ea799433b7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e219f169287b95ab6ba1e82af72f57815ca21600","unresolved":false,"context_lines":[{"line_number":296,"context_line":"            # Set the service port for a proxy to take the original"},{"line_number":297,"context_line":"            if [ \"$CINDER_USE_MOD_WSGI\" \u003d\u003d \"True\" ]; then"},{"line_number":298,"context_line":"                iniset $CINDER_CONF DEFAULT osapi_volume_listen_port $CINDER_SERVICE_PORT_INT"},{"line_number":299,"context_line":"                iniset $CINDER_CONF DEFAULT public_endpoint $CINDER_SERVICE_PROTOCOL://$CINDER_SERVICE_HOST/volume/"},{"line_number":300,"context_line":"            else"},{"line_number":301,"context_line":"                iniset $CINDER_CONF DEFAULT osapi_volume_listen_port $CINDER_SERVICE_PORT_INT"},{"line_number":302,"context_line":"                iniset $CINDER_CONF DEFAULT public_endpoint $CINDER_SERVICE_PROTOCOL://$CINDER_SERVICE_HOST:$CINDER_SERVICE_PORT"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7f287b81_b714f8e9","line":299,"updated":"2017-08-31 08:51:02.000000000","message":"I removed this part of the patch now, see https://review.openstack.org/498828 for a IMO more correct solution that fixes similar issues with other services at the same time.","commit_id":"9c550e8a5712a5bd11458f132b13b68da408311f"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"a5bac65c06ea0c453fa9b03986f6bfbce7ef4c3b","unresolved":false,"context_lines":[{"line_number":379,"context_line":"            get_or_create_endpoint \\"},{"line_number":380,"context_line":"                \"volume\" \\"},{"line_number":381,"context_line":"                \"$REGION_NAME\" \\"},{"line_number":382,"context_line":"                \"$CINDER_SERVICE_PROTOCOL://$CINDER_SERVICE_HOST/volume/v1/\\$(project_id)s\""},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"            get_or_create_service \"cinderv2\" \"volumev2\" \"Cinder Volume Service V2\""},{"line_number":385,"context_line":"            get_or_create_endpoint \\"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7f287b81_1a654c46","line":382,"range":{"start_line":382,"start_character":16,"end_line":382,"end_character":71},"updated":"2017-08-30 14:38:43.000000000","message":"it would be good to synchronize this with the bit above so that we don\u0027t have a lot of hardcoding here. Like maybe a new CINDER_PUBLIC_ENDPOINT_ROOT or something?","commit_id":"9c550e8a5712a5bd11458f132b13b68da408311f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e219f169287b95ab6ba1e82af72f57815ca21600","unresolved":false,"context_lines":[{"line_number":379,"context_line":"            get_or_create_endpoint \\"},{"line_number":380,"context_line":"                \"volume\" \\"},{"line_number":381,"context_line":"                \"$REGION_NAME\" \\"},{"line_number":382,"context_line":"                \"$CINDER_SERVICE_PROTOCOL://$CINDER_SERVICE_HOST/volume/v1/\\$(project_id)s\""},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"            get_or_create_service \"cinderv2\" \"volumev2\" \"Cinder Volume Service V2\""},{"line_number":385,"context_line":"            get_or_create_endpoint \\"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7f287b81_d700a4ad","line":382,"in_reply_to":"7f287b81_1a654c46","updated":"2017-08-31 08:51:02.000000000","message":"Good idea, I\u0027ll look at it in a follow-up patch.","commit_id":"9c550e8a5712a5bd11458f132b13b68da408311f"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"a5bac65c06ea0c453fa9b03986f6bfbce7ef4c3b","unresolved":false,"context_lines":[{"line_number":506,"context_line":"            cinder_url\u003d$service_protocol://$SERVICE_HOST:$service_port"},{"line_number":507,"context_line":"            # Start proxy if tls enabled"},{"line_number":508,"context_line":"            if is_service_enabled tls-proxy; then"},{"line_number":509,"context_line":"                start_tls_proxy cinder \u0027*\u0027 $CINDER_SERVICE_PORT $CINDER_SERVICE_HOST $CINDER_SERVICE_PORT_INT"},{"line_number":510,"context_line":"            fi"},{"line_number":511,"context_line":"        else"},{"line_number":512,"context_line":"            run_process \"c-api\" \"$CINDER_BIN_DIR/uwsgi --ini $CINDER_UWSGI_CONF\""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7f287b81_5ae3d4a4","line":509,"updated":"2017-08-30 14:38:43.000000000","message":"good catch, I guess this was clearly never tested in the old eventlet model.","commit_id":"9c550e8a5712a5bd11458f132b13b68da408311f"}]}