)]}'
{"id":"openstack%2Fdevstack~498604","triplet_id":"openstack%2Fdevstack~master~I52c4ecb70b1ae47e613ba243da5a4d94e5adedf2","project":"openstack/devstack","branch":"master","hashtags":[],"change_id":"I52c4ecb70b1ae47e613ba243da5a4d94e5adedf2","subject":"Create correct directory layout for swift on purpose.","status":"MERGED","created":"2017-08-28 21:22:32.000000000","updated":"2017-09-02 10:26:19.000000000","submitted":"2017-09-02 10:26:19.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"61258dae9302d87bdf823aab9bb1a234d6041881","_number":498604,"virtual_id_number":498604,"owner":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-09-02 10:26:19.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":1,"date":"2017-08-28 22:36:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-09-02 08:49:38.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":2,"date":"2017-08-29 05:14:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-09-02 08:49:38.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-08-28 22:36:27.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2017-08-29 05:14:29.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2017-09-02 08:49:38.000000000","updated_by":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"reviewer":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"state":"REVIEWER"},{"updated":"2017-09-02 10:26:19.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"173920a7b9286aedd71efb118ae00d50e4969b6b","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2017-08-28 21:22:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"845eb9e3fae689e423f08de4dda362d6e223d5c1","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2017-08-28 21:22:48.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline). To recheck leave a comment with \u0027intel-nfv-ci recheck\u0027. For more info go to https://wiki.openstack.org/wiki/ThirdPartySystems/Intel_NFV_CI.\n\n- tempest-dsvm-full-nfv-xenial http://intel-openstack-ci-logs.ovh/portland/2017-08-28/498604/1/check/tempest-dsvm-full-nfv-xenial/cac344c : NOT_REGISTERED\n- tempest-dsvm-ovsdpdk-nfv-networking-centos http://intel-openstack-ci-logs.ovh/portland/2017-08-28/498604/1/check/tempest-dsvm-ovsdpdk-nfv-networking-centos/5527151 : NOT_REGISTERED (non-voting)\n- tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial http://intel-openstack-ci-logs.ovh/portland/2017-08-28/498604/1/check/tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial/93c55b8 : NOT_REGISTERED (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a19fdf66b34953fbf4459d6abf1a30a9b277cd1e","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2017-08-28 22:36:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/devstack/04/498604/1/check/tempest-dsvm-full-xenial/f9900dd/ : SUCCESS in 1h 08m 07s","accounts_in_message":[],"_revision_number":1},{"id":"e86fa6308e30425c34893bc5ea1e49af4d1dad07","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2017-08-29 01:49:58.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- dsvm-tempest-neutron-network http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/04/498604/1/check/dsvm-tempest-neutron-network/d76d960 : SUCCESS in 2h 59m 25s","accounts_in_message":[],"_revision_number":1},{"id":"fb357725060fe1bdae5dd09a45646839530b685c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-29 02:50:44.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial http://logs.openstack.org/04/498604/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/3bb8d02/ : SUCCESS in 1h 36m 16s\n- gate-grenade-dsvm-neutron-ubuntu-xenial http://logs.openstack.org/04/498604/1/check/gate-grenade-dsvm-neutron-ubuntu-xenial/6b0595e/ : SUCCESS in 50m 41s\n- gate-tempest-dsvm-py35-ubuntu-xenial http://logs.openstack.org/04/498604/1/check/gate-tempest-dsvm-py35-ubuntu-xenial/265a342/ : SUCCESS in 1h 21m 07s\n- gate-devstack-docs-ubuntu-xenial http://docs-draft.openstack.org/04/498604/1/check/gate-devstack-docs-ubuntu-xenial/ca946aa//doc/build/html/ : SUCCESS in 3m 09s\n- gate-devstack-bashate http://logs.openstack.org/04/498604/1/check/gate-devstack-bashate/a27c038/ : SUCCESS in 2m 49s\n- gate-devstack-unit-tests http://logs.openstack.org/04/498604/1/check/gate-devstack-unit-tests/0eac95a/ : SUCCESS in 2m 34s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv http://logs.openstack.org/04/498604/1/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv/f3f28c4/ : SUCCESS in 45m 45s (non-voting)\n- gate-devstack-dsvm-updown-ubuntu-xenial http://logs.openstack.org/04/498604/1/check/gate-devstack-dsvm-updown-ubuntu-xenial/b8b919b/ : SUCCESS in 25m 55s\n- gate-devstack-dsvm-py35-updown-ubuntu-xenial-nv http://logs.openstack.org/04/498604/1/check/gate-devstack-dsvm-py35-updown-ubuntu-xenial-nv/d9d0221/ : FAILURE in 56m 22s (non-voting)\n- gate-swift-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/04/498604/1/check/gate-swift-dsvm-functional-ubuntu-xenial-nv/c89c6f1/ : SUCCESS in 17m 49s (non-voting)\n- gate-grenade-dsvm-neutron-multinode-ubuntu-xenial http://logs.openstack.org/04/498604/1/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/3727c96/ : SUCCESS in 57m 21s\n- gate-tempest-dsvm-neutron-full-centos-7-nv http://logs.openstack.org/04/498604/1/check/gate-tempest-dsvm-neutron-full-centos-7-nv/9887d23/ : FAILURE in 1h 42m 18s (non-voting)\n- gate-tempest-dsvm-neutron-linuxbridge-ubuntu-xenial http://logs.openstack.org/04/498604/1/check/gate-tempest-dsvm-neutron-linuxbridge-ubuntu-xenial/986aaa7/ : SUCCESS in 1h 19m 44s\n- gate-tempest-dsvm-neutron-full-opensuse-423-nv http://logs.openstack.org/04/498604/1/check/gate-tempest-dsvm-neutron-full-opensuse-423-nv/e393a23/ : SUCCESS in 1h 15m 19s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv http://logs.openstack.org/04/498604/1/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/3b68110/ : SUCCESS in 1h 26m 20s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c0877a9e0aa1b5f6a53c08218e3f6fe825f36791","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2017-08-29 05:14:29.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"acfbc22e0b77a53edcdd344c068bad7ee079f986","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2017-08-29 16:12:50.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9157fbf36c93c3a412d0dab3c155c954673a6935","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2017-08-31 12:56:02.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-full-nfv-xenial http://intel-openstack-ci-logs.ovh/portland/2017-08-31/498604/1/check/tempest-dsvm-full-nfv-xenial/111ecc6 : SUCCESS in 2h 25m 54s\n- tempest-dsvm-ovsdpdk-nfv-networking-centos http://intel-openstack-ci-logs.ovh/portland/2017-08-31/498604/1/check/tempest-dsvm-ovsdpdk-nfv-networking-centos/0206e31 : SUCCESS in 1h 27m 34s (non-voting)\n- tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial http://intel-openstack-ci-logs.ovh/portland/2017-08-31/498604/1/check/tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial/1ed477c : SUCCESS in 1h 35m 58s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"5b62c23b24c1b2b619c38f95812e5a7c4c9f631c","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2017-09-02 08:49:38.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"2b9b9f02a46f4c0de222117f3dfb1a64f5728a20","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-02 08:49:49.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"e9edfbf4a58b90712bd00393acd61e1df85c5274","date":"2017-09-02 10:26:19.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"61258dae9302d87bdf823aab9bb1a234d6041881","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-02 10:26:19.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial http://logs.openstack.org/04/498604/1/gate/gate-tempest-dsvm-neutron-full-ubuntu-xenial/f801e22/ : SUCCESS in 1h 32m 06s\n- gate-grenade-dsvm-neutron-ubuntu-xenial http://logs.openstack.org/04/498604/1/gate/gate-grenade-dsvm-neutron-ubuntu-xenial/686d636/ : SUCCESS in 45m 19s\n- gate-tempest-dsvm-py35-ubuntu-xenial http://logs.openstack.org/04/498604/1/gate/gate-tempest-dsvm-py35-ubuntu-xenial/cb50442/ : SUCCESS in 1h 32m 42s\n- gate-devstack-docs-ubuntu-xenial http://docs-draft.openstack.org/04/498604/1/gate/gate-devstack-docs-ubuntu-xenial/3ef48cc//doc/build/html/ : SUCCESS in 2m 58s\n- gate-devstack-bashate http://logs.openstack.org/04/498604/1/gate/gate-devstack-bashate/8ed1aef/ : SUCCESS in 1m 58s\n- gate-grenade-dsvm-neutron-multinode-ubuntu-xenial http://logs.openstack.org/04/498604/1/gate/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/8e6530e/ : SUCCESS in 58m 04s\n- gate-tempest-dsvm-neutron-linuxbridge-ubuntu-xenial http://logs.openstack.org/04/498604/1/gate/gate-tempest-dsvm-neutron-linuxbridge-ubuntu-xenial/309d80f/ : SUCCESS in 1h 23m 22s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0e58d22897457831b9dbf02d66a2f29d43803597","revisions":{"0e58d22897457831b9dbf02d66a2f29d43803597":{"kind":"REWORK","_number":1,"created":"2017-08-28 21:22:32.000000000","uploader":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"ref":"refs/changes/04/498604/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/04/498604/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/04/498604/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/04/498604/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/04/498604/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/04/498604/1"}}},"commit":{"parents":[{"commit":"9d7e74e57c73d25e214e0269dbd9d342e8cd960c","subject":"Setup logging for nova_cell1.conf","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/9d7e74e57c73d25e214e0269dbd9d342e8cd960c"}]}],"author":{"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","date":"2017-08-28 21:03:18.000000000","tz":-420},"committer":{"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","date":"2017-08-28 21:03:18.000000000","tz":-420},"subject":"Create correct directory layout for swift on purpose.","message":"Create correct directory layout for swift on purpose.\n\nThe pre-existing configuration for swift on devstack set\u0027s the\n*-server\u0027s devices option (the root of the servers list of devices) to:\n\n    devices \u003d /opt/stack/data/swift/1\n\nwhere \"1\" is the node_number, and will be 2, 3, ... N if the devstack\nmachine is built with more than one swift node/device (pretty sure no\none does that on devstack ever).\n\nThe device(s) in the rings are named (perhaps confusingly similar to the\nswift loopback image) just \"sdb1\", so all storage servers expect to have\na $STACK_USER writeable file system at:\n\n    os.path.join(\u003cdevices_root\u003e, \"sdb1\")\n\nThat directory does not exist when you start up a devstack [1].\n\nCurrently Swift\u0027s object-server\u0027s require that directory exist before\nthey write data into it (even with mount_check \u003d false!).\n\nUnfortunately however, with mount_check\u003dfalse the account/container\nservers are able to create the device directory when it does not exist\n[2].  Which can lead to some unfortunate results with permissions on\nsome deployments using mount_check \u003d false (e.g. testing or\ncontainerized environments).  Fixing this issue [3] uncovered the\npreviously benign [4] mis-configuration in devstack.\n\nAttempting\n\n1. It was lost a long while ago I7c65303791689523f02e5ae44483a6c50b2eed1e\n2. Essentially they want to:\n\n    mkdir -p /opt/stack/data/swift/1/sdb1/containers/\u003cpart#\u003e\n\n... but end up creating the \"sdb1\" dir too!\n3. I3362a6ebff423016bb367b4b6b322bb41ae08764\n4. Benign because the object-server share their device with the\naccount-container devices and they would create the dirs before trying\nto write an object.  It was incorrect, but worked by happenstance, which\nis nearly as good as worked on purpose.\n\nChange-Id: I52c4ecb70b1ae47e613ba243da5a4d94e5adedf2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/0e58d22897457831b9dbf02d66a2f29d43803597"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/0e58d22897457831b9dbf02d66a2f29d43803597"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}