)]}'
{"id":"openstack%2Fdevstack~49872","triplet_id":"openstack%2Fdevstack~master~I51fa9698afb1bfb48596478d83bd1fdcd84ac52e","project":"openstack/devstack","branch":"master","topic":"shocco-errors","hashtags":[],"change_id":"I51fa9698afb1bfb48596478d83bd1fdcd84ac52e","subject":"Fix shocco errors and warnings","status":"MERGED","created":"2013-10-05 11:20:02.000000000","updated":"2013-10-31 14:18:32.000000000","submitted":"2013-10-31 14:18:32.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"5692fc02407cbaf44cbc566c17919e267db9eead","_number":49872,"virtual_id_number":49872,"owner":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-10-31 14:18:32.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-10-24 15:22:15.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},{"value":2,"date":"2013-10-24 23:28:13.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":2,"date":"2013-10-31 11:45:01.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},{"value":0,"date":"2013-10-24 23:28:13.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":1,"date":"2013-10-31 11:45:01.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-10-24 23:28:13.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2013-10-31 11:45:01.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-10-31 14:18:32.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"1c874c3758113d3ec2a028f3a1753bfd8c18e2d6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-05 11:53:04.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- check-tempest-devstack-vm-full http://logs.openstack.org/72/49872/1/check/check-tempest-devstack-vm-full/8018c04 : SUCCESS in 32m 52s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/72/49872/1/check/check-tempest-devstack-vm-postgres-full/4b401ec : SUCCESS in 26m 35s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/72/49872/1/check/check-tempest-devstack-vm-neutron/be4e2d3 : SUCCESS in 15m 27s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/72/49872/1/check/gate-tempest-devstack-vm-large-ops/d8ae360 : SUCCESS in 10m 48s\n- check-grenade-devstack-vm http://logs.openstack.org/72/49872/1/check/check-grenade-devstack-vm/5d7b93b : SUCCESS in 20m 58s\n- check-swift-devstack-vm-functional http://logs.openstack.org/72/49872/1/check/check-swift-devstack-vm-functional/24d8493 : SUCCESS in 12m 14s\n","accounts_in_message":[],"_revision_number":1},{"id":"d2a440c4e1885463af86e3dbfaf3490922523553","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-10-08 14:00:33.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nso, this is good... however I think that we should build a job to sanity check things for this automatically before this is merged, so we can enforce it on all new patches at some point. Can you work with #openstack-infra on that?","accounts_in_message":[],"_revision_number":1},{"id":"b40b0b9b2ae2b1ab604f15aa9dd8bc1a088168a1","author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"date":"2013-10-08 23:42:15.000000000","message":"Patch Set 1:\n\nI can\u0027t without some help on https://bugs.launchpad.net/devstack/+bug/1235626 from Dean or someone else who knows how the website is generated.  I guess I can find someone on #openstack-infra for this, but it\u0027s unlikely to happen this week - next week at the earliest.\n\nI\u0027m not sure I understand the reason why work on the gate should block merging this, however?  Even if we extend the gate to check for shocco errors, we\u0027ll need them fixed before the gate changes, otherwise the gate changes won\u0027t pass the gate itself.","accounts_in_message":[],"_revision_number":1},{"id":"72afbbf42e2a06aa15effa6a12f0d05d097f83e0","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-10-11 20:30:36.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nI think I left my comment on a style checker in the wrong review...it would be great to have but I\u0027d like to get these cleanups in before cutting stable/havana.\n\nAdam, I\u0027m the sole custodian of the build process for devstack.org.  That needs to change but it\u0027s been a low priority for me.  I\u0027m using a shocco fork in my github: https://github.com/dtroyer/shocco/tree/rst_support.  Changes to the site itself should be done as pull requests to github.com:cloudbuilders/devstack.git gh-pages branch.","accounts_in_message":[],"_revision_number":1},{"id":"5e94be46d14bb541cc9aa00c68cf118e656c35c7","author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"date":"2013-10-12 11:52:54.000000000","message":"Patch Set 1:\n\nOops sorry, I already replied in the other review - https://review.openstack.org/#/c/49847/\n\nI said that it looks like there are already at least two utilities out there which could do the job:\n\nhttp://www.shellcheck.net/about.html\n\nhttps://github.com/duggan/shlint\n\nso I don\u0027t think that building a new wheel from scratch makes sense here.\n\nRegarding the build process, if you look at https://bugs.launchpad.net/devstack/+bug/1235626 you\u0027ll see I already found your rst_support branch, but that still isn\u0027t enough information.  Please can you attach to that bug the exact scripts / processes you use to build the website?  The bus factor should be increased from 1 ASAP ;-)","accounts_in_message":[],"_revision_number":1},{"id":"994e0d4ad78f2460ef7da927d1d7984d70e18843","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-10-16 22:13:19.000000000","message":"Patch Set 1:\n\nI\u0027ve worked over my docs script into releaseable form and proposed it in https://review.openstack.org/52226.  It is a first cut but handles all of the shocco processing for devstack.org.  It should be enough for you to duplicate what I\u0027m doing if you run it with no args.  It\u0027ll create a devstack-docs-* directory inside based on the github master.  The major thing lacking yet besides spit-n-polish is the ability to push back to the cloudbuilders repo.","accounts_in_message":[],"_revision_number":1},{"id":"bc889c6f46de2663990eb2edb1fd0b00413e9780","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-10-24 06:03:04.000000000","message":"Patch Set 1:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"49f51943a638bd857dbbc19ddbc28c3c86fc0884","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-10-24 06:03:04.000000000","message":"Patch Set 1: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"ca0fdd551b35f5707fdac2feb5efaad3b4f48660","author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"date":"2013-10-24 15:14:24.000000000","message":"Patch Set 1: Restored\n\nI enhanced shocco with --debug --rst options via https://github.com/rtomayko/shocco/pull/33 to locate\nthe cause of the remaining errors and warnings generated\nby the new tools/build_docs.sh, and will now upload a new\npatch set with the corresponding fixes.","accounts_in_message":[],"_revision_number":1},{"id":"b87ad6335b9b71b554301e036045df3de70fbd74","author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"date":"2013-10-24 15:20:56.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d34102bf6400928dcda2cdbbddde334197fc8691","author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"date":"2013-10-24 15:22:15.000000000","message":"Patch Set 2:\n\n(This is also rebased against the latest master.)","accounts_in_message":[],"_revision_number":2},{"id":"ea4dcfe181f0f406ded5469bbcf04722c56f9871","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-24 16:21:39.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-devstack-bash8 http://logs.openstack.org/72/49872/2/check/gate-devstack-bash8/f9ce89d : SUCCESS in 4s\n- check-tempest-devstack-vm-full http://logs.openstack.org/72/49872/2/check/check-tempest-devstack-vm-full/1beddc8 : SUCCESS in 40m 59s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/72/49872/2/check/check-tempest-devstack-vm-postgres-full/8cca43b : SUCCESS in 1h 00m 35s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/72/49872/2/check/check-tempest-devstack-vm-neutron/7da0951 : SUCCESS in 18m 17s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/72/49872/2/check/gate-tempest-devstack-vm-large-ops/15db110 : SUCCESS in 14m 23s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/72/49872/2/check/gate-tempest-devstack-vm-neutron-large-ops/21aebec : SUCCESS in 17m 25s (non-voting)\n- check-grenade-devstack-vm http://logs.openstack.org/72/49872/2/check/check-grenade-devstack-vm/a1aa3b5 : SUCCESS in 24m 09s\n- check-swift-devstack-vm-functional http://logs.openstack.org/72/49872/2/check/check-swift-devstack-vm-functional/e09f017 : SUCCESS in 11m 10s\n","accounts_in_message":[],"_revision_number":2},{"id":"4c96e2aa511bfd4fb001b4c2d32fe9a58495ef5a","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-10-24 23:28:13.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nDang, you are going to make our docs look good yet.  Thanks for all of this cleanup work.  And for sending the shocco bits upstream.","accounts_in_message":[],"_revision_number":2},{"id":"6ecd3fc9d53830b72fdcea0b7b34f96cfeb5f366","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-10-31 11:45:01.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"acccbf7714801dc21a53e4dc880d82486c31bfa3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-31 11:45:32.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"a5d788f1324d1d412dd20b4116788de9b0734939","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-31 14:18:32.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- gate-devstack-bash8 http://logs.openstack.org/72/49872/2/gate/gate-devstack-bash8/d4587f2 : SUCCESS in 7s\n- gate-tempest-devstack-vm-full http://logs.openstack.org/72/49872/2/gate/gate-tempest-devstack-vm-full/d4a6443 : SUCCESS in 33m 15s\n- gate-tempest-devstack-vm-postgres-full http://logs.openstack.org/72/49872/2/gate/gate-tempest-devstack-vm-postgres-full/f023697 : SUCCESS in 33m 55s\n- gate-tempest-devstack-vm-neutron http://logs.openstack.org/72/49872/2/gate/gate-tempest-devstack-vm-neutron/bbd1a2c : SUCCESS in 19m 32s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/72/49872/2/gate/gate-tempest-devstack-vm-large-ops/3124607 : SUCCESS in 20m 04s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/72/49872/2/gate/gate-tempest-devstack-vm-neutron-large-ops/71ce98e : SUCCESS in 23m 34s (non-voting)\n- gate-grenade-devstack-vm http://logs.openstack.org/72/49872/2/gate/gate-grenade-devstack-vm/b1b842e : SUCCESS in 22m 33s\n- gate-swift-devstack-vm-functional http://logs.openstack.org/72/49872/2/gate/gate-swift-devstack-vm-functional/e5c1a3b : SUCCESS in 12m 22s\n","accounts_in_message":[],"_revision_number":2},{"id":"7815086d7149b7076c9188d35ee111f898f83cb0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-31 14:18:32.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"cb961597cc30f9d8ece17529f09a8291454827e3","revisions":{"0680b5485f44ce6f2e8e0e96753f7a55416c9bec":{"kind":"REWORK","_number":1,"created":"2013-10-05 11:20:02.000000000","uploader":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"ref":"refs/changes/72/49872/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/72/49872/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/72/49872/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/72/49872/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/72/49872/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/72/49872/1"}}},"commit":{"parents":[{"commit":"06e54c74772836fead6679ed115f5f5c9892e8c2","subject":"Merge \"Using no proxy option to skip wget and curl proxy settings in config\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/06e54c74772836fead6679ed115f5f5c9892e8c2"}]}],"author":{"name":"Adam Spiers","email":"aspiers@suse.com","date":"2013-10-05 11:11:07.000000000","tz":60},"committer":{"name":"Adam Spiers","email":"aspiers@suse.com","date":"2013-10-05 11:17:36.000000000","tz":60},"subject":"Fix shocco errors and warnings","message":"Fix shocco errors and warnings\n\nA few Markdown-oriented issues were causing Docutils errors to\nleak into the end-user docs on http://devstack.org\n\nChange-Id: I51fa9698afb1bfb48596478d83bd1fdcd84ac52e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/0680b5485f44ce6f2e8e0e96753f7a55416c9bec"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/0680b5485f44ce6f2e8e0e96753f7a55416c9bec"}]},"branch":"refs/heads/master"},"cb961597cc30f9d8ece17529f09a8291454827e3":{"kind":"REWORK","_number":2,"created":"2013-10-24 15:20:56.000000000","uploader":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"ref":"refs/changes/72/49872/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/72/49872/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/72/49872/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/72/49872/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/72/49872/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/72/49872/2"}}},"commit":{"parents":[{"commit":"897f48a897f9404a6825275c97ae386f0994c0e6","subject":"Merge \"Add the doc build tools\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/897f48a897f9404a6825275c97ae386f0994c0e6"}]}],"author":{"name":"Adam Spiers","email":"aspiers@suse.com","date":"2013-10-05 11:11:07.000000000","tz":60},"committer":{"name":"Adam Spiers","email":"aspiers@suse.com","date":"2013-10-24 14:43:05.000000000","tz":60},"subject":"Fix shocco errors and warnings","message":"Fix shocco errors and warnings\n\nA few Markdown-oriented issues were causing Docutils errors to\nleak into the end-user docs on http://devstack.org\n\nChange-Id: I51fa9698afb1bfb48596478d83bd1fdcd84ac52e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/cb961597cc30f9d8ece17529f09a8291454827e3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/cb961597cc30f9d8ece17529f09a8291454827e3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}