)]}'
{"lib/neutron_plugins/services/l3":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"326b8f5211ba5a5eadfe06cd706a8c46b5162a7a","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            if [ -z $SUBNETPOOL_V6_ID ]; then"},{"line_number":199,"context_line":"                fixed_range_v6\u003d$IPV6_PROVIDER_FIXED_RANGE"},{"line_number":200,"context_line":"            fi"},{"line_number":201,"context_line":"            IPV6_SUBNET_ID\u003d$(openstack --os-cloud devstack-admin --os-region \"$REGION_NAME\" subnet create --project $project_id --ip-version 6 --gateway $IPV6_PROVIDER_NETWORK_GATEWAY $IPV6_PROVIDER_SUBNET_NAME ${SUBNETPOOL_V6_ID:+--subnet-pool $SUBNETPOOL_V6_ID} --network $NET_ID --subnet-range $fixed_range_v6 | grep \u0027 id \u0027 | get_field 2)"},{"line_number":202,"context_line":"            die_if_not_set $LINENO IPV6_SUBNET_ID \"Failure creating IPV6_SUBNET_ID for $IPV6_PROVIDER_SUBNET_NAME $project_id\""},{"line_number":203,"context_line":"        fi"},{"line_number":204,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ff82abbf_33cfb480","line":201,"updated":"2017-11-20 16:04:13.000000000","message":"I\u0027d suggest you change this in the same way","commit_id":"a24a48a580108100e37d2ae6a5730279853abe40"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"affeb4a15864f92b30ab11ad969d60e5c3ae0ce4","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            if [ -z $SUBNETPOOL_V6_ID ]; then"},{"line_number":199,"context_line":"                fixed_range_v6\u003d$IPV6_PROVIDER_FIXED_RANGE"},{"line_number":200,"context_line":"            fi"},{"line_number":201,"context_line":"            IPV6_SUBNET_ID\u003d$(openstack --os-cloud devstack-admin --os-region \"$REGION_NAME\" subnet create --project $project_id --ip-version 6 --gateway $IPV6_PROVIDER_NETWORK_GATEWAY $IPV6_PROVIDER_SUBNET_NAME ${SUBNETPOOL_V6_ID:+--subnet-pool $SUBNETPOOL_V6_ID} --network $NET_ID --subnet-range $fixed_range_v6 | grep \u0027 id \u0027 | get_field 2)"},{"line_number":202,"context_line":"            die_if_not_set $LINENO IPV6_SUBNET_ID \"Failure creating IPV6_SUBNET_ID for $IPV6_PROVIDER_SUBNET_NAME $project_id\""},{"line_number":203,"context_line":"        fi"},{"line_number":204,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ff82abbf_afa1e1ab","line":201,"in_reply_to":"ff82abbf_33cfb480","updated":"2017-11-22 07:25:31.000000000","message":"Done","commit_id":"a24a48a580108100e37d2ae6a5730279853abe40"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"0464d237e635048901257c88c62ab7e7199371db","unresolved":false,"context_lines":[{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        if [[ \"$IP_VERSION\" \u003d~ 4.* ]]; then"},{"line_number":188,"context_line":"            if [ -z $SUBNETPOOL_V4_ID ]; then"},{"line_number":189,"context_line":"                fixed_range_v4\u003d$FIXED_RANGE"},{"line_number":190,"context_line":"            fi"},{"line_number":191,"context_line":"            SUBNET_ID\u003d$(openstack --os-cloud devstack-admin --os-region \"$REGION_NAME\" subnet create --project $project_id --ip-version 4 ${ALLOCATION_POOL:+--allocation-pool $ALLOCATION_POOL} $PROVIDER_SUBNET_NAME --gateway $NETWORK_GATEWAY ${SUBNETPOOL_V4_ID:+--subnet-pool $SUBNETPOOL_V4_ID} --network $NET_ID ${fixed_range_v4:+--subnet-range $fixed_range_v4} | grep \u0027 id \u0027 | get_field 2)"},{"line_number":192,"context_line":"            die_if_not_set $LINENO SUBNET_ID \"Failure creating SUBNET_ID for $PROVIDER_SUBNET_NAME $project_id\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff82abbf_7d2ca2ab","line":189,"updated":"2017-11-27 00:57:06.000000000","message":"this is blank, so maybe it\u0027s easier to just add the argument here\n\n fixed_range_v4\u003d\"--subnet-range $FIXED_RANGE\"\n\nthen just sub that in unconditionally","commit_id":"c60b4a121e39c3b80fb1e899307a54559e43d8ce"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"06e076d6675fd3d73b1aa93e72df62981bcfc78c","unresolved":false,"context_lines":[{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        if [[ \"$IP_VERSION\" \u003d~ 4.* ]]; then"},{"line_number":188,"context_line":"            if [ -z $SUBNETPOOL_V4_ID ]; then"},{"line_number":189,"context_line":"                fixed_range_v4\u003d$FIXED_RANGE"},{"line_number":190,"context_line":"            fi"},{"line_number":191,"context_line":"            SUBNET_ID\u003d$(openstack --os-cloud devstack-admin --os-region \"$REGION_NAME\" subnet create --project $project_id --ip-version 4 ${ALLOCATION_POOL:+--allocation-pool $ALLOCATION_POOL} $PROVIDER_SUBNET_NAME --gateway $NETWORK_GATEWAY ${SUBNETPOOL_V4_ID:+--subnet-pool $SUBNETPOOL_V4_ID} --network $NET_ID ${fixed_range_v4:+--subnet-range $fixed_range_v4} | grep \u0027 id \u0027 | get_field 2)"},{"line_number":192,"context_line":"            die_if_not_set $LINENO SUBNET_ID \"Failure creating SUBNET_ID for $PROVIDER_SUBNET_NAME $project_id\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff82abbf_bf076982","line":189,"in_reply_to":"ff82abbf_2c010606","updated":"2017-11-27 20:22:41.000000000","message":"ahh sorry, i assumed it was already setup as a \"local\" above (which it probably should be)","commit_id":"c60b4a121e39c3b80fb1e899307a54559e43d8ce"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"336e1c4a613869d9628961c2ef325080a68f52a7","unresolved":false,"context_lines":[{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        if [[ \"$IP_VERSION\" \u003d~ 4.* ]]; then"},{"line_number":188,"context_line":"            if [ -z $SUBNETPOOL_V4_ID ]; then"},{"line_number":189,"context_line":"                fixed_range_v4\u003d$FIXED_RANGE"},{"line_number":190,"context_line":"            fi"},{"line_number":191,"context_line":"            SUBNET_ID\u003d$(openstack --os-cloud devstack-admin --os-region \"$REGION_NAME\" subnet create --project $project_id --ip-version 4 ${ALLOCATION_POOL:+--allocation-pool $ALLOCATION_POOL} $PROVIDER_SUBNET_NAME --gateway $NETWORK_GATEWAY ${SUBNETPOOL_V4_ID:+--subnet-pool $SUBNETPOOL_V4_ID} --network $NET_ID ${fixed_range_v4:+--subnet-range $fixed_range_v4} | grep \u0027 id \u0027 | get_field 2)"},{"line_number":192,"context_line":"            die_if_not_set $LINENO SUBNET_ID \"Failure creating SUBNET_ID for $PROVIDER_SUBNET_NAME $project_id\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff82abbf_2c010606","line":189,"in_reply_to":"ff82abbf_7d2ca2ab","updated":"2017-11-27 05:54:57.000000000","message":"In case USE_SUBNETPOOL is true, the SUBNETPOOL_V4_ID has a value, thus the fixed_range_v4 is not set.\nI believe that the safest way to handle it is to have the conditional statement below, but I am open to learning in case it is not a valid use-case","commit_id":"c60b4a121e39c3b80fb1e899307a54559e43d8ce"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"0464d237e635048901257c88c62ab7e7199371db","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            if [ -z $SUBNETPOOL_V6_ID ]; then"},{"line_number":199,"context_line":"                fixed_range_v6\u003d$IPV6_PROVIDER_FIXED_RANGE"},{"line_number":200,"context_line":"            fi"},{"line_number":201,"context_line":"            IPV6_SUBNET_ID\u003d$(openstack --os-cloud devstack-admin --os-region \"$REGION_NAME\" subnet create --project $project_id --ip-version 6 --gateway $IPV6_PROVIDER_NETWORK_GATEWAY $IPV6_PROVIDER_SUBNET_NAME ${SUBNETPOOL_V6_ID:+--subnet-pool $SUBNETPOOL_V6_ID} --network $NET_ID ${$fixed_range_v6:+--subnet-range $fixed_range_v6} | grep \u0027 id \u0027 | get_field 2)"},{"line_number":202,"context_line":"            die_if_not_set $LINENO IPV6_SUBNET_ID \"Failure creating IPV6_SUBNET_ID for $IPV6_PROVIDER_SUBNET_NAME $project_id\""},{"line_number":203,"context_line":"        fi"},{"line_number":204,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff82abbf_dd236ebc","line":201,"updated":"2017-11-27 00:57:06.000000000","message":"${$ doesn\u0027t look right here","commit_id":"c60b4a121e39c3b80fb1e899307a54559e43d8ce"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"336e1c4a613869d9628961c2ef325080a68f52a7","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            if [ -z $SUBNETPOOL_V6_ID ]; then"},{"line_number":199,"context_line":"                fixed_range_v6\u003d$IPV6_PROVIDER_FIXED_RANGE"},{"line_number":200,"context_line":"            fi"},{"line_number":201,"context_line":"            IPV6_SUBNET_ID\u003d$(openstack --os-cloud devstack-admin --os-region \"$REGION_NAME\" subnet create --project $project_id --ip-version 6 --gateway $IPV6_PROVIDER_NETWORK_GATEWAY $IPV6_PROVIDER_SUBNET_NAME ${SUBNETPOOL_V6_ID:+--subnet-pool $SUBNETPOOL_V6_ID} --network $NET_ID ${$fixed_range_v6:+--subnet-range $fixed_range_v6} | grep \u0027 id \u0027 | get_field 2)"},{"line_number":202,"context_line":"            die_if_not_set $LINENO IPV6_SUBNET_ID \"Failure creating IPV6_SUBNET_ID for $IPV6_PROVIDER_SUBNET_NAME $project_id\""},{"line_number":203,"context_line":"        fi"},{"line_number":204,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff82abbf_91294d9c","line":201,"in_reply_to":"ff82abbf_dd236ebc","updated":"2017-11-27 05:54:57.000000000","message":"You are totally right... Fixed.","commit_id":"c60b4a121e39c3b80fb1e899307a54559e43d8ce"}]}