)]}'
{"id":"openstack%2Fdevstack~50540","triplet_id":"openstack%2Fdevstack~master~Iadab72e926848716085a0ce24cdd43753e9ed396","project":"openstack/devstack","branch":"master","topic":"py26-site","hashtags":[],"change_id":"Iadab72e926848716085a0ce24cdd43753e9ed396","subject":"fixup_stuff python 2.6 and prettytable fix","status":"ABANDONED","created":"2013-10-09 07:08:44.000000000","updated":"2013-10-17 06:01:19.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"05861a3999dea742ef4246ffcd36e12860c2ad26","_number":50540,"virtual_id_number":50540,"owner":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2013-10-09 10:39:23.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2013-10-16 17:55:33.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2013-10-12 05:52:21.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2013-10-11 20:15:55.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2013-10-09 10:01:01.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-10-09 10:39:23.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2013-10-11 20:15:55.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"}],"messages":[{"id":"94302e521d36bc1b237436144679ba7c4373f184","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-09 07:55:50.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- check-tempest-devstack-vm-full http://logs.openstack.org/40/50540/1/check/check-tempest-devstack-vm-full/d74bc61 : SUCCESS in 46m 56s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/40/50540/1/check/check-tempest-devstack-vm-postgres-full/5d75c48 : SUCCESS in 38m 36s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/40/50540/1/check/check-tempest-devstack-vm-neutron/fe71b9d : SUCCESS in 18m 08s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/40/50540/1/check/gate-tempest-devstack-vm-large-ops/2feb1f9 : SUCCESS in 11m 09s\n- check-grenade-devstack-vm http://logs.openstack.org/40/50540/1/check/check-grenade-devstack-vm/6ab16ad : SUCCESS in 23m 35s\n- check-swift-devstack-vm-functional http://logs.openstack.org/40/50540/1/check/check-swift-devstack-vm-functional/51f2b24 : SUCCESS in 14m 12s\n","accounts_in_message":[],"_revision_number":1},{"id":"f5b74ea6919703687655c5ccac4f1ae2dd66db7f","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2013-10-09 09:07:30.000000000","message":"Patch Set 1: Work In Progress","accounts_in_message":[],"_revision_number":1},{"id":"51b1b7df482127883dbbcc06301cc1aab0e824bd","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2013-10-09 10:01:01.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"999b6a1111d3718766727ba694327566ef813d19","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-09 10:39:23.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- check-tempest-devstack-vm-full http://logs.openstack.org/40/50540/2/check/check-tempest-devstack-vm-full/acd57e4 : SUCCESS in 28m 41s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/40/50540/2/check/check-tempest-devstack-vm-postgres-full/ac0bc9b : SUCCESS in 38m 14s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/40/50540/2/check/check-tempest-devstack-vm-neutron/00dc18c : SUCCESS in 17m 38s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/40/50540/2/check/gate-tempest-devstack-vm-large-ops/f8e10d4 : SUCCESS in 10m 55s\n- check-grenade-devstack-vm http://logs.openstack.org/40/50540/2/check/check-grenade-devstack-vm/19ea6ca : SUCCESS in 23m 55s\n- check-swift-devstack-vm-functional http://logs.openstack.org/40/50540/2/check/check-swift-devstack-vm-functional/878193a : SUCCESS in 13m 57s\n","accounts_in_message":[],"_revision_number":2},{"id":"5bfc28ea9a298a6c80c4a93916c9accfea78ac37","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-10-11 20:15:55.000000000","message":"Patch Set 2: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"8ac0a264ec6240f3e9d756d11052e052c283c20d","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2013-10-12 05:52:21.000000000","message":"Patch Set 2:\n\nNow I see three situation:\n - You have an already installed prettytable which does not have this issue (probably it is a distro package).\n\n - If your already installed version is in the expected range prettytable\u003e\u003d0.6,\u003c0.8 , but not 0.7.2 the\n the original code fails without a real reason.\n \n - If your already installed version is out of range (prettytable\u003e\u003d0.6,\u003c0.8) probably you will see an issue.\nThis situation is not covered by this change, and it was an issue before this change as well.\nA possible solution is enforcing the version range here, but it will not be in sync with global requirements in the future.\n\n- pip by default installing the latest 0.7.2 package if you do not have an already installed one, or your already had 0.7.2. In this case both the old and new code working properly. \n\nThe real question is what will happen when the 0.7.x (x\u003e2) released.\nIf \u003e\u003d0.7.2 will have the same issue, it will cause gate failure, as with the original code.\n\nOur options are:\n - Enforcing the installation of v0.7.2:\n    - We will upgrade(or downgrade) package from the accepted range. It is not a necessary operation. We might not update to new version when it is possible.\n - Touch more files permission (every version) even if it is not required.\n    (Probably it was not an issue with the older versions.)\n - We are risking a gate issue if the new version will have the same issue. (This was the situation before and after this change.)\nThis option expects, prettytable will be fixed in the newer version.\n\nWould you like to change the original strategy ? \nWhich one do you prefer  ?","accounts_in_message":[],"_revision_number":2},{"id":"685283d71ac611bb6f726115d895b92cedd16955","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-10-14 15:29:48.000000000","message":"Patch Set 2:\n\nAs you say, if the hypothetical prettytable 0.7.3 has this problem then the gate breaks.  This is intentional as we need to know if that is the case. [see below for more on that.]  This script is meant to address short-term fixes for upstream brokenness.  It performs the package installs so we can fix their brokenness before pip starts resolving the dependencies on our code.  It does assume that we\u0027re going to ignore (or overwrite if you\u0027re on CentOS) a system package that may be present is true, but pip would do that later anyway if the system package does not meet requirements.txt\n\nThe good thing about the permissions fixes is that Donald cleaned this up for us in pip 1.4.2 so once we can assume that pip 1.4 is not being used we can remove them.  And once we know the gate has \u003e\u003d 1.4.2 we can forget about worrying about a broken prettytable 0.7.3 or whatever there.\n\nThe py26 stuff does need to be handled, thanks.","accounts_in_message":[],"_revision_number":2},{"id":"a5f427640fc7a3c6e38d0e417887580c1e81e69f","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-10-16 17:55:33.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nThere have been a number of attempts to fix this problem, none quite right.  I have submitted https://review.openstack.org/#/c/52176/ as a fix.  Please have a look and see if it addresses your issue.","accounts_in_message":[],"_revision_number":2},{"id":"9b5ff7d911fc837dbea3690b626775c04431aeb9","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2013-10-17 06:01:19.000000000","message":"Patch Set 2: Abandoned\n\nthx","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3d93de44de2083d080e24cd6240c711df36509c8","revisions":{"33e12dfde78d130dde140091a9528dbd18527d12":{"kind":"REWORK","_number":1,"created":"2013-10-09 07:08:44.000000000","uploader":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"ref":"refs/changes/40/50540/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/40/50540/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/40/50540/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/40/50540/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/40/50540/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/40/50540/1"}}},"commit":{"parents":[{"commit":"67f7da2de299f4f9ab58718aafce336012035cd8","subject":"Merge \"Use the rdo havana repo with the RHEL family\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/67f7da2de299f4f9ab58718aafce336012035cd8"}]}],"author":{"name":"Attila Fazekas","email":"afazekas@redhat.com","date":"2013-10-09 07:04:59.000000000","tz":120},"committer":{"name":"Attila Fazekas","email":"afazekas@redhat.com","date":"2013-10-09 07:04:59.000000000","tz":120},"subject":"fixup_stuff python 2.6","message":"fixup_stuff python 2.6\n\nSince the \u0027set -o errexit\u0027 added the devstack install fails with python\n2.6 even if the egg permission fixup is not required.\n\nIf the python version is reported using the usually py 2.6 directories\nfor SITE_DIRS.\n\nChange-Id: Iadab72e926848716085a0ce24cdd43753e9ed396\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/33e12dfde78d130dde140091a9528dbd18527d12"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/33e12dfde78d130dde140091a9528dbd18527d12"}]},"branch":"refs/heads/master"},"3d93de44de2083d080e24cd6240c711df36509c8":{"kind":"REWORK","_number":2,"created":"2013-10-09 10:01:01.000000000","uploader":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"ref":"refs/changes/40/50540/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/40/50540/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/40/50540/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/40/50540/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/40/50540/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/40/50540/2"}}},"commit":{"parents":[{"commit":"67f7da2de299f4f9ab58718aafce336012035cd8","subject":"Merge \"Use the rdo havana repo with the RHEL family\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/67f7da2de299f4f9ab58718aafce336012035cd8"}]}],"author":{"name":"Attila Fazekas","email":"afazekas@redhat.com","date":"2013-10-09 07:04:59.000000000","tz":120},"committer":{"name":"Attila Fazekas","email":"afazekas@redhat.com","date":"2013-10-09 10:00:14.000000000","tz":120},"subject":"fixup_stuff python 2.6 and prettytable fix","message":"fixup_stuff python 2.6 and prettytable fix\n\nSince the \u0027set -o errexit\u0027 added the devstack install fails with python\n2.6 even if the egg permission fixup is not required.\n\nIf the python version is reported using the usually py 2.6 directories\nfor SITE_DIRS.\n\n\u0027pip_install prettytable\u0027 does not upgrades the prettytable to the\nlatest 0.7.2 version if the system has an already installed\nprettytable.\n\nMost packages requires prettytable\u003e\u003d0.6,\u003c0.8 so the forced upgrade to\n0.7.2 is not required.\nChanging the condition to only attempt to change the permission,\n when the 0.7.2 files are exists.\n\nChange-Id: Iadab72e926848716085a0ce24cdd43753e9ed396\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/3d93de44de2083d080e24cd6240c711df36509c8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/3d93de44de2083d080e24cd6240c711df36509c8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}