)]}'
{"functions-common":[{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"fc610e67310ab9eef76ea7ff018c55ed23a4480f","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        DISTRO\u003d\"f$os_RELEASE\""},{"line_number":376,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (openSUSE) ]]; then"},{"line_number":377,"context_line":"        DISTRO\u003d\"opensuse-$os_RELEASE\""},{"line_number":378,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (SUSE) ]]; then"},{"line_number":379,"context_line":"        # just use major release"},{"line_number":380,"context_line":"        DISTRO\u003d\"sle${os_RELEASE%.*}\""},{"line_number":381,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (Red.*Hat) || \\"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7f515b1d_40b82b29","line":378,"updated":"2017-09-23 12:12:12.000000000","message":"could be changed to ```\u003d \"SUSE\"``` then as this would otherwise match openSUSE","commit_id":"418aa61acbdf477ff485bb89e64ae8db42bf733f"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"de222fc52091df86c2a12ce4e30eb72c8cf908d2","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        DISTRO\u003d\"f$os_RELEASE\""},{"line_number":376,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (openSUSE) ]]; then"},{"line_number":377,"context_line":"        DISTRO\u003d\"opensuse-$os_RELEASE\""},{"line_number":378,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (SUSE) ]]; then"},{"line_number":379,"context_line":"        # just use major release"},{"line_number":380,"context_line":"        DISTRO\u003d\"sle${os_RELEASE%.*}\""},{"line_number":381,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (Red.*Hat) || \\"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7f515b1d_c987630f","line":378,"in_reply_to":"7f515b1d_40b82b29","updated":"2017-09-26 17:36:11.000000000","message":"yes, except that this is an \"elif\" so theoretically the path should never reach this line if \"openSUSE\" is matched first above. But I\u0027ll test and see if we can use  \u003d \"SUSE\". Although that might break older version of sles.","commit_id":"418aa61acbdf477ff485bb89e64ae8db42bf733f"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"fc610e67310ab9eef76ea7ff018c55ed23a4480f","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        GetOSVersion"},{"line_number":456,"context_line":"    fi"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    [[ \"$os_VENDOR\" \u003d~ (openSUSE) || \"$os_VENDOR\" \u003d~ (\"SUSE\") ]]"},{"line_number":459,"context_line":"}"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7f515b1d_0084735d","line":458,"updated":"2017-09-23 12:12:12.000000000","message":"Same here, otherwise the || openSUSE check is redundant. I would prefer to be explicit here.","commit_id":"418aa61acbdf477ff485bb89e64ae8db42bf733f"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"de222fc52091df86c2a12ce4e30eb72c8cf908d2","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        GetOSVersion"},{"line_number":456,"context_line":"    fi"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    [[ \"$os_VENDOR\" \u003d~ (openSUSE) || \"$os_VENDOR\" \u003d~ (\"SUSE\") ]]"},{"line_number":459,"context_line":"}"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7f515b1d_09e1fbd0","line":458,"in_reply_to":"7f515b1d_0084735d","updated":"2017-09-26 17:36:11.000000000","message":"I think we can change this to\n$os_VENDOR \u003d~ (SUSE) as the function\u0027s purpose is to check if it is a SUSE-based distro. (includes opensuse, SLES, etc..)\nso basically anything that has \"SUSE\" in the release name.","commit_id":"418aa61acbdf477ff485bb89e64ae8db42bf733f"}],"lib/databases/mysql":[{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"7f0319684d28479f23a37b26a9af2e3875abf19b","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    # because the package might have been installed already."},{"line_number":91,"context_line":"    sudo mysqladmin -u root password $DATABASE_PASSWORD || true"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    #mysql-community-server on SUSE SLES distros installs with pregenrated"},{"line_number":94,"context_line":"    # password for superuser account. It is stored in /var/log/mysql/mysqld.log"},{"line_number":95,"context_line":"    # we need to find it and use to set the correct password"},{"line_number":96,"context_line":"        if is_suse; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bf57530f_c8658fe3","line":93,"updated":"2017-09-19 22:43:21.000000000","message":"# mysql-community-server","commit_id":"bd9c398c51ec7f8832dcc5120ff56fb4f7735bda"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"fc610e67310ab9eef76ea7ff018c55ed23a4480f","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    # because the package might have been installed already."},{"line_number":91,"context_line":"    sudo mysqladmin -u root password $DATABASE_PASSWORD || true"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    # mysql-community-server on SUSE SLES distros installs with pregenrated"},{"line_number":94,"context_line":"    # password for superuser account. It is stored in /var/log/mysql/mysqld.log"},{"line_number":95,"context_line":"    # we need to find it and use to set the correct password"},{"line_number":96,"context_line":"        if is_suse; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7f515b1d_e09f17b2","line":93,"updated":"2017-09-23 12:12:12.000000000","message":"typ: pregenerated\n\nAlso, SLES ships with mariadb, calling that one mysql-community-server sounds confusing at least to me.","commit_id":"418aa61acbdf477ff485bb89e64ae8db42bf733f"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"de222fc52091df86c2a12ce4e30eb72c8cf908d2","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    # because the package might have been installed already."},{"line_number":91,"context_line":"    sudo mysqladmin -u root password $DATABASE_PASSWORD || true"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    # mysql-community-server on SUSE SLES distros installs with pregenrated"},{"line_number":94,"context_line":"    # password for superuser account. It is stored in /var/log/mysql/mysqld.log"},{"line_number":95,"context_line":"    # we need to find it and use to set the correct password"},{"line_number":96,"context_line":"        if is_suse; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7f515b1d_a96d4733","line":93,"in_reply_to":"7f515b1d_e09f17b2","updated":"2017-09-26 17:36:11.000000000","message":"actually we do mean mysql-community-server.  currently devstack dploys mysql-community-server as the mysql backend for suse based distros (see the installation of the package a few lines above. ~ line 172). I agree that it would be best to use mariadb if it is sles. \nLet me investigate how many lines need to be changed to support mariadb. If it is too many I\u0027ll push it as a follow up patch.","commit_id":"418aa61acbdf477ff485bb89e64ae8db42bf733f"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"fc610e67310ab9eef76ea7ff018c55ed23a4480f","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    # mysql-community-server on SUSE SLES distros installs with pregenrated"},{"line_number":94,"context_line":"    # password for superuser account. It is stored in /var/log/mysql/mysqld.log"},{"line_number":95,"context_line":"    # we need to find it and use to set the correct password"},{"line_number":96,"context_line":"        if is_suse; then"},{"line_number":97,"context_line":"            TEMP_PASSWORD\u003d$(sudo grep \u0027temporary password\u0027 /var/log/mysql/mysqld.log | awk \u0027{print $NF}\u0027) || true"},{"line_number":98,"context_line":"            #we need to reset the password because its expired"},{"line_number":99,"context_line":"            sudo mysql -uroot -p$TEMP_PASSWORD --connect-expired-password -e \"SET PASSWORD  \u003d PASSWORD(\u0027$TEMP_PASSWORD\u0027);\" || true"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7f515b1d_a0a91fe0","line":96,"updated":"2017-09-23 12:12:12.000000000","message":"incorrect indentation? also do you want to check whether this is actually SLES ?","commit_id":"418aa61acbdf477ff485bb89e64ae8db42bf733f"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"de222fc52091df86c2a12ce4e30eb72c8cf908d2","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    # mysql-community-server on SUSE SLES distros installs with pregenrated"},{"line_number":94,"context_line":"    # password for superuser account. It is stored in /var/log/mysql/mysqld.log"},{"line_number":95,"context_line":"    # we need to find it and use to set the correct password"},{"line_number":96,"context_line":"        if is_suse; then"},{"line_number":97,"context_line":"            TEMP_PASSWORD\u003d$(sudo grep \u0027temporary password\u0027 /var/log/mysql/mysqld.log | awk \u0027{print $NF}\u0027) || true"},{"line_number":98,"context_line":"            #we need to reset the password because its expired"},{"line_number":99,"context_line":"            sudo mysql -uroot -p$TEMP_PASSWORD --connect-expired-password -e \"SET PASSWORD  \u003d PASSWORD(\u0027$TEMP_PASSWORD\u0027);\" || true"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7f515b1d_e99fbf00","line":96,"in_reply_to":"7f515b1d_a0a91fe0","updated":"2017-09-26 17:36:11.000000000","message":"Thanks. Yes this section is what is braking every other suse distro. We need to either check sles, or mor generically simply skip if there is no TEMP_PASSWORD in /var/log/mysql/mysqld.log\nThe generic purpose of this section is to get past the scenario where a TEMP_PASSWORD has been defined in myslq by default during installation. so it is meant to actually cover more than just sles.. I know its splitting hairs but I think we should keep this patch generic and follow up with a more specific patch for sles. \n\nI should remove the reference to SLES in the comment!","commit_id":"418aa61acbdf477ff485bb89e64ae8db42bf733f"},{"author":{"_account_id":15736,"name":"Ritesh Anand","email":"tellrit@gmail.com","username":"ritesh"},"change_message_id":"94c18d979569359371017f312f6ea80dec44bb0a","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    # In some SUSE distros, mysql-community-server  installs with pregenerated"},{"line_number":94,"context_line":"    # password for superuser account. It is stored in /var/log/mysql/mysqld.log"},{"line_number":95,"context_line":"    # we need to find it and use to set the correct password"},{"line_number":96,"context_line":"        if is_suse; then"},{"line_number":97,"context_line":"            TEMP_PASSWORD\u003d$(sudo grep \u0027temporary password\u0027 /var/log/mysql/mysqld.log | awk \u0027{print $NF}\u0027) || true"},{"line_number":98,"context_line":"            if [ $TEMP_PASSWORD ]; then"},{"line_number":99,"context_line":"                #we need to reset the password because its expired"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7f515b1d_6f798f2d","line":96,"updated":"2017-09-26 18:13:06.000000000","message":"This can be aligned with the comments; i.e. remove spaces before if block.","commit_id":"bb169e936f19e9540714c47e27aaed7da2770212"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"92433de7c6d28a857da599205cf7411033be4f94","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    # In some SUSE distros, mysql-community-server  installs with pregenerated"},{"line_number":94,"context_line":"    # password for superuser account. It is stored in /var/log/mysql/mysqld.log"},{"line_number":95,"context_line":"    # we need to find it and use to set the correct password"},{"line_number":96,"context_line":"        if is_suse; then"},{"line_number":97,"context_line":"            TEMP_PASSWORD\u003d$(sudo grep \u0027temporary password\u0027 /var/log/mysql/mysqld.log | awk \u0027{print $NF}\u0027) || true"},{"line_number":98,"context_line":"            if [ $TEMP_PASSWORD ]; then"},{"line_number":99,"context_line":"                #we need to reset the password because its expired"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7f515b1d_d4fc4fb6","line":96,"in_reply_to":"7f515b1d_6f798f2d","updated":"2017-09-28 22:15:51.000000000","message":"Done","commit_id":"bb169e936f19e9540714c47e27aaed7da2770212"},{"author":{"_account_id":15736,"name":"Ritesh Anand","email":"tellrit@gmail.com","username":"ritesh"},"change_message_id":"e9bfd9fd471eb5d1862b849d9ae63a7e7ed5467c","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    # password for superuser account. It is stored in /var/log/mysql/mysqld.log"},{"line_number":95,"context_line":"    # we need to find it and use to set the correct password"},{"line_number":96,"context_line":"        if is_suse; then"},{"line_number":97,"context_line":"            TEMP_PASSWORD\u003d$(sudo grep \u0027temporary password\u0027 /var/log/mysql/mysqld.log | awk \u0027{print $NF}\u0027) || true"},{"line_number":98,"context_line":"            if [ $TEMP_PASSWORD ]; then"},{"line_number":99,"context_line":"                #we need to reset the password because its expired"},{"line_number":100,"context_line":"                sudo mysql -uroot -p$TEMP_PASSWORD --connect-expired-password -e \"SET PASSWORD  \u003d PASSWORD(\u0027$TEMP_PASSWORD\u0027);\" || true"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7f515b1d_6af4dacf","line":97,"updated":"2017-09-26 20:04:04.000000000","message":"In case if there are more than one \u0027temporary password\u0027, we would need to get the last one; may be add  \u0027| tail -1\u0027 after awk. I wonder if \u0027|| true\u0027 makes it always true and hence negate the need for next if statement.","commit_id":"bb169e936f19e9540714c47e27aaed7da2770212"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"92433de7c6d28a857da599205cf7411033be4f94","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    # password for superuser account. It is stored in /var/log/mysql/mysqld.log"},{"line_number":95,"context_line":"    # we need to find it and use to set the correct password"},{"line_number":96,"context_line":"        if is_suse; then"},{"line_number":97,"context_line":"            TEMP_PASSWORD\u003d$(sudo grep \u0027temporary password\u0027 /var/log/mysql/mysqld.log | awk \u0027{print $NF}\u0027) || true"},{"line_number":98,"context_line":"            if [ $TEMP_PASSWORD ]; then"},{"line_number":99,"context_line":"                #we need to reset the password because its expired"},{"line_number":100,"context_line":"                sudo mysql -uroot -p$TEMP_PASSWORD --connect-expired-password -e \"SET PASSWORD  \u003d PASSWORD(\u0027$TEMP_PASSWORD\u0027);\" || true"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7f515b1d_b490b344","line":97,"in_reply_to":"7f515b1d_6af4dacf","updated":"2017-09-28 22:15:51.000000000","message":"good point to about the possible more than one temp password. \nAlthough, once it is done once, you can\u0027t really reinstall mysql. but I think adding the tail command might be a good idea. \n\nI believe the || true is meant to prevent the script from aborting if commands fail.  TEMP_PASSWORD will still be either null or a value, if it is null the next if does not execute, if it is wrong password (because it was already change) the commands below should fail silently. i.e. fail on the log but the script should not stop. Samething as above in line 91\n\ndone","commit_id":"bb169e936f19e9540714c47e27aaed7da2770212"},{"author":{"_account_id":15736,"name":"Ritesh Anand","email":"tellrit@gmail.com","username":"ritesh"},"change_message_id":"e9bfd9fd471eb5d1862b849d9ae63a7e7ed5467c","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    # we need to find it and use to set the correct password"},{"line_number":96,"context_line":"        if is_suse; then"},{"line_number":97,"context_line":"            TEMP_PASSWORD\u003d$(sudo grep \u0027temporary password\u0027 /var/log/mysql/mysqld.log | awk \u0027{print $NF}\u0027) || true"},{"line_number":98,"context_line":"            if [ $TEMP_PASSWORD ]; then"},{"line_number":99,"context_line":"                #we need to reset the password because its expired"},{"line_number":100,"context_line":"                sudo mysql -uroot -p$TEMP_PASSWORD --connect-expired-password -e \"SET PASSWORD  \u003d PASSWORD(\u0027$TEMP_PASSWORD\u0027);\" || true"},{"line_number":101,"context_line":"                # remove the password validation plugin (or we have to use complex passwords)"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7f515b1d_e72ec3f8","line":98,"updated":"2017-09-26 20:04:04.000000000","message":"This needs one more [], like \"if [[ $T ]]; then\".","commit_id":"bb169e936f19e9540714c47e27aaed7da2770212"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"92433de7c6d28a857da599205cf7411033be4f94","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    # we need to find it and use to set the correct password"},{"line_number":96,"context_line":"        if is_suse; then"},{"line_number":97,"context_line":"            TEMP_PASSWORD\u003d$(sudo grep \u0027temporary password\u0027 /var/log/mysql/mysqld.log | awk \u0027{print $NF}\u0027) || true"},{"line_number":98,"context_line":"            if [ $TEMP_PASSWORD ]; then"},{"line_number":99,"context_line":"                #we need to reset the password because its expired"},{"line_number":100,"context_line":"                sudo mysql -uroot -p$TEMP_PASSWORD --connect-expired-password -e \"SET PASSWORD  \u003d PASSWORD(\u0027$TEMP_PASSWORD\u0027);\" || true"},{"line_number":101,"context_line":"                # remove the password validation plugin (or we have to use complex passwords)"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7f515b1d_74a8fb8a","line":98,"in_reply_to":"7f515b1d_e72ec3f8","updated":"2017-09-28 22:15:51.000000000","message":"Done","commit_id":"bb169e936f19e9540714c47e27aaed7da2770212"},{"author":{"_account_id":15736,"name":"Ritesh Anand","email":"tellrit@gmail.com","username":"ritesh"},"change_message_id":"982287ccaace2fce480e48f59c05c99175bdf340","unresolved":false,"context_lines":[{"line_number":187,"context_line":"    if [[ \"$MYSQL_DRIVER\" \u003d\u003d \"MySQL-python\" ]]; then"},{"line_number":188,"context_line":"        ADDITIONAL_VENV_PACKAGES+\u003d\",MySQL-python\""},{"line_number":189,"context_line":"    elif [[ \"$MYSQL_DRIVER\" \u003d\u003d \"PyMySQL\" ]]; then"},{"line_number":190,"context_line":"    elif [[ \"$MYSQL_DRIVER\" \u003d\u003d \"PyMySQL\" ]]; then"},{"line_number":191,"context_line":"        ADDITIONAL_VENV_PACKAGES+\u003d\",PyMySQL\""},{"line_number":192,"context_line":"    fi"},{"line_number":193,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7f515b1d_0fd45b1f","line":190,"updated":"2017-09-26 18:07:50.000000000","message":"Looks like this line sneaked in? Duplicate.","commit_id":"bb169e936f19e9540714c47e27aaed7da2770212"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"92433de7c6d28a857da599205cf7411033be4f94","unresolved":false,"context_lines":[{"line_number":187,"context_line":"    if [[ \"$MYSQL_DRIVER\" \u003d\u003d \"MySQL-python\" ]]; then"},{"line_number":188,"context_line":"        ADDITIONAL_VENV_PACKAGES+\u003d\",MySQL-python\""},{"line_number":189,"context_line":"    elif [[ \"$MYSQL_DRIVER\" \u003d\u003d \"PyMySQL\" ]]; then"},{"line_number":190,"context_line":"    elif [[ \"$MYSQL_DRIVER\" \u003d\u003d \"PyMySQL\" ]]; then"},{"line_number":191,"context_line":"        ADDITIONAL_VENV_PACKAGES+\u003d\",PyMySQL\""},{"line_number":192,"context_line":"    fi"},{"line_number":193,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7f515b1d_f49bcb6f","line":190,"in_reply_to":"7f515b1d_0fd45b1f","updated":"2017-09-28 22:15:51.000000000","message":"yikes\ndone","commit_id":"bb169e936f19e9540714c47e27aaed7da2770212"}]}