)]}'
{"id":"openstack%2Fdevstack~50684","triplet_id":"openstack%2Fdevstack~master~I4da676971e9c311cdb3af0757168fa806a3d69d5","project":"openstack/devstack","branch":"master","topic":"bug/1237461","hashtags":[],"change_id":"I4da676971e9c311cdb3af0757168fa806a3d69d5","subject":"xenapi: Set networking defaults","status":"ABANDONED","created":"2013-10-09 15:56:16.000000000","updated":"2013-10-14 08:15:49.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"529d2b210883239f7fef046057ae07ba49fc1b7f","_number":50684,"virtual_id_number":50684,"owner":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2013-10-09 16:39:51.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-10-09 17:25:00.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},{"value":-1,"date":"2013-10-09 17:17:28.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-10-09 16:09:05.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},{"date":"2013-10-09 17:17:28.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-10-09 16:39:51.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2013-10-09 17:17:28.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"}],"messages":[{"id":"610851da67b6a3d555539ae4619fcda1e419942c","author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"date":"2013-10-09 16:01:40.000000000","message":"Patch Set 1: Work In Progress\n\nThe approach does not seem to work.","accounts_in_message":[],"_revision_number":1},{"id":"8752f9171d15938cd68a7abe26403ac6dc37b546","author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"date":"2013-10-09 16:09:05.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"259788f77a1f1ffc8c44c12576700cb3dcc25004","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-09 16:39:51.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- check-tempest-devstack-vm-full http://logs.openstack.org/84/50684/2/check/check-tempest-devstack-vm-full/65f1c1e : SUCCESS in 30m 15s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/84/50684/2/check/check-tempest-devstack-vm-postgres-full/d3f6aa2 : SUCCESS in 30m 32s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/84/50684/2/check/check-tempest-devstack-vm-neutron/2078141 : SUCCESS in 20m 01s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/84/50684/2/check/gate-tempest-devstack-vm-large-ops/30d5b2f : SUCCESS in 11m 22s\n- check-grenade-devstack-vm http://logs.openstack.org/84/50684/2/check/check-grenade-devstack-vm/98bc57d : SUCCESS in 23m 55s\n- check-swift-devstack-vm-functional http://logs.openstack.org/84/50684/2/check/check-swift-devstack-vm-functional/a0e9818 : SUCCESS in 12m 35s\n","accounts_in_message":[],"_revision_number":2},{"id":"7b301191186fd0bfd842e1ca7c7597312109e801","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-10-09 17:17:28.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nPart of the point of the hypervisor-* refactor was to remove this stuff from lib/nova.  It looks like the reap problem is the order that the defaults are assigned.\n\nAs I look at it again, I think the correct fix is to move the code that sources the hypervisor-$VIRT_DRIVER files from stack.sh into lib/nova ahead of the defaults there.","accounts_in_message":[],"_revision_number":2},{"id":"1f4fd83353da93f547e256198e2947e63abcb778","author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"date":"2013-10-09 17:25:00.000000000","message":"Patch Set 2:\n\n@Dean - if you are including the plugins before nova, that won\u0027t work - that was my first patch. They will be overridden by the else branch of the if [ \"$VIRT_DRIVER\" \u003d \u0027baremetal\u0027 ]; expression.\n\nWhat do you think about extending the plugins, so we have another hook, that we could call to provide defaults for other nova components?","accounts_in_message":[],"_revision_number":2},{"id":"f105253db43dc0623ff39c7b9f2af1f9201a99f8","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-10-09 18:02:53.000000000","message":"Patch Set 2:\n\nI like not having the defaults inside functions, that way they\u0027re just there.  \n\nI\u0027m going to do this with the baremetal and default libvirt drivers too, what if I just do them all together now?  I think the concept has worked out well enough to trust it.","accounts_in_message":[],"_revision_number":2},{"id":"7d7e6e7873541568ae8c1b3b7d06c5072d624812","author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"date":"2013-10-09 19:32:36.000000000","message":"Patch Set 2:\n\n@Dean: Yes, sure, that makes sense, if each hypervisor used the plugin approach, we just needed to put the plugin sourcing in front of the nova lib sourcing, and we\u0027re done.","accounts_in_message":[],"_revision_number":2},{"id":"3379bbf6bafbcded64a7a9ba7a47b8a2b49c2a19","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-10-09 20:51:45.000000000","message":"Patch Set 2:\n\nOK, give this a look: https://review.openstack.org/#/c/50748/","accounts_in_message":[],"_revision_number":2},{"id":"8ead4484d7531a174d74209580e64519861e3a7d","author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"date":"2013-10-14 08:15:48.000000000","message":"Patch Set 2: Abandoned\n\nWe should go for Dean\u0027s patch instead of my workaround.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f9deade57b4f2eb472c906f2556af987aa416988","revisions":{"72a6e1f89f1835a244d28a0671ba191b2cfee859":{"kind":"REWORK","_number":1,"created":"2013-10-09 15:56:16.000000000","uploader":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"ref":"refs/changes/84/50684/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/84/50684/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/84/50684/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/84/50684/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/84/50684/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/84/50684/1"}}},"commit":{"parents":[{"commit":"67f7da2de299f4f9ab58718aafce336012035cd8","subject":"Merge \"Use the rdo havana repo with the RHEL family\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/67f7da2de299f4f9ab58718aafce336012035cd8"}]}],"author":{"name":"Mate Lakat","email":"mate.lakat@citrix.com","date":"2013-10-09 15:48:51.000000000","tz":60},"committer":{"name":"Mate Lakat","email":"mate.lakat@citrix.com","date":"2013-10-09 15:48:51.000000000","tz":60},"subject":"Include plugins before nova lib","message":"Include plugins before nova lib\n\nSome plugins (the XenServer) contains default values, consumed by nova.\nIn order for these defaults to take effect, the hypervisor plugin needs\nto be sourced, so the defined variables are available for the high-level\nnova library.\n\nFixes bug 1237461\n\nChange-Id: I4da676971e9c311cdb3af0757168fa806a3d69d5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/72a6e1f89f1835a244d28a0671ba191b2cfee859"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/72a6e1f89f1835a244d28a0671ba191b2cfee859"}]},"branch":"refs/heads/master"},"f9deade57b4f2eb472c906f2556af987aa416988":{"kind":"REWORK","_number":2,"created":"2013-10-09 16:09:05.000000000","uploader":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"ref":"refs/changes/84/50684/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/84/50684/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/84/50684/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/84/50684/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/84/50684/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/84/50684/2"}}},"commit":{"parents":[{"commit":"67f7da2de299f4f9ab58718aafce336012035cd8","subject":"Merge \"Use the rdo havana repo with the RHEL family\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/67f7da2de299f4f9ab58718aafce336012035cd8"}]}],"author":{"name":"Mate Lakat","email":"mate.lakat@citrix.com","date":"2013-10-09 15:48:51.000000000","tz":60},"committer":{"name":"Mate Lakat","email":"mate.lakat@citrix.com","date":"2013-10-09 16:02:39.000000000","tz":60},"subject":"xenapi: Set networking defaults","message":"xenapi: Set networking defaults\n\nAs XenServer runs devstack in a domU, special network interface defaults\nneed to be specified. This change moves the default network interface\nsettings from the driver to the nova library.\n\nFixes bug 1237461\n\nChange-Id: I4da676971e9c311cdb3af0757168fa806a3d69d5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/f9deade57b4f2eb472c906f2556af987aa416988"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/f9deade57b4f2eb472c906f2556af987aa416988"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}