)]}'
{"lib/neutron_plugins/ml2":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"bd8185b285ddfcc18c5f77da4c9b04308eef6989","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        populate_ml2_config /$Q_PLUGIN_CONF_FILE agent enable_distributed_routing\u003dTrue"},{"line_number":150,"context_line":"        # arp_reponder should be enabled by default for DVR. But because of"},{"line_number":151,"context_line":"        # https://bugs.launchpad.net/neutron/+bug/1661717 disabled for linuxbridge agent"},{"line_number":152,"context_line":"        if [[ \"$Q_AGENT\" \u003d \"openvswitch\" ]]; then"},{"line_number":153,"context_line":"            populate_ml2_config /$Q_PLUGIN_CONF_FILE agent arp_responder\u003dTrue"},{"line_number":154,"context_line":"        fi"},{"line_number":155,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7f515b1d_dfe523de","line":152,"range":{"start_line":152,"start_character":25,"end_line":152,"end_character":26},"updated":"2017-10-04 18:02:00.000000000","message":"s/\u003d\u003d right?  although maybe bash allows both since it\u0027s both ways in this file :-/\n\nAlso, since DVR is only supported with the openvswitch agent this check probably isn\u0027t necessary, although I don\u0027t see other code that checks this and fails early.","commit_id":"f5e12bfa6a0f16f462fc864324a728d6a7710301"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"11d3b80abd2b5a01c562886720bf136f6dd48430","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        populate_ml2_config /$Q_PLUGIN_CONF_FILE agent enable_distributed_routing\u003dTrue"},{"line_number":150,"context_line":"        # arp_reponder should be enabled by default for DVR. But because of"},{"line_number":151,"context_line":"        # https://bugs.launchpad.net/neutron/+bug/1661717 disabled for linuxbridge agent"},{"line_number":152,"context_line":"        if [[ \"$Q_AGENT\" \u003d \"openvswitch\" ]]; then"},{"line_number":153,"context_line":"            populate_ml2_config /$Q_PLUGIN_CONF_FILE agent arp_responder\u003dTrue"},{"line_number":154,"context_line":"        fi"},{"line_number":155,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7f515b1d_516fe791","line":152,"range":{"start_line":152,"start_character":25,"end_line":152,"end_character":26},"in_reply_to":"7f515b1d_dfe523de","updated":"2017-10-04 18:18:44.000000000","message":"Thanks Brian. I was not knowing that. Then this \"if\" is not needed.","commit_id":"f5e12bfa6a0f16f462fc864324a728d6a7710301"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"570f8c1134c7c976a4757c85d7558a12b94e52b5","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        populate_ml2_config /$Q_PLUGIN_CONF_FILE agent l2_population\u003dTrue"},{"line_number":148,"context_line":"        populate_ml2_config /$Q_PLUGIN_CONF_FILE agent tunnel_types\u003dvxlan"},{"line_number":149,"context_line":"        populate_ml2_config /$Q_PLUGIN_CONF_FILE agent enable_distributed_routing\u003dTrue"},{"line_number":150,"context_line":"        populate_ml2_config /$Q_PLUGIN_CONF_FILE agent arp_responder\u003dTrue"},{"line_number":151,"context_line":"    fi"},{"line_number":152,"context_line":"}"},{"line_number":153,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7f515b1d_e238183c","line":150,"updated":"2017-10-05 18:53:39.000000000","message":"if it should be enabled whenever dvr is on, can\u0027t we make the agent itself to always enable it whenever enable_distributed_routing is True? If possible, I would like us to reduce the number of knobs that one needs to set to configure a dvr setup properly.","commit_id":"de32c5daefe39a8dc38dd264527b6043f4550369"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"64d2627ca31ff19d5b34164d55f2c1c9621a4712","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        populate_ml2_config /$Q_PLUGIN_CONF_FILE agent l2_population\u003dTrue"},{"line_number":148,"context_line":"        populate_ml2_config /$Q_PLUGIN_CONF_FILE agent tunnel_types\u003dvxlan"},{"line_number":149,"context_line":"        populate_ml2_config /$Q_PLUGIN_CONF_FILE agent enable_distributed_routing\u003dTrue"},{"line_number":150,"context_line":"        populate_ml2_config /$Q_PLUGIN_CONF_FILE agent arp_responder\u003dTrue"},{"line_number":151,"context_line":"    fi"},{"line_number":152,"context_line":"}"},{"line_number":153,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7f515b1d_025fb441","line":150,"in_reply_to":"7f515b1d_02033444","updated":"2017-10-05 18:59:28.000000000","message":"No, in neutron code. If we believe without that the agent is broken, we should always enable it.","commit_id":"de32c5daefe39a8dc38dd264527b6043f4550369"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c7acb65ca784f24a30fcf513ed97ebc6ff5c0e9e","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        populate_ml2_config /$Q_PLUGIN_CONF_FILE agent l2_population\u003dTrue"},{"line_number":148,"context_line":"        populate_ml2_config /$Q_PLUGIN_CONF_FILE agent tunnel_types\u003dvxlan"},{"line_number":149,"context_line":"        populate_ml2_config /$Q_PLUGIN_CONF_FILE agent enable_distributed_routing\u003dTrue"},{"line_number":150,"context_line":"        populate_ml2_config /$Q_PLUGIN_CONF_FILE agent arp_responder\u003dTrue"},{"line_number":151,"context_line":"    fi"},{"line_number":152,"context_line":"}"},{"line_number":153,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7f515b1d_5863511b","line":150,"in_reply_to":"7f515b1d_025fb441","updated":"2017-10-06 08:34:35.000000000","message":"That makes sense, historically I think we introduced this option just because we were gating on ubuntu trusty which had ovs 2.0.x and arp responder didn\u0027t work there.","commit_id":"de32c5daefe39a8dc38dd264527b6043f4550369"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"9ed7d5ebc3ac8ddee20c69c8d12077c9851166c1","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        populate_ml2_config /$Q_PLUGIN_CONF_FILE agent l2_population\u003dTrue"},{"line_number":148,"context_line":"        populate_ml2_config /$Q_PLUGIN_CONF_FILE agent tunnel_types\u003dvxlan"},{"line_number":149,"context_line":"        populate_ml2_config /$Q_PLUGIN_CONF_FILE agent enable_distributed_routing\u003dTrue"},{"line_number":150,"context_line":"        populate_ml2_config /$Q_PLUGIN_CONF_FILE agent arp_responder\u003dTrue"},{"line_number":151,"context_line":"    fi"},{"line_number":152,"context_line":"}"},{"line_number":153,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7f515b1d_f940bc09","line":150,"in_reply_to":"7f515b1d_5863511b","updated":"2017-10-06 12:29:19.000000000","message":"Thanks Kuba and Ihar, I will try to enable in it in ovs agent by default for DVR.","commit_id":"de32c5daefe39a8dc38dd264527b6043f4550369"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"05471f615e4e7905df05946059721e9b5e0aea18","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        populate_ml2_config /$Q_PLUGIN_CONF_FILE agent l2_population\u003dTrue"},{"line_number":148,"context_line":"        populate_ml2_config /$Q_PLUGIN_CONF_FILE agent tunnel_types\u003dvxlan"},{"line_number":149,"context_line":"        populate_ml2_config /$Q_PLUGIN_CONF_FILE agent enable_distributed_routing\u003dTrue"},{"line_number":150,"context_line":"        populate_ml2_config /$Q_PLUGIN_CONF_FILE agent arp_responder\u003dTrue"},{"line_number":151,"context_line":"    fi"},{"line_number":152,"context_line":"}"},{"line_number":153,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7f515b1d_02033444","line":150,"in_reply_to":"7f515b1d_e238183c","updated":"2017-10-05 18:57:19.000000000","message":"So are you suggesting that we make this change in the devstack lib/neutron or lib/neutron-legacy configuration.","commit_id":"de32c5daefe39a8dc38dd264527b6043f4550369"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"3d3aee55c218623c2662f7b8b1e26ec55c1ae019","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        populate_ml2_config /$Q_PLUGIN_CONF_FILE agent l2_population\u003dTrue"},{"line_number":148,"context_line":"        populate_ml2_config /$Q_PLUGIN_CONF_FILE agent tunnel_types\u003dvxlan"},{"line_number":149,"context_line":"        populate_ml2_config /$Q_PLUGIN_CONF_FILE agent enable_distributed_routing\u003dTrue"},{"line_number":150,"context_line":"        populate_ml2_config /$Q_PLUGIN_CONF_FILE agent arp_responder\u003dTrue"},{"line_number":151,"context_line":"    fi"},{"line_number":152,"context_line":"}"},{"line_number":153,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7f515b1d_79accc8b","line":150,"in_reply_to":"7f515b1d_f940bc09","updated":"2017-10-06 12:38:06.000000000","message":"I submitted patch for enablinf arp_responder in agent https://review.openstack.org/#/c/510090/","commit_id":"de32c5daefe39a8dc38dd264527b6043f4550369"}]}