)]}'
{"id":"openstack%2Fdevstack~51209","triplet_id":"openstack%2Fdevstack~master~Ib3cc77686b72311403ccacbd70ae9cf43e6eb4c9","project":"openstack/devstack","branch":"master","topic":"bug/1238595","hashtags":[],"change_id":"Ib3cc77686b72311403ccacbd70ae9cf43e6eb4c9","subject":"baremetal: Allow BM_SECOND_MAC to be unset","status":"MERGED","created":"2013-10-11 13:02:46.000000000","updated":"2013-10-18 04:54:37.000000000","submitted":"2013-10-18 04:54:37.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"708516209f14068db3745ed32e276987d559f35d","_number":51209,"virtual_id_number":51209,"owner":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-10-18 04:54:37.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-10-18 04:15:33.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},{"value":2,"date":"2013-10-14 14:57:52.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-10-18 04:15:33.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2013-10-11 13:34:26.000000000","_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},{"value":0,"date":"2013-10-14 14:57:52.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-10-14 14:57:52.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-10-18 04:15:33.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2013-10-18 04:54:37.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"eb89c286554490bdb3a231eb8957ec974b4b79d2","author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"date":"2013-10-11 13:34:26.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"71ff3a35ceaae1e931649a9606445006996ac86f","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-10-11 13:34:33.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":2},{"id":"7613acb612d62cdc7352d6d15c0fb829efeab26b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-11 16:42:01.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- check-tempest-devstack-vm-full http://logs.openstack.org/09/51209/2/check/check-tempest-devstack-vm-full/5dea0b7 : SUCCESS in 42m 56s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/09/51209/2/check/check-tempest-devstack-vm-postgres-full/bd771bd : SUCCESS in 44m 05s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/09/51209/2/check/check-tempest-devstack-vm-neutron/2cd4f52 : SUCCESS in 24m 01s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/09/51209/2/check/gate-tempest-devstack-vm-large-ops/5270716 : SUCCESS in 40m 18s\n- check-grenade-devstack-vm http://logs.openstack.org/09/51209/2/check/check-grenade-devstack-vm/0834718 : SUCCESS in 33m 51s\n- check-swift-devstack-vm-functional http://logs.openstack.org/09/51209/2/check/check-swift-devstack-vm-functional/f346cb1 : SUCCESS in 13m 06s\n","accounts_in_message":[],"_revision_number":2},{"id":"7fc73361aff68d9197310d053593b280b5eebd3b","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-10-14 14:57:52.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"d90756f7a8b1d1d48157a6b4fd268f2e5e81e5ef","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-18 04:15:33.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"56374a1cdc20f564c0b532ed2d0a05b3282edf93","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-10-18 04:15:33.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"7479ee5e419c3f3db192b49a91c0541215fe5f55","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-18 04:54:37.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"bc33daf13c5d78bca89a0b2f6d9d5ad4b3c78cd8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-18 04:54:37.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- gate-tempest-devstack-vm-full http://logs.openstack.org/09/51209/2/gate/gate-tempest-devstack-vm-full/0e04579 : SUCCESS in 38m 57s\n- gate-tempest-devstack-vm-postgres-full http://logs.openstack.org/09/51209/2/gate/gate-tempest-devstack-vm-postgres-full/50f96a6 : SUCCESS in 38m 00s\n- gate-tempest-devstack-vm-neutron http://logs.openstack.org/09/51209/2/gate/gate-tempest-devstack-vm-neutron/2c25b8d : SUCCESS in 17m 46s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/09/51209/2/gate/gate-tempest-devstack-vm-large-ops/6e85885 : SUCCESS in 15m 17s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/09/51209/2/gate/gate-tempest-devstack-vm-neutron-large-ops/3bde204 : SUCCESS in 16m 02s (non-voting)\n- gate-grenade-devstack-vm http://logs.openstack.org/09/51209/2/gate/gate-grenade-devstack-vm/b13b54e : SUCCESS in 23m 05s\n- gate-swift-devstack-vm-functional http://logs.openstack.org/09/51209/2/gate/gate-swift-devstack-vm-functional/f280677 : SUCCESS in 10m 16s\n","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"af15d35414abea1e0dd9792d3fffcffab47afc1c","revisions":{"682380ddf230cb6aa4a75d9dd73d51f26e6e0eb2":{"kind":"REWORK","_number":1,"created":"2013-10-11 13:02:46.000000000","uploader":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"ref":"refs/changes/09/51209/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/09/51209/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/09/51209/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/09/51209/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/09/51209/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/09/51209/1"}}},"commit":{"parents":[{"commit":"67f7da2de299f4f9ab58718aafce336012035cd8","subject":"Merge \"Use the rdo havana repo with the RHEL family\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/67f7da2de299f4f9ab58718aafce336012035cd8"}]}],"author":{"name":"Arata Notsu","email":"notsu@virtualtech.jp","date":"2013-10-11 12:56:56.000000000","tz":540},"committer":{"name":"Arata Notsu","email":"notsu@virtualtech.jp","date":"2013-10-11 12:59:15.000000000","tz":540},"subject":"baremetal: Allow to use a node with only one nic","message":"baremetal: Allow to use a node with only one nic\n\nWhen BM_SECOND_MAC is not set or empty, do not register\nthe secondary nic.\n\nRelated-Bug: #1238595\nChange-Id: Ib3cc77686b72311403ccacbd70ae9cf43e6eb4c9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/682380ddf230cb6aa4a75d9dd73d51f26e6e0eb2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/682380ddf230cb6aa4a75d9dd73d51f26e6e0eb2"}]},"branch":"refs/heads/master"},"af15d35414abea1e0dd9792d3fffcffab47afc1c":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2013-10-11 13:34:26.000000000","uploader":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"ref":"refs/changes/09/51209/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/09/51209/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/09/51209/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/09/51209/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/09/51209/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/09/51209/2"}}},"commit":{"parents":[{"commit":"67f7da2de299f4f9ab58718aafce336012035cd8","subject":"Merge \"Use the rdo havana repo with the RHEL family\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/67f7da2de299f4f9ab58718aafce336012035cd8"}]}],"author":{"name":"Arata Notsu","email":"notsu@virtualtech.jp","date":"2013-10-11 12:56:56.000000000","tz":540},"committer":{"name":"Arata Notsu","email":"notsu@virtualtech.jp","date":"2013-10-11 13:14:46.000000000","tz":540},"subject":"baremetal: Allow BM_SECOND_MAC to be unset","message":"baremetal: Allow BM_SECOND_MAC to be unset\n\nCurrently DevStack registers the second nic of the baremetal\nnode even if BM_SECOND_MAC is not set or empty. However\nan interface with an empty mac address causes dhcp to fail\n(bug 1238595). And such operation will get to return a error\nafter the bug is resolved. So we should not register the\nsecond nic if BM_SECOND_MAC is not set.\n\nRelated-Bug: #1238595\nChange-Id: Ib3cc77686b72311403ccacbd70ae9cf43e6eb4c9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/af15d35414abea1e0dd9792d3fffcffab47afc1c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/af15d35414abea1e0dd9792d3fffcffab47afc1c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}