)]}'
{"lib/nova_plugins/functions-libvirt":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b86f8190b4ff851938bb019d2f015944775bfaa4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"DEBUG_LIBVIRT_COREDUMPS\u003d$(trueorfalse False DEBUG_LIBVIRT_COREDUMPS)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Only Xenial is left with libvirt-bin.  Everywhere else is libvirtd"},{"line_number":28,"context_line":"if is_ubuntu \u0026\u0026 [ ${DISTRO} \u003d\u003d \"xenial\" ]; then"},{"line_number":29,"context_line":"    LIBVIRT_DAEMON\u003dlibvirt-bin"},{"line_number":30,"context_line":"else"},{"line_number":31,"context_line":"    LIBVIRT_DAEMON\u003dlibvirtd"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3f4b6375_c85b3385","line":28,"updated":"2017-10-19 04:25:33.000000000","message":"I think this was originally checking for the file to be non-distro specific across ubuntu \u0026 debian with I13694fef93d36c2e128e15e7dbfaec9230335585  \n\ni think this time has past, so LGTM","commit_id":"2c2ca80ce0caadc9efa18c9f9289f6b98b3c486e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"14e1955d5be0c09009e9405cbc13b74b540f8458","unresolved":false,"context_lines":[{"line_number":25,"context_line":"DEBUG_LIBVIRT_COREDUMPS\u003d$(trueorfalse False DEBUG_LIBVIRT_COREDUMPS)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Only Xenial is left with libvirt-bin.  Everywhere else is libvirtd"},{"line_number":28,"context_line":"if is_ubuntu \u0026\u0026 [ ${DISTRO} \u003d\u003d \"xenial\" ]; then"},{"line_number":29,"context_line":"    LIBVIRT_DAEMON\u003dlibvirt-bin"},{"line_number":30,"context_line":"else"},{"line_number":31,"context_line":"    LIBVIRT_DAEMON\u003dlibvirtd"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"df87a7cf_a01e945c","line":28,"in_reply_to":"3f4b6375_c85b3385","updated":"2017-12-18 10:14:19.000000000","message":"This is failing in unstack.sh where DISTRO doesn\u0027t seem to be set when this is sourced.","commit_id":"2c2ca80ce0caadc9efa18c9f9289f6b98b3c486e"},{"author":{"_account_id":12907,"name":"Jan Zerebecki","email":"jan.openstack@zerebecki.de","username":"jzerebecki"},"change_message_id":"1bdc3ff852a1ab5aba4fff79d6472ec72856e98f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"DEBUG_LIBVIRT_COREDUMPS\u003d$(trueorfalse False DEBUG_LIBVIRT_COREDUMPS)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Only Xenial is left with libvirt-bin.  Everywhere else is libvirtd"},{"line_number":28,"context_line":"if is_ubuntu \u0026\u0026 [ ${DISTRO} \u003d\u003d \"xenial\" ]; then"},{"line_number":29,"context_line":"    LIBVIRT_DAEMON\u003dlibvirt-bin"},{"line_number":30,"context_line":"else"},{"line_number":31,"context_line":"    LIBVIRT_DAEMON\u003dlibvirtd"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"df87a7cf_c7f5bb58","line":28,"in_reply_to":"df87a7cf_a01e945c","updated":"2017-12-20 07:40:33.000000000","message":"Use of DISTRO and its constructor GetDistro is inconsistent.\n\nunstack.sh is missing the call to GetDistro that stack.sh has. However just adding it would not make things more modular.\n\nThis would be improved by the following changes: In GetDistro return early if DISTRO is already set. In every function that needs DISTRO, call GetDistro before. Move LIBVIRT_DAEMON into its own constructor function and call that before it is needed.","commit_id":"2c2ca80ce0caadc9efa18c9f9289f6b98b3c486e"}]}