)]}'
{"functions-common":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"b4984ef98fa1b9a30c3a72c62e5ea923a7f9c606","unresolved":false,"context_lines":[{"line_number":559,"context_line":"            else"},{"line_number":560,"context_line":"                die $LINENO \"$git_ref is neither branch nor tag\""},{"line_number":561,"context_line":"            fi"},{"line_number":562,"context_line":"        elif [[ \"$git_ref\" \u003d~ \"stable\\/.*\" ]]; then"},{"line_number":563,"context_line":"            cd $git_dest"},{"line_number":564,"context_line":"            # Look for an eol tag for the stable branch."},{"line_number":565,"context_line":"            eol_tag\u003d$(echo ${git_ref:7:${#git_ref}})-eol"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1f485f77_71505f5e","line":562,"range":{"start_line":562,"start_character":13,"end_line":562,"end_character":46},"updated":"2017-11-14 21:33:21.000000000","message":"or\n\n [[ $git_ref \u003d\u003d stable/* ]]","commit_id":"0a72ad89aaa9d87945bf0dcfd74c5bcbd777b136"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"b4984ef98fa1b9a30c3a72c62e5ea923a7f9c606","unresolved":false,"context_lines":[{"line_number":562,"context_line":"        elif [[ \"$git_ref\" \u003d~ \"stable\\/.*\" ]]; then"},{"line_number":563,"context_line":"            cd $git_dest"},{"line_number":564,"context_line":"            # Look for an eol tag for the stable branch."},{"line_number":565,"context_line":"            eol_tag\u003d$(echo ${git_ref:7:${#git_ref}})-eol"},{"line_number":566,"context_line":"            if [[ -n \"`git show-ref refs/tags/$eol_tag`\" ]]; then"},{"line_number":567,"context_line":"                git_update_tag $eol_tag"},{"line_number":568,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1f485f77_f1832fcb","line":565,"range":{"start_line":565,"start_character":12,"end_line":565,"end_character":56},"updated":"2017-11-14 21:33:21.000000000","message":"or\n\n eol_tag\u003d${git_ref#stable/}-eol","commit_id":"0a72ad89aaa9d87945bf0dcfd74c5bcbd777b136"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"e5384364f32ba7717f489d3fb663eb623db79f4d","unresolved":false,"context_lines":[{"line_number":564,"context_line":"            # Look for an eol tag for the stable branch."},{"line_number":565,"context_line":"            eol_tag\u003d${git_ref#stable/}-eol"},{"line_number":566,"context_line":"            if [[ -n \"`git show-ref refs/tags/$eol_tag`\" ]]; then"},{"line_number":567,"context_line":"                git checkout $git_ref"},{"line_number":568,"context_line":"            fi"},{"line_number":569,"context_line":"        fi"},{"line_number":570,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"1f485f77_ca7075df","line":567,"range":{"start_line":567,"start_character":29,"end_line":567,"end_character":37},"updated":"2017-11-15 02:15:19.000000000","message":"-f $eol_tag ?","commit_id":"7fbca0e1675e6d7a87cc6f55de1392de04c1e1c2"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e1bb5a01c1731677600f7e7e3e3667b11fb97996","unresolved":false,"context_lines":[{"line_number":559,"context_line":"            else"},{"line_number":560,"context_line":"                die $LINENO \"$git_ref is neither branch nor tag\""},{"line_number":561,"context_line":"            fi"},{"line_number":562,"context_line":"        elif [[ \"$git_ref\" \u003d\u003d stable/* ]]; then"},{"line_number":563,"context_line":"            cd $git_dest"},{"line_number":564,"context_line":"            # Look for an eol tag for the stable branch."},{"line_number":565,"context_line":"            eol_tag\u003d${git_ref#stable/}-eol"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"1f485f77_ca41900d","line":562,"updated":"2017-11-15 07:02:34.000000000","message":"is this not extremely gate specific?  \n\nthe logic is \"if the $git_dest doesn\u0027t exist, go clone it and check it out at the git_ref\".  we do not hit that in the gate, because zuul has cloned it for us already and then we use devstack-gate:setup_workspace() to copy it in to /opt/stack/new/...\n\nso really the assumption is that the project is already checked out the project on the right branch for us and it will be in /opt/stack/new/ ready to go\n\nthis only gets hit in that very specific environment\n\nI *think* that it would be better to handle this in devstack-gate:setup_workspace().  I think possibly if [1] was changed to look for ${branch} OR \"${branch}-eol\" and check it out at that level, it would work better?\n\n[1] http://git.openstack.org/cgit/openstack-infra/devstack-gate/tree/functions.sh#n420","commit_id":"e5ebf6bf8e21545c3a41d1defa239dce79aa817e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"426a01bf155938ed67ad96d1127b8a3c9c0a05b5","unresolved":false,"context_lines":[{"line_number":559,"context_line":"            else"},{"line_number":560,"context_line":"                die $LINENO \"$git_ref is neither branch nor tag\""},{"line_number":561,"context_line":"            fi"},{"line_number":562,"context_line":"        elif [[ \"$git_ref\" \u003d\u003d stable/* ]]; then"},{"line_number":563,"context_line":"            cd $git_dest"},{"line_number":564,"context_line":"            # Look for an eol tag for the stable branch."},{"line_number":565,"context_line":"            eol_tag\u003d${git_ref#stable/}-eol"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"1f485f77_c7c97eac","line":562,"in_reply_to":"1f485f77_47334ef7","updated":"2017-11-15 14:57:10.000000000","message":"https://review.openstack.org/#/c/520095/","commit_id":"e5ebf6bf8e21545c3a41d1defa239dce79aa817e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3e551897a4a63e97f347a8dddfb64b4ec8cbc08c","unresolved":false,"context_lines":[{"line_number":559,"context_line":"            else"},{"line_number":560,"context_line":"                die $LINENO \"$git_ref is neither branch nor tag\""},{"line_number":561,"context_line":"            fi"},{"line_number":562,"context_line":"        elif [[ \"$git_ref\" \u003d\u003d stable/* ]]; then"},{"line_number":563,"context_line":"            cd $git_dest"},{"line_number":564,"context_line":"            # Look for an eol tag for the stable branch."},{"line_number":565,"context_line":"            eol_tag\u003d${git_ref#stable/}-eol"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"1f485f77_fc152d9d","line":562,"in_reply_to":"1f485f77_ca41900d","updated":"2017-11-15 14:38:29.000000000","message":"Yeah, maybe, I wasn\u0027t sure how the repo got put here in the first place. I knew it had something to do with the workspace setup with zuulv3 but didn\u0027t know the details.","commit_id":"e5ebf6bf8e21545c3a41d1defa239dce79aa817e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4840fb6399c0081b2c547d48c7f76d9a323a8392","unresolved":false,"context_lines":[{"line_number":559,"context_line":"            else"},{"line_number":560,"context_line":"                die $LINENO \"$git_ref is neither branch nor tag\""},{"line_number":561,"context_line":"            fi"},{"line_number":562,"context_line":"        elif [[ \"$git_ref\" \u003d\u003d stable/* ]]; then"},{"line_number":563,"context_line":"            cd $git_dest"},{"line_number":564,"context_line":"            # Look for an eol tag for the stable branch."},{"line_number":565,"context_line":"            eol_tag\u003d${git_ref#stable/}-eol"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"1f485f77_47334ef7","line":562,"in_reply_to":"1f485f77_fc152d9d","updated":"2017-11-15 14:50:58.000000000","message":"\u003e I *think* that it would be better to handle this in devstack-gate:setup_workspace().  I think possibly if [1] was changed to look for ${branch} OR \"${branch}-eol\" and check it out at that level, it would work better?\n\n[1] http://git.openstack.org/cgit/openstack-infra/devstack-gate/tree/functions.sh#n420\n\nLooking at http://logs.openstack.org/58/519758/9/check/legacy-tempest-dsvm-neutron-full/087e5f3/logs/devstack-gate-setup-workspace-new.txt.gz#_2017-11-15_03_21_15_714 - the neutron stable/newton branch is gone, so I don\u0027t know why that\u0027s successfully checking out stable/newton for neutron, that should fall down into the else block to checkout the master branch.\n\nBut then looking at a different change, it doesn\u0027t find stable/newton and checks out master:\n\nhttp://logs.openstack.org/86/519586/1/check/legacy-tempest-dsvm-neutron-full/105d943/logs/devstack-gate-setup-workspace-new.txt.gz#_2017-11-14_09_05_51_525\n\nSo I\u0027m confused as to why setup_workspace sometimes finds stable/newton in neutron and sometimes doesn\u0027t - at this point it should never find that branch since it\u0027s been deleted, and setup_workspace should run before devstack, right?","commit_id":"e5ebf6bf8e21545c3a41d1defa239dce79aa817e"}]}