)]}'
{"doc/source/plugins.rst":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"91536e54fda314201918bbbdd9f57a6a91f9aecb","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  If your plugin depends on another plugin, indicate it in this file"},{"line_number":58,"context_line":"  with a line like the following::"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    plugin_requires \u003cYOUR PLUGIN\u003e \u003cOTHER PLUGIN 1} [\u003cOTHER PLUGIN 2\u003e ...]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  Devstack does not currently use this dependency information, so it\u0027s"},{"line_number":63,"context_line":"  important that users continue to add enable_plugin lines in the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff82abbf_66d8f452","line":60,"updated":"2017-11-21 18:27:25.000000000","message":"Nit: s/}/\u003e/\n\nAlso IMO it would be nicer to have multiple lines for multiple dependencies, e.g.\n\nplugin_requires \u003cYOUR PLUGIN\u003e \u003cOTHER PLUGIN 1\u003e\nplugin_requires \u003cYOUR PLUGIN\u003e \u003cOTHER PLUGIN 2\u003e\n\nWould the plugins be specified by name or by giturl?","commit_id":"ebd8387c98d16f165093a64da52e545803d5a14e"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"4086322f16f491fcd0a0b0ef1c5e185da56171f3","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  If your plugin depends on another plugin, indicate it in this file"},{"line_number":58,"context_line":"  with a line like the following::"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    plugin_requires \u003cYOUR PLUGIN\u003e \u003cOTHER PLUGIN 1} [\u003cOTHER PLUGIN 2\u003e ...]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  Devstack does not currently use this dependency information, so it\u0027s"},{"line_number":63,"context_line":"  important that users continue to add enable_plugin lines in the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff82abbf_092d7842","line":60,"updated":"2017-11-21 21:02:08.000000000","message":"Oh, I didn\u0027t see the } thanks :)\n\nI was thinking name, but now that I look closer, the name is really quite arbitrary and can be whatever the user puts in their local.conf, so it\u0027s outside the plugin author\u0027s control.\n\nThe git url may be more stable, but is less flexible if, say, someone wants to use a local fork.  So when considered in that light, it suffers from almost the same problem as name.\n\nI think we have these options:\n\n1) Use \u0027name\u0027 and figure that most people will probably use the same names.\n2) Use \u0027git url\u0027 and avoid the issue of folks having local forks specified in local.conf.\n3) Add another declaration for a plugin to say \"This is my canonical name\".  Example:\n\n  define_plugin foobar\n\nWould go in settings to say \"this is the foobar plugin\".\n\nOption 3 is probably best.  I\u0027m still okay with 1 (it\u0027s forward-compatible with 3).  I think 2 could cause more problems.","commit_id":"ebd8387c98d16f165093a64da52e545803d5a14e"}]}
