)]}'
{"inc/python":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"222519ff9e67fa0a66af718e8970a0bf71dd29fe","unresolved":false,"context_lines":[{"line_number":419,"context_line":"    #  bashate 0.5.2.dev19 /tmp/env/src/bashate"},{"line_number":420,"context_line":"    # Thus we check the third column to see if we\u0027re installed from"},{"line_number":421,"context_line":"    # some local place."},{"line_number":422,"context_line":"    [[ -n $(pip list --format\u003dcolumns 2\u003e/dev/null | awk \"/$name/ {print \\$3}\") ]]"},{"line_number":423,"context_line":"}"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"# check that everything that\u0027s in LIBS_FROM_GIT was actually installed"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ff82abbf_1d8b481f","line":422,"updated":"2017-11-23 07:17:07.000000000","message":"I\u0027m not sure that this is the correct fix, as it would also match e.g. \u0027glance\u0027 within \u0027python-glanceclient\u0027.\n\nBetter find a way to handle the \u0027-\u0027 vs. \u0027_\u0027 naming differences explicitly.\n\nOr possibly revert https://review.openstack.org/#/q/I5140a7d83bf567b1c3c67516112eb4c57074fa53 if no feasible solution exists.","commit_id":"c6935ff017c0717f0aeabc0b9a79ecd23741e84a"},{"author":{"_account_id":22078,"name":"Damon Li","email":"likailichee@gmail.com","username":"likai"},"change_message_id":"d00b2dbc27a17f67385524736fa4cab9d555b80c","unresolved":false,"context_lines":[{"line_number":419,"context_line":"    #  bashate 0.5.2.dev19 /tmp/env/src/bashate"},{"line_number":420,"context_line":"    # Thus we check the third column to see if we\u0027re installed from"},{"line_number":421,"context_line":"    # some local place."},{"line_number":422,"context_line":"    [[ -n $(pip list --format\u003dcolumns 2\u003e/dev/null | awk \"/$name/ {print \\$3}\") ]]"},{"line_number":423,"context_line":"}"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"# check that everything that\u0027s in LIBS_FROM_GIT was actually installed"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ff82abbf_76b4f135","line":422,"in_reply_to":"ff82abbf_1d8b481f","updated":"2017-11-23 09:10:26.000000000","message":"Cool, what a good opinion it is.\nI will think another way to fix it.\n\nThanks for your review Jens.","commit_id":"c6935ff017c0717f0aeabc0b9a79ecd23741e84a"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"4284f99a0861d3475357169f7d3402ce27ff8c10","unresolved":false,"context_lines":[{"line_number":407,"context_line":"function lib_installed_from_git {"},{"line_number":408,"context_line":"    local name\u003d$1"},{"line_number":409,"context_line":"    local safe_name\u003d$(python -c \"from pkg_resources import safe_name; \\"},{"line_number":410,"context_line":"\t    print safe_name(\u0027${name}\u0027)\")"},{"line_number":411,"context_line":"    # Note \"pip freeze\" doesn\u0027t always work here, because it tries to"},{"line_number":412,"context_line":"    # be smart about finding the remote of the git repo the package"},{"line_number":413,"context_line":"    # was installed from.  This doesn\u0027t work with zuul which clones"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"ff82abbf_113e9dd9","line":410,"updated":"2017-11-27 05:50:00.000000000","message":"this tab is going to cause bashate issues i\u0027d say","commit_id":"faec2dc93bda7ba5c87b1f1e2aaf17f3590b2bee"},{"author":{"_account_id":22078,"name":"Damon Li","email":"likailichee@gmail.com","username":"likai"},"change_message_id":"aeafb6c4881c7614dea1ff2dd743eedda5f555a5","unresolved":false,"context_lines":[{"line_number":407,"context_line":"function lib_installed_from_git {"},{"line_number":408,"context_line":"    local name\u003d$1"},{"line_number":409,"context_line":"    local safe_name\u003d$(python -c \"from pkg_resources import safe_name; \\"},{"line_number":410,"context_line":"\t    print safe_name(\u0027${name}\u0027)\")"},{"line_number":411,"context_line":"    # Note \"pip freeze\" doesn\u0027t always work here, because it tries to"},{"line_number":412,"context_line":"    # be smart about finding the remote of the git repo the package"},{"line_number":413,"context_line":"    # was installed from.  This doesn\u0027t work with zuul which clones"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"ff82abbf_cc965a94","line":410,"in_reply_to":"ff82abbf_113e9dd9","updated":"2017-11-27 06:06:07.000000000","message":"Done","commit_id":"faec2dc93bda7ba5c87b1f1e2aaf17f3590b2bee"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"72b3b12c17c4089b4f31cd4b1dede49c724cbd9a","unresolved":false,"context_lines":[{"line_number":408,"context_line":"    local name\u003d$1"},{"line_number":409,"context_line":"    local safe_name"},{"line_number":410,"context_line":"    safe_name\u003d$(python -c \"from pkg_resources import safe_name; \\"},{"line_number":411,"context_line":"        safe_name(\u0027${name}\u0027)\")"},{"line_number":412,"context_line":"    # Note \"pip freeze\" doesn\u0027t always work here, because it tries to"},{"line_number":413,"context_line":"    # be smart about finding the remote of the git repo the package"},{"line_number":414,"context_line":"    # was installed from.  This doesn\u0027t work with zuul which clones"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"ff82abbf_5f873db6","line":411,"updated":"2017-11-27 20:33:55.000000000","message":"needs to be printed","commit_id":"c2e74dfa3353668c2b47c149bdc845b7dd34e42c"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"0f648172ec0b2e0d090fbcada63fd24f7102b96a","unresolved":false,"context_lines":[{"line_number":408,"context_line":"    local name\u003d$1"},{"line_number":409,"context_line":"    local safe_name"},{"line_number":410,"context_line":"    safe_name\u003d$(python -c \"from pkg_resources import safe_name; \\"},{"line_number":411,"context_line":"        print(safe_name(\u0027${name}\u0027))\")"},{"line_number":412,"context_line":"    # Note \"pip freeze\" doesn\u0027t always work here, because it tries to"},{"line_number":413,"context_line":"    # be smart about finding the remote of the git repo the package"},{"line_number":414,"context_line":"    # was installed from.  This doesn\u0027t work with zuul which clones"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"ff82abbf_6a49045e","line":411,"updated":"2017-11-28 16:38:11.000000000","message":"I\u0027m noticing this may not entirely be python3 safe, but the pip list below doesn\u0027t specify python version either so this isn\u0027t a regression. We\u0027ll just have to clean this up if/when it becomes a problem.","commit_id":"007f588f275ac9d7320d4b24f1d05378d3df3d37"}]}