)]}'
{"id":"openstack%2Fdevstack~525533","triplet_id":"openstack%2Fdevstack~master~I6e2a3bf4f0a66292d5d1aede509f43eb90a720ae","project":"openstack/devstack","branch":"master","topic":"bug/1736385","hashtags":[],"change_id":"I6e2a3bf4f0a66292d5d1aede509f43eb90a720ae","subject":"Use systemctl restart in _run_under_systemd","status":"ABANDONED","created":"2017-12-05 11:22:08.000000000","updated":"2017-12-05 18:44:09.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"691db4b5ac61bc5e5508259209de48ffe7ada3f1","_number":525533,"virtual_id_number":525533,"owner":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"all":[{"date":"2017-12-05 15:16:30.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"date":"2017-12-05 15:12:27.000000000","_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":1,"date":"2017-12-05 14:00:13.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":1,"date":"2017-12-05 14:55:52.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"all":[{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2017-12-05 13:18:08.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-12-05 14:00:13.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2017-12-05 14:55:52.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2017-12-05 15:12:27.000000000","updated_by":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2017-12-05 15:16:30.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"cd4d1ae1ac8a10e6cf603d22db22bd0b1012410b","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2017-12-05 11:22:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"111f20e236be5576fb130f954f8643ac4d3a7783","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2017-12-05 12:21:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/devstack/33/525533/1/check/tempest-dsvm-full-xenial/c87f0da/ : SUCCESS in 59m 09s","accounts_in_message":[],"_revision_number":1},{"id":"88c9f7dc3d932122b6b3080b8698c8a7339cc16e","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2017-12-05 12:37:06.000000000","message":"Patch Set 1:\n\nTesting succeeded on ubuntu-xenial-s390x. For rechecking only on the ubuntu-xenail-s390x CI, add a review comment with recheck-zkvm. Contact info: zkvm-ci@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_zKVM_CI\n\n- check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x http://sng01.objectstorage.softlayer.net/v1/AUTH_1940ea10-6e82-4501-b2f9-eb236510e575/ibmzkvmci/production/525533/1/check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x/af6b73c : SUCCESS in 1h 14m 33s","accounts_in_message":[],"_revision_number":1},{"id":"60953b3d8750d3e7d5e714a716546ffee0c2c6d7","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2017-12-05 13:01:01.000000000","message":"Patch Set 1:\n\nThe depends on didn\u0027t actually work presumably because grenade is in the middle there somewhere. However this http://logs.openstack.org/33/525533/1/check/legacy-grenade-dsvm-neutron/3a42ff5/logs/grenade.sh.txt.gz#_2017-12-05_12_08_05_444 indicates that the desired results are happening.","accounts_in_message":[],"_revision_number":1},{"id":"78716ad1761ad235f824401a685984d9d6f310dd","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2017-12-05 13:02:05.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"bbd31978c5183451bb246a730c4dbc6a068a2761","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2017-12-05 13:18:08.000000000","message":"Patch Set 2: Workflow-1\n\nLooks like there is a more fundamental problem, which was that placement wasn\u0027t being stopped in shutdown.sh of grenade, will fix that instead.","accounts_in_message":[],"_revision_number":2},{"id":"b5a85d747a5aceddb103b576cdf1df9a17539e26","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2017-12-05 14:00:13.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/devstack/33/525533/2/check/tempest-dsvm-full-xenial/0aec0d3/ : SUCCESS in 57m 52s","accounts_in_message":[],"_revision_number":2},{"id":"a75684696bfaaaf302797b11fdce4a753827b7d5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-05 14:55:52.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- legacy-tempest-dsvm-py35 http://logs.openstack.org/33/525533/2/check/legacy-tempest-dsvm-py35/d942b9d/ : SUCCESS in 1h 06m 13s\n- build-openstack-sphinx-docs http://logs.openstack.org/33/525533/2/check/build-openstack-sphinx-docs/cc77c09/html/ : SUCCESS in 4m 34s\n- openstack-tox-bashate http://logs.openstack.org/33/525533/2/check/openstack-tox-bashate/211dd2b/ : SUCCESS in 2m 29s\n- legacy-devstack-unit-tests http://logs.openstack.org/33/525533/2/check/legacy-devstack-unit-tests/590d5e5/ : SUCCESS in 4m 03s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/33/525533/2/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/393177b/ : SUCCESS in 45m 12s (non-voting)\n- legacy-devstack-dsvm-updown http://logs.openstack.org/33/525533/2/check/legacy-devstack-dsvm-updown/94db5e4/ : SUCCESS in 29m 25s\n- legacy-devstack-dsvm-py35-updown http://logs.openstack.org/33/525533/2/check/legacy-devstack-dsvm-py35-updown/4584db3/ : SUCCESS in 23m 27s (non-voting)\n- legacy-swift-dsvm-functional http://logs.openstack.org/33/525533/2/check/legacy-swift-dsvm-functional/f9bed30/ : SUCCESS in 22m 21s (non-voting)\n- legacy-grenade-dsvm-neutron http://logs.openstack.org/33/525533/2/check/legacy-grenade-dsvm-neutron/a81f508/ : SUCCESS in 38m 23s\n- legacy-grenade-dsvm-neutron-multinode http://logs.openstack.org/33/525533/2/check/legacy-grenade-dsvm-neutron-multinode/d4881e8/ : SUCCESS in 52m 01s\n- legacy-tempest-dsvm-neutron-full-centos-7 http://logs.openstack.org/33/525533/2/check/legacy-tempest-dsvm-neutron-full-centos-7/980a30b/ : FAILURE in 11m 31s (non-voting)\n- legacy-tempest-dsvm-neutron-linuxbridge http://logs.openstack.org/33/525533/2/check/legacy-tempest-dsvm-neutron-linuxbridge/484a1b4/ : SUCCESS in 1h 15m 20s\n- legacy-tempest-dsvm-neutron-full-opensuse-423 http://logs.openstack.org/33/525533/2/check/legacy-tempest-dsvm-neutron-full-opensuse-423/419c072/ : SUCCESS in 1h 25m 01s (non-voting)\n- legacy-tempest-dsvm-neutron-multinode-full http://logs.openstack.org/33/525533/2/check/legacy-tempest-dsvm-neutron-multinode-full/e839350/ : SUCCESS in 1h 32m 28s (non-voting)\n- legacy-tempest-dsvm-neutron-full http://logs.openstack.org/33/525533/2/check/legacy-tempest-dsvm-neutron-full/f042383/ : SUCCESS in 1h 46m 07s\n- devstack http://logs.openstack.org/33/525533/2/check/devstack/24540d3/ : SUCCESS in 17m 40s","accounts_in_message":[],"_revision_number":2},{"id":"122c477743d3a904f14bca17074e0afe366168b3","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2017-12-05 15:12:27.000000000","message":"Patch Set 2:\n\nTesting succeeded on ubuntu-xenial-s390x. For rechecking only on the ubuntu-xenail-s390x CI, add a review comment with recheck-zkvm. Contact info: zkvm-ci@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_zKVM_CI\n\n- check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x http://sng01.objectstorage.softlayer.net/v1/AUTH_1940ea10-6e82-4501-b2f9-eb236510e575/ibmzkvmci/production/525533/2/check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x/dd98853 : SUCCESS in 1h 56m 20s","accounts_in_message":[],"_revision_number":2},{"id":"d94eee206f970a28d1ed62d80862c032c3966920","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2017-12-05 15:16:30.000000000","message":"Patch Set 2:\n\nBuild succeeded.\n\n- dsvm-tempest-neutron-network http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/33/525533/2/check/dsvm-tempest-neutron-network/d1d11e7 : SUCCESS in 2h 00m 31s","accounts_in_message":[],"_revision_number":2},{"id":"f94a86e10619d88286f9b74ac2b20a48a0a78a43","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2017-12-05 18:44:09.000000000","message":"Abandoned\n\nwrong fix, the right fix is in grenade but having some issues there: I7f2158aeaef82a47e11c6e29675e542023fff4be","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b7c655ec9ba05264c6b9e72daca084b2512f27ff","revisions":{"9f4a64451385f8b91e739455d5d72c64363002c2":{"kind":"REWORK","_number":1,"created":"2017-12-05 11:22:08.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/33/525533/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/33/525533/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/33/525533/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/33/525533/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/33/525533/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/33/525533/1"}}},"commit":{"parents":[{"commit":"d576620e33dd8ca2d0d9ff6496cdc957f3239998","subject":"Merge \"Convert to safe name in lib_installed_from_git\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d576620e33dd8ca2d0d9ff6496cdc957f3239998"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2017-12-05 11:13:39.000000000","tz":0},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2017-12-05 11:13:39.000000000","tz":0},"subject":"WIP Use systemctl restart in _run_under_systemd","message":"WIP Use systemctl restart in _run_under_systemd\n\n\u0027systemctl restart\u0027 means either restart or start, but \u0027start\u0027 means\nrun if not running, otherwise return okay.\n\nThis presents a problem for some services when they were were running\nunder systemd in the OLD target in grenade: they do not restart.\n\nSee the linked bug for more detail, and links to examples of the\nproblem.\n\n(A WIP while a depends on confirms this fixes the nova problem.)\n\nChange-Id: I6e2a3bf4f0a66292d5d1aede509f43eb90a720ae\nCloses-Bug: #1736385\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/9f4a64451385f8b91e739455d5d72c64363002c2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/9f4a64451385f8b91e739455d5d72c64363002c2"}]},"branch":"refs/heads/master"},"b7c655ec9ba05264c6b9e72daca084b2512f27ff":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2017-12-05 13:02:05.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/33/525533/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/33/525533/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/33/525533/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/33/525533/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/33/525533/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/33/525533/2"}}},"commit":{"parents":[{"commit":"d576620e33dd8ca2d0d9ff6496cdc957f3239998","subject":"Merge \"Convert to safe name in lib_installed_from_git\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d576620e33dd8ca2d0d9ff6496cdc957f3239998"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2017-12-05 11:13:39.000000000","tz":0},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2017-12-05 13:01:25.000000000","tz":0},"subject":"Use systemctl restart in _run_under_systemd","message":"Use systemctl restart in _run_under_systemd\n\n\u0027systemctl restart\u0027 means either restart or start, but \u0027start\u0027 means\nrun if not running, otherwise return okay.\n\nThis presents a problem for some services when they were were running\nunder systemd in the OLD target in grenade: they do not restart.\n\nSee the linked bug for more detail, and links to examples of the\nproblem.\n\nChange-Id: I6e2a3bf4f0a66292d5d1aede509f43eb90a720ae\nCloses-Bug: #1736385\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/b7c655ec9ba05264c6b9e72daca084b2512f27ff"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/b7c655ec9ba05264c6b9e72daca084b2512f27ff"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}