)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"05917cd2df28223fb8b14697378c271deb0b00a5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If the bridge mappings are overridden then this indicates the bridges"},{"line_number":10,"context_line":"have been setup manually before devstack is started so we should skip"},{"line_number":11,"context_line":"the parts where devstack sets up the bridges if the mappings are"},{"line_number":12,"context_line":"overridden."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ibc31defbeeb8105ad6105a326dd0193ea6de778f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df7087c5_fe4e7e94","line":12,"updated":"2018-03-22 11:20:05.000000000","message":"I\u0027m not sure that this assumption is valid, as the variable is also being set within lib/neutron_plugins/openvswitch_agent under some conditions.","commit_id":"e223a15b1277103bd3202d0ccaa737f3a297b771"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"fe6f8f0f40d9ce58962231296c536a7a409313db","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If the bridge mappings are overridden then this indicates the bridges"},{"line_number":10,"context_line":"have been setup manually before devstack is started so we should skip"},{"line_number":11,"context_line":"the parts where devstack sets up the bridges if the mappings are"},{"line_number":12,"context_line":"overridden."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ibc31defbeeb8105ad6105a326dd0193ea6de778f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df7087c5_4c957f3f","line":12,"in_reply_to":"df7087c5_4cd01f20","updated":"2018-03-22 12:35:29.000000000","message":"Perhaps a launchpad bug with description and an example of a failure caused by overriding BRIDGE_MAPPINGS would help to understand what is this patch trying to address.","commit_id":"e223a15b1277103bd3202d0ccaa737f3a297b771"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"5e91a54f56334ac9f72ab9468890c167aeebdf64","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If the bridge mappings are overridden then this indicates the bridges"},{"line_number":10,"context_line":"have been setup manually before devstack is started so we should skip"},{"line_number":11,"context_line":"the parts where devstack sets up the bridges if the mappings are"},{"line_number":12,"context_line":"overridden."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ibc31defbeeb8105ad6105a326dd0193ea6de778f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df7087c5_4cd01f20","line":12,"in_reply_to":"df7087c5_fe4e7e94","updated":"2018-03-22 12:34:24.000000000","message":"Don\u0027t you just want to skip setting up $OVS_PHYSICAL_BRIDGE if it\u0027s already set? I fail to see where we interfere with bridges from BRIDGE_MAPPINGS when override.","commit_id":"e223a15b1277103bd3202d0ccaa737f3a297b771"}],"lib/neutron-legacy":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"05917cd2df28223fb8b14697378c271deb0b00a5","unresolved":false,"context_lines":[{"line_number":484,"context_line":"function start_mutnauq_l2_agent {"},{"line_number":485,"context_line":"    run_process q-agt \"$AGENT_BINARY --config-file $NEUTRON_CONF --config-file /$Q_PLUGIN_CONF_FILE\""},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    if is_provider_network \u0026\u0026 [[ $Q_AGENT \u003d\u003d \"openvswitch\" ]] \u0026\u0026 [[ $OVS_BRIDGE_MAPPINGS \u003d\u003d \"\" ]]; then"},{"line_number":488,"context_line":"        sudo ovs-vsctl --no-wait -- --may-exist add-port $OVS_PHYSICAL_BRIDGE $PUBLIC_INTERFACE"},{"line_number":489,"context_line":"        sudo ip link set $OVS_PHYSICAL_BRIDGE up"},{"line_number":490,"context_line":"        sudo ip link set br-int up"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"df7087c5_de613a3b","line":487,"updated":"2018-03-22 11:20:05.000000000","message":"This breaks if $OVS_BRIDGE_MAPPINGS is empty. Using \n\n[[ -z \"$OVS_BRIDGE_MAPPINGS\" ]]\n\nwould be the correct way I think.\n\nBut actually OVS_BRIDGE_MAPPINGS does get set in lib/neutron_plugins/openvswitch_agent so I\u0027m not sure whether this will break certain scenarios.","commit_id":"e223a15b1277103bd3202d0ccaa737f3a297b771"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"5e91a54f56334ac9f72ab9468890c167aeebdf64","unresolved":false,"context_lines":[{"line_number":484,"context_line":"function start_mutnauq_l2_agent {"},{"line_number":485,"context_line":"    run_process q-agt \"$AGENT_BINARY --config-file $NEUTRON_CONF --config-file /$Q_PLUGIN_CONF_FILE\""},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    if is_provider_network \u0026\u0026 [[ $Q_AGENT \u003d\u003d \"openvswitch\" ]] \u0026\u0026 [[ $OVS_BRIDGE_MAPPINGS \u003d\u003d \"\" ]]; then"},{"line_number":488,"context_line":"        sudo ovs-vsctl --no-wait -- --may-exist add-port $OVS_PHYSICAL_BRIDGE $PUBLIC_INTERFACE"},{"line_number":489,"context_line":"        sudo ip link set $OVS_PHYSICAL_BRIDGE up"},{"line_number":490,"context_line":"        sudo ip link set br-int up"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"df7087c5_8c5637ce","line":487,"in_reply_to":"df7087c5_de613a3b","updated":"2018-03-22 12:34:24.000000000","message":"I think it does work with double bracket [[, it would break with just a single [","commit_id":"e223a15b1277103bd3202d0ccaa737f3a297b771"}],"lib/neutron_plugins/services/l3":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"05917cd2df28223fb8b14697378c271deb0b00a5","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            die_if_not_set $LINENO IPV6_SUBNET_ID \"Failure creating IPV6_SUBNET_ID for $IPV6_PROVIDER_SUBNET_NAME $project_id\""},{"line_number":207,"context_line":"        fi"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        if [[ $Q_AGENT \u003d\u003d \"openvswitch\" ]] \u0026\u0026 [[ $OVS_BRIDGE_MAPPINGS \u003d\u003d \"\" ]]; then"},{"line_number":210,"context_line":"            sudo ip link set $OVS_PHYSICAL_BRIDGE up"},{"line_number":211,"context_line":"            sudo ip link set br-int up"},{"line_number":212,"context_line":"            sudo ip link set $PUBLIC_INTERFACE up"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"df7087c5_1e4fb2bd","line":209,"updated":"2018-03-22 11:20:05.000000000","message":"Same issue","commit_id":"e223a15b1277103bd3202d0ccaa737f3a297b771"}]}