)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c96787d19b66493f79bbe93f99601e98884cf4ae","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-12-27 10:56:07 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"use openstack command instead of nova command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Iee0b81a994a4da5b3f4572c2e8eb30514cd43f89"},{"line_number":10,"context_line":"Signed-off-by: Ryota MIBU \u003cr-mibu@cq.jp.nec.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f91af0f_7f5bb086","line":8,"updated":"2018-01-01 15:04:46.000000000","message":"please add a little explanation here, for example which command. that will make reviewers lives a little easier.","commit_id":"17205baf473a5dcc082b66924fb7c480394362a5"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"e58a13bfdbc4f892b01de42a962f1d90abbeda3b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-12-27 10:56:07 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"use openstack command instead of nova command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Iee0b81a994a4da5b3f4572c2e8eb30514cd43f89"},{"line_number":10,"context_line":"Signed-off-by: Ryota MIBU \u003cr-mibu@cq.jp.nec.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f91af0f_c8de3ad9","line":8,"in_reply_to":"9f91af0f_7f5bb086","updated":"2018-01-09 06:46:48.000000000","message":"Done","commit_id":"17205baf473a5dcc082b66924fb7c480394362a5"}],"functions":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"dc7fd7b1b935f5b700920ebb35cab2be2d352d25","unresolved":false,"context_lines":[{"line_number":505,"context_line":"    local network_name\u003d$2"},{"line_number":506,"context_line":"    local ip"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"    ip\u003d$(openstack server show -c address -f value \"$vm_id\" \\"},{"line_number":509,"context_line":"        | sed -n \"s/^.*$network_name\u003d\\([0-9\\.]*\\).*$/\\1/p\")"},{"line_number":510,"context_line":"    if [[ $ip \u003d \"\" ]];then"},{"line_number":511,"context_line":"        die $LINENO \"[Fail] Couldn\u0027t get ipaddress of VM\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7f96bb07_ddb680da","line":508,"updated":"2018-01-12 01:20:16.000000000","message":"I believe it\u0027s \"addresses\" (note \"es\") but wouldn\u0027t something like accessIPv4 be what this wants?","commit_id":"461527c0ef43fb0d641d75590c9db20212c36e4d"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"9267aec9c523ca51dcd4ec48a10107143c07f23c","unresolved":false,"context_lines":[{"line_number":505,"context_line":"    local network_name\u003d$2"},{"line_number":506,"context_line":"    local ip"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"    ip\u003d$(openstack server show -c address -f value \"$vm_id\" \\"},{"line_number":509,"context_line":"        | sed -n \"s/^.*$network_name\u003d\\([0-9\\.]*\\).*$/\\1/p\")"},{"line_number":510,"context_line":"    if [[ $ip \u003d \"\" ]];then"},{"line_number":511,"context_line":"        die $LINENO \"[Fail] Couldn\u0027t get ipaddress of VM\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7f96bb07_ff3a49e5","line":508,"in_reply_to":"7f96bb07_ddb680da","updated":"2018-01-12 08:13:33.000000000","message":"you are right. thanks!\n\nhttps://github.com/openstack/python-openstackclient/blob/master/openstackclient/compute/v2/server.py#L170","commit_id":"461527c0ef43fb0d641d75590c9db20212c36e4d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4f545dbf4720f07c77d0cdffab6d6c5676edb572","unresolved":false,"context_lines":[{"line_number":509,"context_line":"    nova_result\u003d\"$(nova show $vm_id)\""},{"line_number":510,"context_line":"    ip\u003d$(echo \"$nova_result\" | grep \"$network_name\" | get_field 2)"},{"line_number":511,"context_line":"    if [[ $ip \u003d \"\" ]];then"},{"line_number":512,"context_line":"        echo \"$nova_result\""},{"line_number":513,"context_line":"        die $LINENO \"[Fail] Couldn\u0027t get ipaddress of VM\""},{"line_number":514,"context_line":"    fi"},{"line_number":515,"context_line":"    echo $ip"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7f96bb07_72b452f3","side":"PARENT","line":512,"range":{"start_line":512,"start_character":8,"end_line":512,"end_character":27},"updated":"2018-01-19 18:48:05.000000000","message":"I have a small concern about this removal.\nWhen we face this \"die\", this debug message is helpful for debugging.\nIf removing it, the debug will be hard because the instance cannot be found after a cleanup happens.\nSo how about keeping this debug message like\n\n + openstack_result\u003d$(openstack server show -c addresses -f value \"$vm_id\")\n + ip\u003d$(echo $openstack_result | sed -n \"s/^.*$network_name\u003d\\([0-9\\.]*\\).*$/\\1/p\")\n if [[ $ip \u003d \"\" ]];then\n +   echo $openstack_result\n     die $LINENO \"[Fail] Couldn\u0027t get ipaddress of VM\"\n\n?","commit_id":"63ed03cc59ff666e3b1f7b229d4545c6cce9b9a8"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"2548ff7508bc8c303ea0c7cc23c1d94e901f93e0","unresolved":false,"context_lines":[{"line_number":509,"context_line":"    nova_result\u003d\"$(nova show $vm_id)\""},{"line_number":510,"context_line":"    ip\u003d$(echo \"$nova_result\" | grep \"$network_name\" | get_field 2)"},{"line_number":511,"context_line":"    if [[ $ip \u003d \"\" ]];then"},{"line_number":512,"context_line":"        echo \"$nova_result\""},{"line_number":513,"context_line":"        die $LINENO \"[Fail] Couldn\u0027t get ipaddress of VM\""},{"line_number":514,"context_line":"    fi"},{"line_number":515,"context_line":"    echo $ip"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7f96bb07_0b9be217","side":"PARENT","line":512,"range":{"start_line":512,"start_character":8,"end_line":512,"end_character":27},"in_reply_to":"7f96bb07_72b452f3","updated":"2018-01-24 14:52:41.000000000","message":"understood. I\u0027ll also add VM ID in that message as well.","commit_id":"63ed03cc59ff666e3b1f7b229d4545c6cce9b9a8"}]}