)]}'
{"id":"openstack%2Fdevstack~53098","triplet_id":"openstack%2Fdevstack~master~I8e08cce63d35c503c36ff1e09805f3db427d082d","project":"openstack/devstack","branch":"master","topic":"stackforge","hashtags":[],"change_id":"I8e08cce63d35c503c36ff1e09805f3db427d082d","subject":"exit cleanup in functions","status":"MERGED","created":"2013-10-22 11:32:20.000000000","updated":"2013-10-22 21:33:40.000000000","submitted":"2013-10-22 21:33:39.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8891e37fa6c7701ddcec89b8f24751955b8109f7","_number":53098,"virtual_id_number":53098,"owner":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-10-22 21:33:39.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-10-22 15:23:48.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-10-22 20:47:07.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-10-22 20:47:07.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2013-10-22 21:33:39.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"2431040f14da93bd1d18a7f31d8816f37e9597b9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-22 12:09:02.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- check-tempest-devstack-vm-full http://logs.openstack.org/98/53098/1/check/check-tempest-devstack-vm-full/4118f06 : SUCCESS in 31m 23s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/98/53098/1/check/check-tempest-devstack-vm-postgres-full/c35781f : SUCCESS in 31m 43s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/98/53098/1/check/check-tempest-devstack-vm-neutron/fcb078e : SUCCESS in 32m 01s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/98/53098/1/check/gate-tempest-devstack-vm-large-ops/d16b598 : SUCCESS in 14m 51s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/98/53098/1/check/gate-tempest-devstack-vm-neutron-large-ops/411a120 : SUCCESS in 16m 55s (non-voting)\n- check-grenade-devstack-vm http://logs.openstack.org/98/53098/1/check/check-grenade-devstack-vm/a33cf3b : SUCCESS in 35m 23s\n- check-swift-devstack-vm-functional http://logs.openstack.org/98/53098/1/check/check-swift-devstack-vm-functional/b8c7d73 : SUCCESS in 21m 17s\n","accounts_in_message":[],"_revision_number":1},{"id":"8df9a84b555342760cd2cd31a5cae6702a6eb0c2","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-10-22 15:23:48.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"0e36853f36247b5c21af1ef95f44bd1f5563db9a","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-10-22 20:47:07.000000000","message":"Patch Set 1: Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"600ed18ed066a536e177b5468347ad01ded744ef","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-22 20:47:08.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"e9c704b8c21ec373932d9921662affb02ca86dc2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-22 21:33:39.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- gate-devstack-bash8 http://logs.openstack.org/98/53098/1/gate/gate-devstack-bash8/e1a74f5 : SUCCESS in 49s (non-voting)\n- gate-tempest-devstack-vm-full http://logs.openstack.org/98/53098/1/gate/gate-tempest-devstack-vm-full/4763347 : SUCCESS in 30m 52s\n- gate-tempest-devstack-vm-postgres-full http://logs.openstack.org/98/53098/1/gate/gate-tempest-devstack-vm-postgres-full/d38f69c : SUCCESS in 30m 08s\n- gate-tempest-devstack-vm-neutron http://logs.openstack.org/98/53098/1/gate/gate-tempest-devstack-vm-neutron/f00f574 : SUCCESS in 19m 44s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/98/53098/1/gate/gate-tempest-devstack-vm-large-ops/7448ca2 : SUCCESS in 25m 47s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/98/53098/1/gate/gate-tempest-devstack-vm-neutron-large-ops/950f802 : SUCCESS in 30m 42s (non-voting)\n- gate-grenade-devstack-vm http://logs.openstack.org/98/53098/1/gate/gate-grenade-devstack-vm/6ad5dbb : SUCCESS in 24m 19s\n- gate-swift-devstack-vm-functional http://logs.openstack.org/98/53098/1/gate/gate-swift-devstack-vm-functional/78cb767 : SUCCESS in 11m 16s\n","accounts_in_message":[],"_revision_number":1},{"id":"0a0bec983f6762907143f2a39f008b1794638185","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-22 21:33:40.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"dc30bd3eb457aaea66451621695cddfa8213a169","revisions":{"dc30bd3eb457aaea66451621695cddfa8213a169":{"kind":"REWORK","_number":1,"created":"2013-10-22 11:32:20.000000000","uploader":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"ref":"refs/changes/98/53098/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/98/53098/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/98/53098/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/98/53098/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/98/53098/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/98/53098/1"}}},"commit":{"parents":[{"commit":"ff38d464e41db3d8f83c2b85b48f983e424f3a23","subject":"Merge \"Use nova.conf for auth_token configs.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/ff38d464e41db3d8f83c2b85b48f983e424f3a23"}]}],"author":{"name":"Sean Dague","email":"sdague@linux.vnet.ibm.com","date":"2013-10-22 11:30:47.000000000","tz":-240},"committer":{"name":"Sean Dague","email":"sdague@linux.vnet.ibm.com","date":"2013-10-22 11:32:04.000000000","tz":-240},"subject":"exit cleanup in functions","message":"exit cleanup in functions\n\nwe should always use die instead of exit so that we know why we\nfailed.\n\nAlso remove instances where exit is called after die, as that is\na noop.\n\nChange-Id: I8e08cce63d35c503c36ff1e09805f3db427d082d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/dc30bd3eb457aaea66451621695cddfa8213a169"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/dc30bd3eb457aaea66451621695cddfa8213a169"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}