)]}'
{"id":"openstack%2Fdevstack~531248","triplet_id":"openstack%2Fdevstack~stable%2Fnewton~Iee7c922cd534ff9ec67cffd2aaa1a03360c1b74a","project":"openstack/devstack","branch":"stable/newton","topic":"531248","hashtags":[],"change_id":"Iee7c922cd534ff9ec67cffd2aaa1a03360c1b74a","subject":"Differentiate between DEFAULT_IMAGE_NAME and filename","status":"ABANDONED","created":"2018-01-04 21:38:03.000000000","updated":"2021-11-09 10:13:46.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d43c6b77c8edd8abb02574e74aa694ab17616d98","_number":531248,"virtual_id_number":531248,"owner":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2018-01-04 23:42:18.000000000","_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"date":"2018-01-09 08:36:28.000000000","_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":1,"date":"2018-01-04 22:53:35.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"date":"2018-01-09 19:32:56.000000000","_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":-1,"date":"2018-01-04 23:25:57.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2018-01-09 04:53:11.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-01-04 22:53:35.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-01-04 23:25:57.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-01-04 23:42:18.000000000","updated_by":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-01-09 04:53:11.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2018-01-09 08:36:28.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"}],"messages":[{"id":"ce13ae493387e70523be9fcdf5d457575db5597f","author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"date":"2018-01-04 21:38:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ece0436e0a444a38fb38e2fc865a09149b5da01f","author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"date":"2018-01-04 21:47:35.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4ad052229e34bf94a91c94aefe9f431a79f45d54","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2018-01-04 22:53:35.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial-nv https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/devstack/48/531248/2/check/tempest-dsvm-full-xenial-nv/f05fca5/ : SUCCESS in 1h 05m 36s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"de53e5461e7787d95369a082fb92e422b688e254","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-04 23:25:57.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- legacy-tempest-dsvm-neutron-full http://logs.openstack.org/48/531248/2/check/legacy-tempest-dsvm-neutron-full/1830969/ : SUCCESS in 1h 22m 21s\n- build-openstack-sphinx-docs http://logs.openstack.org/48/531248/2/check/build-openstack-sphinx-docs/0909e5a/ : FAILURE in 5m 17s\n- openstack-tox-bashate http://logs.openstack.org/48/531248/2/check/openstack-tox-bashate/4121166/ : SUCCESS in 4m 58s\n- legacy-devstack-unit-tests http://logs.openstack.org/48/531248/2/check/legacy-devstack-unit-tests/7123f4a/ : SUCCESS in 3m 38s\n- legacy-swift-dsvm-functional http://logs.openstack.org/48/531248/2/check/legacy-swift-dsvm-functional/5338cac/ : SUCCESS in 17m 48s (non-voting)\n- legacy-tempest-dsvm-neutron-full-centos-7 http://logs.openstack.org/48/531248/2/check/legacy-tempest-dsvm-neutron-full-centos-7/28114dd/ : FAILURE in 30m 55s (non-voting)\n- legacy-tempest-dsvm-neutron-linuxbridge http://logs.openstack.org/48/531248/2/check/legacy-tempest-dsvm-neutron-linuxbridge/75a6401/ : FAILURE in 1h 02m 15s\n- legacy-tempest-dsvm-neutron-multinode-full http://logs.openstack.org/48/531248/2/check/legacy-tempest-dsvm-neutron-multinode-full/c2dff2e/ : SUCCESS in 1h 25m 01s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"ea5a7d01790d69b3b31a7a176de54937eeebc1ad","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2018-01-04 23:42:18.000000000","message":"Patch Set 2:\n\nTesting failed ubuntu-xenial-s390x. For rechecking only on the ubuntu-xenial-s390x CI, add a review comment with recheck-zkvm. Contact info: zkvm-ci@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_zKVM_CI\n\n- check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x http://sng01.objectstorage.softlayer.net/v1/AUTH_1940ea10-6e82-4501-b2f9-eb236510e575/ibmzkvmci/production/531248/2/check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x/137eb90 : FAILURE in 1h 25m 04s","accounts_in_message":[],"_revision_number":2},{"id":"0782727d3f5db9eb7f495475410a1875e8fcbb6c","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2018-01-08 23:32:55.000000000","message":"Patch Set 2:\n\ni\u0027ll swing back by this when docs fixes merges","accounts_in_message":[],"_revision_number":2},{"id":"a1658063afe794fa07645fd24c6e0899bb6d6117","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2018-01-09 04:53:11.000000000","message":"Patch Set 2: Code-Review+2\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"c3debeb04623b85308920f78eb2eb3b386a16997","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2018-01-09 06:06:10.000000000","message":"Patch Set 2:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial-nv https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/devstack/48/531248/2/check/tempest-dsvm-full-xenial-nv/d243590/ : SUCCESS in 1h 06m 03s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"1c50e5ee7027c4b1432fd00ef772dd4ea90295df","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-09 06:28:13.000000000","message":"Patch Set 2:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- legacy-tempest-dsvm-neutron-full http://logs.openstack.org/48/531248/2/check/legacy-tempest-dsvm-neutron-full/2403692/ : SUCCESS in 1h 20m 01s\n- build-openstack-sphinx-docs http://logs.openstack.org/48/531248/2/check/build-openstack-sphinx-docs/7adf7f7/ : FAILURE in 3m 19s\n- openstack-tox-bashate http://logs.openstack.org/48/531248/2/check/openstack-tox-bashate/bdecc53/ : SUCCESS in 2m 52s\n- legacy-devstack-unit-tests http://logs.openstack.org/48/531248/2/check/legacy-devstack-unit-tests/c271ddb/ : SUCCESS in 3m 13s\n- legacy-swift-dsvm-functional http://logs.openstack.org/48/531248/2/check/legacy-swift-dsvm-functional/104d435/ : SUCCESS in 19m 43s (non-voting)\n- legacy-tempest-dsvm-neutron-full-centos-7 http://logs.openstack.org/48/531248/2/check/legacy-tempest-dsvm-neutron-full-centos-7/80fa903/ : FAILURE in 17m 56s (non-voting)\n- legacy-tempest-dsvm-neutron-linuxbridge http://logs.openstack.org/48/531248/2/check/legacy-tempest-dsvm-neutron-linuxbridge/be7cfa2/ : SUCCESS in 1h 17m 50s\n- legacy-tempest-dsvm-neutron-multinode-full http://logs.openstack.org/48/531248/2/check/legacy-tempest-dsvm-neutron-multinode-full/5ed0106/ : SUCCESS in 1h 29m 34s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"8900abbfb85bbefc0f83a58d1b769ca1afeeb34c","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2018-01-09 08:36:28.000000000","message":"Patch Set 2:\n\nI didn\u0027t assume stable/newton would still be updated when it is formally EOL for quite some time already. If you want docs build to pass, you need to backport https://review.openstack.org/530940","accounts_in_message":[],"_revision_number":2},{"id":"7f76ae52552f9af149888061b22f8c62f3624fd2","author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"date":"2018-01-09 19:32:56.000000000","message":"Patch Set 2:\n\nWe can probably abandon this as soon as the tempest jobs are removed and the branch is actually EOL\u0027d. I just pushed this because it was blocking a tempest side config. I\u0027ve talked to other members of the stable team and the newton eol was held up by some last minute critical fixes (which have been approved)","accounts_in_message":[],"_revision_number":2},{"id":"d43c6b77c8edd8abb02574e74aa694ab17616d98","tag":"autogenerated:gerrit:abandon","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2021-11-09 10:13:46.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"976478ff4f7055f378f05370848a1c311171ed43","revisions":{"5d63620ba891dcb8289fdb01dc0da819ef8ddef1":{"kind":"REWORK","_number":1,"created":"2018-01-04 21:38:03.000000000","uploader":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"ref":"refs/changes/48/531248/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/48/531248/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/48/531248/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/48/531248/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/48/531248/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/48/531248/1"}}},"commit":{"parents":[{"commit":"386aefe441cdcdedb566dc014c6abd5f7dd16c97","subject":"Use \"pip list\" in check_libs_from_git","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/386aefe441cdcdedb566dc014c6abd5f7dd16c97"}]}],"author":{"name":"Matthew Treinish","email":"mtreinish@kortar.org","date":"2017-02-16 20:45:11.000000000","tz":-300},"committer":{"name":"Matthew Treinish","email":"mtreinish@kortar.org","date":"2018-01-04 21:36:57.000000000","tz":-300},"subject":"Differentiate between DEFAULT_IMAGE_NAME and filename","message":"Differentiate between DEFAULT_IMAGE_NAME and filename\n\nThe DEFAULT_IMAGE_NAME variable is used to reference the name of the\ndefault image in glance after it has been uploaded by devstack. It is\nused both inside and outside of devstack for that purpose. However, when\nconfiguring tempest there are some tests which also do image uploads and\nneed a filename for specifying which file they should upload into glance\nfor testing purposes. Previously we were just using DEFAULT_IMAGE_NAME\nfor both purposes, but this causes a conflict if the name of the image\nwe upload into glance does not have a file extension. So instead of\nconflating the things this commit differentiates between them and adds a\nnew DEFAULT_IMAGE_FILE_NAME variable to use for this purpose.\n\nThis conflicts because there were several intermediate changes before\nthis was finished. This just skips to the end state. Additionally the\nchange id is removed because to get things working in the gate\nconsistently this needs to land in a very specific order. This can\u0027t be\ndone if the change-ids all match.\n\nConflicts:\n\tlib/tempest\n\tstackrc\n\n(cherry picked from commit befe0925e7cb3d3b34ee9e856c4bc822a499975f)\n\nChange-Id: Iee7c922cd534ff9ec67cffd2aaa1a03360c1b74a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/5d63620ba891dcb8289fdb01dc0da819ef8ddef1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/5d63620ba891dcb8289fdb01dc0da819ef8ddef1"}]},"branch":"refs/heads/stable/newton"},"976478ff4f7055f378f05370848a1c311171ed43":{"kind":"REWORK","_number":2,"created":"2018-01-04 21:47:35.000000000","uploader":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"ref":"refs/changes/48/531248/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/48/531248/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/48/531248/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/48/531248/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/48/531248/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/48/531248/2"}}},"commit":{"parents":[{"commit":"386aefe441cdcdedb566dc014c6abd5f7dd16c97","subject":"Use \"pip list\" in check_libs_from_git","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/386aefe441cdcdedb566dc014c6abd5f7dd16c97"}]}],"author":{"name":"Matthew Treinish","email":"mtreinish@kortar.org","date":"2017-02-16 20:45:11.000000000","tz":-300},"committer":{"name":"Matthew Treinish","email":"mtreinish@kortar.org","date":"2018-01-04 21:47:29.000000000","tz":-300},"subject":"Differentiate between DEFAULT_IMAGE_NAME and filename","message":"Differentiate between DEFAULT_IMAGE_NAME and filename\n\nThe DEFAULT_IMAGE_NAME variable is used to reference the name of the\ndefault image in glance after it has been uploaded by devstack. It is\nused both inside and outside of devstack for that purpose. However, when\nconfiguring tempest there are some tests which also do image uploads and\nneed a filename for specifying which file they should upload into glance\nfor testing purposes. Previously we were just using DEFAULT_IMAGE_NAME\nfor both purposes, but this causes a conflict if the name of the image\nwe upload into glance does not have a file extension. So instead of\nconflating the things this commit differentiates between them and adds a\nnew DEFAULT_IMAGE_FILE_NAME variable to use for this purpose.\n\nThis conflicts because there were several intermediate changes before\nthis was finished. This just skips to the end state. Additionally the\nchange id is removed because to get things working in the gate\nconsistently this needs to land in a very specific order. This can\u0027t be\ndone if the change-ids all match.\n\nConflicts:\n\tlib/tempest\n\tstackrc\n\n(cherry picked from commit befe0925e7cb3d3b34ee9e856c4bc822a499975f)\n\nChange-Id: Iee7c922cd534ff9ec67cffd2aaa1a03360c1b74a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/976478ff4f7055f378f05370848a1c311171ed43"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/976478ff4f7055f378f05370848a1c311171ed43"}]},"branch":"refs/heads/stable/newton"}},"requirements":[],"submit_records":[],"submit_requirements":[]}