)]}'
{"lib/neutron_plugins/services/l3":[{"author":{"_account_id":16710,"name":"Eric Berglund","email":"esberglu@us.ibm.com","username":"esberglu"},"change_message_id":"f4d5382e4634fa5811e6f4e048697e983875063f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"if [[ $IP_VERSION !\u003d \"4\" ]] \u0026\u0026 [[ $IP_VERSION !\u003d \"6\" ]] \u0026\u0026 [[ $IP_VERSION !\u003d \"4+6\" ]]; then"},{"line_number":6,"context_line":"    die $LINENO \"IP_VERSION must be either 4, 6, or 4+6\""},{"line_number":7,"context_line":"fi"},{"line_number":8,"context_line":"# Specify if the initial private and external networks should be created"},{"line_number":9,"context_line":"NEUTRON_CREATE_INITIAL_NETWORKS\u003d${NEUTRON_CREATE_INITIAL_NETWORKS:-True}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"## Provider Network Information"},{"line_number":12,"context_line":"PROVIDER_SUBNET_NAME\u003d${PROVIDER_SUBNET_NAME:-\"provider_net\"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7f96bb07_b08aa018","side":"PARENT","line":9,"range":{"start_line":8,"start_character":0,"end_line":9,"end_character":72},"updated":"2018-01-12 18:55:10.000000000","message":"Never used in this file","commit_id":"b09e9b9b48d0f858729d2b88b033a18873b2a89e"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c4b326fd2827f1eeade459cdbe0bca9d4492618d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"if [[ $IP_VERSION !\u003d \"4\" ]] \u0026\u0026 [[ $IP_VERSION !\u003d \"6\" ]] \u0026\u0026 [[ $IP_VERSION !\u003d \"4+6\" ]]; then"},{"line_number":6,"context_line":"    die $LINENO \"IP_VERSION must be either 4, 6, or 4+6\""},{"line_number":7,"context_line":"fi"},{"line_number":8,"context_line":"# Specify if the initial private and external networks should be created"},{"line_number":9,"context_line":"NEUTRON_CREATE_INITIAL_NETWORKS\u003d${NEUTRON_CREATE_INITIAL_NETWORKS:-True}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"## Provider Network Information"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7f96bb07_80706fa7","side":"PARENT","line":8,"updated":"2018-01-12 20:55:57.000000000","message":"Is it used by something that sources this file, though?  (That doesn\u0027t already source lib/neutron, that is.)  I\u0027m gonna say better idea to leave this alone here and propose this deletion in a separate patch (or not at all).","commit_id":"b09e9b9b48d0f858729d2b88b033a18873b2a89e"},{"author":{"_account_id":16710,"name":"Eric Berglund","email":"esberglu@us.ibm.com","username":"esberglu"},"change_message_id":"b3fca8b4fabc0379597d96554c4fe328dce59a50","unresolved":false,"context_lines":[{"line_number":5,"context_line":"if [[ $IP_VERSION !\u003d \"4\" ]] \u0026\u0026 [[ $IP_VERSION !\u003d \"6\" ]] \u0026\u0026 [[ $IP_VERSION !\u003d \"4+6\" ]]; then"},{"line_number":6,"context_line":"    die $LINENO \"IP_VERSION must be either 4, 6, or 4+6\""},{"line_number":7,"context_line":"fi"},{"line_number":8,"context_line":"# Specify if the initial private and external networks should be created"},{"line_number":9,"context_line":"NEUTRON_CREATE_INITIAL_NETWORKS\u003d${NEUTRON_CREATE_INITIAL_NETWORKS:-True}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"## Provider Network Information"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7f96bb07_5dec65f2","side":"PARENT","line":8,"in_reply_to":"7f96bb07_80706fa7","updated":"2018-01-15 20:46:28.000000000","message":"This is only sourced by lib/neutron, but I\u0027m fine with leaving it here.","commit_id":"b09e9b9b48d0f858729d2b88b033a18873b2a89e"}],"stack.sh":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c4b326fd2827f1eeade459cdbe0bca9d4492618d","unresolved":false,"context_lines":[{"line_number":1293,"context_line":"    start_neutron"},{"line_number":1294,"context_line":"fi"},{"line_number":1295,"context_line":"# Once neutron agents are started setup initial network elements"},{"line_number":1296,"context_line":"if is_service_enabled q-svc \u0026\u0026 [[ \"$NEUTRON_CREATE_INITIAL_NETWORKS\" \u003d\u003d \"True\" ]]; then"},{"line_number":1297,"context_line":"    echo_summary \"Creating initial neutron network elements\""},{"line_number":1298,"context_line":"    create_neutron_initial_network"},{"line_number":1299,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7f96bb07_20507bd4","side":"PARENT","line":1296,"updated":"2018-01-12 20:55:57.000000000","message":"Does this not do what we want?","commit_id":"b09e9b9b48d0f858729d2b88b033a18873b2a89e"},{"author":{"_account_id":16710,"name":"Eric Berglund","email":"esberglu@us.ibm.com","username":"esberglu"},"change_message_id":"b3fca8b4fabc0379597d96554c4fe328dce59a50","unresolved":false,"context_lines":[{"line_number":1293,"context_line":"    start_neutron"},{"line_number":1294,"context_line":"fi"},{"line_number":1295,"context_line":"# Once neutron agents are started setup initial network elements"},{"line_number":1296,"context_line":"if is_service_enabled q-svc \u0026\u0026 [[ \"$NEUTRON_CREATE_INITIAL_NETWORKS\" \u003d\u003d \"True\" ]]; then"},{"line_number":1297,"context_line":"    echo_summary \"Creating initial neutron network elements\""},{"line_number":1298,"context_line":"    create_neutron_initial_network"},{"line_number":1299,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7f96bb07_1d3b3d9c","side":"PARENT","line":1296,"in_reply_to":"7f96bb07_20507bd4","updated":"2018-01-15 20:46:28.000000000","message":"This would do what we want if we were still using q-svc. But it isn\u0027t touched because we moved from q-svc (legacy) to neutron-api. See L453 of lib/neutron in this change. Prior to this patch, neutron networks would be created there as long as neutron-api is enabled.","commit_id":"b09e9b9b48d0f858729d2b88b033a18873b2a89e"}]}
