)]}'
{"id":"openstack%2Fdevstack~53755","triplet_id":"openstack%2Fdevstack~master~Iab1a817b15d86144163b5094bb58f94b15c598a0","project":"openstack/devstack","branch":"master","topic":"zsh","hashtags":[],"change_id":"Iab1a817b15d86144163b5094bb58f94b15c598a0","subject":"zsh openrc compatibility","status":"MERGED","created":"2013-10-24 22:53:34.000000000","updated":"2013-10-31 14:16:50.000000000","submitted":"2013-10-31 14:16:50.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"77e830930ca9fc41dcf6f3e52b581da4209659eb","_number":53755,"virtual_id_number":53755,"owner":{"_account_id":7500,"name":"Peter Feiner","email":"peter@gridcentric.ca","username":"peter"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-10-31 14:16:50.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":7500,"name":"Peter Feiner","email":"peter@gridcentric.ca","username":"peter"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-10-25 17:37:11.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2013-10-25 16:03:15.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":7500,"name":"Peter Feiner","email":"peter@gridcentric.ca","username":"peter"},{"value":2,"date":"2013-10-31 11:43:55.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-10-25 17:37:11.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2013-10-25 16:02:32.000000000","_account_id":7500,"name":"Peter Feiner","email":"peter@gridcentric.ca","username":"peter"},{"value":1,"date":"2013-10-31 11:43:55.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":7500,"name":"Peter Feiner","email":"peter@gridcentric.ca","username":"peter"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":7500,"name":"Peter Feiner","email":"peter@gridcentric.ca","username":"peter"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-10-25 17:37:11.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2013-10-31 11:43:55.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-10-31 14:16:50.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"579a77b834807331d1426c2ec3fc94fffc9e180d","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-10-24 23:24:18.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nThis actually doesn\u0027t work when openrc or stackrc are sourced by scripts not in the top-level devstack directory.\n\nFor example, while the exercise scripts themselves don\u0027t use BASH_SOURCE, if openrc doesn\u0027t use it then stackrc can not be found.\n\nopenrc, stackrc and eucarc are sourced in a number of places and hard-coding the relative location is not an option.  This is one reason we specifically say that we only support Bash 3.x+.","accounts_in_message":[],"_revision_number":1},{"id":"0aae485d28ff2e6b44c1927c9b6a24f5c59c4dcd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-24 23:25:37.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-devstack-bash8 http://logs.openstack.org/55/53755/1/check/gate-devstack-bash8/062acfd : SUCCESS in 4s\n- check-tempest-devstack-vm-full http://logs.openstack.org/55/53755/1/check/check-tempest-devstack-vm-full/c36e41f : SUCCESS in 28m 12s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/55/53755/1/check/check-tempest-devstack-vm-postgres-full/9261b0e : SUCCESS in 31m 53s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/55/53755/1/check/check-tempest-devstack-vm-neutron/3d474c0 : SUCCESS in 20m 33s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/55/53755/1/check/gate-tempest-devstack-vm-large-ops/df0678e : SUCCESS in 14m 52s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/55/53755/1/check/gate-tempest-devstack-vm-neutron-large-ops/e1e73e1 : SUCCESS in 16m 29s (non-voting)\n- check-grenade-devstack-vm http://logs.openstack.org/55/53755/1/check/check-grenade-devstack-vm/5a7d01e : FAILURE in 13m 54s\n- check-swift-devstack-vm-functional http://logs.openstack.org/55/53755/1/check/check-swift-devstack-vm-functional/394f8e5 : SUCCESS in 10m 55s\n","accounts_in_message":[],"_revision_number":1},{"id":"f06afbc771c14cbf4ffd9a67b109c33ab91e1944","author":{"_account_id":7500,"name":"Peter Feiner","email":"peter@gridcentric.ca","username":"peter"},"date":"2013-10-25 16:02:32.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"3e06d0bc95ae7c0edf6941c3731f22afc77244dc","author":{"_account_id":7500,"name":"Peter Feiner","email":"peter@gridcentric.ca","username":"peter"},"date":"2013-10-25 16:03:15.000000000","message":"Patch Set 2:\n\nYou\u0027re right! I\u0027ve uploaded a fix.","accounts_in_message":[],"_revision_number":2},{"id":"7745831f985939d76006d8b36420629332508204","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-25 16:34:29.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-devstack-bash8 http://logs.openstack.org/55/53755/2/check/gate-devstack-bash8/f1add0a : SUCCESS in 5s\n- check-tempest-devstack-vm-full http://logs.openstack.org/55/53755/2/check/check-tempest-devstack-vm-full/e76e8d4 : SUCCESS in 26m 53s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/55/53755/2/check/check-tempest-devstack-vm-postgres-full/0b79446 : SUCCESS in 31m 39s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/55/53755/2/check/check-tempest-devstack-vm-neutron/06a0747 : SUCCESS in 18m 38s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/55/53755/2/check/gate-tempest-devstack-vm-large-ops/04b96d9 : SUCCESS in 14m 31s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/55/53755/2/check/gate-tempest-devstack-vm-neutron-large-ops/6607e82 : SUCCESS in 17m 33s (non-voting)\n- check-grenade-devstack-vm http://logs.openstack.org/55/53755/2/check/check-grenade-devstack-vm/86c0640 : SUCCESS in 25m 47s\n- check-swift-devstack-vm-functional http://logs.openstack.org/55/53755/2/check/check-swift-devstack-vm-functional/247893a : SUCCESS in 11m 20s\n","accounts_in_message":[],"_revision_number":2},{"id":"3bc3478a00040c4fe4e9b2fffdd46eb2eab942b4","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-10-25 17:37:11.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nI\u0027ll buy that, thanks","accounts_in_message":[],"_revision_number":2},{"id":"ce84d350b707ab0b79721ca867276b74ceb51ff1","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-10-31 11:43:55.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"41c406ce5911038d13a45ecdd64156614f23a955","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-31 11:45:09.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"2fcebfbd1cdd24865d0553b1eb23a4d9ad522ef3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-31 14:16:50.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- gate-devstack-bash8 http://logs.openstack.org/55/53755/2/gate/gate-devstack-bash8/74aa752 : SUCCESS in 11s\n- gate-tempest-devstack-vm-full http://logs.openstack.org/55/53755/2/gate/gate-tempest-devstack-vm-full/853b6c0 : SUCCESS in 33m 11s\n- gate-tempest-devstack-vm-postgres-full http://logs.openstack.org/55/53755/2/gate/gate-tempest-devstack-vm-postgres-full/db6e560 : SUCCESS in 32m 03s\n- gate-tempest-devstack-vm-neutron http://logs.openstack.org/55/53755/2/gate/gate-tempest-devstack-vm-neutron/3dde1de : SUCCESS in 23m 40s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/55/53755/2/gate/gate-tempest-devstack-vm-large-ops/d7326cc : SUCCESS in 17m 44s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/55/53755/2/gate/gate-tempest-devstack-vm-neutron-large-ops/f54390d : SUCCESS in 24m 41s (non-voting)\n- gate-grenade-devstack-vm http://logs.openstack.org/55/53755/2/gate/gate-grenade-devstack-vm/5b4e694 : SUCCESS in 23m 13s\n- gate-swift-devstack-vm-functional http://logs.openstack.org/55/53755/2/gate/gate-swift-devstack-vm-functional/a47d224 : SUCCESS in 13m 39s\n","accounts_in_message":[],"_revision_number":2},{"id":"ad7a1480337047ebce83522c747fcde35e4560ad","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-31 14:16:50.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"388e36c98bf3efae3a1e25eabdd291f0b5b5e7c9","revisions":{"dd5a4572f4d5512bc9953cc4661b9132017519aa":{"kind":"REWORK","_number":1,"created":"2013-10-24 22:53:34.000000000","uploader":{"_account_id":7500,"name":"Peter Feiner","email":"peter@gridcentric.ca","username":"peter"},"ref":"refs/changes/55/53755/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/55/53755/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/55/53755/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/55/53755/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/55/53755/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/55/53755/1"}}},"commit":{"parents":[{"commit":"0c42f250430ad2e68c0a72804179a80522a159df","subject":"Merge \"Just reset the repo instead of trying to co files\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/0c42f250430ad2e68c0a72804179a80522a159df"}]}],"author":{"name":"Peter Feiner","email":"peter@gridcentric.ca","date":"2013-10-24 22:51:44.000000000","tz":-240},"committer":{"name":"Peter Feiner","email":"peter@gridcentric.ca","date":"2013-10-24 22:51:44.000000000","tz":-240},"subject":"zsh openrc compatibility","message":"zsh openrc compatibility\n\nReplacing $BASH_SOURCE with $0 makes devstack zsh friendly. Now you can source\ndevstack\u0027s openrc from a zsh shell.\n\nTested with bash and zsh :-)\n\nChange-Id: Iab1a817b15d86144163b5094bb58f94b15c598a0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/dd5a4572f4d5512bc9953cc4661b9132017519aa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/dd5a4572f4d5512bc9953cc4661b9132017519aa"}]},"branch":"refs/heads/master"},"388e36c98bf3efae3a1e25eabdd291f0b5b5e7c9":{"kind":"REWORK","_number":2,"created":"2013-10-25 16:02:32.000000000","uploader":{"_account_id":7500,"name":"Peter Feiner","email":"peter@gridcentric.ca","username":"peter"},"ref":"refs/changes/55/53755/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/55/53755/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/55/53755/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/55/53755/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/55/53755/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/55/53755/2"}}},"commit":{"parents":[{"commit":"0c42f250430ad2e68c0a72804179a80522a159df","subject":"Merge \"Just reset the repo instead of trying to co files\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/0c42f250430ad2e68c0a72804179a80522a159df"}]}],"author":{"name":"Peter Feiner","email":"peter@gridcentric.ca","date":"2013-10-24 22:51:44.000000000","tz":-240},"committer":{"name":"Peter Feiner","email":"peter@gridcentric.ca","date":"2013-10-25 16:00:06.000000000","tz":-240},"subject":"zsh openrc compatibility","message":"zsh openrc compatibility\n\nReplacing $BASH_SOURCE with ${BASH_SOURCE:-$0} makes devstack zsh friendly: in\nbash, $BASH_SOURCE is used per usual; in zsh, where $BASH_SOURCE isn\u0027t\ndefined, $0 is used, which, unlike in bash, evaluates to the current\nsource file.\n\nNow you can source devstack\u0027s openrc from a zsh shell.\n\nTested with bash and zsh from directories other than the root devstack\ndirectory.\n\nChange-Id: Iab1a817b15d86144163b5094bb58f94b15c598a0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/388e36c98bf3efae3a1e25eabdd291f0b5b5e7c9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/388e36c98bf3efae3a1e25eabdd291f0b5b5e7c9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}