)]}'
{".zuul.yaml":[{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"1eea384245b51142448f346b63c7cf70028eb2da","unresolved":false,"context_lines":[{"line_number":161,"context_line":"      subnode:"},{"line_number":162,"context_line":"        subnode_localrc:"},{"line_number":163,"context_line":"          DATABASE_TYPE: mysql"},{"line_number":164,"context_line":"          GLANCE_HOSTPORT: \"{{ hostvars[\u0027controller\u0027][\u0027ansible_host\u0027] }}:9292\""},{"line_number":165,"context_line":"          Q_HOST: \"{{ hostvars[\u0027controller\u0027][\u0027ansible_host\u0027] }}\""},{"line_number":166,"context_line":"          RABBIT_HOST: \"{{ hostvars[\u0027controller\u0027][\u0027ansible_host\u0027] }}\""},{"line_number":167,"context_line":"          DATABASE_HOST: \"{{ hostvars[\u0027controller\u0027][\u0027ansible_host\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3fa0c359_104d6671","line":164,"updated":"2018-02-20 05:50:36.000000000","message":"I think that you should add SERVICE_HOST variable here.","commit_id":"79c337575d4a7f87b8a47f2526c8394ed180f6b9"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"b4e7979dbbf27af9453842a95fe578a763f7b444","unresolved":false,"context_lines":[{"line_number":153,"context_line":"          LIVE_MIGRATION_AVAILABLE: true"},{"line_number":154,"context_line":"          USE_BLOCK_MIGRATION_FOR_LIVE_MIGRATION: true"},{"line_number":155,"context_line":"          SERVICE_HOST: \"{{ hostvars[\u0027controller\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}\""},{"line_number":156,"context_line":"          PUBLIC_BRIDGE_MTU: \"{{ hostvars[\u0027controller\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}\""},{"line_number":157,"context_line":"          HOSTIP: \"{{ hostvars[\u0027controller\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}\""},{"line_number":158,"context_line":"        devstack_localconf:"},{"line_number":159,"context_line":"          post-config:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3fa0c359_64a9707a","line":156,"updated":"2018-02-21 08:29:29.000000000","message":"This looks like wrong for the MTU value.","commit_id":"152a152adec16a4697b8e50378a690ee54fd3707"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"2cddb4148a15095ae835ea130b89e5c420a09431","unresolved":false,"context_lines":[{"line_number":213,"context_line":"          IPV4_ADDRS_SAFE_TO_USE: 10.1.0.0/20"},{"line_number":214,"context_line":"          FLOATING_RANGE: 172.24.5.0/24"},{"line_number":215,"context_line":"          PUBLIC_NETWORK_GATEWAY: 172.24.5.1"},{"line_number":216,"context_line":"          SWIFT_REPLICAS: 1"},{"line_number":217,"context_line":"          SWIFT_START_ALL_SERVICES: false"},{"line_number":218,"context_line":"          SWIFT_HASH: 1234123412341234"},{"line_number":219,"context_line":"          LOGFILE: /opt/stack/logs/devstacklog.txt"},{"line_number":220,"context_line":"          LOG_COLOR: false"},{"line_number":221,"context_line":"          VERBOSE: true"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"3fa0c359_5c3dd9b8","line":218,"range":{"start_line":216,"start_character":10,"end_line":218,"end_character":38},"updated":"2018-02-25 09:13:46.000000000","message":"Swift isn\u0027t installed in subnode. Do we need these configs?","commit_id":"a38d10b9c206b6d075ffef91779e9bc0d556c339"}],"playbooks/pre.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7aa2c36f6443dd28a317f88ce253fd5b61d3bb0e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"      # TODO(andreaf) This should work, but it may have to be reconcilied with"},{"line_number":18,"context_line":"      # the MTU setting used by the multinode setup roles in multinode pre.yaml"},{"line_number":19,"context_line":"      set_fact:"},{"line_number":20,"context_line":"        external_bridge_mtu: \"{{ local_mtu | int - 50 }}\""},{"line_number":21,"context_line":"  roles:"},{"line_number":22,"context_line":"    - test-matrix"},{"line_number":23,"context_line":"    - configure-swap"}],"source_content_type":"text/x-yaml","patch_set":77,"id":"df7087c5_4ea1d345","line":20,"updated":"2018-03-13 22:45:07.000000000","message":"This looks like it duplicated the code from the openstack-infra/devstack-gate repo, in devstack-vm-gate.sh, which doesn\u0027t support an IPv6 underlay.  I\u0027ve been trying to fix it like so: https://review.openstack.org/#/c/343041/14/devstack-vm-gate.sh but I\u0027m not sure how that would be implemented here.","commit_id":"5e714d33081455af4bd7a45bb9e60a905ad6f2e7"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"42911c9dfa62586b96ccc0c77400c1a41f54c841","unresolved":false,"context_lines":[{"line_number":19,"context_line":"      set_fact:"},{"line_number":20,"context_line":"        external_bridge_mtu: \"{{ local_mtu | int - 50 }}\""},{"line_number":21,"context_line":"  roles:"},{"line_number":22,"context_line":"    - test-matrix"},{"line_number":23,"context_line":"    - configure-swap"},{"line_number":24,"context_line":"    - setup-stack-user"},{"line_number":25,"context_line":"    - setup-tempest-user"}],"source_content_type":"text/x-yaml","patch_set":77,"id":"df7087c5_e245c571","line":22,"range":{"start_line":22,"start_character":6,"end_line":22,"end_character":17},"updated":"2018-03-09 00:34:52.000000000","message":"We shouldn\u0027t need this at all anymore right?","commit_id":"5e714d33081455af4bd7a45bb9e60a905ad6f2e7"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"1733da4f9a045efc85395f82031369f586fcf2d3","unresolved":false,"context_lines":[{"line_number":19,"context_line":"      set_fact:"},{"line_number":20,"context_line":"        external_bridge_mtu: \"{{ local_mtu | int - 50 }}\""},{"line_number":21,"context_line":"  roles:"},{"line_number":22,"context_line":"    - test-matrix"},{"line_number":23,"context_line":"    - configure-swap"},{"line_number":24,"context_line":"    - setup-stack-user"},{"line_number":25,"context_line":"    - setup-tempest-user"}],"source_content_type":"text/x-yaml","patch_set":77,"id":"df7087c5_3e4bc8b0","line":22,"range":{"start_line":22,"start_character":6,"end_line":22,"end_character":17},"in_reply_to":"df7087c5_e245c571","updated":"2018-03-09 16:52:26.000000000","message":"Right - I was planning on removing all test-matrix bits in a follow up patch - here I\u0027m just overriding them with base \u003d False","commit_id":"5e714d33081455af4bd7a45bb9e60a905ad6f2e7"}],"roles/orchestrate-devstack/tasks/main.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"42911c9dfa62586b96ccc0c77400c1a41f54c841","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Run devstack on the controller"},{"line_number":2,"context_line":"  include_role:"},{"line_number":3,"context_line":"    name: run-devstack"},{"line_number":4,"context_line":"  when: inventory_hostname \u003d\u003d \u0027controller\u0027"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Setup devstack on sub-nodes"},{"line_number":7,"context_line":"  block:"}],"source_content_type":"text/x-yaml","patch_set":77,"id":"df7087c5_c53d2bbc","line":4,"updated":"2018-03-09 00:34:52.000000000","message":"One concern here is that I *think* I recall sdague saying you can\u0027t reliably bring up compute nodes before the controller node is up. But we aren\u0027t enforcing the order of operations here instead we are just checking what to do based on being a controller or a subnode below.\n\nWe don\u0027t have an guarantee that the discover_hosts.sh below will actually run after this controller runs do we? because this playbook will run against all and the order is arbitrary?","commit_id":"5e714d33081455af4bd7a45bb9e60a905ad6f2e7"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"1733da4f9a045efc85395f82031369f586fcf2d3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Run devstack on the controller"},{"line_number":2,"context_line":"  include_role:"},{"line_number":3,"context_line":"    name: run-devstack"},{"line_number":4,"context_line":"  when: inventory_hostname \u003d\u003d \u0027controller\u0027"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Setup devstack on sub-nodes"},{"line_number":7,"context_line":"  block:"}],"source_content_type":"text/x-yaml","patch_set":77,"id":"df7087c5_5e56bc5e","line":4,"in_reply_to":"df7087c5_c53d2bbc","updated":"2018-03-09 16:52:26.000000000","message":"I wonder if I could fix this using handlers or some other sync mechanism so that subnodes only start after controller is done.\n\nIn fact what I see happening is that controller is done first, but I don\u0027t know why.","commit_id":"5e714d33081455af4bd7a45bb9e60a905ad6f2e7"}],"roles/sync-devstack-data/tasks/main.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"42911c9dfa62586b96ccc0c77400c1a41f54c841","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  with_items:"},{"line_number":28,"context_line":"    - \"{{ devstack_base_dir }}/data/ca-bundle.pem\""},{"line_number":29,"context_line":"    - \"{{ devstack_base_dir }}/data/CA\""},{"line_number":30,"context_line":"  when: inventory_hostname \u003d\u003d \u0027controller\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: Push the CA certificate"},{"line_number":33,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":77,"id":"df7087c5_e5a4ef0a","line":30,"updated":"2018-03-09 00:34:52.000000000","message":"Instead of doing a pull push can you just push directly from the source repo? line 36 and 45 below would end up being the paths above in the with_items?","commit_id":"5e714d33081455af4bd7a45bb9e60a905ad6f2e7"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d3abf0b4c408bf5bf67f64741cbf32eebbc7b106","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  with_items:"},{"line_number":28,"context_line":"    - \"{{ devstack_base_dir }}/data/ca-bundle.pem\""},{"line_number":29,"context_line":"    - \"{{ devstack_base_dir }}/data/CA\""},{"line_number":30,"context_line":"  when: inventory_hostname \u003d\u003d \u0027controller\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: Push the CA certificate"},{"line_number":33,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":77,"id":"df7087c5_4f228454","line":30,"in_reply_to":"df7087c5_7e238006","updated":"2018-03-09 19:17:09.000000000","message":"Ah right the context of ansible is the executor not the controller.","commit_id":"5e714d33081455af4bd7a45bb9e60a905ad6f2e7"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"1733da4f9a045efc85395f82031369f586fcf2d3","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  with_items:"},{"line_number":28,"context_line":"    - \"{{ devstack_base_dir }}/data/ca-bundle.pem\""},{"line_number":29,"context_line":"    - \"{{ devstack_base_dir }}/data/CA\""},{"line_number":30,"context_line":"  when: inventory_hostname \u003d\u003d \u0027controller\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: Push the CA certificate"},{"line_number":33,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":77,"id":"df7087c5_7e238006","line":30,"in_reply_to":"df7087c5_e5a4ef0a","updated":"2018-03-09 16:52:26.000000000","message":"The CA data is generated after devstack runs on the controller, so I can either pull push or ssh between controller and sub-nodes directly.\nAnything else zuul will block.","commit_id":"5e714d33081455af4bd7a45bb9e60a905ad6f2e7"}]}