)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"422182bde0b01b90bbc6cd4b6ec99a368479336f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mohammed Naser \u003cmnaser@vexxhost.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-02-23 16:22:03 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Create NOVA_COMPUTE_SERVICE_TIMEOUT in is_nova_ready function"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The function was introduced in [0] using a hardcoded timeout of 60"},{"line_number":10,"context_line":"seconds which turns out to be too small on slow machines. Create a new"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa0c359_d346c17b","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":35},"updated":"2018-02-23 21:29:37.000000000","message":"NOVA_READY_TIMEOUT","commit_id":"158af197270ccafb960331cad798e8c8ffc2a7b8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"422182bde0b01b90bbc6cd4b6ec99a368479336f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The function was introduced in [0] using a hardcoded timeout of 60"},{"line_number":10,"context_line":"seconds which turns out to be too small on slow machines. Create a new"},{"line_number":11,"context_line":"global variable NOVA_COMPUTE_SERVICE_TIMEOUT instead so that users can"},{"line_number":12,"context_line":"override the timeout if necessary."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[0] I32eb59b9d6c225a3e93992be3a3b9f4b251d7189"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa0c359_7361ed04","line":11,"range":{"start_line":11,"start_character":16,"end_line":11,"end_character":44},"updated":"2018-02-23 21:29:37.000000000","message":"NOVA_READY_TIMEOUT","commit_id":"158af197270ccafb960331cad798e8c8ffc2a7b8"}],"lib/nova":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6846b23ead3ac52ebc4e38a8f1136bc042535c61","unresolved":false,"context_lines":[{"line_number":1000,"context_line":"        # because of the dom0/domU split. Just ignore for now."},{"line_number":1001,"context_line":"        return"},{"line_number":1002,"context_line":"    fi"},{"line_number":1003,"context_line":"    wait_for_compute $SERVICE_TIMEOUT"},{"line_number":1004,"context_line":"}"},{"line_number":1005,"context_line":""},{"line_number":1006,"context_line":"function start_nova {"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa0c359_f315fd9c","line":1003,"updated":"2018-02-23 21:06:37.000000000","message":"I\u0027m not sure if this is the right way to go for this particular timeout. I would suggest defining a separate variable that defaults to $SERVICE_TIMEOUT but then we can configure the wait_for_compute timeout to be higher without globally changing the SERVICE_TIMEOUT.","commit_id":"70775c7d675de1eee0f14f5602ee2f775855d501"}],"stackrc":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5b53a7adfb7d870562accf43293cdb749a6a65a8","unresolved":false,"context_lines":[{"line_number":814,"context_line":"SERVICE_TIMEOUT\u003d${SERVICE_TIMEOUT:-60}"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"# Nova compute service startup timeout"},{"line_number":817,"context_line":"NOVA_COMPUTE_SERVICE_TIMEOUT\u003d${NOVA_COMPUTE_SERVICE_TIMEOUT:-60}"},{"line_number":818,"context_line":""},{"line_number":819,"context_line":"# Service graceful shutdown timeout"},{"line_number":820,"context_line":"SERVICE_GRACEFUL_SHUTDOWN_TIMEOUT\u003d${SERVICE_GRACEFUL_SHUTDOWN_TIMEOUT:-5}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa0c359_d3ea4172","line":817,"range":{"start_line":817,"start_character":61,"end_line":817,"end_character":63},"updated":"2018-02-23 21:17:17.000000000","message":"I would default to SERVICE_TIMEOUT, which defaults to 60.","commit_id":"2b5c48e3c870afd56f1f42539d91ad8ccc8efb71"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5b53a7adfb7d870562accf43293cdb749a6a65a8","unresolved":false,"context_lines":[{"line_number":814,"context_line":"SERVICE_TIMEOUT\u003d${SERVICE_TIMEOUT:-60}"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"# Nova compute service startup timeout"},{"line_number":817,"context_line":"NOVA_COMPUTE_SERVICE_TIMEOUT\u003d${NOVA_COMPUTE_SERVICE_TIMEOUT:-60}"},{"line_number":818,"context_line":""},{"line_number":819,"context_line":"# Service graceful shutdown timeout"},{"line_number":820,"context_line":"SERVICE_GRACEFUL_SHUTDOWN_TIMEOUT\u003d${SERVICE_GRACEFUL_SHUTDOWN_TIMEOUT:-5}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa0c359_b3e775ac","line":817,"range":{"start_line":817,"start_character":0,"end_line":817,"end_character":28},"updated":"2018-02-23 21:17:17.000000000","message":"The name is a bit confusing if we don\u0027t use this to wait for n-cpu to start, which is what SERVICE_TIMEOUT is for.\n\nMaybe just call it IS_NOVA_READY_TIMEOUT?","commit_id":"2b5c48e3c870afd56f1f42539d91ad8ccc8efb71"}]}